Hi Wietse,
I have a good news for you. While fixing the bug and auditing all of
its extent, I noticed that the PROXY protocol doesn't use the CRC32
but CRC32c (the Castagnoli variant), which is *not* affected by the
signedness bug :
crc = (crc >> 8) ^ crctable[(crc ^ (*buf++)) & 0xff];
I
On Sun, Jan 12, 2020 at 08:40:31AM -0500, Wietse Venema wrote:
> Willy Tarreau:
> > All this shows that neither CRC32 nor CRC32c are that much used today,
> > or that the usage is limited to situations not sensitive to interop
> > issues. So I want to see it fixed, and
Hi Wietse,
[CCing haproxy ML and responding inline]
First, thanks a lot for your detailed analysis.
On Sat, Jan 11, 2020 at 09:03:19PM -0500, Wietse Venema wrote:
> I found a portability bug in haproxy's CRC32 implementation, while
> adding adding CRC32 support to Postfix's haproxy2 code. The
On Tue, Dec 31, 2019 at 10:34:14AM +0100, Tamás Gérczei wrote:
> Thanks Willy, I appreciate the clue and your helpful intention -
> unfortunately this isn't something I can personally do owing to lack of
> knowledge. I don't know whether the v1 implementation had been a
> community patch or
On Tue, Dec 31, 2019 at 08:21:05AM +0100, Tamás Gérczei wrote:
> Thanks Wietse, this is what I thought and found out during my
> experiments,That said, now knowing that only v1 is supported, may I ask
> whether you have considered implementing v2 support? I'm about to
> migrate to a setup where
Hi Wietse,
On Thu, Sep 06, 2012 at 02:33:55PM -0400, Wietse Venema wrote:
Naval saini:
Sep 6 16:37:48 r22 postfix/postscreen[3992]: warning: haproxy read: time
limit exceeded
Sep 6 16:46:51 r22 postfix/postscreen[5233]: warning: haproxy read: time
limit exceeded
Sep 6 16:50:49 r22
Hi Wietse,
On Sun, Jun 17, 2012 at 08:25:12PM -0400, Wietse Venema wrote:
Non-production release postfix-2.10-20120617-nonprod has support
for up-stream proxy agents in postscreen(8) and smtpd(8).
To enable, specify one of:
postscreen_upstream_proxy_protocol = haproxy
Hi Wietse,
[ just subscribed to the list, I realized that our past conversation
was dropped since I was not subscribed, never mind ]
On Thu, Jun 07, 2012 at 08:16:53PM -0400, Wietse Venema wrote:
Willy Tarreau:
Regardless of command format details, if the proxy prepends a command