Re: PATCH: non-Postfix processes in init mode

2019-02-18 Thread Tamás Gérczei
Sure, I must suck at expressing myself as well. Not only had it been left intact and moved into the conditional construct, it had still been there without that in addition, thereby defeating the very purpose of patching. Like I said, contrary to what I might seem, I'm no moron and I've realized the

Re: PATCH: non-Postfix processes in init mode

2019-02-18 Thread Wietse Venema
Tam?s G?rczei: > Indeed, I should have had some rest before applying your patch... I did > create the condition, branching on init mode towards continue as > intended, yet also left the original call there right thereafter :D It You MUST KEEP the original panic call, like this: if ((proc

Re: PATCH: non-Postfix processes in init mode

2019-02-18 Thread Tamás Gérczei
Indeed, I should have had some rest before applying your patch... I did create the condition, branching on init mode towards continue as intended, yet also left the original call there right thereafter :D It applied and compiled well and I was sure I used the new packages and image so I was relucta

Re: PATCH: non-Postfix processes in init mode

2019-02-18 Thread Wietse Venema
Tam?s G?rczei: > 1 root 0:00 /usr/libexec/postfix/master -i >... > 78 postfix 0:00 smtpd -n smtp -t inet -u -o stress= > > Feb 18 09:36:57 mail-postfix-0 postfix/master[1]: panic: master_reap: > unknown pid: 78* > > + if (init_mode) > > + continue; /

Re: PATCH: non-Postfix processes in init mode

2019-02-18 Thread Tamás Gérczei
So I've now configured init mode in foreground with logging properly on stdout and your patch applied to the last 3.5 snapshot and I got the same panic, although this time not against my piped spamd process, rather smtpd, it would appear: / # ps PID   USER TIME  COMMAND     1 root  0:00 /u

Re: PATCH: non-Postfix processes in init mode

2019-02-17 Thread Wietse Venema
Tam?s G?rczei: > Thanks Wietse, I'll definitely try this patch -? but this code didn't > change in quite a bit of time. If in doubt, look RTFM the Postfix 3.3.1 announcement. * Postfix did not support running as a PID=1 process, which complicated Postfix management in containers. The "postf

Re: PATCH: non-Postfix processes in init mode

2019-02-17 Thread Tamás Gérczei
Hm.. Thanks to You both, I'll go take a look at this. On 2019. 02. 17. 16:14, Wietse Venema wrote: > Tam?s G?rczei: >> Thanks Wietse, I'll definitely try this patch -? but this code didn't >> change in quite a bit of time. > If in doubt, look RTFM the Postfix 3.3.1 announcement. > > * Postfix di

Re: PATCH: non-Postfix processes in init mode

2019-02-17 Thread A. Schulze
Am 17.02.19 um 16:01 schrieb Tamás Gérczei: > Anyway I'm invoking postfix-script in order to start master: I wonder why you don't use "postfix start-fg" available since postfix-3.3.1 (http://www.postfix.org/announcements/postfix-3.3.1.html) Andreas

Re: PATCH: non-Postfix processes in init mode

2019-02-17 Thread Tamás Gérczei
Thanks Wietse, I'll definitely try this patch -  but this code didn't change in quite a bit of time. Can this behaviour I'm seeing somehow relate to a change introduced between 3.3.0 and 3.3.2 ? I have zero problems with the exact same setup and configuration on 3.3.0. Anyway I'm invoking postfix-s

PATCH: non-Postfix processes in init mode

2019-02-17 Thread Wietse Venema
Wietse Venema: > Tam?s G?rczei: > > Hello List, > > > > I'd like to ask whether You're aware of any change which might cause > > breakage in my setup involving spamc with a completely unchanged > > configuration in between - I'm getting the following error: > > > > *"panic: master_reap: unknown p