Re: [prometheus-developers] Changing consensus on HTTP headers

2022-12-07 Thread Matthias Rampke
In general, what is a foot gun to me can be a rocket shoe to you, so I am in favor of providing them to those who require them, with clear labeling of the dangers. Specifically in this case, it has become more common ("beyond corp", "zero trust") to use HTTPS over the public internet, combined wit

Re: [prometheus-developers] Changing consensus on HTTP headers

2022-12-06 Thread Bjoern Rabenstein
On 06.12.22 23:15, Julien Pivotto wrote: > > https://github.com/prometheus/prometheus/issues/1724 > > Quoting Brian in 2016: > > The question here is how complex do we want to allow scraping protocol > > to be, and how complex a knot are we willing to let users tie themselves > > in via the core

Re: [prometheus-developers] Changing consensus on HTTP headers

2022-12-06 Thread Julien Pivotto
On 06 Dec 17:54, Bjoern Rabenstein wrote: > On 28.11.22 11:29, Julien Pivotto wrote: > > > > However, I have crafted a pull request that changes that consensus and > > makes HTTP headers configurable in the common HTTP client, with some > > reserved headers. > > For findability: https://github.co

Re: [prometheus-developers] Changing consensus on HTTP headers

2022-12-06 Thread Bjoern Rabenstein
On 28.11.22 11:29, Julien Pivotto wrote: > > However, I have crafted a pull request that changes that consensus and > makes HTTP headers configurable in the common HTTP client, with some > reserved headers. For findability: https://github.com/prometheus/common/pull/416 > What does the community

[prometheus-developers] Changing consensus on HTTP headers

2022-11-28 Thread Julien Pivotto
Hello, We once again got a request last week regarding overwriting HTTP header. This is a frequent request, even if it does not seem to affect a lot of users. However, I have crafted a pull request that changes that consensus and makes HTTP headers configurable in the common HTTP client, with so