Cool thanks :).
I started with this PR: https://github.com/prometheus/prometheus/pull/9188
By the way, do you think the repository prometheus-community/codemirror
should move to the org prometheus ?
Le mar. 10 août 2021 à 19:27, Julien Pivotto a
écrit :
> On 10 Aug 18:51, Augustin Husson
On 10 Aug 18:51, Augustin Husson wrote:
> Is it ok for you too Julien ?
>
> If yes, is it ok if I'm doing some PRs to proceed ?
Yes :)
>
> Le mar. 10 août 2021 à 16:31, Julius Volz a
> écrit :
>
> > I would be fine with that as well, yeah. It's more overall complexity
> > having to sync
Is it ok for you too Julien ?
If yes, is it ok if I'm doing some PRs to proceed ?
Le mar. 10 août 2021 à 16:31, Julius Volz a
écrit :
> I would be fine with that as well, yeah. It's more overall complexity
> having to sync things, but then at least that extra complexity doesn't
> concern the
I would be fine with that as well, yeah. It's more overall complexity
having to sync things, but then at least that extra complexity doesn't
concern the main Prometheus repo :)
On Tue, Aug 10, 2021 at 3:10 PM Augustin Husson
wrote:
> Oh yeah, I like this idea ! Thanks Rob :).
>
> I think that
Oh yeah, I like this idea ! Thanks Rob :).
I think that would cover all concerns raised for the moment, right Julien
and Julius ?
I forgot to mention it, but yes of course Julien the prometheus web ui will
use the local version of the codemirror-promql and won't use the npm
package.
Le mar. 10
You could also follow the Kubernetes model where subdirectories of the
repository is mirrored to a second repository (either by CI or some other
infrastructure) and there the code is tagged.
That way you still have a monorepo of all the code and can make single
changes across layers, but the
>From my point of view, to have a different tag wasn't because I didn't want
to wait for a Prometheus release.
In fact, currently these repositories are for the moment quite in a
maintenance mode. It just follows the changes of PromQL basically. So it's
quite fine to wait for the Prometheus
I like the idea. I want to make sure that having multiple tag formats for
differently-versioned subprojects (Prometheus itself and one or multiple
npm packages) doesn't cause any problems I don't foresee. It would be great
if people more familiar with the current Prometheus CI / build system could
Hello fellow Prometheus developers :),
As you probably know, in Prometheus, you have since a couple month a great
PromQL editor (with autocomplete, linter, highlight feature) which is for
the moment maintained in two separate repositories:
- prometheus-community/codemirror-promql
9 matches
Mail list logo