Re: Lite mode is in SVN -- mostly

2009-07-31 Thread Kenton Varda
On Wed, Jul 29, 2009 at 3:41 PM, ijuma ism...@juma.me.uk wrote: Is there a way to disable this behaviour? As you say, it doesn't seem particularly useful for sophisticated JVMs and unless I am missing something, the queue is currently unbounded so it could end up retaining quite a bit of

Allow setting compression level on GzipOutputStream

2009-07-31 Thread kenton
Reviewers: peter.keen_gmail.com, Description: Hi Peter, I decided to extend this patch a bit. I didn't like all the default options to the constructor, so I created a separate Options struct -- this way people don't have to set a buffer size in order to set compression level (which is good

Re: Allow setting compression level on GzipOutputStream

2009-07-31 Thread peter . keen
On 2009/07/31 23:56:40, kenton wrote: This looks great, Kenton. Thanks for cleaning it up! The tests look pretty decent as well. With such a small golden message you're probably not going to see any difference between the different compression levels, and it is just passed through to zlib so

Re: Allow setting compression level on GzipOutputStream

2009-07-31 Thread Kenton Varda
Yeah, the test only compares default compression to no compression -- even with the small message, default compression manages to compress a little bit. Committed as rev 170. On Fri, Jul 31, 2009 at 5:08 PM, peter.k...@gmail.com wrote: On 2009/07/31 23:56:40, kenton wrote: This looks great,

text relocation inside libprotoc.so.4.0.0

2009-07-31 Thread hw...@gear6.com
A question on the right behavior of libprotoc.so.4.0.0. On a CentOS 5.1, I downloaded and installed the latest protocol buffer 2.1. Make check runs fine. Then when I tried to do make under the ./ example directory, SELinux reports that protoc attempted to load /usr/ local/lib/libprotoc.so.4.0.0

Re: text relocation inside libprotoc.so.4.0.0

2009-07-31 Thread Kenton Varda
I think text relocation has something to do with the way a dynamic library is compiled and/or loaded. This is not something which Protocol Buffers asks for specifically -- either libtool, your linker, or your binary loader chose to use this feature without being asked for it. It seems that