Re: [protobuf] Better plugin support for cmake builds

2023-03-02 Thread Li He
Well, it's very simple to add to the existing implementation and is not limited to grpc (which I am just using as an example). According to https://protobuf.dev/reference/cpp/api-docs/google.protobuf.compiler.plugin/ We just need to extract the plugin name from PLUGIN using regex and try to

Re: [protobuf] Better plugin support for cmake builds

2023-03-02 Thread 'Adam Cozzette' via Protocol Buffers
Thanks for the suggestion and sorry for taking so long to reply. It's an interesting idea but I guess I'm skeptical of whether it's worth the effort to avoid an extra protoc invocation, since in my experience protoc invocations are not usually the bottleneck in build performance. I would also be

[protobuf] Better plugin support for cmake builds

2023-02-24 Thread Li He
Hi protobuf community members, I had an idea about some improvements for the protobuf cmake file . It was discussed over a recent merge request