Reviewers: peter.keen_gmail.com,
Description:
Hi Peter, I decided to extend this patch a bit. I didn't like all the
default options to the constructor, so I created a separate Options
struct -- this way people don't have to set a buffer size in order to
set compression level (which is good
On 2009/07/31 23:56:40, kenton wrote:
This looks great, Kenton. Thanks for cleaning it up! The tests look
pretty decent as well. With such a small golden message you're probably
not going to see any difference between the different compression
levels, and it is just passed through to zlib so
Yeah, the test only compares default compression to no compression --
even with the small message, default compression manages to compress a
little bit.
Committed as rev 170.
On Fri, Jul 31, 2009 at 5:08 PM, peter.k...@gmail.com wrote:
On 2009/07/31 23:56:40, kenton wrote:
This looks great,
