Re: [Pulp-dev] Cherry pick labeling

2020-03-18 Thread Ina Panova
It would be great if we could automate this part as well. As per responsibility, I think both reviewer and author should share it. Obviously if this is a new contributor, as Tanya mentioned, then reviewer should make sure the label is properly placed if needed. Regards, Ina Panova Senio

Re: [Pulp-dev] Cherry pick labeling

2020-03-18 Thread David Davis
I think it would be easy to automatically apply the cherry pick label with Github Actions. Github Actions has all sorts of events that can trigger workflows including opening a new PR[0]. This workflow could also automatically move the redmine issue to POST and comment with the PR too. [0] https:/

Re: [Pulp-dev] Cherry pick labeling

2020-03-18 Thread Tatiana Tereshchenko
I believe it's the responsibility of both the author and the PR reviewer. If it's a one-time contribution from someone, then the PR reviewer is likely the one who is aware whether the cherry-pick should be done or not. However in the majority of cases, we have regular contributors and they are awa

[Pulp-dev] Cherry pick labeling

2020-03-17 Thread David Davis
Today we missed a change that could have maybe have gone out with the 3.2 release. It stemmed from a lack of clarity around whose responsibility it is to label PRs with the cherry pick label. I think the general agreement is that it's ultimately the responsibility of the PR reviewer to add this lab