On Thu, Dec 4, 2014 at 8:42 PM, Peter Meerwald wrote:
> Hello David,
>
>> > I am still trying to valgrind pulseaudio. The previous attempt yielded
>> > nothing about the bug that I was trying to debug, but found a Bluetooth
>> > issue. This time, I thought that maybe some memory pool or flist was
Hello David,
> > I am still trying to valgrind pulseaudio. The previous attempt yielded
> > nothing about the bug that I was trying to debug, but found a Bluetooth
> > issue. This time, I thought that maybe some memory pool or flist was
> > causing valgrind to mistakenly consider the samples to be
05.12.2014 02:06, David Henningsson wrote:
In case PA_MEMPOOL_DISABLE is set, pa_memblock_new_pool can return
NULL. It does not make sense to set up a srbchannel without a shared
memory pool, so just fail in this case.
The patch indeed avoids the assertion failure. Thanks!
Reported-by: Alexa
On 2014-12-04 18:54, Alexander E. Patrakov wrote:
Hello.
I am still trying to valgrind pulseaudio. The previous attempt yielded
nothing about the bug that I was trying to debug, but found a Bluetooth
issue. This time, I thought that maybe some memory pool or flist was
causing valgrind to mista
In case PA_MEMPOOL_DISABLE is set, pa_memblock_new_pool can return
NULL. It does not make sense to set up a srbchannel without a shared
memory pool, so just fail in this case.
Reported-by: Alexander Patrakov
Signed-off-by: David Henningsson
---
src/pulsecore/srbchannel.c | 3 +++
1 file changed
(I have also looked at previous patches in the series, but have no
comments about them)
04.12.2014 23:44, Tanu Kaskinen wrote:
+void pa_tunnel_manager_remote_server_new(pa_tunnel_manager *manager,
pa_tunnel_manager_remote_server_config *config) {
Why void? There are some failure conditions (
This doesn't change the behaviour in any important way. The purpose of
this move is to provide access to logind from multiple modules without
needing to use the logind API from more than one place. Currently
there's only one module using liblogind.so, but module-tunnel-manager
will need seat tracki
The initial use case for this module is to connect user PulseAudio
instances to the system instance via tunnel sinks and sources. This
is the so called "cascaded setup". The point of doing that is to allow
multiple users to access the same hardware simultaneously.
The module connects to zero or mo
This makes the tunnel manager load tunnel sinks and sources for all
devices in the remote servers, except for monitor sources.
---
src/modules/tunnel-manager/remote-device.c | 93 ++
src/modules/tunnel-manager/remote-device.h | 3 +
2 files changed, 96 insertions(+)
d
When using PulseAudio in system mode, it may be interesting to know
which seats the devices are assigned to. This will be used in the
tunnel manager to filter out the devices that belong to other users.
---
src/modules/udev-util.c | 9 +
src/modules/udev-util.h | 2 ++
2 files changed, 11
When running a user PulseAudio instance on top of the system instance,
seat tracking will be useful for filtering out devices in the system
instance that belong to some other user.
---
src/modules/logind/logind.c | 107
src/modules/logind/logind.h | 13
There's no real configurability yet, because only one condition is
supported. Support for more conditions will be added later.
The syntax of the configuration option pretends to be some programming
language:
[General]
remote-device-tunnel-enabled-condition = !device.is_monitor
However, h
This is needed by the tunnel manager. It feels a bit silly to
introduce new source files for just this function, but I couldn't
think of any other appropriate place. pa_device_type_t is defined
in pulse/def.h, and that's not an appropriate place for any
functions.
---
src/Makefile.am |
This allows the tunnel manager to avoid devices that belong to some
other user.
The remote-device-tunnel-enabled-condition option in
tunnel-manager.conf now supports two values, describing two different
policies for enabling a tunnel for a given remote device:
"!device.is_monitor"
"!devic
Here's yet another version of module-tunnel-manager. New in v3:
* The libtunnel-manager code is split into more files, because
tunnel-manager.c started to get rather big.
* The policy of choosing which devices to create tunnels for is now
configurable. Previously the hard-coded policy was
This is useful in log messages that aren't translated (we already have
pa_yes_no(), but that returns translated strings).
---
src/pulsecore/core-util.h | 4
1 file changed, 4 insertions(+)
diff --git a/src/pulsecore/core-util.h b/src/pulsecore/core-util.h
index 8db56c5..b880075 100644
--- a/
---
src/pulsecore/core.h | 1 +
src/pulsecore/module.c | 2 ++
2 files changed, 3 insertions(+)
diff --git a/src/pulsecore/core.h b/src/pulsecore/core.h
index 1f9df73..db7308c 100644
--- a/src/pulsecore/core.h
+++ b/src/pulsecore/core.h
@@ -128,6 +128,7 @@ typedef enum pa_core_hook {
PA_CO
This prepares for loading tunnel sink and source module instances from
the tunnel manager.
If the tunnel manager is available, and the tunnel manager has
sample spec and channel map information for the device, then let's use
that information when creating the sink or source so that the tunnel
will
Hello.
I am still trying to valgrind pulseaudio. The previous attempt yielded
nothing about the bug that I was trying to debug, but found a Bluetooth
issue. This time, I thought that maybe some memory pool or flist was
causing valgrind to mistakenly consider the samples to be properly
initial
See objections to the code in this email:
http://lists.freedesktop.org/archives/pulseaudio-discuss/2014-March/020174.html
Signed-off-by: Alexander E. Patrakov
---
src/modules/module-equalizer-sink.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/modules/module-equalizer-sink.c
b/sr
For module-equalizer-sink, I have used the agreed-upon wording.
For module-dbus-protocol, I have tried to write something similar.
Alexander E. Patrakov (2):
Warn on loading module-equalizer-sink
Warn on loading module-dbus-protocol
src/modules/dbus/module-dbus-protocol.c | 5 +
src/modu
See also
https://www.mail-archive.com/ubuntu-audio-dev@lists.launchpad.net/msg00268.html
The warning may be useful for users who carried over the module-loading
statement from default configuration files shipped with old PulseAudio
versions.
Signed-off-by: Alexander E. Patrakov
---
src/modules/
22 matches
Mail list logo
