In some cases, depending on the instruction that performs the load, orc
ignores the size of the parameter when loading it for the first time.
Explicitly load the parameter into a temp to make sure it is loaded
correctly, like we do for the 2ch case.
See
On Fri, 2015-01-02 at 14:22 +0100, Peter Meerwald wrote:
the description of pa_dynarray_last() should be something like
Returns a pointer to the last element or NULL if the array is empty.
Ok, I'll fix it and send a new patch series. Did you review the whole
series, or only this one patch?
--
This fixes crashes when trying to use module-rtp-recv or
module-combine-sink together with module-tunnel-sink-new.
module-rtp-recv and module-combine-sink assume that all IO threads use
pa_rtpoll.
BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=73429
---
The PA_DYNARRAY_FOREACH macro requires that pa_dynarray_get() returns
NULL if the index is out of bounds.
---
src/pulsecore/dynarray.c | 4 +++-
src/pulsecore/dynarray.h | 5 +
src/pulsecore/tokenizer.c | 3 ---
3 files changed, 8 insertions(+), 4 deletions(-)
diff --git
Also, remove the talk about fast variants of functions that remove
entries from an array. Currently there's no need for order-preserving
functions, so all functions are fast.
---
src/pulsecore/dynarray.c | 18 ++
src/pulsecore/dynarray.h | 12 ++--
2 files changed, 24
---
src/pulsecore/dynarray.c | 9 +
src/pulsecore/dynarray.h | 3 +++
2 files changed, 12 insertions(+)
diff --git a/src/pulsecore/dynarray.c b/src/pulsecore/dynarray.c
index b207eca..82db496 100644
--- a/src/pulsecore/dynarray.c
+++ b/src/pulsecore/dynarray.c
@@ -79,6 +79,15 @@ void
This fixes crashes when trying to use module-tunnel-sink-new together
with module-rtp-recv or module-combine-sink.
Changes in v2: improved documentation for pa_dynarray_get() and
pa_dynarray_last().
Tanu Kaskinen (6):
dynarray: Add pa_dynarray_last()
dynarray: Add
---
src/pulsecore/dynarray.c | 20
src/pulsecore/dynarray.h | 5 +
2 files changed, 25 insertions(+)
diff --git a/src/pulsecore/dynarray.c b/src/pulsecore/dynarray.c
index 392e7d6..d6ef3b8 100644
--- a/src/pulsecore/dynarray.c
+++ b/src/pulsecore/dynarray.c
@@ -106,6
08.01.2015 01:52, Andrey Semashev wrote:
Do I understand correctly that you tried to enforce 8 ms (or 2?)
latency in PA? If so then I would rather dismiss it since, as we know,
soxr latency is around 20 ms, sometimes more, and you can't achieve 8
ms with it.
Yes, the whole post (including the
On Wed, Jan 7, 2015 at 7:39 PM, Peter Meerwald pme...@pmeerw.net wrote:
case PA_RESAMPLER_PEAKS:
-if (a == PA_SAMPLE_S16NE || b == PA_SAMPLE_S16NE)
-work_format = PA_SAMPLE_S16NE;
Were the rows above removed on purpose? I suppose the behaviour
On Wed, 2015-01-07 at 17:54 +0100, Peter Meerwald wrote:
On Fri, 2015-01-02 at 14:22 +0100, Peter Meerwald wrote:
the description of pa_dynarray_last() should be something like
Returns a pointer to the last element or NULL if the array is empty.
Ok, I'll fix it and send a new patch
This is an updated set of patches first announced and discussed here:
looks good, patch 2/4 seems to be missing (not posted?)
some mention of the first soxr patch series would be nice,
http://lists.freedesktop.org/archives/pulseaudio-discuss/2014-August/021050.html
p.
--
Peter Meerwald
On Fri, 2015-01-02 at 14:22 +0100, Peter Meerwald wrote:
the description of pa_dynarray_last() should be something like
Returns a pointer to the last element or NULL if the array is empty.
Ok, I'll fix it and send a new patch series. Did you review the whole
series, or only this one
Hello,
On Wednesday 07 January 2015 15:41:14 David Henningsson wrote:
On 2015-01-07 15:08, Andrey Semashev wrote:
Added ID and names for the resampler presets and also corrected the
working sample rate deduction to take the new resampler into account.
Removed duplicate condition
07.01.2015 15:14, Alexander E. Patrakov wrote:
I will retest with qemu (via its alsa backend) later today.
Done, both for pa and alsa backends. I must say that soxr-based
resamplers break a configuration that worked fine (except the initial
period of several seconds) with speex-float-5.
The new backend supports 3 quality levels: mq, hq and vhq; 16-bit integer and
32-bit float samples. Discussion and quality assessment are here:
http://comments.gmane.org/gmane.comp.audio.pulseaudio.general/22158
---
src/pulsecore/resampler/soxr.c | 171 +
---
man/pulse-daemon.conf.5.xml.in | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/man/pulse-daemon.conf.5.xml.in b/man/pulse-daemon.conf.5.xml.in
index 754312e..e1ee673 100644
--- a/man/pulse-daemon.conf.5.xml.in
+++ b/man/pulse-daemon.conf.5.xml.in
@@ -88,7
---
configure.ac| 17 +
src/Makefile.am | 6 ++
2 files changed, 23 insertions(+)
diff --git a/configure.ac b/configure.ac
index 2ccf094..23144d1 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1140,6 +1140,21 @@ AS_IF([test x$with_speex = xyes test
x$HAVE_SPEEX =
On 2015-01-07 15:08, Andrey Semashev wrote:
Added ID and names for the resampler presets and also corrected the working
sample rate deduction to take the new resampler into account. Removed duplicate
condition checks from the deduction code.
---
src/pulsecore/resampler.c | 23
19 matches
Mail list logo
