Re: [pulseaudio-discuss] [RFC PATCH 2/4] switch-on-port-available: Change criteria for keeping the active profile

2018-11-22 Thread Tanu Kaskinen
On Wed, 2018-11-21 at 11:43 -0800, João Paulo Rechi Vita wrote: > Hello Tanu! Sorry it took me so long to get back on this issue, but I > was busy with some urgent things lately. Please find my reply in-line > below. No problem! > On Sun, Oct 7, 2018 at 12:46 AM Tanu Kaskinen wrote

Re: [pulseaudio-discuss] [PATCH v2] Absolute volume control for A2DP transport

2018-11-16 Thread Tanu Kaskinen
Thanks for the patch! Before I'll review the patch, can you resubmit it using "git send-email"? The patch doesn't apply in its current form, because lines are wrapped (there might be other formatting issues as well). "git send-email" is guaranteed to produce well-formatted patches. Instructions

Re: [pulseaudio-discuss] [PATCH v5] alsa-sink/source, sink, source: Consider sample format for avoid-resampling/passthrough

2018-11-15 Thread Tanu Kaskinen
On Fri, 2018-11-16 at 01:12 +0900, Sangchul Lee wrote: > Sample format(e.g. 16 bit, 24 bit) was not considered even if the > avoid-resampling option is set or the passthrough mode is used. > This patch checks both sample format and rate of a stream to > determine whether to avoid resampling in

Re: [pulseaudio-discuss] Weak bass in stereo mode – possibility of virtual 2.1 sound profiles

2018-11-15 Thread Tanu Kaskinen
On Thu, 2018-11-15 at 23:50 +0500, Alexander E. Patrakov wrote: > Alexander E. Patrakov : > > Tanu Kaskinen : > > > On Sat, 2018-10-13 at 22:29 +0500, Alexander E. Patrakov wrote: > > > > Note that I am unhappy with it, because it fixes only a particular > >

Re: [pulseaudio-discuss] Weak bass in stereo mode – possibility of virtual 2.1 sound profiles

2018-11-15 Thread Tanu Kaskinen
On Sat, 2018-10-13 at 22:29 +0500, Alexander E. Patrakov wrote: > On 10/7/18 6:27 PM, Alexander E. Patrakov wrote: > > вс, 7 окт. 2018 г. в 16:42, Karl Ove Hufthammer > >: > > > > Alexander E. Patrakov skreiv 07.10.2018 09:44: > > > > > > I don’t

Re: [pulseaudio-discuss] [PATCH v4] alsa-sink/source, sink, source: Consider sample format for avoid-resampling/passthrough

2018-11-14 Thread Tanu Kaskinen
On Wed, 2018-10-31 at 23:48 +0900, Sangchul Lee wrote: > Sample format(e.g. 16 bit, 24 bit) was not considered even if the > avoid-resampling option is set or the passthrough mode is used. > This patch checks both sample format and rate of a stream to > determine whether to avoid resampling in

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2018-11-08 Thread Tanu Kaskinen
On Tue, 2018-11-06 at 21:14 +, Andrea A wrote: > Thanks a lot for the reply > > > If the preset files are expected to be shared between users, then the > database.h stuff isn't good, because different users can have their > pulseaudio configured with different database formats. I like the

Re: [pulseaudio-discuss] PulseAudio null sink monitor gives distorted audio randomly

2018-11-08 Thread Tanu Kaskinen
On Thu, 2018-11-08 at 14:56 +0500, Alexander E. Patrakov wrote: > Mikael Nousiainen : > > > I've got a very weird issue with PulseAudio when trying to route audio > > from one application (Firefox 64.0b7 (64-bit)) to another one (WSJT-X > > v1.9.1). > > I'm experiencing the same issue with

Re: [pulseaudio-discuss] New equalizer module (module-eqpro-sink), some questions

2018-11-06 Thread Tanu Kaskinen
On Mon, 2018-11-05 at 00:14 +0500, Alexander E. Patrakov wrote: > Andrea A : > > I'm writing a new equalizer module for PA, > > https://github.com/andrea993/audioeqpro/blob/master/pulsemodule/module-eqpro-sink.c > > I've almost done but I need some information from developer about how to > >

Re: [pulseaudio-discuss] [PATCH v3] alsa-sink/source, sink, source: Consider sample format for avoid-resampling/passthrough

2018-10-30 Thread Tanu Kaskinen
On Fri, 2018-09-28 at 01:37 +0900, Sangchul Lee wrote: > Sample format(e.g. 16 bit, 24 bit) was not considered even if the > avoid-resampling option is set or the passthrough mode is used. > This patch checks both sample format and rate of a stream to > determine whether to avoid resampling in

Re: [pulseaudio-discuss] avoid-resampling -> avoid-processing

2018-10-25 Thread Tanu Kaskinen
On Mon, 2018-10-15 at 09:59 +0530, Arun Raghavan wrote: > > On Thu, 27 Sep 2018, at 11:13 AM, Sangchul Lee wrote: > > 2018년 9월 27일 (목) 오후 12:30, Arun Raghavan 님이 작성: > > > On Wed, 26 Sep 2018, at 5:15 PM, Sangchul Lee wrote: > > > > > > We could provide more fine-grained control

Re: [pulseaudio-discuss] volume-test failed in 1.12.2

2018-10-12 Thread Tanu Kaskinen
On Sat, 2018-08-18 at 22:08 +0100, Ken Moffat wrote: > Testing this prior to updating Beyond LinuxFromScratch I got a test > failure, so reporting as asked. > > = >pulseaudio 12.2: src/test-suite.log > = > > #

Re: [pulseaudio-discuss] [RFC PATCH 4/4] switch-on-connect: Do not ignore HDMI sinks

2018-10-09 Thread Tanu Kaskinen
On Tue, 2018-08-07 at 22:00 -0700, João Paulo Rechi Vita wrote: > HDMI ports are normally present on cards connected to an internal bus, > and module-switch-on-connect should switch to them when a HDMI monitor > is plugged. > > This is specially relevant on setups where the HDMI port of a machine

Re: [pulseaudio-discuss] [RFC PATCH 3/4] alsa-card: Switch profile when the active one becomes unavailable

2018-10-09 Thread Tanu Kaskinen
On Tue, 2018-08-07 at 22:00 -0700, João Paulo Rechi Vita wrote: > When the active profile of a card becomes unavailable and no other > module changes it to a better profile (i.e. there are no available ports > that module-switch-on-port-available could switch to) the card will be > stuck on an

Re: [pulseaudio-discuss] can rewindings in the null sink produce noises in programs recording its monitor?

2018-10-09 Thread Tanu Kaskinen
On Sat, 2018-10-06 at 15:29 -0300, wellington wallace wrote: > Hi! PulseEffects developer here again. > > Like the title says I'd like to know if rewinds can cause crackling noises > when we are recording from a null sink monitor. Yes it can:

Re: [pulseaudio-discuss] [RFC PATCH 2/4] switch-on-port-available: Change criteria for keeping the active profile

2018-10-07 Thread Tanu Kaskinen
On Fri, 2018-10-05 at 18:26 -0700, João Paulo Rechi Vita wrote: > On Wed, Oct 3, 2018 at 3:22 AM Tanu Kaskinen wrote: > > On Tue, 2018-08-07 at 22:00 -0700, João Paulo Rechi Vita wrote: > > > Prefer the active profile only if it has ports with available status YES > >

Re: [pulseaudio-discuss] [RFC PATCH 2/4] switch-on-port-available: Change criteria for keeping the active profile

2018-10-03 Thread Tanu Kaskinen
On Tue, 2018-08-07 at 22:00 -0700, João Paulo Rechi Vita wrote: > Prefer the active profile only if it has ports with available status YES > on the same direction of the port we are trying to switch to and a > higher priority than whichever profile we would select to switch to a > new port. I

Re: [pulseaudio-discuss] [RFC PATCH 1/4] card: New API pa_card_profile_has_available_ports

2018-10-03 Thread Tanu Kaskinen
On Tue, 2018-08-07 at 22:00 -0700, João Paulo Rechi Vita wrote: > New function to check if a card has any ports with a certain > availability for a specific direction. > > This was built uppon previous work by Mario Sanchez Prada. > --- > src/pulsecore/card.c | 18 ++ >

Re: [pulseaudio-discuss] [PATCH 0/7] Misc cleanups

2018-10-03 Thread Tanu Kaskinen
On Tue, 2018-08-07 at 20:39 -0700, João Paulo Rechi Vita wrote: > I've been refactoring and expanding the audio-routing patches we carry > downstream at Endless and ended-up with a few cleanup patches in the > process. Basically they make the code a bit easier to read and > understand (hopefully

Re: [pulseaudio-discuss] Audio APP (sink-input) bind to the sink with only unplugged hdmi-audio ports on it

2018-10-02 Thread Tanu Kaskinen
On Mon, 2018-10-01 at 10:18 +0800, Hui Wang wrote: > On 2018年09月30日 18:30, Tanu Kaskinen wrote: > > On Sun, 2018-09-30 at 15:03 +0800, Hui Wang wrote: > > > This issue is also reported to: > > > https://gitlab.freedesktop.org/pulseaudio/pulseaudio/issues/579 > > &

Re: [pulseaudio-discuss] Audio APP (sink-input) bind to the sink with only unplugged hdmi-audio ports on it

2018-09-30 Thread Tanu Kaskinen
On Sun, 2018-09-30 at 15:03 +0800, Hui Wang wrote: > This issue is also reported to: > https://gitlab.freedesktop.org/pulseaudio/pulseaudio/issues/579 > > Recently we found a weird issue on many laptops with the ubuntu 18.04, > it uses the pulseaudio-11.1 (I guess the PA of the latest version

Re: [pulseaudio-discuss] avoid-resampling -> avoid-processing

2018-09-24 Thread Tanu Kaskinen
On Fri, 2018-09-21 at 19:09 +0530, Arun Raghavan wrote: > > On Fri, 21 Sep 2018, at 6:47 PM, Arun Raghavan wrote: > > On Fri, 21 Sep 2018, at 4:33 PM, Sangchul Lee wrote: > > > > I'm thinking that we should change the avoid resampling flag on sinks > > > > to instead be avoid processing -- the

Re: [pulseaudio-discuss] avoid-resampling -> avoid-processing

2018-09-23 Thread Tanu Kaskinen
On Wed, 2018-09-19 at 17:59 +0530, Arun Raghavan wrote: > Hello, > I'm thinking that we should change the avoid resampling flag on sinks > to instead be avoid processing -- the idea being that we try not just > to reconfigure to a given sample rate, but for the entire sample spec > (and eventually

Re: [pulseaudio-discuss] Bluetooth A2DP aptX codec quality

2018-09-18 Thread Tanu Kaskinen
On Fri, 2018-09-14 at 15:43 +0300, ValdikSS wrote: > On 13/09/2018 11:23, Tanu Kaskinen wrote: > > > > How is the bitrate calculated? I'd like to write a section on the > > Bluetooth wiki page[1] that explains the SBC codec with a table showing > > how the different pa

Re: [pulseaudio-discuss] [PATCH v2 2/2] Bluetooth A2DP aptX codec support

2018-09-17 Thread Tanu Kaskinen
On Thu, 2018-09-13 at 11:12 +0200, Pali Rohár wrote: > On Wednesday 05 September 2018 13:57:08 Tanu Kaskinen wrote: > > > + Bluetooth A2DP aptX codec (optional) ### > > > + > > > +AC_ARG_ENABLE([aptx], > > > +AS_HELP_STRING([--disable-aptx],[Disa

Re: [pulseaudio-discuss] [PATCH v2 1/2] Modular API for Bluetooth A2DP codec

2018-09-17 Thread Tanu Kaskinen
(I sent my review both to you and to the list, but you replied only privately - probably not on purpose. I'll send this mail only to the list.) On Thu, 2018-09-13 at 10:54 +0200, Pali Rohár wrote: > On Tuesday 04 September 2018 11:44:10 Tanu Kaskinen wrote: > > Using libopenaptx

Re: [pulseaudio-discuss] Bluetooth A2DP aptX codec quality

2018-09-13 Thread Tanu Kaskinen
On Wed, 2018-09-12 at 19:03 +0300, Luiz Augusto von Dentz wrote: > Hi Pali, > > On Wed, Sep 12, 2018 at 1:42 PM, Pali Rohár wrote: > > Hello! > > > > I would like to let you know that Serge from soundexpert.org did in last > > month some research on aptX and its quality. Detailed article is on

Re: [pulseaudio-discuss] [PATCH v2 2/2] Bluetooth A2DP aptX codec support

2018-09-05 Thread Tanu Kaskinen
On Sat, 2018-07-28 at 17:34 +0200, Pali Rohár wrote: > This patch provides support for aptX codec in bluetooth A2DP profile. In > pulseaudio it is implemented as a new profile a2dp_aptx_sink. For aptX > encoding it uses open source LGPLv2.1+ licensed libopenaptx library which > can be found at

Re: [pulseaudio-discuss] [PATCH v2 1/2] Modular API for Bluetooth A2DP codec

2018-09-05 Thread Tanu Kaskinen
On Tue, 2018-09-04 at 11:44 +0300, Tanu Kaskinen wrote: > On Sat, 2018-07-28 at 17:34 +0200, Pali Rohár wrote: > > +static size_t pa_sbc_select_configuration(const pa_sample_spec > > *sample_spec, const uint8_t *capabilities_buffer, size_t capabilities_size, > > uint8_t *

Re: [pulseaudio-discuss] [PATCH v2 1/2] Modular API for Bluetooth A2DP codec

2018-09-04 Thread Tanu Kaskinen
Hi Pali! Thanks a lot for working on this! Arun has been strongly advocating using GStreamer, and I don't know if his position is that "AptX must be implemented with GStreamer or not implemented at all". I hope not. To me the library choice is not important. Using libopenaptx directly doesn't

Re: [pulseaudio-discuss] Gitlab CI

2018-08-27 Thread Tanu Kaskinen
On Mon, 2018-08-27 at 16:36 +0530, Arun Raghavan wrote: > Hey folks, > I've now pushed and enabled CI for our gitlab instance. This runs in > an Ubuntu 18.04-based docker image, Dockerfile is in scripts/. For > now the image is manually uploaded onto our fd.o docker registry, > but it would be

Re: [pulseaudio-discuss] [PATCH 8/8] message-params: Add read functions for arrays

2018-08-16 Thread Tanu Kaskinen
On Wed, 2018-08-15 at 21:31 +0200, Georg Chini wrote: > Thank you for your reviews. It will probably take until October before I can > send a new series. OK, no problem! -- Tanu https://www.patreon.com/tanuk https://liberapay.com/tanuk ___

Re: [pulseaudio-discuss] [PATCH v2] alsa-sink/source, sink, source: Consider sample format for avoid-resampling/passthrough

2018-08-13 Thread Tanu Kaskinen
On Sat, 2018-07-28 at 00:38 +0900, Sangchul Lee wrote: > Sample format(e.g. 16 bit, 24 bit) was not considered even if the > avoid-resampling option is set or the passthrough mode is used. > This patch checks both sample format and rate of a stream to > determine whether to avoid resampling in

Re: [pulseaudio-discuss] [PATCH] card: Log availability status when choosing initial profile

2018-08-13 Thread Tanu Kaskinen
On Thu, 2018-07-26 at 13:57 -0700, João Paulo Rechi Vita wrote: > On Fri, Jun 29, 2018 at 5:02 AM, Tanu Kaskinen wrote: > > On Wed, 2018-06-27 at 15:01 -0700, João Paulo Rechi Vita wrote: > > > --- > > > src/pulsecore/card.c | 5 + > > > 1 file change

Re: [pulseaudio-discuss] [PATCH] Support the older model of NI's Traktor Audio 2 DJ

2018-08-13 Thread Tanu Kaskinen
On Mon, 2018-07-23 at 13:39 +0100, Will Stott wrote: > From: Will Stott > > --- > src/modules/alsa/mixer/profile-sets/90-pulseaudio.rules | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/modules/alsa/mixer/profile-sets/90-pulseaudio.rules >

Re: [pulseaudio-discuss] [PATCH 0/8] *** Overview ***

2018-08-12 Thread Tanu Kaskinen
On Mon, 2018-07-16 at 20:25 -0400, Yclept Nemo wrote: > Module zeroconf-discover would add the same sink twice: once over IPv4, once > over IPv6. Fixes: > > * Options to disable IPv4 and IPv6. If both options are provided, the module >fails to load. > * Option to only load one tunnel per

Re: [pulseaudio-discuss] [PATCH 7/8] Fix pa_object_new macro (missing close paren)

2018-08-12 Thread Tanu Kaskinen
On Mon, 2018-07-16 at 20:25 -0400, Yclept Nemo wrote: > --- > src/pulsecore/object.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/pulsecore/object.h b/src/pulsecore/object.h > index b3d500e2..15e8365b 100644 > --- a/src/pulsecore/object.h > +++

Re: [pulseaudio-discuss] [PATCH 5/8] Fixes

2018-08-12 Thread Tanu Kaskinen
Please include these fixes in the original patches. On Mon, 2018-07-16 at 20:25 -0400, Yclept Nemo wrote: > --- > src/modules/module-tunnel-sink-new.c | 2 +- > src/modules/module-tunnel-source-new.c | 2 +- > src/modules/module-zeroconf-discover.c | 21 + > 3 files

Re: [pulseaudio-discuss] [PATCH 4/8] tunnel*: put sink/source after authentication

2018-08-12 Thread Tanu Kaskinen
On Mon, 2018-07-16 at 20:25 -0400, Yclept Nemo wrote: > Call 'pa_sink_put' or 'pa_source_put' after the connection is > authorized. For the new tunnel modules this involves sending a > module-specific message from the IO thread to the main thread. On > receipt the sink/source message handler calls

Re: [pulseaudio-discuss] [PATCH 3/8] zeroconf-discover: add argument 'one_per_name_type'

2018-08-11 Thread Tanu Kaskinen
On Mon, 2018-07-16 at 20:25 -0400, Yclept Nemo wrote: > If 'one_per_name_type' is true, only add one tunnel per avahi service > name and type. In effect, do not add more than one sink or source per > remote pulseaudio server. Is avahi service name the address? And is service type sink or source?

Re: [pulseaudio-discuss] [PATCH 2/8] zeroconf-discover: fix memory issues

2018-08-11 Thread Tanu Kaskinen
On Mon, 2018-07-16 at 20:25 -0400, Yclept Nemo wrote: > Fix memory leak and prevent posible double-free. > --- > src/modules/module-zeroconf-discover.c | 20 +--- > 1 file changed, 17 insertions(+), 3 deletions(-) > > diff --git a/src/modules/module-zeroconf-discover.c >

Re: [pulseaudio-discuss] [PATCH 1/8] zeroconf-discover: add arguments to disable ipv4/6

2018-08-11 Thread Tanu Kaskinen
On Mon, 2018-07-16 at 20:25 -0400, Yclept Nemo wrote: > --- > src/modules/module-zeroconf-discover.c | 57 > +++--- > 1 file changed, 53 insertions(+), 4 deletions(-) Thanks for the patches! Please always explain in the commit message why the change is done. I don't

Re: [pulseaudio-discuss] [PATCH] pacat: Fix code style

2018-08-11 Thread Tanu Kaskinen
On Sun, 2018-07-15 at 23:58 +0200, shu...@sthu.org wrote: > From: Stefan Huber > > --- > src/utils/pacat.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/utils/pacat.c b/src/utils/pacat.c > index 6c4db4bb..275fb7c7 100644 > --- a/src/utils/pacat.c > +++

Re: [pulseaudio-discuss] [PATCH 0/2] [paprefs] Port to gdbus

2018-08-11 Thread Tanu Kaskinen
On Sun, 2018-07-15 at 15:56 +0200, Jan Tojnar wrote: > I wanted to get rid of the deprecated dbus-glib dependency in favour of > GDBus built into GLib. > > I tested the Install button and it does seem to open GNOME Software correctly, > and the DBus message sent by the app is the same as the one

Re: [pulseaudio-discuss] [PATCH] Suppress udev detection of sound card for some units on IEEE 1394 bus

2018-08-11 Thread Tanu Kaskinen
On Sun, 2018-07-15 at 19:57 +0900, Takashi Sakamoto wrote: > A bug was filed to bugzilla.kernel.org for a quirk of some models which > ALSA BeBoB driver supports. > > Bug 199365 - repeating bus resets on Firewire bus with Focusrite Saffaire > 26/io >

Re: [pulseaudio-discuss] [PATCH 3/3] module-role-ducking: Add argument duck_while_corked

2018-08-11 Thread Tanu Kaskinen
On Fri, 2018-07-13 at 11:21 +0300, Juho Hämäläinen wrote: > With this enabled when trigger stream is available but > in corked state trigger is already applied to interaction > streams. This is useful when trigger stream pauses for > a while before playing, so that the trigger happens > slightly

Re: [pulseaudio-discuss] [PATCH 8/8] message-params: Add read functions for arrays

2018-08-11 Thread Tanu Kaskinen
On Mon, 2018-04-09 at 19:35 +0200, Georg Chini wrote: > --- > doc/messaging_api.txt | 5 ++ > src/map-file | 4 + > src/pulse/message-params.c | 202 > + > src/pulse/message-params.h | 12 +++ > 4 files changed, 223

Re: [pulseaudio-discuss] [PATCH 2/3] stream-interaction: Update interaction logic.

2018-08-07 Thread Tanu Kaskinen
On Fri, 2018-07-13 at 11:21 +0300, Juho Hämäläinen wrote: > Stream interaction groups now have hashmaps for all trigger and interaction > states and roles. We track both trigger streams and interaction streams > separately, so that applying interaction (ducking or cork and muting) is > relatively

Re: [pulseaudio-discuss] [PATCH 7/8] message-params: Add read/write functions for various simple data types

2018-08-06 Thread Tanu Kaskinen
On Mon, 2018-04-09 at 19:35 +0200, Georg Chini wrote: > See doc/messaging_api.txt for the added functions. All read functions > return 1 on success, 0 if end of string is found and -1 on parse error. > Additionally, for the numeric/boolean read functions, 2 is returned if > the list element is

Re: [pulseaudio-discuss] [PATCH v2 0/2] Bluetooth A2DP aptX codec support

2018-08-06 Thread Tanu Kaskinen
On Mon, 2018-08-06 at 13:52 +0300, Tanu Kaskinen wrote: > On Mon, 2018-08-06 at 10:25 +0200, Pali Rohár wrote: > > On Friday 03 August 2018 12:45:51 Tanu Kaskinen wrote: > > > On Fri, 2018-08-03 at 10:33 +0200, Pali Rohár wrote: > > > > On Saturday 28 July

Re: [pulseaudio-discuss] [PATCH v2 0/2] Bluetooth A2DP aptX codec support

2018-08-06 Thread Tanu Kaskinen
On Mon, 2018-08-06 at 10:25 +0200, Pali Rohár wrote: > On Friday 03 August 2018 12:45:51 Tanu Kaskinen wrote: > > On Fri, 2018-08-03 at 10:33 +0200, Pali Rohár wrote: > > > On Saturday 28 July 2018 17:34:51 Pali Rohár wrote: > > > > This patch series moves A2DP codec

Re: [pulseaudio-discuss] [PATCH v2 0/2] Bluetooth A2DP aptX codec support

2018-08-03 Thread Tanu Kaskinen
On Fri, 2018-08-03 at 10:33 +0200, Pali Rohár wrote: > On Saturday 28 July 2018 17:34:51 Pali Rohár wrote: > > This patch series moves A2DP codec code into new modules and add > > support for Bluetooth A2DP aptX codec. > > > > Pali Rohár (2): > > Modular API for Bluetooth A2DP codec > >

Re: [pulseaudio-discuss] [PATCH 1/3] stream-interaction: Use LLIST for groups.

2018-08-01 Thread Tanu Kaskinen
On Fri, 2018-07-13 at 11:21 +0300, Juho Hämäläinen wrote: > Use LLIST instead of array for interaction groups, and refactor parsing. > Side effect from refactoring is that module-role-cork also now supports > interaction groups. The commit message could be clearer on *why* this change is made. Is

Re: [pulseaudio-discuss] [PATCH 6/8] message-params: Allow parameter strings to contain escaped curly braces

2018-08-01 Thread Tanu Kaskinen
On Mon, 2018-07-30 at 13:23 +0200, Georg Chini wrote: > On 30.07.2018 11:18, Tanu Kaskinen wrote: > > On Sun, 2018-07-29 at 22:36 +0200, Georg Chini wrote: > > > On 29.07.2018 21:47, Tanu Kaskinen wrote: > > > > On Fri, 2018-07-27 at 10:51 +0200, Georg Chini wrote:

Re: [pulseaudio-discuss] [PATCH 6/8] message-params: Allow parameter strings to contain escaped curly braces

2018-07-30 Thread Tanu Kaskinen
On Sun, 2018-07-29 at 22:36 +0200, Georg Chini wrote: > On 29.07.2018 21:47, Tanu Kaskinen wrote: > > On Fri, 2018-07-27 at 10:51 +0200, Georg Chini wrote: > > > On 27.07.2018 10:08, Tanu Kaskinen wrote: > > > > On Thu, 2018-07-26 at 18:02 +0200, Georg Chini wrote:

Re: [pulseaudio-discuss] [PATCH 6/8] message-params: Allow parameter strings to contain escaped curly braces

2018-07-29 Thread Tanu Kaskinen
On Fri, 2018-07-27 at 10:51 +0200, Georg Chini wrote: > On 27.07.2018 10:08, Tanu Kaskinen wrote: > > On Thu, 2018-07-26 at 18:02 +0200, Georg Chini wrote: > > > On 26.07.2018 12:37, Tanu Kaskinen wrote: > > > > On Sun, 2018-07-22 at 21:11 +0200, Georg Chini wrote:

[pulseaudio-discuss] [ANNOUNCE] paprefs 1.0

2018-07-29 Thread Tanu Kaskinen
module dir. Felipe Sateler (1): Port from GTK2 to GTK3 Jan Tojnar (1): Port to meson NicoHood (1): Added fixed port 5004 option for rtp sender Piotr Drąg (1): i18n: update Polish translation Sylvain Baubeau (1): Move from GConf to GSettings Tanu Kaskinen

Re: [pulseaudio-discuss] [PATCH 3/3] alsa-sink/source, sink, source: Consider sample format for avoid-resampling

2018-07-27 Thread Tanu Kaskinen
On Tue, 2018-07-10 at 23:48 +0900, Sangchul Lee wrote: > Thanks for the comments. > Before sharing new patchset, I have two questions about your comment. :) Sorry for the delay in replying, I'm quite a bit behind on the mailing list mails... > > > @@ -113,11 +113,20 @@ struct userdata { > > > >

Re: [pulseaudio-discuss] [PATCH] bluetooth: Add missing argument to module's usage

2018-07-27 Thread Tanu Kaskinen
On Thu, 2018-07-26 at 09:41 -0700, João Paulo Rechi Vita wrote: > On Mon, Jul 9, 2018 at 7:25 PM, João Paulo Rechi Vita > wrote: > > module-bluetooth-discover usage was missing the autodetect_mtu argument. > > --- > > src/modules/bluetooth/module-bluez5-discover.c | 1 + > > 1 file changed, 1

Re: [pulseaudio-discuss] [PATCH 6/8] message-params: Allow parameter strings to contain escaped curly braces

2018-07-27 Thread Tanu Kaskinen
On Thu, 2018-07-26 at 18:02 +0200, Georg Chini wrote: > On 26.07.2018 12:37, Tanu Kaskinen wrote: > > On Sun, 2018-07-22 at 21:11 +0200, Georg Chini wrote: > > > On 22.07.2018 17:48, Tanu Kaskinen wrote: > > > > On Sun, 2018-07-22 at 16:02 +0200, Georg Chini wrote:

Re: [pulseaudio-discuss] [PATCH 6/8] message-params: Allow parameter strings to contain escaped curly braces

2018-07-26 Thread Tanu Kaskinen
On Sun, 2018-07-22 at 21:11 +0200, Georg Chini wrote: > On 22.07.2018 17:48, Tanu Kaskinen wrote: > > On Sun, 2018-07-22 at 16:02 +0200, Georg Chini wrote: > > > On 21.07.2018 20:17, Tanu Kaskinen wrote: > > > > On Mon, 2018-04-09 at 19:35 +0200, Georg Chini w

[pulseaudio-discuss] [PATCH paprefs 5/8] README: add a news item for the upcoming release

2018-07-25 Thread Tanu Kaskinen
--- doc/README.html.in | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/README.html.in b/doc/README.html.in index 4170c73..f6ae93f 100644 --- a/doc/README.html.in +++ b/doc/README.html.in @@ -37,6 +37,11 @@ General Public License for more details. News +Soon: Version 1.0

[pulseaudio-discuss] [PATCH paprefs 6/8] README: remove reference to an ancient Debian version

2018-07-25 Thread Tanu Kaskinen
It's of little use to know that the initial version was written on an August 2006 version of Debian testing. --- doc/README.html.in | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/doc/README.html.in b/doc/README.html.in index f6ae93f..f75cd8a 100644 ---

[pulseaudio-discuss] [PATCH paprefs 4/8] README: remove the "Acknowledgements" section

2018-07-25 Thread Tanu Kaskinen
Acknowledging people's contributions is nice, but I don't like the chore of keeping the section up to date. --- doc/README.html.in | 7 --- 1 file changed, 7 deletions(-) diff --git a/doc/README.html.in b/doc/README.html.in index d6b1c99..4170c73 100644 --- a/doc/README.html.in +++

[pulseaudio-discuss] [PATCH paprefs 2/8] README: remove the copyright notice

2018-07-25 Thread Tanu Kaskinen
The copyright notice would need updating, because there are also others than Lennart who own copyrights to paprefs, and the years are out of date. Having to continuously update the copyright years seems just unnecessary churn to me. Interested people can browse the git history if they're

[pulseaudio-discuss] [PATCH paprefs 8/8] README: remove the page footer

2018-07-25 Thread Tanu Kaskinen
Keeping the footer up to date is extra work with little benefit. --- doc/README.html.in | 2 -- 1 file changed, 2 deletions(-) diff --git a/doc/README.html.in b/doc/README.html.in index 2f4e843..81dc09b 100644 --- a/doc/README.html.in +++ b/doc/README.html.in @@ -118,8 +118,6 @@ compilation and

[pulseaudio-discuss] [PATCH paprefs 7/8] README: clarify the PulseAudio version requirement

2018-07-25 Thread Tanu Kaskinen
It sounded like the only supported PulseAudio version would be 12.0. --- doc/README.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/README.html.in b/doc/README.html.in index f75cd8a..2f4e843 100644 --- a/doc/README.html.in +++ b/doc/README.html.in @@ -88,7 +88,7 @@

[pulseaudio-discuss] [PATCH paprefs 1/8] remove the autotools build system

2018-07-25 Thread Tanu Kaskinen
The port to Meson broke the .desktop file translations when using the autotools build system: https://lists.freedesktop.org/archives/pulseaudio-discuss/2018-July/030248.html Rather than spending effort on fixing the issue, let's just remove the autotools build system, since we don't really need

[pulseaudio-discuss] [PATCH paprefs 3/8] README: add "Bug Reports" and "Contributing Code" sections

2018-07-25 Thread Tanu Kaskinen
--- doc/README.html.in | 9 + 1 file changed, 9 insertions(+) diff --git a/doc/README.html.in b/doc/README.html.in index eab824f..d6b1c99 100644 --- a/doc/README.html.in +++ b/doc/README.html.in @@ -20,6 +20,8 @@ Installation Acknowledgements Download +Bug Reports +

[pulseaudio-discuss] [PATCH paprefs 0/8] Remove autotools and update README

2018-07-25 Thread Tanu Kaskinen
The README patches are the same that I submitted earlier with a couple of changes: the news section now mentions that autotools has been replaced with meson, and one commit message needed tweaking now that we've had a couple of PulseAudio releases after 12.0. Tanu Kaskinen (8): remove

Re: [pulseaudio-discuss] [PATCH 6/8] message-params: Allow parameter strings to contain escaped curly braces

2018-07-22 Thread Tanu Kaskinen
On Sun, 2018-07-22 at 16:02 +0200, Georg Chini wrote: > On 21.07.2018 20:17, Tanu Kaskinen wrote: > > On Mon, 2018-04-09 at 19:35 +0200, Georg Chini wrote: > > > The patch adds the possibility to escape curly braces within parameter > > > strings > > >

Re: [pulseaudio-discuss] [PATCH v2] card-restore: Don't restore profile on Bluetooth cards by default

2018-07-22 Thread Tanu Kaskinen
On Fri, 2018-07-20 at 12:39 -0700, João Paulo Rechi Vita wrote: > We can provide a better overall user experience with Bluetooth cards by > always choosing the higher audio quality profile (A2DP) by default and > updating the profile selection dynamically according to which streams > are active at

Re: [pulseaudio-discuss] [PATCH 6/8] message-params: Allow parameter strings to contain escaped curly braces

2018-07-21 Thread Tanu Kaskinen
On Mon, 2018-04-09 at 19:35 +0200, Georg Chini wrote: > The patch adds the possibility to escape curly braces within parameter strings > and introduces several new functions that can be used for writing parameters. > > For writing, the structure pa_message_param, which is a wrapper for pa_strbuf

[pulseaudio-discuss] [PATCH paprefs] .gitignore: add build

2018-07-21 Thread Tanu Kaskinen
With meson the build directory is always chosen manually, so it can be named anything, but in practice "build" is the usual name. Let's add that to .gitignore to keep the repository status clean after building. --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore

[pulseaudio-discuss] [ANNOUNCE] PulseAudio 12.2

2018-07-16 Thread Tanu Kaskinen
Hi all, The tarball for 12.1 contained a broken configure script (building failed when gsettings was enabled), so don't use that! Use PulseAudio 12.2, it's better! There are no changes besides the regenerated tarball with a working configure script and updated NEWS file. Download here:

Re: [pulseaudio-discuss] [ANNOUNCE] PulseAudio 12.1

2018-07-16 Thread Tanu Kaskinen
On Mon, 2018-07-16 at 17:33 +0300, Tanu Kaskinen wrote: > We'll need to release a new tarball, and I think we should bump the > version number as well so that there won't be any confusion from having > two different 12.1 tarballs. There are no changes needed in the git > repository,

Re: [pulseaudio-discuss] [ANNOUNCE] PulseAudio 12.1

2018-07-16 Thread Tanu Kaskinen
On Sat, 2018-07-14 at 19:55 +0300, Tanu Kaskinen wrote: > Hi all, > > Some regressions slipped into the 12.0 release, so here comes 12.1 that > tries to make things better: > > * Fixed a crash when switching to the A2DP bluetooth profile > * Fixed the plugin search path

Re: [pulseaudio-discuss] [patch] ops: catch repeated finalisation

2018-07-16 Thread Tanu Kaskinen
On Thu, 2018-07-05 at 05:16 +0100, jnq...@gmail.com wrote: > The internal operation_set_state function already returns early if the > new state is the same as the existing state. The attached patch extends > this to return early if already in a finalised (done/cancelled) state, > i.e. blocks

Re: [pulseaudio-discuss] Native Instruments Audio 2 DJ

2018-07-16 Thread Tanu Kaskinen
On Wed, 2018-07-04 at 14:57 +0100, w.stott wrote: > Hello I'm new here and haven't really used many mailing lists. So I hope > this is the correct place to ask... > > I have a Native Instruments Audio 2 DJ (which is an older version of > their Audio 2). It's effectively exactly the same thing

Re: [pulseaudio-discuss] [PATCH 5/8] pactl: Implement list message-handlers

2018-07-15 Thread Tanu Kaskinen
On Mon, 2018-04-09 at 19:35 +0200, Georg Chini wrote: > For better readability, "pactl list message-handlers" is introduced which > prints a formatted output of "pactl send-message /core list-handlers". > > The patch also adds the functions pa_message_param_split_list() and >

Re: [pulseaudio-discuss] [PATCH 4/8] core: add message handler

2018-07-15 Thread Tanu Kaskinen
On Mon, 2018-04-09 at 19:35 +0200, Georg Chini wrote: > This patch adds a small message handler to the core which enables > clients to list available handlers via the list-handlers message. > Command: pacmd send-message /core list-handlers > pactl can be used with the same parameters. > > The

Re: [pulseaudio-discuss] [paprefs] [PATCH] Port to meson

2018-07-15 Thread Tanu Kaskinen
On Tue, 2018-07-10 at 15:12 +0200, Jan Tojnar wrote: > It will build fine, only the translations will not be merged back to > the produced desktop file. Solution would be porting the autotools > code > from intltool to vanilla gettext (see >

Re: [pulseaudio-discuss] [PATCH] card-restore: Don't restore profile on Bluetooth cards by default

2018-07-15 Thread Tanu Kaskinen
On Tue, 2018-07-10 at 13:10 +0300, Luiz Augusto von Dentz wrote: > Hi Joao, > > On Tue, Jul 10, 2018 at 5:23 AM, João Paulo Rechi Vita > wrote: > > We can provide a better overall user experience with Bluetooth > > cards by > > always choosing the higher audio quality profile (A2DP) by default >

[pulseaudio-discuss] [ANNOUNCE] PulseAudio 12.1

2018-07-14 Thread Tanu Kaskinen
Hi all, Some regressions slipped into the 12.0 release, so here comes 12.1 that tries to make things better: * Fixed a crash when switching to the A2DP bluetooth profile * Fixed the plugin search path in module-ladspa-sink * Fixed file permissions for the pipes created by module-pipe-sink and

Re: [pulseaudio-discuss] [PATCH] Port to meson

2018-07-10 Thread Tanu Kaskinen
On Sun, 2018-07-08 at 04:46 +0200, Jan Tojnar wrote: > --- > doc/README.html.in | 8 +++ > doc/html2txt | 2 ++ > doc/meson.build| 25 > meson.build| 52 ++ > meson_options.txt | 1 + >

[pulseaudio-discuss] Planning 12.1

2018-07-10 Thread Tanu Kaskinen
Hi all, A few things broke in PulseAudio 12.0: switching bluetooth profile from off to a2dp started crashing, module-ladspa-sink didn't find any plugins any more and module-pipe-sink became unusable in the system mode due to stricter file permissions. These issues have now been fixed, so I

Re: [pulseaudio-discuss] [patches] constification round #4 (pa_mainloop_api)

2018-07-10 Thread Tanu Kaskinen
On Mon, 2018-07-09 at 18:16 +0100, jnq...@gmail.com wrote: > On Mon, 2018-07-09 at 13:23 +0300, Tanu Kaskinen wrote: > > On Thu, 2018-07-05 at 23:51 +0100, jnq...@gmail.com wrote: > > > On Wed, 2018-07-04 at 11:46 +0300, Tanu Kaskinen wrote: > > > > Patch 4 c

Re: [pulseaudio-discuss] [PATCH 3/8] pactl, pacmd, cli-command: Add send-message command

2018-07-09 Thread Tanu Kaskinen
On Mon, 2018-04-09 at 19:35 +0200, Georg Chini wrote: > The patch also adds some API documentation. > --- > doc/messaging_api.txt| 15 ++ > man/pactl.1.xml.in | 7 +++ > man/pulse-cli-syntax.5.xml.in| 7 +++ > shell-completion/bash/pulseaudio |

[pulseaudio-discuss] [PATCH 7/7][paprefs] README: remove the page footer

2018-07-09 Thread Tanu Kaskinen
Keeping the footer up to date is extra work with little benefit. --- doc/README.html.in | 2 -- 1 file changed, 2 deletions(-) diff --git a/doc/README.html.in b/doc/README.html.in index 2c67a62..8fb1421 100644 --- a/doc/README.html.in +++ b/doc/README.html.in @@ -116,8 +116,6 @@ compilation and

[pulseaudio-discuss] [PATCH 5/7][paprefs] README: remove reference to an ancient Debian version

2018-07-09 Thread Tanu Kaskinen
It's of little use to know that the initial version was written on an August 2006 version of Debian testing. --- doc/README.html.in | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/doc/README.html.in b/doc/README.html.in index cd0c592..3c73715 100644 ---

[pulseaudio-discuss] [PATCH 6/7][paprefs] README: clarify the PulseAudio version requirement

2018-07-09 Thread Tanu Kaskinen
It sounded like the only supported PulseAudio version is 12.0 (well, currently that's true, but the text won't be updated when new PulseAudio versions are released). --- doc/README.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/README.html.in b/doc/README.html.in

[pulseaudio-discuss] [PATCH 0/7][paprefs] preparing for paprefs release

2018-07-09 Thread Tanu Kaskinen
As I'm preparing to release paprefs 1.0, I went through the README and found several things that needed updating. Removing the copyright notice and the Acknowledgements section are potentially controversial, feel free to send your objections and I'll reconsider. Tanu Kaskinen (7): README

[pulseaudio-discuss] [PATCH 1/7][paprefs] README: remove the copyright notice

2018-07-09 Thread Tanu Kaskinen
The copyright notice would need updating, because there are also others than Lennart who own copyrights to paprefs, and the years are out of date. Having to continuously update the copyright years seems just unnecessary churn to me. Interested people can browse the git history if they're

[pulseaudio-discuss] [PATCH 2/7][paprefs] README: add "Bug Reports" and "Contributing Code" sections

2018-07-09 Thread Tanu Kaskinen
--- doc/README.html.in | 9 + 1 file changed, 9 insertions(+) diff --git a/doc/README.html.in b/doc/README.html.in index 15c6e95..4e959bb 100644 --- a/doc/README.html.in +++ b/doc/README.html.in @@ -20,6 +20,8 @@ Installation Acknowledgements Download +Bug Reports +

[pulseaudio-discuss] [PATCH 4/7][paprefs] README: add a news item for the upcoming release

2018-07-09 Thread Tanu Kaskinen
--- doc/README.html.in | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/README.html.in b/doc/README.html.in index 47b1bde..cd0c592 100644 --- a/doc/README.html.in +++ b/doc/README.html.in @@ -37,6 +37,9 @@ General Public License for more details. News +Soon: Version 1.0 released;

[pulseaudio-discuss] [PATCH 3/7][paprefs] README: remove the "Acknowledgements" section

2018-07-09 Thread Tanu Kaskinen
Acknowledging people's contributions is nice, but I don't like the chore of keeping the section up to date. --- doc/README.html.in | 7 --- 1 file changed, 7 deletions(-) diff --git a/doc/README.html.in b/doc/README.html.in index 4e959bb..47b1bde 100644 --- a/doc/README.html.in +++

Re: [pulseaudio-discuss] [PATCH] pipe-sink, pipe-source: fix file permissions

2018-07-09 Thread Tanu Kaskinen
On Sat, 2018-07-07 at 11:48 +0200, Georg Chini wrote: > On 04.07.2018 12:40, Tanu Kaskinen wrote: > > We recently changed the umask of the daemon from 022 to 077, which broke > > module-pipe-sink in the system mode, because nobody was allowed to read > > from the pipe. > &

Re: [pulseaudio-discuss] [patches] constification round #4 (pa_mainloop_api)

2018-07-09 Thread Tanu Kaskinen
On Thu, 2018-07-05 at 23:51 +0100, jnq...@gmail.com wrote: > On Wed, 2018-07-04 at 11:46 +0300, Tanu Kaskinen wrote: > > On Mon, 2018-07-02 at 17:58 +0100, jnq...@gmail.com wrote: > > > On Fri, 2018-06-29 at 16:06 +0300, Tanu Kaskinen wrote: > > > > On Thu,

Re: [pulseaudio-discuss] [PATCH 3/3] alsa-sink/source, sink, source: Consider sample format for avoid-resampling

2018-07-05 Thread Tanu Kaskinen
On Fri, 2018-06-29 at 04:57 +0900, Sangchul Lee wrote: > Sample format(e.g. 16 bit, 24 bit) was not considered even if the > avoid-resampling option is set. This patch checks both sample format > and rate of a stream to determine whether to avoid resampling in > case of the option is set. In other

Re: [pulseaudio-discuss] [PATCH 2/3] alsa-sink/source: Rename a variable for supported sample rates in userdata

2018-07-05 Thread Tanu Kaskinen
On Fri, 2018-06-29 at 04:57 +0900, Sangchul Lee wrote: > It is changed from 'rates' to 'supported_rates'. > > Signed-off-by: Sangchul Lee > --- > src/modules/alsa/alsa-sink.c | 18 +- > src/modules/alsa/alsa-source.c | 14 +++--- > 2 files changed, 16 insertions(+), 16

<    1   2   3   4   5   6   7   8   9   10   >