Jacob Helwig wrote:
> This maintenance release fixes two issues with Puppet 2.6.5.
To help with testing on Fedora or RHEL/CentOS, I've updated the yum
repos at:
http://tmz.fedorapeople.org/repo/puppet/
Packages for EL 4 - 6 and Fedora 13 - 15 are available for testing.
Add the puppet.repo fi
This maintenance release fixes two issues with Puppet 2.6.5.
Bug #6418: Files with the "source" parameter set are automatically set to audit
The audit functionality was activated unexpectedly on file resources
that use the "source" parameter. This could cause spurrious notify
events. These
On Wed, Mar 2, 2011 at 16:32, Ben Hughes wrote:
> On Wed, Mar 02, 2011 at 03:24:32PM -0800, Daniel Pittman wrote:
>
>> After every single test in the spec suite, assert that there are no
>> log messages at error or higher in the collected logs, before we flush
>> them. If there are, fail hard, an
On Wed, Mar 02, 2011 at 03:24:32PM -0800, Daniel Pittman wrote:
> After every single test in the spec suite, assert that there are no
> log messages at error or higher in the collected logs, before we flush
> them. If there are, fail hard, and treat it as disaster.
This looks a really good addit
The reasons for this change are to
1. Standardize our products' licenses on GPLv2
2. Prepare for the potential Apache license move since we've been told
by lawyers that it's easier to move from GPLv2
Reviewed-by: Nigel Kersetn, James Turnbull, Markus Roberts
Signed-off-by: Matt Robinson
--
I think this is a great idea. It'll catch a ton of problems that we
otherwise miss, as you say, and I've been bitten a lot by them. I
think it'll also encourage us to have better log and error hygiene in
general.
It will almost definitely result in a ton of failing tests at first,
so expect to s
So, we have a history of problems turning up where we write tests that
look like they are passing, then it later turns out that we actually
caught the exception, emitted a nasty error to the logs, and
everything *looked* right from the perspective of the test code.
Which is nasty, especially when t
Ruby 1.9.x was choking on some ASCII in one of the desc fields
Signed-off-by: James Turnbull
---
lib/puppet/type/macauthorization.rb |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/puppet/type/macauthorization.rb
b/lib/puppet/type/macauthorization.rb
index ef6fbb
ftools is used in the rake gem rasks. It is deprecated in
Ruby 1.9.x and so we've replaced it with FileUtils.
Signed-off-by: James Turnbull
---
tasks/rake/gem.rake |9 +
1 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/tasks/rake/gem.rake b/tasks/rake/gem.rake
index d65
In the git_workflow task we have an invalid when: foo clause
Replaced with when; foo
Signed-off-by: James Turnbull
---
tasks/rake/git_workflow.rake |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tasks/rake/git_workflow.rake b/tasks/rake/git_workflow.rake
index b2f96c
+1
On Wed, Mar 2, 2011 at 12:47 PM, James Turnbull wrote:
> This came from the use of the @@colormap class variable.
>
> The variables has been changed to a constant.
>
> Signed-off-by: James Turnbull
> ---
> lib/puppet/util/log/destinations.rb |6 +++---
> 1 files changed, 3 insertions(+),
On Wed, Mar 2, 2011 at 12:47 PM, James Turnbull wrote:
> The kick application has the option to ping hosts. On 1.9.x this
> code was returning "Invalid next". The next in this code has been
> replaced with an exit. Testing has confirmed this doesn't change the
> behavior of puppet kick.
>
+1
The
This came from the use of the @@colormap class variable.
The variables has been changed to a constant.
Signed-off-by: James Turnbull
---
lib/puppet/util/log/destinations.rb |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/puppet/util/log/destinations.rb
b/lib/p
Patches broken out and commit message more detailed.
--
You received this message because you are subscribed to the Google Groups
"Puppet Developers" group.
To post to this group, send email to puppet-dev@googlegroups.com.
To unsubscribe from this group, send email to
puppet-dev+unsubscr...@goo
The kick application has the option to ping hosts. On 1.9.x this
code was returning "Invalid next". The next in this code has been
replaced with an exit. Testing has confirmed this doesn't change the
behavior of puppet kick.
Signed-off-by: James Turnbull
---
lib/puppet/application/kick.rb |2
Signed-off-by: James Turnbull
---
lib/puppet/util/command_line/puppetrun |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/lib/puppet/util/command_line/puppetrun
b/lib/puppet/util/command_line/puppetrun
index 7eba3b2..3437405 100755
--- a/lib/puppet/util/command_line/pupp
From: Duncan Phillips
From: Duncan Phillips
Signed-off-by: Brice Figureau
---
.../util/rdoc/generators/template/puppet/puppet.rb | 91 +++-
1 files changed, 49 insertions(+), 42 deletions(-)
diff --git a/lib/puppet/util/rdoc/generators/template/puppet/puppet.rb
b/lib/puppe
On Tue, Mar 1, 2011 at 23:08, James Turnbull wrote:
> --- a/lib/puppet/application/kick.rb
> +++ b/lib/puppet/application/kick.rb
> @@ -104,7 +104,7 @@ class Puppet::Application::Kick < Puppet::Application
> out = %x{ping -c 1 #{host}}
> unless $CHILD_STATUS == 0
> $stderr.pri
- Original Message -
> On Wed, Mar 2, 2011 at 8:07 AM, R.I.Pienaar wrote:
>
> > Consider this.
> >
> > * Today you enable auditing, state.yaml gets the audit properties
> > all is fine.
> > * 6 months later you disable auditing - now the audit properties
> > remain but are
> > orp
On Wed, Mar 2, 2011 at 8:07 AM, R.I.Pienaar wrote:
> Consider this.
>
> * Today you enable auditing, state.yaml gets the audit properties all is
> fine.
> * 6 months later you disable auditing - now the audit properties remain but
> are
> orphaned as we're not purging them
> * you now chan
R.I. --
>> I'm not sure that the "how it got in there" part is irrelevant (for
>> instance, I'd like if you could confirm that state.yaml shows
>> type=>absent on a node that has not been upgraded, and note the
> yes, all my nodes have it - before upgrading. and people on IRC also
> has it witho
- Original Message -
>
> !ruby/sym type: !ruby/sym absent
>
> for files that were _never_ set to absent. Setting them to ensure =>
> absent
> today doesnt result in the same line being written either, I think
> there's
> some combination of properties, source etc that causes this.
>
>
R.I. --
> > If :absent is there, I believe it was correct (that is, that the
> > > file really was absent).
>
> the file wasn't absent.
This is the thing we need to be trying to reproduce then.
also notice its :type not :ensure.
>
That's an implementation detail, which I don't think we need to
- Original Message -
> On Tue, Mar 1, 2011 at 5:28 PM, Markus Roberts
> wrote:
> > N --
> >
> >> > That is reassuring.
> >> >
> >> > I think if we peel away:
> >> >
> >> > * the "always auditing" bug
> >>
> >> Yes. I believe this is fixed by Jesse's patch you reviewed:
> >>
> >>
> >> htt
Hello,
the feature number for this at redmine is: #6530
Greets,
Jonas
> From: Jonas Genannt
>
>
> Signed-off-by: Jonas Genannt
> ---
> Local-branch: feature/master/6530
> lib/puppet/provider/package/gem.rb |2 ++
> lib/puppet/type/package.rb | 12
>
Markus Roberts:
> As a hack, I've occasionally done something like:
>
> diff --git a/lib/puppet/application/apply.rb
[...]
> -
> Puppet::Node::Environment.new(Puppet[:environment]).known_resource_types
> + print
> ZAML.dump(Puppet::Node::Environment.new(Puppet[:environment]).known_reso
26 matches
Mail list logo
