[Puppet-dev] [PATCH/puppet-dashboard 3/3] (#4403) Do timezone arithmetic outside of the DB in the Status model

2011-03-15 Thread Jacob Helwig
We now pre-calculate the UTC timestamps of the day boundaries of the local timezone, and use these to bucket the reports in the DB. This saves us from having to rely on MySQL specific DB functions. This also allows us to properly calculate the day boundaries across DST changes, rather than relyin

[Puppet-dev] [PATCH/puppet-dashboard 2/3] Remove dead code from Status model

2011-03-15 Thread Jacob Helwig
The latest, and recent class methods were not actually used anywhere, nor was the interval local variable in by_interval. Paired-with: Nick Lewis Signed-off-by: Jacob Helwig --- Local-branch: tickets/next/4403-fix-dst-handling app/models/status.rb |9 - 1 files changed, 0 insertio

[Puppet-dev] [PATCH/puppet-dashboard 1/3] Validate the user supplied daily_run_history_length

2011-03-15 Thread Jacob Helwig
daily_run_history_length should always be >= 1, so we raise an ArgumentException if this is not the case. Paired-with: Nick Lewis Signed-off-by: Jacob Helwig --- Local-branch: tickets/next/4403-fix-dst-handling lib/settings_reader.rb |6 ++ spec/lib/settings_reader_spec.rb |

[Puppet-dev] [PATCH/puppet 1/1] Fix #5610: Prevent unnecessary RAL lookups

2011-03-15 Thread Jesse Wolfe
Reviewed-By: Paul Berry Signed-off-by: Jesse Wolfe --- lib/puppet/type.rb |2 +- spec/unit/type_spec.rb | 13 - 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/lib/puppet/type.rb b/lib/puppet/type.rb index 205d809..d24cc85 100644 --- a/lib/puppet/type.rb +++

[Puppet-dev] [PATCH/puppet 1/1] (#6723) Fix withenv environment restoration bug

2011-03-15 Thread Max Martin
Ensured that withenv properly restores the environment after it runs a block and added testing for the method. Reviewed-by: Matt Robinson and Daniel Pittman Signed-off-by: Max Martin --- lib/puppet/util/execution.rb |9 +++ spec/unit/util/execution_spec.rb | 49 ++

Re: [Puppet-dev] Re: Yaml output not quite right from puppet api

2011-03-15 Thread Markus Roberts
On Tue, Mar 15, 2011 at 3:45 PM, Corey Osman wrote: > I am very new to yaml so I have to research your suggestions. It > sounds like I'll need to create an object for the yaml output to map > to though. > > I'll respond back in the thread once I figure this out. > It looks likr pyyaml does supp

[Puppet-dev] [PATCH/facter 1/1] (#6719) Restricts virtualization types for zones

2011-03-15 Thread Adrien Thebo
- The virtual fact will only check if a system is a zone if the operating system is solaris. Signed-off-by: Adrien Thebo --- Local-branch: tickets/next/6719 lib/facter/virtual.rb |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/lib/facter/virtual.rb b/lib/facter/vi

[Puppet-dev] [PATCH/facter 1/1] (#5011) Adds swap statistics for OSX

2011-03-15 Thread Adrien Thebo
- Added swapfree and swapsize facts - Tests will now run correctly for osx swap tests Signed-off-by: Adrien Thebo --- Local-branch: tickets/next/5011 lib/facter/memory.rb | 30 ++ spec/unit/memory_spec.rb | 45 + 2

[Puppet-dev] [PATCH/facter 1/1] (#2721) Merged patch from Brane GraAnar

2011-03-15 Thread Adrien Thebo
- Adds support for Slamd64 and Bluewhite64 for the operatingsystem fact - Adds support for Slamd64 and Bluewhite64 for the operatingsystemrelease fact Signed-off-by: Adrien Thebo --- Local-branch: tickets/next/2721 lib/facter/operatingsystem.rb|8 ++-- lib/facter/operatin

[Puppet-dev] Re: Yaml output not quite right from puppet api

2011-03-15 Thread Corey Osman
I am very new to yaml so I have to research your suggestions. It sounds like I'll need to create an object for the yaml output to map to though. I'll respond back in the thread once I figure this out. On Mar 15, 6:05 pm, Markus Roberts wrote: > Corey -- > > I mentioned this before in a p

Re: [Puppet-dev] Yaml output not quite right from puppet api

2011-03-15 Thread Markus Roberts
Corey -- I mentioned this before in a previous post but I can't find that post. > > Anyways, I am using the puppet api rest interface and my python yaml > parser doesn't like the output given. Exactly what parser are you > guys using to encode your objects into Yaml? I don't know why my > parser

[Puppet-dev] Yaml output not quite right from puppet api

2011-03-15 Thread Corey Osman
I mentioned this before in a previous post but I can't find that post. Anyways, I am using the puppet api rest interface and my python yaml parser doesn't like the output given. Exactly what parser are you guys using to encode your objects into Yaml? I don't know why my parser is choking you the

Re: [Puppet-dev] Patch to fix #6718

2011-03-15 Thread Matt Robinson
On Tue, Mar 15, 2011 at 7:23 AM, Robin Bowes wrote: > I'm having trouble getting git mail_patches to work on my > tickets/2.6.x/6718 branch, so I'm sending this patch manually. I'm assuming you mean `rake mail_patches` here. The git commands that this actually invokes are `git format-patch` and

[Puppet-dev] [PATCH/puppet 1/2] (#5428) More fully "stub" Puppet::Resource::Reference for use with storedconfigs

2011-03-15 Thread Jacob Helwig
The Puppet::Resource::Reference class wasn't stubbing enough of the 0.25.x behavior to satisfy the needs of storedconfigs. Since P::R::Reference, and Puppet::Resource were merged as part of 2.6.x, we can pretend that P::Resource is P::R::Reference for the purposes of loading data from storedconfig

[Puppet-dev] [PATCH/puppet 2/2] Remove extra trailing whitespace from lib/puppet/resource.rb

2011-03-15 Thread Jacob Helwig
Paired-with: Daniel Pittman Signed-off-by: Jacob Helwig --- Local branch: ticket/2.6.next/5428-handle-0.25.x-storedconfig-data lib/puppet/resource.rb |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/puppet/resource.rb b/lib/puppet/resource.rb index e47fc7e..45ee2e9

Re: [Puppet-dev] Re: Help with creating a python puppet module using curl "pycurl" and auth.conf issues

2011-03-15 Thread Markus Roberts
> # ACL is wide open > path / > #auth no > allow * > > > This finally worked. You were right about the trailing characters. I > had a space after no and a space after the *. I removed the space and > commented out the auth and I am able to get the data. > I've updated the ticket for this bug (

Re: [Puppet-dev] Re: Help with creating a python puppet module using curl "pycurl" and auth.conf issues

2011-03-15 Thread Luke Kanies
If you mean, does the system default to requiring authentication, the answer is yes. Mostly - the only default ACLs that allows unauthenticated connections are the ones that allow uploading of the CSR and downloading of the signed cert. If you start a master in verbose mode in the foreground, y

[Puppet-dev] Re: Help with creating a python puppet module using curl "pycurl" and auth.conf issues

2011-03-15 Thread Corey Osman
# ACL is wide open path / #auth no allow * This finally worked. You were right about the trailing characters. I had a space after no and a space after the *. I removed the space and commented out the auth and I am able to get the data. Now, from my understand when no auth exists it assumes au

[Puppet-dev] Patch to fix #6718

2011-03-15 Thread Robin Bowes
I'm having trouble getting git mail_patches to work on my tickets/2.6.x/6718 branch, so I'm sending this patch manually. This fixes the bug (#6718) whereby it is not possible to create a new service. diff --git a/lib/puppet/provider/service/runit.rb b/lib/puppet/provider/service/runit.rb index 03

Re: [Puppet-dev] Re: [PATCH/puppet 19/19] (#4258) pkgutil provider: better handling of short package names

2011-03-15 Thread Dominic Cleal
On 10/03/11 08:03, Juerg Walz wrote: > Thanks for the feedback, Dominic. > I've never actually ran it with debugging turned on (again, I'm fairly > new to Puppet, and Ruby). I need to read up on the prefetching and > what's expected in the alias. My mods up to now were mostly trial-and- > error...

[Puppet-dev] [PATCH/facter 1/1] Fixed #6616 - Stubbing in VMware tests on Linux

2011-03-15 Thread James Turnbull
Signed-off-by: James Turnbull --- Local-branch: tickets/master/6616 lib/facter/virtual.rb |2 +- spec/unit/virtual_spec.rb |4 2 files changed, 5 insertions(+), 1 deletions(-) diff --git a/lib/facter/virtual.rb b/lib/facter/virtual.rb index 47c9504..cf84f75 100644 --- a/lib/fac

[Puppet-dev] [PATCH/facter 1/1] Fixed #3087 - Identify VMWare

2011-03-15 Thread James Turnbull
Added support for VMWareESX and ESXi to operatingsystem and operatingsystemrelease facts Added appropriate tests Signed-off-by: James Turnbull --- Local-branch: tickets/master/3087 lib/facter/operatingsystem.rb|9 + lib/facter/operatingsystemrelease.rb | 10 +++

[Puppet-dev] [PATCH/facter 1/1] (#6327) Memory facts should be available on Mac Darwin

2011-03-15 Thread Ben Hughes
There's no easy defined way of getting memory information from the command line. Copying mainly the OpenBSD facts, but having to pull in memory free from the vm_stat utility, and parsing the weird vm.swapusage sysctl value for swap. Parsing "top -l 1 -n 0" seemed an option, but that took over a se

[Puppet-dev]

2011-03-15 Thread Ben Hughes
Going to try to add some unit tests to this if I can. Can people with Macs have a test too please? Thanks. -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to puppet-dev@googlegroups.com. To unsubscribe from