[Puppet-dev] [PATCH/puppet 1/1] (#6857) Password disclosure when changing a user's password

2011-03-31 Thread James Turnbull
From: Ben Hughes Make the should_to_s and is_to_s functions to return a form of 'redacted'. Rather than send the password hash to system logs in cases of failure or running in --noop mode, just state whether it's the new or old hash. We're already doing this with password changes that work, so t

[Puppet-dev] [PATCH/puppet 1/1] (#6937) Document the recurse parameter of File type.

2011-03-31 Thread Ben Hughes
Update the desc block with information gleaned from #1469 and the code about recurse => remote and other types of recursion. The auto generated documentation was sparse and this is an area that often comes up on the mailing list/IRC. Signed-off-by: Ben Hughes --- lib/puppet/type/file.rb | 12

Re: [Puppet-dev] Re: [PATCH/puppet 1/3] (#5660) New Type to handle /etc/services entries

2011-03-31 Thread Trevor Vaughan
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Ah, I hadn't realized that. Also, what about Windows? Would this cover something there as well? Trevor On 03/31/2011 06:21 PM, Nigel Kersten wrote: > On Thu, Mar 31, 2011 at 2:32 PM, Trevor Vaughan > wrote: >> Fair enough. >> >> nss: or nss_foo? >

Re: [Puppet-dev] Re: [PATCH/puppet 1/3] (#5660) New Type to handle /etc/services entries

2011-03-31 Thread Nigel Kersten
On Thu, Mar 31, 2011 at 2:32 PM, Trevor Vaughan wrote: > Fair enough. > > nss: or nss_foo? > > According to nsswitch.conf(5) this would include: Mac OS X uses /etc/{hosts,services,networks} but Name Service Switch isn't meaningful at all. I think we're getting too OS-flavor-specific in this thre

Re: [Puppet-dev] Re: [PATCH/puppet 1/3] (#5660) New Type to handle /etc/services entries

2011-03-31 Thread Trevor Vaughan
Fair enough. nss: or nss_foo? According to nsswitch.conf(5) this would include: aliases ethers group -> Covered by 'group' type hosts -> Covered by 'host' type netgroup networks passwd -> Covered by 'user' type protocols publickey rpc services -> The one we want to cover shadow -> Covered by 'us

Re: [Puppet-dev] Re: [PATCH/puppet 1/3] (#5660) New Type to handle /etc/services entries

2011-03-31 Thread Oliver
On 31 March 2011 21:17, Trevor Vaughan wrote: > I'm not sure if it's that easy. > > In Fedora, at least, network materials are grouped into the > 'initscripts' package and items such as /etc/hosts and /etc/services > are in the 'setup' package. > > You almost would need a LSB category to give thes

Re: [Puppet-dev] Re: [PATCH/puppet 1/3] (#5660) New Type to handle /etc/services entries

2011-03-31 Thread Trevor Vaughan
I'm not sure if it's that easy. In Fedora, at least, network materials are grouped into the 'initscripts' package and items such as /etc/hosts and /etc/services are in the 'setup' package. You almost would need a LSB category to give these a really broad header (where applicable). I'm not sure i

[Puppet-dev] Re: [PATCH/puppet 1/3] (#5660) New Type to handle /etc/services entries

2011-03-31 Thread Oliver Hookins
On Mar 31, 4:45 pm, Jacob Helwig wrote: > On Thu, 31 Mar 2011 08:16:31 -0400, Trevor Vaughan wrote: > > > I don't like 'port', but I'm having a hard time coming up with a good > > alternate. > > > sys_service? > > > The man page says "The Internet network services list" so perhaps > > net_svc or

Re: [Puppet-dev] [PATCH/puppet 1/3] (#5660) New Type to handle /etc/services entries

2011-03-31 Thread Jacob Helwig
On Thu, 31 Mar 2011 08:16:31 -0400, Trevor Vaughan wrote: > > I don't like 'port', but I'm having a hard time coming up with a good > alternate. > > sys_service? > > The man page says "The Internet network services list" so perhaps > net_svc or net_service? > network_service, or net_service a

Re: [Puppet-dev] [PATCH/puppet 1/3] (#5660) New Type to handle /etc/services entries

2011-03-31 Thread James Turnbull
Trevor Vaughan wrote: > I don't like 'port', but I'm having a hard time coming up with a good > alternate. > > sys_service? > > The man page says "The Internet network services list" so perhaps > net_svc or net_service? > I like net_service. James -- James Turnbull Puppet Labs 1-503-734-857

Re: [Puppet-dev] [PATCH/puppet 1/3] (#5660) New Type to handle /etc/services entries

2011-03-31 Thread Trevor Vaughan
I don't like 'port', but I'm having a hard time coming up with a good alternate. sys_service? The man page says "The Internet network services list" so perhaps net_svc or net_service? Trevor On Wed, Mar 30, 2011 at 6:44 PM, Nigel Kersten wrote: > On Tue, Mar 29, 2011 at 12:56 PM, Stefan Schult