Currently if you run rake metrics:all on puppet, you get no results from flay
(the metric that looks for code duplication), because it apparently assumes a
blank set of target directories unless told otherwise. This patch adds the
necessary configuration to the rake task. (Are there any others t
Signed-off-by: Michael Kincaid
---
Local-branch: ticket/next/6515
lib/facter/processor.rb | 135 --
lib/facter/util/processor.rb | 88 +
spec/fixtures/cpuinfo/amd64dual | 57 +++
spec/fixtures/cpuinfo/amd64quad |
sysfs enumeration has also been added, and the processorcount on Darwin (but
not the "processor" fact on Darwin, yet)
>From Michael Kincaid # This line is ignored.
From: Michael Kincaid
Subject: 6515/2945 fixing processor and processorcount issues
In-Reply-To:
--
You received this message
Signed-off-by: Michael Kincaid
---
Local-branch: ticket/next/6515
lib/facter/processor.rb |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/lib/facter/processor.rb b/lib/facter/processor.rb
index df4e9af..44bb3e7 100644
--- a/lib/facter/processor.rb
+++ b/lib/facter/p
Signed-off-by: Michael Kincaid
---
Local-branch: ticket/next/4980
lib/facter/architecture.rb | 10 +--
spec/unit/architecture_spec.rb | 54
2 files changed, 55 insertions(+), 9 deletions(-)
create mode 100755 spec/unit/architecture_spec.rb
d
Signed-off-by: Michael Kincaid
---
Local-branch: ticket/next/4869
lib/facter/manufacturer.rb |5 +
lib/facter/util/manufacturer.rb |2 +-
2 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/lib/facter/manufacturer.rb b/lib/facter/manufacturer.rb
index 26aef5f..98ed29e
Signed-off-by: Michael Kincaid
---
Local-branch: ticket/next/4508
lib/facter/virtual.rb |5 +
spec/unit/virtual_spec.rb | 19 +++
2 files changed, 24 insertions(+), 0 deletions(-)
diff --git a/lib/facter/virtual.rb b/lib/facter/virtual.rb
index a583995..739d346 100
Signed-off-by: Michael Kincaid
---
Local-branch: ticket/next/3856
lib/facter/virtual.rb |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/facter/virtual.rb b/lib/facter/virtual.rb
index a583995..3cb5b42 100644
--- a/lib/facter/virtual.rb
+++ b/lib/facter/virtual.rb
Please disregard this patch; it isn't mine. I only intended to submit
the following one (#2747), but hadn't rebased correctly before doing
so.
--Michael
On May 12, 4:57 pm, Michael Kincaid wrote:
> From: Dominic Maraglia
>
> Signed-off-by: Michael Kincaid
> ---
> Local-branch: ticket/next/2747
From: Dominic Maraglia
Signed-off-by: Michael Kincaid
---
Local-branch: ticket/next/2747
.../ticket_7039_facter_multiple_facts_one_file.rb | 31
1 files changed, 31 insertions(+), 0 deletions(-)
create mode 100644
accecptance/tests/ticket_7039_facter_multiple_facts_on
Check for xsd_kva for dom0, rather than independent_wallclock (which is present
on both dom0 and domu). Work around /proc/xen/capabilities, which is sometimes
not world-readable.
Signed-off-by: Michael Kincaid
---
Local-branch: ticket/next/2747
lib/facter/virtual.rb | 15 +++
Even if the discussion had been on the list, we should have a better
commit message explaining why a revert is being done, and there still
ought to be a reviewer.
http://projects.puppetlabs.com/projects/puppet/wiki/Development_Lifecycle#Commit+Messages
On Thu, May 12, 2011 at 4:07 PM, Daniel Pittm
On Thu, May 12, 2011 at 16:11, Jacob Helwig wrote:
> On Thu, 12 May 2011 16:07:10 -0700, Daniel Pittman wrote:
>> On Thu, May 12, 2011 at 15:59, Jacob Helwig wrote:
>> > On Thu, 12 May 2011 15:55:10 -0700, Daniel Pittman wrote:
> Ah! Excellent! Thanks for updating that.
Thank you for the remi
A number of lines in app/models/node.rb were long enough to make working with
the source difficult; this change brings every line under 100 columns.
Paired-With: Jacob Helwig
Signed-off-by: Pieter van de Bruggen
---
Local-branch: tickets/next/6991
app/models/node.rb | 56 +
This graph, appearing at the top of the dashboard's front page, provides a
succinct overview of the current state of your infrastructure. Nodes are
classified in one of four distinct categories:
* Unresponsive - Dashboard has not received a recent report from the node.
* Failed - The node is re
From: Nick Lewis
A node is pending if it a) has noop events, and b) is not failed.
Paired-With: Daniel Pittman
Signed-off-by: Pieter van de Bruggen
---
Local-branch: tickets/next/6991
app/models/node.rb |7 +++
spec/models/node_spec.rb | 24
2 files ch
In support of the node status summary change, it is valuable for us to have
a few named scopes that we can easily compose. To that end, we've refactored
the pending scope to take a boolean predicate, and introduced two new scopes
('current' and 'successful'). While these scopes bear only passing
On Thu, 12 May 2011 16:07:10 -0700, Daniel Pittman wrote:
>
> On Thu, May 12, 2011 at 15:59, Jacob Helwig wrote:
> > On Thu, 12 May 2011 15:55:10 -0700, Daniel Pittman wrote:
> >>
> >> This reverts commit 9329a1f33b4d7df81ad8661de74f8a3656428570.
> >>
> >> Conflicts:
> >>
> >> spec/unit/int
On Thu, May 12, 2011 at 15:59, Jacob Helwig wrote:
> On Thu, 12 May 2011 15:55:10 -0700, Daniel Pittman wrote:
>>
>> This reverts commit 9329a1f33b4d7df81ad8661de74f8a3656428570.
>>
>> Conflicts:
>>
>> spec/unit/interface/action_builder_spec.rb
>> spec/unit/interface/action_spec.rb
>>
On Thu, 12 May 2011 15:55:10 -0700, Daniel Pittman wrote:
>
> This reverts commit 9329a1f33b4d7df81ad8661de74f8a3656428570.
>
> Conflicts:
>
> spec/unit/interface/action_builder_spec.rb
> spec/unit/interface/action_spec.rb
> ---
> lib/puppet/interface/action.rb |5 --
This reverts commit 9329a1f33b4d7df81ad8661de74f8a3656428570.
Conflicts:
spec/unit/interface/action_builder_spec.rb
spec/unit/interface/action_spec.rb
---
lib/puppet/interface/action.rb |5 --
lib/puppet/interface/action_builder.rb | 10
spec/unit/inter
The TestIndirection test face defined in indirection_base_spec did not
have copyright or license information defined; this was causing
order-dependent test failures when unit tests were run before other
specs (as in rake spec). This commit adds license and copyright info to
the test face to prevent
We are presently merging up, so shortly any of 2.7.x, 2.7.next, next,
or master will have the same content. :)
I would advise the 2.7.0 RC2 release, but give it a couple of hours
and you don't need to care any longer.
Daniel
On Thu, May 12, 2011 at 10:18, James Turnbull wrote:
> So next questio
Although URLs with usernames and passwords were valid in the previous version
of the external_node
script, they weren't being passed in the HTTP request. This commit adds a
username and password
to the request if a user is present in the URL.
The "if uri.user" isn't strictly necessary, since req
On Thu, May 12, 2011 at 4:50 PM, Daniel Pittman wrote:
> On Thu, May 12, 2011 at 07:36, Nigel Kersten wrote:
>> On Thu, May 12, 2011 at 5:14 AM, Luke Kanies wrote:
>>> On May 11, 2011, at 10:01 PM, Nigel Kersten wrote:
>>>
Is it possible to access the name of the calling class from inside a
It's handy to be able to support those people that wish to be kind to
non-gmail users by setting the In-Reply-To mail header, when sending
patches in response to an existing mail thread.
Signed-off-by: Jacob Helwig
---
Local-branch: tickets/next/7498-support-in-reply-to-in-rake-mail_patches
task
Since Puppet 2.6.x we've been using the more standard Ruby coding
style of 2-space indents.
Signed-off-by: Jacob Helwig
---
Local-branch: tickets/next/7498-support-in-reply-to-in-rake-mail_patches
tasks/rake/git_workflow.rake | 187 +-
1 files changed, 93
Alex,
You can test out this patch series. ;-)
--
You received this message because you are subscribed to the Google Groups
"Puppet Developers" group.
To post to this group, send email to puppet-dev@googlegroups.com.
To unsubscribe from this group, send email to
puppet-dev+unsubscr...@googlegro
So next question - which branch is best?
If I am developing a 2.7.x Face should I checkout the rc2 tag?
Can I confirm that master is our current Dev HEAD? And next is?
Thanks!
James
On May 12, 2011 9:58 AM, "James Turnbull" wrote:
--
You received this message because you are subscribed to th
The secret_agent face shows two methods -copyright and license. Neither of
these seem to work and I can't find any code implementing them. Are they
valid?
Thanks
James
--
You received this message because you are subscribed to the Google Groups
"Puppet Developers" group.
To post to this group,
See
https://groups.google.com/group/puppet-dev/browse_thread/thread/5b0de3c40d3f1873#
-- their implementation is in 2.7.x but not next.
--
You received this message because you are subscribed to the Google Groups
"Puppet Developers" group.
To post to this group, send email to puppet-dev@googleg
That's my issue then! I am developing against next. Probably explains the
other issues I was about to email also. :)
Thanks Nick and Daniel!
James
On May 12, 2011 9:52 AM, "Nick Fagerlund"
wrote:
> I just went digging. The documentation module is present in 2.7.0rc2,
> and not present in next.
I just went digging. The documentation module is present in 2.7.0rc2,
and not present in next. (?!) So James, are you coding against next?
--
You received this message because you are subscribed to the Google Groups
"Puppet Developers" group.
To post to this group, send email to puppet-dev@googl
On Thu, May 12, 2011 at 07:36, Nigel Kersten wrote:
> On Thu, May 12, 2011 at 5:14 AM, Luke Kanies wrote:
>> On May 11, 2011, at 10:01 PM, Nigel Kersten wrote:
>>
>>> Is it possible to access the name of the calling class from inside a
>>> function?
>>
>> You should be able to use '@name'...
>
>
On Thu, May 12, 2011 at 07:00, James Turnbull wrote:
> The secret_agent face shows two methods - copyright and license.
> Neither of these seem to work and I can't find any code implementing
> them. Are they valid? If not the code should probably be removed.
Yes, they are valid, and no, I don't
On May 12, 2011, at 7:56 AM, Nigel Kersten wrote:
> On Thu, May 12, 2011 at 2:36 PM, Nigel Kersten wrote:
>> On Thu, May 12, 2011 at 5:14 AM, Luke Kanies wrote:
>>> On May 11, 2011, at 10:01 PM, Nigel Kersten wrote:
>>>
Is it possible to access the name of the calling class from inside a
On Thu, May 12, 2011 at 2:36 PM, Nigel Kersten wrote:
> On Thu, May 12, 2011 at 5:14 AM, Luke Kanies wrote:
>> On May 11, 2011, at 10:01 PM, Nigel Kersten wrote:
>>
>>> Is it possible to access the name of the calling class from inside a
>>> function?
>>
>> You should be able to use '@name'...
>
On Thu, May 12, 2011 at 5:14 AM, Luke Kanies wrote:
> On May 11, 2011, at 10:01 PM, Nigel Kersten wrote:
>
>> Is it possible to access the name of the calling class from inside a
>> function?
>
> You should be able to use '@name'...
Nope. In case I wasn't clear, it's a Puppet function that I'd l
You got me. I just use 'git send-email' and stuff, because it lets me
do the right thing. :)
Daniel
On Wed, May 11, 2011 at 17:02, ajsharp wrote:
> How do I attach a new/revised patch to this email thread with the
> mail_patches rake task?
>
> On May 10, 11:50 am, markus wrote:
>> > > Yea, you
39 matches
Mail list logo
