Re: [Puppet-dev] [PATCH/facter 1/1] (#6792) Added osfamily fact.

2011-06-09 Thread Adrien Thebo
I added suse support, but I'm going to hold of on resending the patches for a little while. It was discussed that adding windows support would be good, and I should add that code before sending yet another copy of the patches to the dev list. On Jun 9, 2011, at 2:03 PM, Michael Knox wrote: > +1

[Puppet-dev] [PATCH/puppet-dashboard 1/1] (#7544) Group report resources by status

2011-06-09 Thread Max Martin
When viewing an individual report, resources are now grouped by their status. Paired-with: Matt Robinson Signed-off-by: Max Martin --- Local-branch: ticket/master/7544-resource-grouping app/views/reports/_resource_statuses.html.haml | 44 +--- 1 files changed, 24 insertion

[Puppet-dev] [PATCH/puppet-dashboard 1/1] (#7840) Increase consistency of status definitions and remove old code

2011-06-09 Thread Max Martin
This commit overhauls the sidebar to be consistent with the data views in the new tabs on the homepage. The homepage itself has been reorganized to put the status summary graph on top, followed by the stacked bar chart of report statuses, and the recently reported nodes chart at the bottom has been

Re: [Puppet-dev] [PATCH/facter 1/2] (#6515 and #2945) Fix processorcount for some ARM, add sysfs enumeration as a backup, tests

2011-06-09 Thread Jacob Helwig
With a change this big, I'd have thought you'd have more to say in the commit message about why it's necessary and why #6515 and #2945 are combined into a single commit when the tickets aren't marked as duplicates of each other. ;) There are a lot of introduced trailing whitespace, and hard-tabs i

[Puppet-dev] Re: [Puppet Users] Prerun, Postrun Commands, and Stages

2011-06-09 Thread Nigel Kersten
On Thu, Jun 9, 2011 at 1:22 PM, Josh Cooper wrote: > > One use of pre commands that isn't solved with stages is to check "Should > I > > even do a Puppet run right now?" or anything else that is out of band in > a > > similar sense. > > This makes complete sense and is how the feature was intende

Re: [Puppet-dev] [PATCH/facter 1/1] (#6792) Added osfamily fact.

2011-06-09 Thread Michael Knox
+1, To support SLES/SLED/OpenSuSE ... +elsif FileTest.exists?("/etc/SuSE-version") + "suse" Cheers Mike On 9/06/11 6:43 AM, Adrien Thebo wrote: Added osfamily fact to determine if a given operating system is a derivative of a common operating system. Signed-off-by: Adrien Thebo --- L

Re: [Puppet-dev] [PATCH/facter 2/2] Reinstate uname -p naming of processor on OpenBSD

2011-06-09 Thread Jacob Helwig
On Thu, 12 May 2011 18:20:11 -0700, Michael Kincaid wrote: > > Signed-off-by: Michael Kincaid > --- > Local-branch: ticket/next/6515 > lib/facter/processor.rb |6 ++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/lib/facter/processor.rb b/lib/facter/processor.rb > i

[Puppet-dev] Re: [Puppet Users] Prerun, Postrun Commands, and Stages

2011-06-09 Thread Josh Cooper
> One use of pre commands that isn't solved with stages is to check "Should I > even do a Puppet run right now?" or anything else that is out of band in a > similar sense. This makes complete sense and is how the feature was intended to work, but unfortunately, it never has worked that way (for th

[Puppet-dev] [PATCH/puppet-dashboard 1/1] maint: Fix migration to check for nil value

2011-06-09 Thread Max Martin
Our latest migration to add resource status information to the metrics tables was calling the munge method on reports before checking to see whether the node actually had a report. This commit adds a sanity check to make sure munge won't be called on a nil object. Paired-with:Matt Robinson Signed

[Puppet-dev] [PATCH/facter 1/1] (#6792) Added osfamily fact.

2011-06-09 Thread Adrien Thebo
Added osfamily fact to determine if a given operating system is a derivative of a common operating system. Signed-off-by: Adrien Thebo --- Local-branch: ticket/master/6792 lib/facter/osfamily.rb | 24 spec/unit/osfamily_spec.rb | 26 ++ 2

Re: [Puppet-dev] [PATCH/facter 1/1] (#6792) Added osfamily fact.

2011-06-09 Thread Jacob Helwig
On Thu, 09 Jun 2011 09:20:36 -0700, Dan Bode wrote: > > On Wed, Jun 8, 2011 at 1:43 PM, Adrien Thebo wrote: > > > Added osfamily fact to determine if a given operating system is a > > derivative of a common operating system. > > > > Huge +1 > So, Adrien. Where are the tests? ;P > > > Signe

Re: [Puppet-dev] [PATCH/facter 1/1] (#6792) Added osfamily fact.

2011-06-09 Thread Dan Bode
On Thu, Jun 9, 2011 at 9:41 AM, markus wrote: > > > > > > > Huge +1 > unmeasurable +1i > > > > > > > Because you've reviewed it, or because you think it's a good idea? > > > > One convention that works (for me at least) is to use complex numbers > where the real part is for the actual code an

Re: [Puppet-dev] [PATCH/facter 1/1] (#6792) Added osfamily fact.

2011-06-09 Thread markus
> > > > Huge +1 > > > > Because you've reviewed it, or because you think it's a good idea? > One convention that works (for me at least) is to use complex numbers where the real part is for the actual code and the imaginary part is for the idea. Thus (+1+1i) means "Oh yeah, we need this and

Re: [Puppet-dev] [PATCH/facter 1/1] (#6792) Added osfamily fact.

2011-06-09 Thread Jacob Helwig
On Thu, 09 Jun 2011 09:20:36 -0700, Dan Bode wrote: > > Huge +1 > Because you've reviewed it, or because you think it's a good idea? -- Jacob Helwig signature.asc Description: Digital signature

Re: [Puppet-dev] [PATCH/facter 1/1] (#6792) Added osfamily fact.

2011-06-09 Thread Dan Bode
On Wed, Jun 8, 2011 at 1:43 PM, Adrien Thebo wrote: > Added osfamily fact to determine if a given operating system is a > derivative of a common operating system. > Huge +1 > Signed-off-by: Adrien Thebo > --- > Local-branch: ticket/master/6792 > lib/facter/osfamily.rb | 24

[Puppet-dev] Re: [Puppet Users] Prerun, Postrun Commands, and Stages

2011-06-09 Thread Nigel Kersten
On Thu, Jun 9, 2011 at 3:15 AM, Dean Wilson wrote: > On Wed, Jun 08, 2011 at 05:50:58PM -0700, Josh Cooper wrote: > > > It'd be great to hear about your experience with the pre/post run > > commands and what use cases you are trying to solve. > > We use the feature to generate additional informat