This change updates the documentation in the README file to reflect the
project name of Cloud Provisioner.
Reviewed-by: Dan Bode
Signed-off-by: Jeff McCune
---
README.markdown | 37 -
1 files changed, 24 insertions(+), 13 deletions(-)
diff --git a/README.m
This change updates the Modulefile such that the resulting module is
named cloud-provisioner rather than cloudpack.
This only changes the high level module name, it does not change the
internal CloudPack ruby variable names or source files.
Reviewed-by: Dan Bode
Signed-off-by: Jeff McCune
---
Keep alive has been disabled since 2008, and seems to have caused problems when
it was enabled before then. Since there doesn't seem to be any push to get it
working again, just remove it to simplify this code.
This also allows us to entirely remove the usage of Puppet::Util::Cacher from
HttpPool.
This change fixes the module filename parsing method to support module
names with hyphens and dashes in them.
Without this change the following module name was causing an error in
the install action:
puppetlabs-cloud-provisioner-0.0.1git-95-g6541187.tar.gz
This error was caused by the module
On Jul 19, 2011, at 9:59 AM, Brice Figureau wrote:
> On 18/07/11 09:18, Tim Sharpe wrote:
>> We have a generic create_resource matcher than can be used however for a
>> nicer experience I also want to create specific matchers for the built
>> in types.
>>
>> it { should create_resource('package',
>
> > it "should not fail if the path is fully qualified, with a trailing
> separator" do
>
> -path = "/some/path/with/trailing/separator"
> > -path_with_separator = "#{path}#{File::SEPARATOR}"
> > -File.stubs(:lstat).with(path).returns stub('stat')
> > +path_with_separator = "#{
OK, cool. That wasn't clear from the context, and might do with a
comment in the test, but at least doesn't regress anything.
On Tue, Jul 19, 2011 at 15:51, Josh Cooper wrote:
> I didn't change the daemon code itself (which already skips those signals).
> I just changed the spec test to match th
I didn't change the daemon code itself (which already skips those signals).
I just changed the spec test to match the implementation on Windows.
In other words, the decision to abandon or not was already made before these
changes were made. With that said, the implications of what happens on
Windo
...and the features they enable on Unix? What happens with those?
If there has been a decision to abandon, for example, the ability to
reload the configuration file of a running Puppet Agent in daemon
mode, then great. Otherwise something to indicate that this is still
pending would be awesome.
I am concerned that many of these tests are now "passing", and don't
have any of the annotation for getting back to that were found. Given
how some of these failures are going to be fairly subtle, and that we
don't really do an exhaustive job of input testing, I worry that they
will end up missed.
On Tue, Jul 19, 2011 at 15:25, Jacob Helwig wrote:
> On Tue, 19 Jul 2011 15:13:40 -0700, Daniel Pittman wrote:
>>
>> On Tue, Jul 19, 2011 at 14:59, Josh Cooper wrote:
>> > Puppet uses both colon and File::PATH_SEPARATOR in various places, which
>> > does not work on Windows, where File::PATH_SEPA
HUP, USR1, and USR2 are not supported on Windows, so I don't see any point
in writing a pending test for something that will never happen.
Josh
On Tue, Jul 19, 2011 at 3:36 PM, Daniel Pittman wrote:
> On Tue, Jul 19, 2011 at 14:59, Josh Cooper wrote:
> > The signals HUP, USR1, and USR2 are not
On Tue, Jul 19, 2011 at 14:59, Josh Cooper wrote:
> The signals HUP, USR1, and USR2 are not supported on Windows. The
> Puppet::Daemon code already skipped trapping these on Windows,
> but the spec test was expecting them to be trapped. This commit
> just updates the spec test to match the existin
These set of changes are intended to get the tests working and the
implementation in a stable state, though not strictly correct for the
reasons you mention and also UNC paths, etc. Rather than make those changes
in this patch series, I will be making a second pass, refactoring path
validation into
On Tue, Jul 19, 2011 at 14:59, Josh Cooper wrote:
> Absolute paths on Unix, e.g. /foo/bar, are not absolute on Windows,
> which breaks many test cases. This commit adds a method to
> PuppetSpec::Files.make_absolute that makes the path absolute in
> test cases.
>
> On Unix (Puppet.features.posix?)
The previous set of windows patches accidentally changed %w{/one}
to make_absolute("/one"). This commit changes it back to
[make_absolute("/one")].
Reviewed-by: Jacob Helwig
Signed-off-by: Josh Cooper
---
Local-branch: feature/master/8268-puppet-agent-windows
spec/unit/parser/type_loader_spec.r
On Tue, 19 Jul 2011 15:13:40 -0700, Daniel Pittman wrote:
>
> On Tue, Jul 19, 2011 at 14:59, Josh Cooper wrote:
> > Puppet uses both colon and File::PATH_SEPARATOR in various places, which
> > does not work on Windows, where File::PATH_SEPARATOR is a semi-colon. This
> > commit changes the code a
Looks right to me, but the test could use a bit more.
This throws an exception with the current code, right? It'd be helpful to
confirm that the generated CSR is the one saved, at the least.
On Jul 19, 2011, at 11:40 AM, Dan Bode wrote:
> The certificate generate action was previously
> attept
On Tue, Jul 19, 2011 at 14:59, Josh Cooper wrote:
> When testing whether a file path is absolute, the regexp was only
> handling POSIX style file paths. This commit requires Windows
> style file paths to start with a drive letter. A future commit
> will refacter the various places we do path valid
On Tue, Jul 19, 2011 at 14:59, Josh Cooper wrote:
> Puppet uses both colon and File::PATH_SEPARATOR in various places, which
> does not work on Windows, where File::PATH_SEPARATOR is a semi-colon. This
> commit changes the code and tests to consistently use File::PATH_SEPARATOR.
>
> Reviewed-by: J
Several tests were broken due to pecularities of Windows
and Ruby on Windows:
* Ruby on windows does not differentiate between group and
other file permissions.
* All open file handles must be closed before the file can
be deleted
* Sometimes the current working directory (Dir.getwd) is
repo
Many spec tests fail on Windows because there are no default
providers implemented for Windows yet. Several others are
failing due to Puppet::Util::Cacher not working correctly,
so for now the tests that are known to fail are marked with
:fails_on_windows => true. To skip these tests, you can run:
The signals HUP, USR1, and USR2 are not supported on Windows. The
Puppet::Daemon code already skipped trapping these on Windows,
but the spec test was expecting them to be trapped. This commit
just updates the spec test to match the existing daemon code.
Reviewed-by: Jacob Helwig
Signed-off-by: J
When testing whether a file path is absolute, the regexp was only
handling POSIX style file paths. This commit requires Windows
style file paths to start with a drive letter. A future commit
will refacter the various places we do path validation to
support both Windows drive letters and UNC paths.
Puppet uses both colon and File::PATH_SEPARATOR in various places, which
does not work on Windows, where File::PATH_SEPARATOR is a semi-colon. This
commit changes the code and tests to consistently use File::PATH_SEPARATOR.
Reviewed-by: Jacob Helwig
Signed-off-by: Josh Cooper
---
Local-branch: f
These commits enable the majority of spec tests to run on Windows. Most of
the issues were a result of absolute paths on Unix, e.g. /foo/bar, not
being absolute paths on Windows, but being used in contexts that expect
absolute paths, e.g. puppet file type.
When specifying absolute paths in spec te
Greetings!
Please review the pull request #4: Fix for (#8499) --mktemp must work with mac opened by Michael Stahnke (stahnma)
Some more information about the pull request:
Opened: Tue Jul 19 19:02:35 UTC 2011
Based on: puppetlabs:master (a8d85ef7541b520ff674
please disregard the first email in the thread. I decided to clean up the
wording of the unit tests and resubmitted.
On Tue, Jul 19, 2011 at 11:40 AM, Dan Bode wrote:
> The certificate generate action was previously
> attepting to save the csr twice.
>
> This patch resolves the issue and elimina
The certificate generate action was previously
attepting to save the csr twice.
This patch resolves the issue and eliminates the
resulting error message.
Signed-off-by: Dan Bode
---
Local-branch: issue/2.7.x/7637_creates_csr_twice
lib/puppet/face/certificate.rb |1 -
spec/unit/face/cert
The certificate generate action was previously
attepting to save the csr twice.
This patch resolves the issue and eliminates the
resulting error message.
Signed-off-by: Dan Bode
---
Local-branch: issue/2.7.x/7637_creates_csr_twice
lib/puppet/face/certificate.rb |1 -
spec/unit/face/cert
On 18/07/11 09:18, Tim Sharpe wrote:
> We have a generic create_resource matcher than can be used however for a
> nicer experience I also want to create specific matchers for the built
> in types.
>
> it { should create_resource('package',
> 'mysql-server').with_param('ensure', 'present') }
> vs
>
31 matches
Mail list logo
