[Puppet-dev] [PATCH/Module/cloud-provisioner 1/1] (#8706) Fix spec tests of option validation

2011-07-29 Thread Jeff McCune
With the changes to Puppet core in 2.7.x the behavior changed with additional method arguments being passed to actions, specifically :extra => {}. This change caused false positive failures in the spec tests. This change updates the spec test to take into account the implicit addition of :extra =

Re: [Puppet-dev] using relationships inside a defined type?

2011-07-29 Thread Luke Kanies
On Jul 29, 2011, at 12:12 PM, Rudy X. Desjardins wrote: > Hopefully someone here can help - having issues for days now w.r.t. > trying to get a dependency working inside a defined resource type... > here's the verbatim type as it exists currently (note that I've > re-arranged a lot of this multipl

[Puppet-dev] (puppetlabs/puppet) New pull request: (#8677) Merge updates to vcsrepo [2.7.x]

2011-07-29 Thread wearetherobots
Greetings! Please review the pull request #18: (#8677) Merge updates to vcsrepo [2.7.x] opened by Matthaus Litteken (mlitteken) Some more information about the pull request: Opened: Fri Jul 29 22:56:15 UTC 2011 Based on: puppetlabs:2.7.x (1e826bfe371de673725

[Puppet-dev] Announce: Puppet-dashboard 1.2rc4 Available

2011-07-29 Thread Michael Stahnke
This a feature release candidate (number 4) of Puppet Dashboard. This release is available for download at: http://downloads.puppetlabs.com/dashboard/ We have included Debian and RPM packages as well as a tarball. See the Verifying Puppet Download section at: http://projects.puppetlabs.com/proj

[Puppet-dev] [PATCH/Module/puppetlabs-stdlib 2/2] (#8709) Add hash merging function

2011-07-29 Thread Dan Bode
In Puppet, it is not possible to reassign hash values. This function allows a reasonable way to perform hash munging in Puppet. Reviewed-by: Jeff McCune Signed-off-by: Dan Bode --- lib/puppet/parser/functions/merge.rb| 28 spec/unit/puppet/parser/functions/merge_spec

[Puppet-dev] [PATCH/Module/puppetlabs-stdlib 1/2] (#8708) Add has_key function

2011-07-29 Thread Dan Bode
It is difficult to use existance of keys in a hash as a boolean condition in Puppet (see #8705) This function provides a working solution until the underlying issue in Puppet can be resolved. Reviewed-by: Jeff McCune Signed-off-by: Dan Bode --- lib/puppet/parser/functions/has_key.rb

[Puppet-dev] ANNOUNCE: Puppet 2.7.2rc3 available

2011-07-29 Thread Michael Stahnke
Puppet 2.7.2rc3 is available. RC2 was accidentally packaged from the wrong branch; thus causing some odd regressions and behavior. I apologize for that. This rc corrects that mistake. New since RC2 === * Fix an issue where some commits in 2.7.x made their way into 2.7.2rc2 due to a branch conf

[Puppet-dev] [PATCH/puppet 1/1] (#8644) Host provider on Windows

2011-07-29 Thread Josh Cooper
The host provider did not work on Windows because it didn't know where to find its hosts file. The provider now uses Win32::Resolv, which is part of the standard ruby library, to find it. Several host type/provider spec tests were marked as fails_on_windows, but now that the provider is working, I

[Puppet-dev] [PATCH/puppet-dashboard 1/1] (#8691) Fix the order of changed and unchanged resources on the report summary

2011-07-29 Thread Matt Robinson
Signed-off-by: Matt Robinson --- Local-branch: ticket/1.2rc/8691 app/views/reports/index.html.haml |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/app/views/reports/index.html.haml b/app/views/reports/index.html.haml index 545d4ca..f6399f3 100644 --- a/app/views/report

[Puppet-dev] [PATCH/puppet 1/1] (#8704) Give better errors for invalid fileserver.conf

2011-07-29 Thread Matt Robinson
If you tried to just put an allow or deny line in the fileserver.conf without a mount point, you got a really confusing error message: lib/puppet/network/handler/fileserver.rb:285:in `readconfig': undefined method `info' for nil:NilClass (NoMethodError) Now instead we give an error saying no

[Puppet-dev] using relationships inside a defined type?

2011-07-29 Thread Rudy X. Desjardins
Hopefully someone here can help - having issues for days now w.r.t. trying to get a dependency working inside a defined resource type... here's the verbatim type as it exists currently (note that I've re-arranged a lot of this multiple times to try different things, ie: before, require, autorequire

[Puppet-dev] [PATCH/puppet 1/2] (#8660) Default config dir to %PROGRAMDATA% on Windows

2011-07-29 Thread Josh Cooper
The puppet install.rb script now defaults the config directory to %PROGRAMDATA%\PuppetLabs\puppet\etc on Windows. This is more inline with Windows best-practices, as this directory is used to store application data across all users. The PROGRAMDATA environment variable also takes into account alter

[Puppet-dev] [PATCH/puppet 2/2] (#8660) Fix destdir option on Windows

2011-07-29 Thread Josh Cooper
Specifying the --destdir option failed on windows because the install script attempted to concatenate two absolute paths together. On Unix, this is fine, but on Windows, it fails because the colon (part of the drive specifier) is not a valid filename character. This commit adds a method to join two

Re: [Puppet-dev] Re: [Puppet Users] ANNOUNCE: Puppet Dashboard 1.2rc3 available

2011-07-29 Thread Ohad Levy
On Fri, Jul 29, 2011 at 10:14 AM, David Schmitt wrote: > On 29.07.2011 08:43, Nick Lewis wrote: >> >> On Thu, Jul 28, 2011 at 11:34 PM, David Schmitt  wrote: >>> >>> I tried to login to redmine with openid, but just got an "internal >>> error". >>> >>> Here's the report: >>> >>> When having unreso

[Puppet-dev] [PATCH/facter 1/1] (#8660) Fix destdir option on Windows

2011-07-29 Thread Josh Cooper
Specifying the --destdir option failed on windows because the install script attempted to concatenate two absolute paths together. On Unix, this is fine, but on Windows, it fails because the colon (part of the drive specifier) is not a valid filename character. This commit adds a method to join two

Re: [Puppet-dev] Re: [Puppet Users] ANNOUNCE: Puppet Dashboard 1.2rc3 available

2011-07-29 Thread Michael Stahnke
> > PS: Everyone who ever again says Debian has outdated Software should > take a redhat floppy and ... > The CentOS guys back-ported 187 to EL 5. Maybe that will help? http://centos.karan.org/el5/ruby187/ -- You received this message because you are subscribed to the Google Groups "Puppet D

Re: [Puppet-dev] Re: Redmine upgrade

2011-07-29 Thread David Schmitt
On 29.07.2011 10:02, James Turnbull wrote: David Schmitt wrote: On 29.07.2011 08:35, Ben Hughes wrote: On Wed, Jul 27, 2011 at 11:55:16AM -0700, Ben Hughes wrote: It should be swift, and probably, no one will even notice. Let us all just pretend that was the case... If anyone is seeing any

Re: [Puppet-dev] Re: Redmine upgrade

2011-07-29 Thread James Turnbull
David Schmitt wrote: > On 29.07.2011 08:35, Ben Hughes wrote: >> On Wed, Jul 27, 2011 at 11:55:16AM -0700, Ben Hughes wrote: >> >>> It should be swift, and probably, no one will even notice. >> >> Let us all just pretend that was the case... >> >> If anyone is seeing anything out of sorts, please g

Re: [Puppet-dev] Re: Redmine upgrade

2011-07-29 Thread David Schmitt
On 29.07.2011 08:35, Ben Hughes wrote: On Wed, Jul 27, 2011 at 11:55:16AM -0700, Ben Hughes wrote: It should be swift, and probably, no one will even notice. Let us all just pretend that was the case... If anyone is seeing anything out of sorts, please give me a shout (or, if you still can,

Re: [Puppet-dev] Re: [Puppet Users] ANNOUNCE: Puppet Dashboard 1.2rc3 available

2011-07-29 Thread David Schmitt
On 29.07.2011 08:43, Nick Lewis wrote: On Thu, Jul 28, 2011 at 11:34 PM, David Schmitt wrote: I tried to login to redmine with openid, but just got an "internal error". Here's the report: When having unresolved parameter collisions in the dashboard, lib/node_group_graph throws and error: Ac