[Puppet-dev] (puppetlabs/hiera) Differentiate between unique and non-unique array search

2012-02-10 Thread wearetherobots
Please review pull request #32: Differentiate between unique and non-unique array search opened by (Preston4tw) Description: A small patch to add an option to allow for non-unique array search by default, and a different unique array search. Opened: Sat Feb 11

[Puppet-dev] (puppetlabs/puppet-acceptance) Allow multiple exitcodes for initial puppet agent run

2012-02-10 Thread wearetherobots
Please review pull request #144: Allow multiple exitcodes for initial puppet agent run opened by (justinstoller) Description: Prior to this (a change I made to not effectively bounce the agent service) only accepted an exit code of 0. This worked for my testing because o

[Puppet-dev] (puppetlabs/facter) (#9555) removing trailing whitespace

2012-02-10 Thread wearetherobots
Please review pull request #169: (#9555) removing trailing whitespace opened by (ghoneycutt) Description: suggest adding these lines to your vimrc highlight ExtraWhitespace ctermbg=darkgreen guibg=darkgreen match ExtraWhitespace /\s+$/ Opened: Sat Feb 11 00:4

[Puppet-dev] (puppetlabs/puppet-acceptance) Previously the add master to /etc/hosts step would move all lines

2012-02-10 Thread wearetherobots
Please review pull request #143: Previously the add master to /etc/hosts step would move all lines opened by (justinstoller) Description: except for those that contained the hostname of the master. If someone had an /etc/hosts file like this: 127.0.0.1 localhost localh

[Puppet-dev] (puppetlabs/puppet-acceptance) remove autosign default from with_master_running_on

2012-02-10 Thread wearetherobots
On Fri Feb 10 23:53:51 UTC 2012 pull request #141 was closed. remove autosign default from with_master_running_on requested by (cprice-puppet) The pull request was merged by: justinstoller -- You received this message because you are subscribed to the Google Groups "

[Puppet-dev] (puppetlabs/puppet) Feature/2.7.x/5454 pluginsync features autosign

2012-02-10 Thread wearetherobots
On Fri Feb 10 23:46:01 UTC 2012 pull request #489 was closed. Feature/2.7.x/5454 pluginsync features autosign requested by (cprice-puppet) The pull request was merged by: joshcooper -- You received this message because you are subscribed to the Google Groups "Puppet

[Puppet-dev] (puppetlabs/puppet-acceptance) (#12565 & #12566) `--pre SCRIPT` and help usage

2012-02-10 Thread wearetherobots
Please review pull request #142: (#12565 & #12566) `--pre SCRIPT` and help usage opened by (justinstoller) Description: Prior to this you would only get the usage banner if you used -h or --help this makes the usage banner printed when no arguments are supplied as well. (

Re: [Puppet-dev] mocha issues

2012-02-10 Thread Patrick Carlisle
https://github.com/floehopper/mocha/issues/65 Fixed in 0.10.4 Basically if you set an expectation on the same instance of something (usually happens with a class or module method) in multiple tests, the expectation would only be checked in the first test. On Fri, Feb 10, 2012 at 10:25 AM, Chris

[Puppet-dev] (puppetlabs/puppet) Feature/2.7.x/5454 pluginsync features autosign

2012-02-10 Thread wearetherobots
On Fri Feb 10 22:52:58 UTC 2012 pull request #488 was closed. Feature/2.7.x/5454 pluginsync features autosign requested by (cprice-puppet) -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send

[Puppet-dev] (puppetlabs/puppet) Feature/2.7.x/5454 pluginsync features autosign

2012-02-10 Thread wearetherobots
Please review pull request #489: Feature/2.7.x/5454 pluginsync features autosign opened by (cprice-puppet) Description: We are removing "autosign" from the list of default arguments for the with_master_running_on method in the acceptance test framework. Thus, this test no

[Puppet-dev] (puppetlabs/puppet-dashboard) (#12440) Add config flag to puppet-dashboard file in rh spec

2012-02-10 Thread wearetherobots
Please review pull request #84: (#12440) Add config flag to puppet-dashboard file in rh spec opened by (MosesMendoza) Description: Without this commit, the installer for dashboard treats the /etc/sysconfig/puppet-dashboard config file as a regular file and overwrites it d

[Puppet-dev] (puppetlabs/puppet) (#10299) Puppet.features.root? should be true when running as LocalSystem

2012-02-10 Thread wearetherobots
On Fri Feb 10 20:20:33 UTC 2012 pull request #482 was closed. (#10299) Puppet.features.root? should be true when running as LocalSystem requested by (joshcooper) -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To po

[Puppet-dev] (puppetlabs/puppet) (#12412) Don't assume root user exists

2012-02-10 Thread wearetherobots
Please review pull request #487: (#12412) Don't assume root user exists opened by (joshcooper) Description: Previously, the test was verifying that puppet didn't create theroot user, assuming it already existed on the host. But that's not the case on Windows. This commit

[Puppet-dev] (puppetlabs/puppet) Ticket/2.7.x/12106 pmt uninstall command ux improvements

2012-02-10 Thread wearetherobots
On Fri Feb 10 19:16:59 UTC 2012 pull request #486 was closed. Ticket/2.7.x/12106 pmt uninstall command ux improvements requested by (kelseyhightower) The pull request was merged by: daniel-pittman -- You received this message because you are subscribed to the Google

Re: [Puppet-dev] mocha issues

2012-02-10 Thread Chris Price
Patrick could probably explain it better than I, as he did more investigating into repro cases. I believe that the gist of it is that if you call "expects" for the same method more than once, all of the expectations except for the very first one will just be ignored and result in false positives.

Re: [Puppet-dev] mocha issues

2012-02-10 Thread R.I.Pienaar
hey, do you have details of what the problem is? thanks - Original Message - > From: "Chris Price" > To: puppet-dev@googlegroups.com > Sent: Tuesday, February 7, 2012 5:36:19 PM > Subject: [Puppet-dev] mocha issues > > Hi all, > > > Just an FYI, Patrick and I discovered a pretty majo

[Puppet-dev] (puppetlabs/puppet-acceptance) remove autosign default from with_master_running_on

2012-02-10 Thread wearetherobots
Please review pull request #141: remove autosign default from with_master_running_on opened by (cprice-puppet) Description: The previous change set added some additional default arguments for "with_master_running_on". One of those was "--autosign". This commit removes t

[Puppet-dev] (puppetlabs/puppet-acceptance) (maint) alter 03_ValidateSignCert to use new with_master defaults

2012-02-10 Thread wearetherobots
On Fri Feb 10 07:59:05 UTC 2012 pull request #140 was closed. (maint) alter 03_ValidateSignCert to use new with_master defaults requested by (justinstoller) The pull request was merged by: justinstoller -- You received this message because you are subscribed to the G