[Puppet-dev] (puppetlabs/puppet) Removed unused code for FileServer

2012-03-28 Thread wearetherobots
Please review pull request #612: Removed unused code for FileServer opened by (zaphod42) Description: There is no way that this code can be used since in tries to require puppet/network/handler which doesn't exist. So if this code was ever loaded it would raise an error.

[Puppet-dev] handling of :undef in functions

2012-03-28 Thread Chris Price
Hi all, I'm reviewing a ticket related to how we handle "undef" when it is passed to a puppet function. The current behavior is to convert it to an empty string before passing it off to the function body, but I'm not sure that's the right thing to do as it seems to eliminate the ability to handle

[Puppet-dev] (puppetlabs/puppet) Ticket/2.7.x/12101 reapply autoload

2012-03-28 Thread wearetherobots
Please review pull request #611: Ticket/2.7.x/12101 reapply autoload opened by (pcarlisle) Description: This adds shared contexts in rspec for stubbing out platform specific path behavior. This was backed out once before, because we didn't have a recent enough rspec in o

[Puppet-dev] (puppetlabs/puppet-docs) Maint: Fix broken links

2012-03-28 Thread wearetherobots
Please review pull request #61: Maint: Fix broken links opened by (joshcooper) Description: If you are on the docs.puppetlabs.com site, then selecting Service > Events & Training or Customer Supports gives a 404. Referencing these pages from www.puppetlabs.com gives the d

[Puppet-dev] (puppetlabs/puppet) Ticket/2.7.x/12466 unset x forwarded for headers in supplied config

2012-03-28 Thread wearetherobots
Please review pull request #610: Ticket/2.7.x/12466 unset x forwarded for headers in supplied config opened by (MosesMendoza) Description: Without this patch the handling of X-Forwarded-For headers is insecure in a default apache conf supplied with puppet. This patch ensu

[Puppet-dev] (puppetlabs/puppet-docs) Windows updates

2012-03-28 Thread wearetherobots
Please review pull request #60: Windows updates opened by (joshcooper) Description: Opened: Wed Mar 28 18:03:37 UTC 2012 Based on: puppetlabs:master (5fcfc8f3d6a48f47e0cf65dbc74b9ab05cae09bc) Requested merge: joshcooper:windows-updates (fff7c8

[Puppet-dev] (puppetlabs/puppet) Added missing self.class… otherwise it failed.

2012-03-28 Thread wearetherobots
Please review pull request #609: Added missing self.class… otherwise it failed. opened by (damjanek) Description: Opened: Wed Mar 28 12:02:50 UTC 2012 Based on: puppetlabs:master (ed0e0dbe91a81c6d4e4eecf734eb0cef2819161a) Requested merge: damj