[Puppet-dev] (puppetlabs/puppet) (#13584) master swallows errors during startup

2012-04-02 Thread wearetherobots
Please review pull request #619: (#13584) master swallows errors during startup opened by (cprice-puppet) Description: Our main "exit_on_fail" method was only catching and logging a limited subset of all possible errors; this was preventing some types of errors (e.g. File

[Puppet-dev] (puppetlabs/puppet) (#9167) Do not send email when nothing changes

2012-04-02 Thread wearetherobots
Please review pull request #618: (#9167) Do not send email when nothing changes opened by (kelseyhightower) Description: Without this patch the tagmail report sends an email even when there are no changes or resources out of sync. This has the undesired effect of sending

Re: [Puppet-dev] handling of :undef in functions

2012-04-02 Thread Daniel Pittman
On Mon, Apr 2, 2012 at 08:54, Nigel Kersten wrote: > So to translate from the bug report, it sounds like we're going to (go > back to?) representing :undef as nil inside Ruby? I think that is the right decision, but I wouldn't hold it completely decided. Someone could remember the horrible root

Re: [Puppet-dev] handling of :undef in functions

2012-04-02 Thread Chris Price
Yeah. Probably better to be safe than sorry. I'll plan on adding the deprecation warning to Telly and then probably open a new ticket for implementation, and we can slot that in to a later roadmap. On Mon, Apr 2, 2012 at 10:09 AM, Randall Hansen wrote: > On Mon, Apr 2, 2012 at 9:43 AM, Andrew P

Re: [Puppet-dev] handling of :undef in functions

2012-04-02 Thread Randall Hansen
On Mon, Apr 2, 2012 at 9:43 AM, Andrew Parker wrote: > Retroactively deprecating functionality seems like an odd thing to do. From > my standpoint of a user of software I wouldn't expect that features of a > minor version were deprecated in a patch release in order to be removed at > the next maj

Re: [Puppet-dev] handling of :undef in functions

2012-04-02 Thread Andrew Parker
Retroactively deprecating functionality seems like an odd thing to do. From my standpoint of a user of software I wouldn't expect that features of a minor version were deprecated in a patch release in order to be removed at the next major/minor release. On Apr 2, 2012, at 9:25 AM, Chris Price w

Re: [Puppet-dev] handling of :undef in functions

2012-04-02 Thread Chris Price
If we're thinking about deprecating in 2.7.x, we should probably make the changes soon (perhaps in a branch off of Telly) and try to have some folks spend some time testing against existing modules. I don't have a clear picture of how wide the impact could be, and with Telly shipping in a few mont

Re: [Puppet-dev] handling of :undef in functions

2012-04-02 Thread Nigel Kersten
So to translate from the bug report, it sounds like we're going to (go back to?) representing :undef as nil inside Ruby? Whether that be templates or the Ruby DSL? is that right? I feel like this is the right thing to do. :undef is all we have to represent nil in the Puppet DSL, and it's a bit t