Re: [Puppet-dev] Module Testing and Facter 3

2015-05-22 Thread Kylo Ginsberg
Thanks for the feedback, Gareth and Josh. We need to figure out the steps here, so this is super useful. A couple minor comments below, and I'm consolidating the replies. On Sun, May 17, 2015 at 8:37 AM, Gareth Rushgrove wrote: > I'd be happy to see a PR against puppet-module-skeleton > (https

Re: [Puppet-dev] Adding metrics in agent report - PUP-4634

2015-05-22 Thread R.I.Pienaar
- Original Message - > From: "Romain F." > To: "puppet-dev" > Sent: Friday, May 22, 2015 2:17:47 PM > Subject: Re: [Puppet-dev] Adding metrics in agent report - PUP-4634 > Le vendredi 22 mai 2015 14:53:10 UTC+2, R.I. Pienaar a écrit : >> >> these would be good to add to both last_run_s

Re: [Puppet-dev] Adding metrics in agent report - PUP-4634

2015-05-22 Thread Romain F.
Le vendredi 22 mai 2015 14:53:10 UTC+2, R.I. Pienaar a écrit : > > these would be good to add to both last_run_summary.yaml and the reports > indeed, > I mentioned this in the ticket but the report already contains a wealth of > perf > data, I have a report parser you can use on the CLI that p

Re: [Puppet-dev] Adding metrics in agent report - PUP-4634

2015-05-22 Thread R.I.Pienaar
hello, - Original Message - > From: "Romain F." > To: "puppet-dev" > Sent: Friday, May 22, 2015 8:20:16 AM > Subject: [Puppet-dev] Adding metrics in agent report - PUP-4634 > Hi everyone, > Following the suggestion of Henrik L. we'll continue the discussion of > PUP-4634 here. > It bega

[Puppet-dev] Adding metrics in agent report - PUP-4634

2015-05-22 Thread Romain F.
Hi everyone, Following the suggestion of Henrik L. we'll continue the discussion of PUP-4634 here. It began with my suggestion of adding some timings in agent code in order to check steps which can take some time. And, thus, being able to troubleshoot pretty ugly things like this : Info: Cachin