On Fri, Jan 13, 2012 at 7:10 PM, Todd Zullinger wrote:
> Matt Robinson wrote:
>> I've wanted command line completion for some time, so I've whipped
>> something up that gets it going:
>>
>> https://github.com/mmrobins/puppet-completion
>>
>> I&#
I've wanted command line completion for some time, so I've whipped
something up that gets it going:
https://github.com/mmrobins/puppet-completion
I've been meaning to get it to a state to merge into Puppet core, but
haven't had the time yet, so I've made it a standalone repo so that
people can us
the type spec to
> ensure
> this documentation is being generated correctly.
>
> Paired-with: Matt Robinson m...@puppetlabs.com
>
> Thanks!
> The Pull Request Bot
>
> Diff follows:
>
> diff --git a/lib/puppet/type.rb b/lib/puppet/type.rb
> index d
On Wed, Sep 7, 2011 at 6:15 PM, Michael Stahnke wrote:
> 3. Dashboard has had no commits since 1.2.0, so no RC this month.
Dashboard does have commits since 1.2.0
$ git log --oneline --no-merges 1.2.0..
6b10a5e maint: Move duplicated code to a helper method
02ca4ff maint: Fix node_ids method by
Duplicate methods are moved of a module, and very similar methods are
generated programatically, which is a lot fewer lines, but slightly less
readable.
Reviewed-by: Nick Lewis
Signed-off-by: Matt Robinson
---
Local-branch: ticket/master/8878_add_nodes_from_group_page
app/models/node.rb
It's really unusable to have to go to each node's edit page to add a
list of nodes to a group. Now you can just add the nodes on the group's
create or edit page.
Signed-off-by: Matt Robinson
---
Local-branch: ticket/master/8878_add_nodes_from_group_page
w to
enable the file bucket.
Also fixed some other bugs such as rendering text if you passed an
invalid md5 and improved test robustness.
Based on code from Jacob Helwig
Reviewed-by: Nick Lewis
Signed-off-by: Matt Robinson
---
Local-branch: ticket/1.2rc/7934-filebucket_links
app/controllers
it from working with the agent (#5362), or if the inspect
runs don't have --archive_files set (which defaults to false).
The baseline plugin will update its usage of popup_md5s as part of
ticket #9105.
Reviewed-by: Nick Lewis
Signed-off-by: Matt Robinson
---
Local-branch: ticket/1.2rc
Mac's filesystems aren't case sensitive, so developing this change
didn't catch the issue with requiring filenames that had been
uppercased.
Reviewed-by: Nick Lewis
Signed-off-by: Matt Robinson
---
Local-branch: ticket/2.7.x/maint-fix_inspect_help
lib/puppet/application.rb
Ignore. This patch wasn't one I meant to mail out, it was already in 2.7.x.
On Tue, Aug 9, 2011 at 11:36 AM, Matt Robinson wrote:
> From: Michael Stahnke
>
>
> Signed-off-by: Matt Robinson
> ---
> Local-branch: ticket/2.7.x/maint-fix_inspect_h
Ignore. This patch wasn't one I meant to mail out, it was already in 2.7.x.
On Tue, Aug 9, 2011 at 11:36 AM, Matt Robinson wrote:
> From: Michael Stahnke
>
> Signed-off-by: Michael Stahnke
> Signed-off-by: Matt Robinson
> ---
> Local-branch: ticket/2.7.x/maint-
From: Michael Stahnke
Signed-off-by: Michael Stahnke
Signed-off-by: Matt Robinson
---
Local-branch: ticket/2.7.x/maint-fix_inspect_help
lib/puppet.rb |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/puppet.rb b/lib/puppet.rb
index 765c95c..5ccdd41 100644
--- a/lib
Inspect wasn't documenting the only two options it has, archive_files
and archive_file_server. Now it does.
Reviewed-by: Nick Lewis
Signed-off-by: Matt Robinson
---
Local-branch: ticket/2.7.x/maint-fix_inspect_help
lib/puppet/application/inspect.rb | 10 +-
1 files chang
it's not
found.
Reviewed-by: Nick Lewis
Signed-off-by: Matt Robinson
---
Local-branch: ticket/2.7.x/maint-fix_inspect_help
lib/puppet/application.rb |9 -
spec/unit/application_spec.rb |4
2 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/lib/pupp
From: Michael Stahnke
Signed-off-by: Matt Robinson
---
Local-branch: ticket/2.7.x/maint-fix_inspect_help
CHANGELOG | 66 +++-
1 files changed, 60 insertions(+), 6 deletions(-)
diff --git a/CHANGELOG b/CHANGELOG
index cfdcf49..0464108
: Josh Lifton
Signed-off-by: Matt Robinson
---
Local-branch: ticket/1.2rc/8488-reports_column_consistency
app/views/nodes/_reports.html.haml | 26 ++---
app/views/nodes/_reports_table_tfoot.html.haml |5 +++
app/views/reports/_reports_table.html.haml | 45
Per the W3: must appear before within a table, so that a
browser can render the foot before receiving all the rows of data.
Reviewed-by: Josh Lifton
Signed-off-by: Matt Robinson
---
Local-branch: ticket/1.2rc/8488-reports_column_consistency
app/views/nodes/_reports_table_tfoot.html.haml
Signed-off-by: Matt Robinson
---
Local-branch: ticket/1.2rc/8691
app/views/reports/index.html.haml |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/app/views/reports/index.html.haml
b/app/views/reports/index.html.haml
index 545d4ca..f6399f3 100644
--- a/app/views
ror saying no mount point was specified.
Reviewed-by: Josh Cooper
Signed-off-by: Matt Robinson
---
Local-branch: ticket/2.7.x/8704-fileserverconf_parse_errors
lib/puppet/network/handler/fileserver.rb |3 ++
spec/unit/network/handler/fileserver_spec.rb | 32 +
e cutting
> a new rc is 8691.
> Dan
>
> On Thu, Jul 28, 2011 at 4:38 PM, Matt Robinson wrote:
>>
>> A race condition issue has been found with DelayedJob report
>> processing. The fix has been committed to the rc branch, so another
A race condition issue has been found with DelayedJob report
processing. The fix has been committed to the rc branch, so another
RC will be necessary.
Ticket #8686
commit:e86526f224058d8d049b2f8b93d5fdca57332ad8
On Fri, Jul 22, 2011 at 4:18 PM, Michael Stahnke wrote:
> This a feature release ca
The previous error was just:
Host has already been taken
The problem is that host by itself isn't unique, but the error message
would lead you to believe it is. Instead, mention that the host, kind,
time combo needs to be unique.
Paired-with: Jacob Helwig
Signed-off-by: Matt Rob
iewed-by: Jacob Helwig
Signed-off-by: Matt Robinson
---
Local-branch: ticket/1.2rc/8686
app/models/report.rb |8 ++-
...28195829_add_node_host_uniqueness_constraint.rb | 15 ++
spec/models/report_spec.rb | 54
now these workarounds like needing to load all
templates, the scope object now uses method_missing to find the function
if available.
Paired-with: Nick Lewis
Signed-off-by: Matt Robinson
---
Local-branch: ticket/2.7.x/4549-functions_in_templates
lib/puppet/parser/scope.rb | 10 ++
spec
/certificate_authority/interface.rb:85:in
`method='
Invalid method to apply
Reviewed-by: Pieter van de Bruggen
Signed-off-by: Matt Robinson
---
Local-branch: ticket/2.7.x/maint-show_help_for_cert_without_subcommand
lib/puppet/application/cert.rb |3 ++-
spec/unit/applic
On Mon, Jul 25, 2011 at 1:10 PM, Daniel Pittman wrote:
> On Mon, Jul 25, 2011 at 12:57, Matt Robinson wrote:
>> Requiring puppet before the run_mode has been set by the application
>> causes the default run_mode of 'user' to be set instead of what the
>> applic
It's always bothered me that when running puppet inspect (or any
application that produces a report really) the master gives no
indication that anything happened when it processes the report.
Reviewed-by: Max Martin
Signed-off-by: Matt Robinson
---
lib/puppet/indirector/report/process
Reviewed-by: Max Martin
Signed-off-by: Matt Robinson
---
lib/puppet/type/file/source.rb |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/puppet/type/file/source.rb b/lib/puppet/type/file/source.rb
index 6ebec51..2fb65bb 100755
--- a/lib/puppet/type/file/source.rb
ata from a fileserver.
Reviewed-by: Max Martin
Signed-off-by: Matt Robinson
---
lib/puppet/application/inspect.rb |7 +--
spec/unit/application/inspect_spec.rb |5 +
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/lib/puppet/application/inspect.rb
b/lib/puppet/a
This is definitely possible. You can manage services like mysql with
puppet: http://docs.puppetlabs.com/references/stable/type.html#service,
and you could use a puppet exec resource to to import:
http://docs.puppetlabs.com/references/stable/type.html#exec. You may
also want to check for modules t
Reviewed in person with NickF and he'll merge it to 2.7.x. +1
On Fri, Jul 15, 2011 at 10:54 AM, nfagerlund wrote:
> The agent/apply/device man pages mentioned the 2 and 4 exit codes, but didn't
> mention that they can combine to make 6 if there are both changes and
> failures.
> This commit add
From: Max Martin
Settings#writesub was not checking the type of the mode value passed in
from the defaults, causing it to pass a string for mode to File.open,
leading to failures. This commit resolves that issue.
Paired-with: Matt Robinson
Signed-off-by: Matt Robinson
---
lib/puppet/util.rb
run, since previously
the tests depended on the a json feature, which we didn't have. We do,
however, have a pson feature.
Reviewed-by: Nick Lewis
Signed-off-by: Matt Robinson
---
Local-branch: ticket/2.7.x/4142-metadata_json
lib/puppet/module.rb |5 +++-
spec/unit/module
ncludes a brief mention in the
README that the user should setup log rotation, and ticket #8264 was
created to setup log rotation in the packaged version of Dashboard.
Reviewed-by: Daniel Pittman
Signed-off-by: Matt Robinson
---
Local-branch: ticket/master/8251-logger_verbosity
README.markdo
aired-with: Josh Cooper
Signed-off-by: Matt Robinson
---
Local-branch: ticket/master/8090-git_ignore_plugin_files
.gitignore |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/.gitignore b/.gitignore
index 24688df..cc8a07c 100644
--- a/.gitignore
+++ b/.gitignore
@@ -21,6
Pratik,
I'm not sure I know what problem you're referring to in the context of
this really old thread. Could you specify what problem you're trying
to solve?
Matt
On Wed, Jun 22, 2011 at 9:55 AM, Pratik Khadloya wrote:
> I too see the same problem. Were you able to find the solution?
>
> --
> Yo
Plugins should be able to add navigation links so you can get to the
views they define.
Reviewed-by: Nick Lewis
Signed-off-by: Matt Robinson
---
Local-branch: ticket/master/7958-plugin_navigation_links
app/views/shared/_global_nav.html.haml |2 ++
1 files changed, 2 insertions(+), 0
: Matt Robinson
---
Local-branch: ticket/master/maint-fix_db_seed
db/seeds.rb | 106 ---
1 files changed, 0 insertions(+), 106 deletions(-)
delete mode 100644 db/seeds.rb
diff --git a/db/seeds.rb b/db/seeds.rb
deleted file mode 100644
A patch series that upgrades the version of Rails that Puppet
Dashboard vendors from 2.3.5 to 2.3.12 was just merged in to
Dashboard's master branch. I wasn't able to easily generate a patch
to send out over email since some code in Rails is over 998
characters, and git format-patch doesn't handle
It used to be that to list the faces available and their actions and
options, you had this legacy based face application. This functionality
has all been moved into the puppet help face application.
Reviewed-by: Daniel Pittman
Signed-off-by: Matt Robinson
---
Local-branch: ticket/2.7rc/7557
ed no Exception, got #
in lib/puppet/face/indirector/face.rb when listing the indirections for
the help text.
I toyed with creating a real indirection for the test, but that was
harder than expected.
Paired-with: Max Martin
Signed-off-by: Matt Robinson
---
Local-branch: ticket/2.7rc/
this is a safe fix to prevent them from having autoload slowness.
Paired-with: Max Martin
Signed-off-by: Matt Robinson
---
Local-branch: ticket/2.7rc/maint-faces_docs_spec_fixes
lib/puppet/util/autoload.rb |2 +-
spec/unit/util/autoload_spec.rb |4 ++--
2 files changed, 3 i
Robinson
Signed-off-by: Matt Robinson
---
Local-branch: ticket/2.7rc/maint-faces_docs_spec_fixes
lib/puppet/interface/documentation.rb|4 +++-
spec/shared_behaviours/documentation_on_faces.rb | 11 +--
2 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/lib/puppet
There were a few test failures introduced by the recent documentation branch
merge to 2.7.x. Most of these were hard to catch on a dev box because they
only failed when active record wasn't installed or in an order dependent
fashion. Jenkins got them though. This patch series fixes those test
ow we just list the terminuses available in the load path without
trying to load them. The terminus will still raise an error if you try
to use it without its dependencies being met.
Paired-with: Max Martin
Signed-off-by: Matt Robinson
---
Local-branch: ticket/2.7rc/maint-faces_docs_spec_fixes
ly convert when you call enumerable methods on strings.
Paired-with: Josh Cooper
Signed-off-by: Matt Robinson
---
Local-branch: ticket/next/7507-ruby19_fix
spec/unit/physicalprocessorcount_spec.rb |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a
Also removed some monkey patching on Signal that would have
theoretically done this without having to explicitly call trap on Signal
in order to stub it, but it's not working.
This allows us to ctrl+c (send SIGINT) in the middle of a spec run.
Paired-with: Josh Cooper
Signed-off-by:
is just changes them to be different in the example file so that it's
easier to get started with sane defaults.
Reviewed-by: Josh Cooper
Signed-off-by: Matt Robinson
---
Local-branch: ticket/next/maint-better_database_default_names
config/database.yml.example |4 ++--
1 files changed
, and Jenkins will give us email
notification if it doesn't or if we break something that was already
working.
Reviewed-by: Daniel Pittman
Signed-off-by: Matt Robinson
---
Local-branch: ticket/2.7.x/7507-filter_19_failures
spec/integration/application/doc_spec.rb |2 +-
Ruby 1.9 is strict about argument arity for methods that are
metaprogrammatically defined. A ton of specs that were setting up
when_invoked didn't pass options even though they should have been.
Reviewed-by: Daniel Pittman
Signed-off-by: Matt Robinson
---
Local-branch: ticket/2.7.x
esses all the places ack turned up the code doing this
include? check instead of directly calling method_defined?.
Thanks to Alex Sharp ajsh...@gmail.com for pointing out the Ruby 1.9
problems and working toward a solution.
Reviewed-by: Nick Lewis
Signed-off-by: Matt Robinson
---
Local-branch: t
I noticed a test failure when I ran the specs without an internet
connection. Specs should never need an internet connection to pass.
Reviewed-by: Max Martin
Signed-off-by: Matt Robinson
---
Local-branch: ticket/2.7.x/7468-stub_xmlrpc_internet_call
spec/unit/provider/package/pip_spec.rb
for
removal as far as I'm concerned, but apparently Luke wants it in there.
Reviewed-by: Pieter van de Bruggen
Signed-off-by: Matt Robinson
---
Local-branch: ticket/2.7.x/7291-ruby19-fixes
spec/lib/puppet/face/huzzah.rb |2 +-
spec/lib/puppet/face/version_matching.rb |2 +-
instead of the typical ASCII
32
Reviewed-by: Pieter van de Bruggen
Signed-off-by: Matt Robinson
---
Local-branch: ticket/2.7.x/7291-ruby19-fixes
lib/puppet/face/certificate.rb |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/puppet/face/certificate.rb b/lib/puppet/face
ibyte char (US-ASCII)
Rather than declare the encoding to allow the French word, I've
translated it (after having to look it up myself).
Reviewed-by: Pieter van de Bruggen
Signed-off-by: Matt Robinson
---
Local-branch: ticket/2.7.x/7291-ruby19-fixes
lib/puppet/face/resource.rb |2 +
This initially seemed like a good idea to me, but after playing with
it there's some issues. The real problem isn't whether there's a sub
method on Symbol, but that instance_methods used to return Strings in
Ruby 1.8.7 and now returns Symbols in 1.9. So by monkey patching
symbols to convert to a
Contrary to the current code and ticket #7314 I think syntax errors in
Faces should raise errors immediately instead of just warning in the
log. I could be convinced otherwise, but the discussion with the
original coder of the current behavior and the aforementioned ticket
haven't done so. Genera
Cool, glad to see this getting in. I was about to review it to say it
looked good since I had worked on it with you a month ago, but I see
it's already been merged with Jacob's review.
On Thu, May 12, 2011 at 12:31 PM, nfagerlund wrote:
> Although URLs with usernames and passwords were valid in
Even if the discussion had been on the list, we should have a better
commit message explaining why a revert is being done, and there still
ought to be a reviewer.
http://projects.puppetlabs.com/projects/puppet/wiki/Development_Lifecycle#Commit+Messages
On Thu, May 12, 2011 at 4:07 PM, Daniel Pittm
s due to the ia_load_module parameter requiring manages_aix_lam
> > and additionally having a defaultto value of "compat."
> >
> > Paired-with: Matt Robinson
> > Signed-off-by: Max Martin
> > ---
> > Local-branch: ticket/2.7.x/7137-spurious-warnin
I realized I forgot to include the ticket number in my last email about
including ticket numbers.
I believe this patch series was for #4996.
On Mon, Apr 25, 2011 at 11:45 AM, Matt Robinson wrote:
> Thanks for mailing that Russell, it's easier for us to keep track of what
> we st
Thanks for mailing that Russell, it's easier for us to keep track of what we
still need to review if it gets sent to the list since we've been keeping
track of patches in patchwork:
https://patchwork.puppetlabs.com/project/puppet/list/
That said, it's also really helpful if your commit messages in
Hey Russel,
I'm cleaning out old email and see nobody ever responded to this one, sorry
about that. I think this issue has since been fixed in Dashboard v1.1.0
http://projects.puppetlabs.com/issues/6835
http://projects.puppetlabs.com/issues/6791
If you still see this problem with Dashboard pleas
On Wed, Apr 20, 2011 at 9:00 AM, Jacob Helwig wrote:
> There was a topic branch that was accidentally merged into the 2.7.x
> branch. Since there wasn't anything else done since this, we're just
> rolling 2.7.x back to exclude the merge commit, and the change it
> brought in.
>
> If you're worki
So based on this doc change I assume it's been verified that we don't
need the namespaceauth.conf file anymore? If that's the case, then
ticket #4388 can be moved from "needs decision" to accepted, right?
On Mon, Apr 18, 2011 at 4:54 PM, nfagerlund wrote:
> Puppet kick's help referred only to th
Jake
The behavior in 2.7 when running the master with
--allow_duplicate_certs set is the same as in 2.6.x in that you can
manually (using something like curl or the new 'puppet certificate'
face) generate multiple certs with same CN name, but the agent errors
the same way regardless of the puppet v
This release addresses some issues issues with Dashboard v1.1.0
#6532 - There is a rake task for generating random sample reports for
testing. rake reports:samples:generate
CHANGELOG
v1.1.1rc1
==
f1b2af4 (#7060) Use absolute paths for cert/private key
1a3e607 maint: Document the `rake repo
This release addresses issues with the Puppet 2.6.x series.
Bug #4884:
Shell exec provider that executes code as a raw shell script
Bug #5670:
Failed resources don't improperly trigger a refresh
Feature #2331:
New macports provider
You can find the full release notes for Puppet at:
https
Reviewed-by: Daniel Pittman
Signed-off-by: Matt Robinson
---
Local-branch: ticket/next/6830-more_ruby19_fixes
lib/puppet/parser/functions/sha1.rb |2 +-
lib/puppet/transaction.rb |8
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/lib/puppet/parser
Ruby 1.9 is less forgiving about treating symbols like strings.
Reviewed-by: Daniel Pittman
Signed-off-by: Matt Robinson
---
Local-branch: ticket/next/6830-more_ruby19_fixes
lib/puppet/interface/option_builder.rb |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib
If you're going to use special characters in a file and use Ruby 1.9 you
need to specify the character encoding at the top of the file.
Reviewed-by: Daniel Pittman
Signed-off-by: Matt Robinson
---
Local-branch: ticket/next/6830-more_ruby19_fixes
.../things_that_declare_optio
With this change Puppet can do simple master / client interactions in
Ruby 1.9 (after I put in a few patches to fix minor incompatibilities
- coming soon). We're getting close to Ruby 1.9 support.
On Tue, Apr 12, 2011 at 5:18 PM, Nick Lewis wrote:
> POST with a singular indirection is turned int
On Tue, Apr 12, 2011 at 11:03 AM, Brice Figureau
wrote:
> Hi,
>
> On 12/04/11 19:50, Nick Lewis wrote:
>> If this option is true, a certificate request with the same CN as an existing
>> certificate will override the existing certificate when signed. With the
>> option
>> false, the new certifica
Bendler
wrote:
> Hi Matt,
>
> 2011/4/8 Matt Robinson
>>
>> [...]
>> We definitely appreciate any help testing RC's and releases, so I look
>> forward to your feedback.
>> [...]
>
> Ok, here it is (CentOS 5.6 system). I've changed:
>
On Rails < 3 this patch results in:
NameError: undefined method `scope' for class `Puppet::Rails::InventoryNode'
I've got a patch coming that works (should be mailed out by now), and
passes tests (which it would be really good to run before emailing out
patches
http://projects.puppetlabs.com/pro
is
Signed-off-by: Matt Robinson
---
lib/puppet/rails/inventory_node.rb |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/lib/puppet/rails/inventory_node.rb
b/lib/puppet/rails/inventory_node.rb
index 52f8621..da7e610 100644
--- a/lib/puppet/rails/inventory_node.rb
+++ b/
We mentioned in the release notes how to upgrade your reports, but
didn't document it in the README. This led to some confusion when
people upgraded and their reports went missing.
Reviewed-by: Nick Lewis
Signed-off-by: Matt Robinson
---
Local-branch: ticket/next/
then if you're using older Rubies you're probably not expecting much for
performance anyway.
Reviewed-by: Daniel Pittman
Signed-off-by: Matt Robinson
---
Local-branch: ticket/next/maint-backport_array_combination
lib/puppet/util/monkey_patches.rb | 14 ++
Hi Thomas, sorry for the slow reply on this and lack of packages for
testing. We messed up and forgot to put packages out with Dashboard
for the RC or the release. This should be fixed now for the release,
and we've updated our RC checklist to make testing packages for the
next time.
We definite
The current code only returns PSON correctly. I'm putting in a ticket
today for fixing problems with YAML and other supported formats.
On Tue, Apr 5, 2011 at 12:11 PM, Corey Osman wrote:
> Horray! I am excited to test out the list of signed certificates.
> What serialization format would the li
It would be great if there was some WHY explanation in the commit message.
On Tue, Apr 5, 2011 at 10:42 AM, James Turnbull wrote:
>
> Signed-off-by: James Turnbull
> ---
> Local-branch: tickets/master/6974
> COPYING | 339
> -
> LI
On Mon, Apr 4, 2011 at 1:39 PM, Patrick wrote:
>
> On Apr 4, 2011, at 11:48 AM, Jacob Helwig wrote:
>
>> 1. Reports will need to be converted to a new schematized format when
>> upgrading (#5459). Rather than just storing reports as serialized
>> YAML in the database as is currently done in v1
class Foo
def initialize
@a = 2
@b = "two"
end
end
p Foo.new.instance_variables
In Ruby 1.8 this prints
["@a", "@b"]
In Ruby 1.9 this prints
[:@a, :@b]
Reviewed-by: Jesse Wolfe
Signed-off-by: Matt Robinson
---
Local-branch: ticket
# inherited from Bar
In Ruby 1.8 the to_s override used to be in effect so printed:
Bar inherited from Foo
some other class inherited from Bar
Reviewed-by: Jesse Wolfe
Signed-off-by: Matt Robinson
---
Local-branch: ticket/next/6830-ready_to_merge
spec/unit/indirector/active_rec
In Ruby 1.9 calling .each on a stub calls to_a, and if you're not
stubbing to_a you get:
unexpected invocation: #.to_a()
Could have stubbed to_a also, but less stubbing is better in these cases
Reviewed-by: Jesse Wolfe
Signed-off-by: Matt Robinson
---
Local-branch: ticket/next
This won't be the last of these sets to fix Ruby 1.9 issues, but it's closer
every time. This set of patches reduces the spec failures from more than 600
to around 250, although almost all the fixes in this set were with tests
instead of implementation.
Remaining big issues are dealing with RD
MD5.new('mystring')
=> #
ruby-1.8.7-p330 :005 > MD5.new('mystring').to_s
=> "169319501261c644a58610f967e8f9d0"
ruby-1.8.7-p330 :006 > Digest::MD5.new('mystring')
ArgumentError: wrong number of arguments (1 for 0)
Reviewed-by: Jesse Wolfe
Signed-off-
Ruby 1.9 won't allow to_i to be called on a symbol. It results in the
error:
undefined method `to_i' for :now:Symbol
Reviewed-by: Jesse Wolfe
Signed-off-by: Matt Robinson
---
Local-branch: ticket/next/6830-ready_to_merge
spec/unit/network/authconfig_spec.rb |2 +-
YAML_ATTRIBUTES was being declared as strings and then intersected with
the list of instance_variables, which in Ruby 1.9 comes back as symbols,
so results in an empty list every time.
Reviewed-by: Jesse Wolfe
Signed-off-by: Matt Robinson
---
Local-branch: ticket/next/6830-ready_to_merge
lib
As seen in other Ruby 1.9 compatibility patches already. Fixes errors
like:
undefined method `dirname' for Puppet::Type::File:Class
Reviewed-by: Jesse Wolfe
Signed-off-by: Matt Robinson
---
Local-branch: ticket/next/6830-ready_to_merge
lib/puppet/type/tidy.rb |6 +++---
lib/puppet
Another case where in Ruby 1.8 you can call enumerable methods on
strings that you can't in Ruby 1.9.
undefined method `collect' for "dev2 dev1":String
Reviewed-by: Jesse Wolfe
Signed-off-by: Matt Robinson
---
Local-branch: ticket/next/6830-ready_to_merge
lib/puppet/
On Mon, Mar 28, 2011 at 10:27 AM, Daniel Pittman wrote:
> On Sun, Mar 27, 2011 at 20:09, Ben Hughes wrote:
> >
> > Signed-off-by: Ben Hughes
> > ---
> > Local-branch: tickets/master/6832
> > install.rb |2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/install.
y 1.9 does
class Foo
define_method('bar') do
puts 'baz'
end
end
Foo.new.bar("idonttakearguments")
In Ruby 1.8 this prints: baz
In Ruby 1.9 this errors with: 19_test.rb:3:in `block in ': wrong
number of arguments (1 for 0) (ArgumentError
This fixes errors like
undefined method `expand_path` for Puppet::Type::File::Class
When expand_path was meant to be called on Ruby's File class.
Signed-off-by: Matt Robinson
---
Local-branch: ticket/next/6830_stat_calls
lib/puppet/type/exec.rb | 20 ++--
1 files ch
I know I've done this recently, and it's just that I forgot, not that
there's too much magic. If anything perhaps `rake mail_patches` could
by a little more magic by defaulting the subject to the branch name.
At least the cover email should come through at pretty close to the
same time as the patc
There were a few very important changes we forgot to highlight in the
Dashboard v1.1.0rc1 release notes.
1. Reports will need to be converted to a new schematized format when
upgrading (#5459). Rather than just storing reports as serialized
YAML in the database as is currently done in v1.0.4, th
As Nick noted in another email, this is probably because you have
storeconfigs enabled too. We're writing a fix for this problem and
will be doing a Puppet Dashbaord rc2 later today.
On Thu, Mar 17, 2011 at 11:19 AM, Russell Jackson wrote:
> On 03/16/2011 05:38 PM, Nick Lewis wrote:
>> This rele
I think your conditional is backwards. Rails 2 has named_scope, Rails
3 has scope, so we want to alias scope to named scope when
activerecord < 3
On Wed, Mar 23, 2011 at 3:21 PM, James Turnbull wrote:
> Added alias method for ActiveRecord versions before 3.0
>
> Signed-off-by: James Turnbull
>
These changes get our tests running under Ruby 1.9 instead of just giving
syntax errors and bombing out early. More importantly, the changes don't break
any tests (or appear to break any functionality) when running Puppet under Ruby
1.8.
When running under Ruby 1.9 there are currently 2003 fai
le is the Ruby File class
and not something scoped in Puppet.
Reviewed-by: Jacob Helwig
Signed-off-by: Matt Robinson
---
Local-branch: ticket/next/6820_ruby19_fixes
lib/puppet/type/file.rb | 28 ++--
1 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/lib/p
1 - 100 of 324 matches
Mail list logo
