> What I see in these examples is a need for a way of manipulating the
> data (collect,
> select, reject, etc.). Once the data is manipulated correctly, then
> create_resources and title expansion can take over.
+1
In my own (small) use of Puppet lately, I've keenly felt the lack of data
transfo
On Mon, Aug 6, 2012 at 2:26 PM, Andy Parker wrote:
> On Mon, Aug 6, 2012 at 1:30 PM, Pieter van de Bruggen
> wrote:
> > On Mon, Aug 6, 2012 at 12:45 PM, Andy Parker
> wrote:
> >>
> >> On Mon, Aug 6, 2012 at 11:57 AM, Ken Barber wrote:
> >> >>
On Mon, Aug 6, 2012 at 12:45 PM, Andy Parker wrote:
> On Mon, Aug 6, 2012 at 11:57 AM, Ken Barber wrote:
> >> the thing I need to do better in mco is write a package maintainers
> >> guide to make it clear to people how to undo the bundling as there's
> >> been some mistakes made where people ju
On Wed, May 16, 2012 at 2:22 PM, Luke Kanies wrote:
> On May 16, 2012, at 2:00 PM, Daniel Pittman wrote:
>
> > On Wed, May 16, 2012 at 1:51 PM, Deepak Giridharagopal
> > wrote:
> >> On Wed, May 16, 2012 at 2:07 PM, Chris Price
> wrote:
> >>>
> >>> p.s., if we do go down this path it would be in
.
> >
> >
> > Not to say that the benefits might not be worthwhile... just seems
> > like a big leap to take.
> >
> >
> >
> >
> > On Wed, May 16, 2012 at 12:58 PM, Luke Kanies < l...@puppetlabs.com >
> > wrote:
> >
> >
&
On Tue, May 15, 2012 at 9:56 AM, Jeff Weiss wrote:
> Puppet Community,
>
> We need your help.
>
> We have a terrific contribution from Bart ten Brinke that would add an
> `unless_uid` parameter to user resources. The pull is request is 628 (
> https://github.com/puppetlabs/puppet/pull/628).
>
> W
Question: If a node declaration masks a top-scope variable, is there ever a
good reason to refer to the old value?
On Tue, Apr 17, 2012 at 9:05 AM, Andrew Parker wrote:
>
> On Apr 17, 2012, at 2:03 AM, R.I.Pienaar wrote:
>
> > I like the general idea for sure, but I think it still leaves way too
On Wed, Apr 4, 2012 at 1:58 PM, Ken Barber wrote:
> > Invoking Windows' native color support changes the color of the pen at
> that
> > particular moment, tightly coupling the colorization time with output
> time.
> > In Facter, this is less of a big deal, since you're effectively
> choosing to
ba415872cf1e37900322f2deb763a186598
> >>
> >> On Wed, Apr 4, 2012 at 9:59 AM, Ken Barber wrote:
> >>>
> >>> I know win32console was offering similar functionality for ANSI escape
> >>> codes for Windows - but I think last time we looked win32con
gt; I know win32console was offering similar functionality for ANSI escape
> >> codes for Windows - but I think last time we looked win32console was
> >> out of maintenance. Have you found something else since then Josh?
> >>
> >> On Wed, Apr 4, 2012 at 5:46
>From what I heard yesterday from Josh (and I reserve the right to have
mis-understood), Windows gained support for ANSI escapes, meaning we no
longer need to special case the `color` setting for Windows. The module
that handles colors in core probably doesn't look that different from the
module t
I've gone ahead and updated the ticket with all the additional context I
have, including re-opening the ticket (which I should have done promptly
when I took the code out the first time ... oops). I don't want to lose the
progress we've made against this ticket, or the fact that there's still work
12:35 AM, Pieter van de Bruggen wrote:
> > This feature (and the corresponding tests) were causing intermittent
> > failures which we were unable to trace. We will reintroduce this
> > behavior when we can do so without test fragility.
>
> This is probably the most essential
This feature (and the corresponding tests) were causing intermittent
failures which we were unable to trace. We will reintroduce this
behavior when we can do so without test fragility.
Reviewed-By: Matt Robinson
Signed-off-by: Pieter van de Bruggen
---
Local-branch: tickets/2.7.x/1886
lib
The `node clean` code has introduced a systematic change in
state which is not uniformly protected against by the tests.
As these order dependent failures arise, we should refactor
the tests to be more robust.
Reviewed-By: Matt Robinson
Signed-off-by: Pieter van de Bruggen
---
Local-branch
indirections we
already offer read access for the yaml, this changeset adds
the destroy handler which only removes the yaml file for
a request. This can be used to remove cached entries.
This work is based on the initial work of Brice Figureau
Signed-off-by: Pieter van de Bruggen
---
Local
This includes various style changes, and assorted fixes to testing.
Paired-With: Matt Robinson
Signed-off-by: Pieter van de Bruggen
---
Local-branch: feature/2.7.x/1886
lib/puppet/face/ca.rb | 30 +++---
lib/puppet/face/node/clean.rb | 111
Sounds right to me. +1
On Thu, Jul 28, 2011 at 11:24 AM, Josh Cooper wrote:
> On Mar 18, 12:20 pm, Markus Roberts wrote:
> > On Fri, Mar 18, 2011 at 12:07 PM, Jay Flowers
> wrote:
> > > I finally got some more time to work on this. I ended up getting
> RubyMine
> > > setup and configured for
By default, the SSL-related faces should all render a strings,
not with `Object#inspect`.
Reviewed-By: Daniel Pittman
Signed-off-by: Pieter van de Bruggen
---
Local-branch: tickets/2.7.x/7293
lib/puppet/face/certificate.rb |4 ++--
lib/puppet/face/certificate_request.rb
The additional quotation marks frustrate certain syntax highlighters,
and are completely unnecessary for their use.
Reviewed-By: Daniel Pittman
Signed-off-by: Pieter van de Bruggen
---
Local-branch: tickets/2.7.x/7293
lib/puppet/face/certificate_request.rb | 10 +-
lib/puppet
Signed-off-by: Pieter van de Bruggen
---
Local-branch: tickets/2.7.x/7266
lib/puppet/application/certificate.rb |5 -
lib/puppet/face/certificate.rb| 22 +-
spec/unit/face/certificate_spec.rb| 20
3 files changed, 29 insertions
wrote:
> On Fri, Jul 22, 2011 at 14:30, Pieter van de Bruggen
> wrote:
> > Reviewed-By: Mike Stahnke
> >
> > Signed-off-by: Pieter van de Bruggen
> > ---
> > Local-branch: tickets/1.2rc/8589
> > app/views/reports/_resource_statuses
Reviewed-By: Mike Stahnke
Signed-off-by: Pieter van de Bruggen
---
Local-branch: tickets/1.2rc/8589
app/views/reports/_resource_statuses.html.haml |2 +-
lib/core_callbacks.rb |6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/app/views
orts alone.
Reviewed-By: Daniel Pittman
Signed-off-by: Pieter van de Bruggen
---
Local-branch: tickets/1.2rc/8544
app/views/reports/show.html.haml |2 +-
public/images/icons/bullet_red.png | Bin 0 -> 1068 bytes
public/stylesheets/tables.css |5 +
3 files changed, 6 ins
On Wed, Jul 13, 2011 at 12:32 PM, Michael Stahnke wrote:
> >
> > The only suggestion I have is to maybe link to
> > "
> https://github.com/puppetlabs/puppet-dashboard/blob/v#{APP_VERSION}/README.markdown
> "
> > so you will get the documentation for your version of Dashboard.
> >
> >
> As we move
fairly minimal.
Reviewed-By: Matt Robbinson
Signed-off-by: Pieter van de Bruggen
---
Local-branch: tickets/master/8121
config/initializers/sass.rb | 13 +
1 files changed, 13 insertions(+), 0 deletions(-)
create mode 100644 config/initializers/sass.rb
diff --git a/config/initial
Reviewed-By: Randall Hansen
Signed-off-by: Pieter van de Bruggen
---
Local-branch: tickets/master/8196
app/views/layouts/application.html.haml|1 +
app/views/shared/_node_manager_sidebar.html.haml |2 ++
.../_node_manager_sidebar_for_type.html.haml |1 +
3 files
Paired-With: Randall Hansen
Signed-off-by: Pieter van de Bruggen
---
Local-branch: tickets/master/8196
public/stylesheets/layout.css |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/public/stylesheets/layout.css b/public/stylesheets/layout.css
index ac134c7..90159df
This enables partials to add classes to the body definition, which
makes certain styling operations simpler.
Reviewed-By: Randall Hansen
Signed-off-by: Pieter van de Bruggen
---
Local-branch: tickets/master/8196
app/helpers/application_helper.rb |4
app/views/layouts
This brings us closer to the desired presentation for the data, without
changing the markup in unsightly ways. This has been tested against Chrome,
Safari 5.0.4, and Firefox 4.
Reviewed-By: Randall Hansen
Signed-off-by: Pieter van de Bruggen
---
Local-branch: poc/master/align-node-counts
Given that we've got Rails, we might as well make use of some of the tools
they give us. Especially given that they do pretty much the same thing we
just wrote.
Reviewed-By: Nick Lewis
Signed-off-by: Pieter van de Bruggen
---
Local-branch: tickets/next/7537
app/views/reports/_report.html
This change implements a simple algorithm to convert "registry names" into
human readable names, allowing plugins to augment the :report_view_widgets
without unnecessary fatalities.
Reviewed-By: Daniel Pittman
Signed-off-by: Pieter van de Bruggen
---
Local-branch: tickets/next/7537
replaces the index page with a more informative message when
Dashboard is not aware of any nodes.
Reviewed-By: Jacob Helwig
Signed-off-by: Pieter van de Bruggen
---
Local-branch: tickets/next/7560
app/views/pages/home.html.haml| 30 +-
spec/helpers
Paired-With: Matt Robinson
Signed-off-by: Pieter van de Bruggen
---
Local-branch: tickets/2.7.x/7507
spec/integration/util/file_locking_spec.rb |2 +-
spec/unit/indirector/facts/couch_spec.rb |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/spec/integration/util
A number of lines in app/models/node.rb were long enough to make working with
the source difficult; this change brings every line under 100 columns.
Paired-With: Jacob Helwig
Signed-off-by: Pieter van de Bruggen
---
Local-branch: tickets/next/6991
app/models/node.rb | 56
-off-by: Pieter van de Bruggen
---
Local-branch: tickets/next/6991
app/controllers/pages_controller.rb | 17 ++--
app/helpers/pages_helper.rb |3 +
app/views/pages/_node_summary_row.haml| 13 ++
app/views/pages/home.html.haml| 38 ---
From: Nick Lewis
A node is pending if it a) has noop events, and b) is not failed.
Paired-With: Daniel Pittman
Signed-off-by: Pieter van de Bruggen
---
Local-branch: tickets/next/6991
app/models/node.rb |7 +++
spec/models/node_spec.rb | 24
2 files
scopes bear only passing resemblance
to the existing concepts with those names, we are moving towards these
semantics overall.
Paired-With: Nick Lewis
Signed-off-by: Pieter van de Bruggen
---
Local-branch: tickets/next/6991
app/models/node.rb | 35 ++
spec/f
By default, it is useful to permit an individual node to query
information about itself, and there is no good reason to reject
this by default.
Paired-With: Nick Lewis
Signed-off-by: Pieter van de Bruggen
---
Local-branch: tickets/2.7.x/7179
conf/auth.conf|5
execute in the opposite order.
Reviewed-By: Daniel Pittman
Signed-off-by: Pieter van de Bruggen
---
Local-branch: tickets/2.7.x/7289
lib/puppet/interface.rb|2 +
lib/puppet/interface/action.rb | 14 +-
lib/puppet/interface/option_manager.rb
Good point on the naming convention. Must've slipped my mind -- I'll have a
patch out for it shortly.
On Mon, Apr 25, 2011 at 12:32 PM, Randall Hansen wrote:
> On Mon, Apr 25, 2011 at 12:20 PM, Pieter van de Bruggen
> wrote:
>
> > + def inherit_options_from(action
ife?
>
> --
> http://puppetlabs.com/ | +1-615-594-8199 | @puppetmasterd
>
> On Apr 25, 2011, at 8:20 PM, Pieter van de Bruggen
> wrote:
>
> > Reviewed-By: Matt Robinson
> >
> > Signed-off-by: Pieter van de Bruggen
> > ---
> > Local-branch: ticket
Reviewed-By: Matt Robinson
Signed-off-by: Pieter van de Bruggen
---
Local-branch: tickets/2.7.next/7220
lib/puppet/interface/action.rb |5 +++
lib/puppet/interface/action_builder.rb | 10 +
spec/unit/interface/action_builder_spec.rb | 55
Paired-With: Randall Hansen
Signed-off-by: Pieter van de Bruggen
---
Local-branch: tickets/next/6989
app/views/reports/_report.html.haml |5 -
public/javascripts/application.js |3 +++
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/app/views/reports
Paired-With: Randall Hansen
Signed-off-by: Pieter van de Bruggen
---
Local-branch: tickets/next/6989
app/views/reports/_report.html.haml |7 ++---
public/javascripts/application.js| 12 -
public/javascripts/jquery-tabify.min.js |1 -
public/stylesheets
Paired-With: Randall Hansen
Signed-off-by: Pieter van de Bruggen
---
Local-branch: tickets/next/6989
app/views/reports/_report.html.haml |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/app/views/reports/_report.html.haml
b/app/views/reports/_report.html.haml
Paired-With: Randall Hansen
Signed-off-by: Pieter van de Bruggen
---
Local-branch: tickets/next/6989
app/views/reports/_log.html.haml | 29 +++
app/views/reports/_metrics.html.haml |2 +-
app/views/reports/_resource_statuses.html.haml |7
Paired-With: Randall Hansen
Signed-off-by: Pieter van de Bruggen
---
Local-branch: tickets/next/6989
app/views/layouts/application.html.haml |2 +-
app/views/reports/_report.html.haml | 13 -
lib/registry.rb |2 ++
public/javascripts/jquery
Paired-With: Randall Hansen
Signed-off-by: Pieter van de Bruggen
---
Local-branch: tickets/next/6989
app/views/layouts/application.html.haml|2 +-
app/views/reports/_resource_statuses.html.haml |9 +-
public/javascripts/application.js | 11 +-
public/javascripts
Signed-off-by: Pieter van de Bruggen
---
Local-branch: tickets/next/6989
app/views/reports/_report.html.haml |8 +---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/app/views/reports/_report.html.haml
b/app/views/reports/_report.html.haml
index 6455aa4..910de8e 100644
Reviewed-By: Jacob Helwig
Signed-off-by: Pieter van de Bruggen
---
Local-branch: tickets/next/6989
app/views/reports/_report.html.haml | 10 +-
lib/registry.rb | 10 ++
2 files changed, 11 insertions(+), 9 deletions(-)
diff --git a/app/views/reports
Signed-off-by: Pieter van de Bruggen
---
Local-branch: tickets/next/6989
public/stylesheets/application.css |8 +++-
public/stylesheets/sass/application.scss |5 ++---
2 files changed, 5 insertions(+), 8 deletions(-)
diff --git a/public/stylesheets/application.css
b/public
52 matches
Mail list logo