Re: [Puppet-dev] Ruby DSL deprecated completely?

2013-02-26 Thread Pieter van de Bruggen
> What I see in these examples is a need for a way of manipulating the > data (collect, > select, reject, etc.). Once the data is manipulated correctly, then > create_resources and title expansion can take over. +1 In my own (small) use of Puppet lately, I've keenly felt the lack of data transfo

Re: [Puppet-dev] Bundling minitar for puppet module face

2012-08-06 Thread Pieter van de Bruggen
On Mon, Aug 6, 2012 at 2:26 PM, Andy Parker wrote: > On Mon, Aug 6, 2012 at 1:30 PM, Pieter van de Bruggen > wrote: > > On Mon, Aug 6, 2012 at 12:45 PM, Andy Parker > wrote: > >> > >> On Mon, Aug 6, 2012 at 11:57 AM, Ken Barber wrote: > >> >>

Re: [Puppet-dev] Bundling minitar for puppet module face

2012-08-06 Thread Pieter van de Bruggen
On Mon, Aug 6, 2012 at 12:45 PM, Andy Parker wrote: > On Mon, Aug 6, 2012 at 11:57 AM, Ken Barber wrote: > >> the thing I need to do better in mco is write a package maintainers > >> guide to make it clear to people how to undo the bundling as there's > >> been some mistakes made where people ju

Re: [Puppet-dev] Community input requested on potential `unless_uid` addition to user resources

2012-05-16 Thread Pieter van de Bruggen
On Wed, May 16, 2012 at 2:22 PM, Luke Kanies wrote: > On May 16, 2012, at 2:00 PM, Daniel Pittman wrote: > > > On Wed, May 16, 2012 at 1:51 PM, Deepak Giridharagopal > > wrote: > >> On Wed, May 16, 2012 at 2:07 PM, Chris Price > wrote: > >>> > >>> p.s., if we do go down this path it would be in

Re: [Puppet-dev] Community input requested on potential `unless_uid` addition to user resources

2012-05-16 Thread Pieter van de Bruggen
. > > > > > > Not to say that the benefits might not be worthwhile... just seems > > like a big leap to take. > > > > > > > > > > On Wed, May 16, 2012 at 12:58 PM, Luke Kanies < l...@puppetlabs.com > > > wrote: > > > > &

Re: [Puppet-dev] Community input requested on potential `unless_uid` addition to user resources

2012-05-16 Thread Pieter van de Bruggen
On Tue, May 15, 2012 at 9:56 AM, Jeff Weiss wrote: > Puppet Community, > > We need your help. > > We have a terrific contribution from Bart ten Brinke that would add an > `unless_uid` parameter to user resources. The pull is request is 628 ( > https://github.com/puppetlabs/puppet/pull/628). > > W

Re: [Puppet-dev] Changes to variable scoping in Telly

2012-04-17 Thread Pieter van de Bruggen
Question: If a node declaration masks a top-scope variable, is there ever a good reason to refer to the old value? On Tue, Apr 17, 2012 at 9:05 AM, Andrew Parker wrote: > > On Apr 17, 2012, at 2:03 AM, R.I.Pienaar wrote: > > > I like the general idea for sure, but I think it still leaves way too

Re: [Puppet-dev] Text Console Colors

2012-04-04 Thread Pieter van de Bruggen
On Wed, Apr 4, 2012 at 1:58 PM, Ken Barber wrote: > > Invoking Windows' native color support changes the color of the pen at > that > > particular moment, tightly coupling the colorization time with output > time. > > In Facter, this is less of a big deal, since you're effectively > choosing to

Re: [Puppet-dev] Text Console Colors

2012-04-04 Thread Pieter van de Bruggen
ba415872cf1e37900322f2deb763a186598 > >> > >> On Wed, Apr 4, 2012 at 9:59 AM, Ken Barber wrote: > >>> > >>> I know win32console was offering similar functionality for ANSI escape > >>> codes for Windows - but I think last time we looked win32con

Re: [Puppet-dev] Text Console Colors

2012-04-04 Thread Pieter van de Bruggen
gt; I know win32console was offering similar functionality for ANSI escape > >> codes for Windows - but I think last time we looked win32console was > >> out of maintenance. Have you found something else since then Josh? > >> > >> On Wed, Apr 4, 2012 at 5:46

Re: [Puppet-dev] Text Console Colors

2012-04-04 Thread Pieter van de Bruggen
>From what I heard yesterday from Josh (and I reserve the right to have mis-understood), Windows gained support for ANSI escapes, meaning we no longer need to special case the `color` setting for Windows. The module that handles colors in core probably doesn't look that different from the module t

Re: [Puppet-dev] [PATCH/puppet 1/1] (Maint.) Disable cleaning of storeconfigs.

2011-08-04 Thread Pieter van de Bruggen
I've gone ahead and updated the ticket with all the additional context I have, including re-opening the ticket (which I should have done promptly when I took the code out the first time ... oops). I don't want to lose the progress we've made against this ticket, or the fact that there's still work

Re: [Puppet-dev] [PATCH/puppet 1/1] (Maint.) Disable cleaning of storeconfigs.

2011-08-04 Thread Pieter van de Bruggen
12:35 AM, Pieter van de Bruggen wrote: > > This feature (and the corresponding tests) were causing intermittent > > failures which we were unable to trace. We will reintroduce this > > behavior when we can do so without test fragility. > > This is probably the most essential

[Puppet-dev] [PATCH/puppet 1/1] (Maint.) Disable cleaning of storeconfigs.

2011-07-28 Thread Pieter van de Bruggen
This feature (and the corresponding tests) were causing intermittent failures which we were unable to trace. We will reintroduce this behavior when we can do so without test fragility. Reviewed-By: Matt Robinson Signed-off-by: Pieter van de Bruggen --- Local-branch: tickets/2.7.x/1886 lib

[Puppet-dev] [PATCH/puppet 1/1] (Maint.) Fix spec failures related to leaking state.

2011-07-28 Thread Pieter van de Bruggen
The `node clean` code has introduced a systematic change in state which is not uniformly protected against by the tests. As these order dependent failures arise, we should refactor the tests to be more robust. Reviewed-By: Matt Robinson Signed-off-by: Pieter van de Bruggen --- Local-branch

[Puppet-dev] [PATCH/puppet 1/2] Fix #1886 - Add node cleanup capability

2011-07-28 Thread Pieter van de Bruggen
indirections we already offer read access for the yaml, this changeset adds the destroy handler which only removes the yaml file for a request. This can be used to remove cached entries. This work is based on the initial work of Brice Figureau Signed-off-by: Pieter van de Bruggen --- Local

[Puppet-dev] [PATCH/puppet 2/2] (#1886) Clean up `node clean` for merge.

2011-07-28 Thread Pieter van de Bruggen
This includes various style changes, and assorted fixes to testing. Paired-With: Matt Robinson Signed-off-by: Pieter van de Bruggen --- Local-branch: feature/2.7.x/1886 lib/puppet/face/ca.rb | 30 +++--- lib/puppet/face/node/clean.rb | 111

Re: [Puppet-dev] Re: Debugging Puppet on Windows

2011-07-28 Thread Pieter van de Bruggen
Sounds right to me. +1 On Thu, Jul 28, 2011 at 11:24 AM, Josh Cooper wrote: > On Mar 18, 12:20 pm, Markus Roberts wrote: > > On Fri, Mar 18, 2011 at 12:07 PM, Jay Flowers > wrote: > > > I finally got some more time to work on this. I ended up getting > RubyMine > > > setup and configured for

[Puppet-dev] [PATCH/puppet 2/2] (#7293) Set default format for SSL-related faces.

2011-07-25 Thread Pieter van de Bruggen
By default, the SSL-related faces should all render a strings, not with `Object#inspect`. Reviewed-By: Daniel Pittman Signed-off-by: Pieter van de Bruggen --- Local-branch: tickets/2.7.x/7293 lib/puppet/face/certificate.rb |4 ++-- lib/puppet/face/certificate_request.rb

[Puppet-dev] [PATCH/puppet 1/2] (Maint.) Unquoting HEREDOCs.

2011-07-25 Thread Pieter van de Bruggen
The additional quotation marks frustrate certain syntax highlighters, and are completely unnecessary for their use. Reviewed-By: Daniel Pittman Signed-off-by: Pieter van de Bruggen --- Local-branch: tickets/2.7.x/7293 lib/puppet/face/certificate_request.rb | 10 +- lib/puppet

[Puppet-dev] [PATCH/puppet 1/1] (#7266) Move Certificate option validation into face.

2011-07-25 Thread Pieter van de Bruggen
Signed-off-by: Pieter van de Bruggen --- Local-branch: tickets/2.7.x/7266 lib/puppet/application/certificate.rb |5 - lib/puppet/face/certificate.rb| 22 +- spec/unit/face/certificate_spec.rb| 20 3 files changed, 29 insertions

Re: [Puppet-dev] [PATCH/puppet-dashboard 1/1] (#8589) Report events are now ordered by name.

2011-07-22 Thread Pieter van de Bruggen
wrote: > On Fri, Jul 22, 2011 at 14:30, Pieter van de Bruggen > wrote: > > Reviewed-By: Mike Stahnke > > > > Signed-off-by: Pieter van de Bruggen > > --- > > Local-branch: tickets/1.2rc/8589 > > app/views/reports/_resource_statuses

[Puppet-dev] [PATCH/puppet-dashboard 1/1] (#8589) Report events are now ordered by name.

2011-07-22 Thread Pieter van de Bruggen
Reviewed-By: Mike Stahnke Signed-off-by: Pieter van de Bruggen --- Local-branch: tickets/1.2rc/8589 app/views/reports/_resource_statuses.html.haml |2 +- lib/core_callbacks.rb |6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/views

[Puppet-dev] [PATCH/puppet-dashboard 1/1] (#8544) Make empty inspected resources "red".

2011-07-22 Thread Pieter van de Bruggen
orts alone. Reviewed-By: Daniel Pittman Signed-off-by: Pieter van de Bruggen --- Local-branch: tickets/1.2rc/8544 app/views/reports/show.html.haml |2 +- public/images/icons/bullet_red.png | Bin 0 -> 1068 bytes public/stylesheets/tables.css |5 + 3 files changed, 6 ins

Re: [Puppet-dev] Review for patch on dashboard

2011-07-13 Thread Pieter van de Bruggen
On Wed, Jul 13, 2011 at 12:32 PM, Michael Stahnke wrote: > > > > The only suggestion I have is to maybe link to > > " > https://github.com/puppetlabs/puppet-dashboard/blob/v#{APP_VERSION}/README.markdown > " > > so you will get the documentation for your version of Dashboard. > > > > > As we move

[Puppet-dev] [PATCH/puppet-dashboard 1/1] (#8121) Properly generate CSS from SASS in production.

2011-07-06 Thread Pieter van de Bruggen
fairly minimal. Reviewed-By: Matt Robbinson Signed-off-by: Pieter van de Bruggen --- Local-branch: tickets/master/8121 config/initializers/sass.rb | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) create mode 100644 config/initializers/sass.rb diff --git a/config/initial

[Puppet-dev] [PATCH/puppet-dashboard 2/3] (#8196) Add a body class describing sidebar state.

2011-07-01 Thread Pieter van de Bruggen
Reviewed-By: Randall Hansen Signed-off-by: Pieter van de Bruggen --- Local-branch: tickets/master/8196 app/views/layouts/application.html.haml|1 + app/views/shared/_node_manager_sidebar.html.haml |2 ++ .../_node_manager_sidebar_for_type.html.haml |1 + 3 files

[Puppet-dev] [PATCH/puppet-dashboard 3/3] (#8196) Adjust content width based on body classes.

2011-07-01 Thread Pieter van de Bruggen
Paired-With: Randall Hansen Signed-off-by: Pieter van de Bruggen --- Local-branch: tickets/master/8196 public/stylesheets/layout.css |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/public/stylesheets/layout.css b/public/stylesheets/layout.css index ac134c7..90159df

[Puppet-dev] [PATCH/puppet-dashboard 1/3] (#8196) Clean up body class manipulation.

2011-07-01 Thread Pieter van de Bruggen
This enables partials to add classes to the body definition, which makes certain styling operations simpler. Reviewed-By: Randall Hansen Signed-off-by: Pieter van de Bruggen --- Local-branch: tickets/master/8196 app/helpers/application_helper.rb |4 app/views/layouts

[Puppet-dev] [PATCH/puppet-dashboard 1/1] Aligning node category names in sidebar.

2011-06-20 Thread Pieter van de Bruggen
This brings us closer to the desired presentation for the data, without changing the markup in unsightly ways. This has been tested against Chrome, Safari 5.0.4, and Firefox 4. Reviewed-By: Randall Hansen Signed-off-by: Pieter van de Bruggen --- Local-branch: poc/master/align-node-counts

[Puppet-dev] [PATCH/puppet-dashboard 1/1] (#7537) Use #titleize for report tab names.

2011-05-19 Thread Pieter van de Bruggen
Given that we've got Rails, we might as well make use of some of the tools they give us. Especially given that they do pretty much the same thing we just wrote. Reviewed-By: Nick Lewis Signed-off-by: Pieter van de Bruggen --- Local-branch: tickets/next/7537 app/views/reports/_report.html

[Puppet-dev] [PATCH/puppet-dashboard 1/1] (#7537) Add reasonable defaults for report tab names.

2011-05-19 Thread Pieter van de Bruggen
This change implements a simple algorithm to convert "registry names" into human readable names, allowing plugins to augment the :report_view_widgets without unnecessary fatalities. Reviewed-By: Daniel Pittman Signed-off-by: Pieter van de Bruggen --- Local-branch: tickets/next/7537

[Puppet-dev] [PATCH/puppet-dashboard 1/1] (#7560) Clean up the Dashboard index for 0 nodes.

2011-05-19 Thread Pieter van de Bruggen
replaces the index page with a more informative message when Dashboard is not aware of any nodes. Reviewed-By: Jacob Helwig Signed-off-by: Pieter van de Bruggen --- Local-branch: tickets/next/7560 app/views/pages/home.html.haml| 30 +- spec/helpers

[Puppet-dev] [PATCH/puppet 1/1] (#7507) Add more filters for Ruby 1.9 spec failures

2011-05-17 Thread Pieter van de Bruggen
Paired-With: Matt Robinson Signed-off-by: Pieter van de Bruggen --- Local-branch: tickets/2.7.x/7507 spec/integration/util/file_locking_spec.rb |2 +- spec/unit/indirector/facts/couch_spec.rb |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/spec/integration/util

[Puppet-dev] [PATCH/puppet-dashboard 2/4] (#6991) Cleanup of excessively long lines.

2011-05-12 Thread Pieter van de Bruggen
A number of lines in app/models/node.rb were long enough to make working with the source difficult; this change brings every line under 100 columns. Paired-With: Jacob Helwig Signed-off-by: Pieter van de Bruggen --- Local-branch: tickets/next/6991 app/models/node.rb | 56

[Puppet-dev] [PATCH/puppet-dashboard 4/4] (#6991) Add the Node Status summary graph.

2011-05-12 Thread Pieter van de Bruggen
-off-by: Pieter van de Bruggen --- Local-branch: tickets/next/6991 app/controllers/pages_controller.rb | 17 ++-- app/helpers/pages_helper.rb |3 + app/views/pages/_node_summary_row.haml| 13 ++ app/views/pages/home.html.haml| 38 ---

[Puppet-dev] [PATCH/puppet-dashboard 1/4] (#6537) Add a pending scope to nodes

2011-05-12 Thread Pieter van de Bruggen
From: Nick Lewis A node is pending if it a) has noop events, and b) is not failed. Paired-With: Daniel Pittman Signed-off-by: Pieter van de Bruggen --- Local-branch: tickets/next/6991 app/models/node.rb |7 +++ spec/models/node_spec.rb | 24 2 files

[Puppet-dev] [PATCH/puppet-dashboard 3/4] (#6991) Massage Node named scopes.

2011-05-12 Thread Pieter van de Bruggen
scopes bear only passing resemblance to the existing concepts with those names, we are moving towards these semantics overall. Paired-With: Nick Lewis Signed-off-by: Pieter van de Bruggen --- Local-branch: tickets/next/6991 app/models/node.rb | 35 ++ spec/f

[Puppet-dev] [PATCH/puppet 1/1] (#7179) Modify default ACL for /node/.

2011-05-04 Thread Pieter van de Bruggen
By default, it is useful to permit an individual node to query information about itself, and there is no good reason to reject this by default. Paired-With: Nick Lewis Signed-off-by: Pieter van de Bruggen --- Local-branch: tickets/2.7.x/7179 conf/auth.conf|5

[Puppet-dev] [PATCH/puppet 1/1] (#7289) Specify order for option decorations.

2011-04-29 Thread Pieter van de Bruggen
execute in the opposite order. Reviewed-By: Daniel Pittman Signed-off-by: Pieter van de Bruggen --- Local-branch: tickets/2.7.x/7289 lib/puppet/interface.rb|2 + lib/puppet/interface/action.rb | 14 +- lib/puppet/interface/option_manager.rb

Re: [Puppet-dev] [PATCH/puppet 1/1] (#7220) Add the ability to "inherit" options.

2011-04-25 Thread Pieter van de Bruggen
Good point on the naming convention. Must've slipped my mind -- I'll have a patch out for it shortly. On Mon, Apr 25, 2011 at 12:32 PM, Randall Hansen wrote: > On Mon, Apr 25, 2011 at 12:20 PM, Pieter van de Bruggen > wrote: > > > + def inherit_options_from(action

Re: [Puppet-dev] [PATCH/puppet 1/1] (#7220) Add the ability to "inherit" options.

2011-04-25 Thread Pieter van de Bruggen
ife? > > -- > http://puppetlabs.com/ | +1-615-594-8199 | @puppetmasterd > > On Apr 25, 2011, at 8:20 PM, Pieter van de Bruggen > wrote: > > > Reviewed-By: Matt Robinson > > > > Signed-off-by: Pieter van de Bruggen > > --- > > Local-branch: ticket

[Puppet-dev] [PATCH/puppet 1/1] (#7220) Add the ability to "inherit" options.

2011-04-25 Thread Pieter van de Bruggen
Reviewed-By: Matt Robinson Signed-off-by: Pieter van de Bruggen --- Local-branch: tickets/2.7.next/7220 lib/puppet/interface/action.rb |5 +++ lib/puppet/interface/action_builder.rb | 10 + spec/unit/interface/action_builder_spec.rb | 55

[Puppet-dev] [PATCH/puppet-dashboard 2/9] (#6989) Refactor Javascript into application.js

2011-04-20 Thread Pieter van de Bruggen
Paired-With: Randall Hansen Signed-off-by: Pieter van de Bruggen --- Local-branch: tickets/next/6989 app/views/reports/_report.html.haml |5 - public/javascripts/application.js |3 +++ 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/app/views/reports

[Puppet-dev] [PATCH/puppet-dashboard 6/9] (#6989) Add basic styling for tabs.

2011-04-20 Thread Pieter van de Bruggen
Paired-With: Randall Hansen Signed-off-by: Pieter van de Bruggen --- Local-branch: tickets/next/6989 app/views/reports/_report.html.haml |7 ++--- public/javascripts/application.js| 12 - public/javascripts/jquery-tabify.min.js |1 - public/stylesheets

[Puppet-dev] [PATCH/puppet-dashboard 3/9] (#6989) Refactor user-facing names.

2011-04-20 Thread Pieter van de Bruggen
Paired-With: Randall Hansen Signed-off-by: Pieter van de Bruggen --- Local-branch: tickets/next/6989 app/views/reports/_report.html.haml |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/app/views/reports/_report.html.haml b/app/views/reports/_report.html.haml

[Puppet-dev] [PATCH/puppet-dashboard 9/9] (#6989) Improve messages for empty tabs.

2011-04-20 Thread Pieter van de Bruggen
Paired-With: Randall Hansen Signed-off-by: Pieter van de Bruggen --- Local-branch: tickets/next/6989 app/views/reports/_log.html.haml | 29 +++ app/views/reports/_metrics.html.haml |2 +- app/views/reports/_resource_statuses.html.haml |7

[Puppet-dev] [PATCH/puppet-dashboard 1/9] (#6989) Add "tabs" for report sections.

2011-04-20 Thread Pieter van de Bruggen
Paired-With: Randall Hansen Signed-off-by: Pieter van de Bruggen --- Local-branch: tickets/next/6989 app/views/layouts/application.html.haml |2 +- app/views/reports/_report.html.haml | 13 - lib/registry.rb |2 ++ public/javascripts/jquery

[Puppet-dev] [PATCH/puppet-dashboard 8/9] (#6989) Squash bugs in IE{7,8}.

2011-04-20 Thread Pieter van de Bruggen
Paired-With: Randall Hansen Signed-off-by: Pieter van de Bruggen --- Local-branch: tickets/next/6989 app/views/layouts/application.html.haml|2 +- app/views/reports/_resource_statuses.html.haml |9 +- public/javascripts/application.js | 11 +- public/javascripts

[Puppet-dev] [PATCH/puppet-dashboard 5/9] (#6989) Remove a call to Registry.each_callback.

2011-04-20 Thread Pieter van de Bruggen
Signed-off-by: Pieter van de Bruggen --- Local-branch: tickets/next/6989 app/views/reports/_report.html.haml |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/app/views/reports/_report.html.haml b/app/views/reports/_report.html.haml index 6455aa4..910de8e 100644

[Puppet-dev] [PATCH/puppet-dashboard 4/9] (#6989) Remove ugly #name hack.

2011-04-20 Thread Pieter van de Bruggen
Reviewed-By: Jacob Helwig Signed-off-by: Pieter van de Bruggen --- Local-branch: tickets/next/6989 app/views/reports/_report.html.haml | 10 +- lib/registry.rb | 10 ++ 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/app/views/reports

[Puppet-dev] [PATCH/puppet-dashboard 7/9] (#6989) Fix font rendering in Firefox.

2011-04-20 Thread Pieter van de Bruggen
Signed-off-by: Pieter van de Bruggen --- Local-branch: tickets/next/6989 public/stylesheets/application.css |8 +++- public/stylesheets/sass/application.scss |5 ++--- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/public/stylesheets/application.css b/public