[Puppet-dev] [PATCH/facter 1/1] (#6792) Added osfamily fact.

2011-06-10 Thread Adrien Thebo
Added osfamily fact to determine if a given operating system is a derivative of a common operating system. Signed-off-by: Adrien Thebo --- Local-branch: ticket/master/6792 lib/facter/osfamily.rb | 27 +++ spec/unit/osfamily_spec.rb | 32 +++

Re: [Puppet-dev] [PATCH/facter 1/1] (#6792) Added osfamily fact.

2011-06-09 Thread Adrien Thebo
I added suse support, but I'm going to hold of on resending the patches for a little while. It was discussed that adding windows support would be good, and I should add that code before sending yet another copy of the patches to the dev list. On Jun 9, 2011, at 2:03 PM, Michael Knox wrote: > +1

Re: [Puppet-dev] [PATCH/facter 1/1] (#6792) Added osfamily fact.

2011-06-09 Thread Michael Knox
+1, To support SLES/SLED/OpenSuSE ... +elsif FileTest.exists?("/etc/SuSE-version") + "suse" Cheers Mike On 9/06/11 6:43 AM, Adrien Thebo wrote: Added osfamily fact to determine if a given operating system is a derivative of a common operating system. Signed-off-by: Adrien Thebo --- L

[Puppet-dev] [PATCH/facter 1/1] (#6792) Added osfamily fact.

2011-06-09 Thread Adrien Thebo
Added osfamily fact to determine if a given operating system is a derivative of a common operating system. Signed-off-by: Adrien Thebo --- Local-branch: ticket/master/6792 lib/facter/osfamily.rb | 24 spec/unit/osfamily_spec.rb | 26 ++ 2

Re: [Puppet-dev] [PATCH/facter 1/1] (#6792) Added osfamily fact.

2011-06-09 Thread Jacob Helwig
On Thu, 09 Jun 2011 09:20:36 -0700, Dan Bode wrote: > > On Wed, Jun 8, 2011 at 1:43 PM, Adrien Thebo wrote: > > > Added osfamily fact to determine if a given operating system is a > > derivative of a common operating system. > > > > Huge +1 > So, Adrien. Where are the tests? ;P > > > Signe

Re: [Puppet-dev] [PATCH/facter 1/1] (#6792) Added osfamily fact.

2011-06-09 Thread Dan Bode
On Thu, Jun 9, 2011 at 9:41 AM, markus wrote: > > > > > > > Huge +1 > unmeasurable +1i > > > > > > > Because you've reviewed it, or because you think it's a good idea? > > > > One convention that works (for me at least) is to use complex numbers > where the real part is for the actual code an

Re: [Puppet-dev] [PATCH/facter 1/1] (#6792) Added osfamily fact.

2011-06-09 Thread markus
> > > > Huge +1 > > > > Because you've reviewed it, or because you think it's a good idea? > One convention that works (for me at least) is to use complex numbers where the real part is for the actual code and the imaginary part is for the idea. Thus (+1+1i) means "Oh yeah, we need this and

Re: [Puppet-dev] [PATCH/facter 1/1] (#6792) Added osfamily fact.

2011-06-09 Thread Jacob Helwig
On Thu, 09 Jun 2011 09:20:36 -0700, Dan Bode wrote: > > Huge +1 > Because you've reviewed it, or because you think it's a good idea? -- Jacob Helwig signature.asc Description: Digital signature

Re: [Puppet-dev] [PATCH/facter 1/1] (#6792) Added osfamily fact.

2011-06-09 Thread Dan Bode
On Wed, Jun 8, 2011 at 1:43 PM, Adrien Thebo wrote: > Added osfamily fact to determine if a given operating system is a > derivative of a common operating system. > Huge +1 > Signed-off-by: Adrien Thebo > --- > Local-branch: ticket/master/6792 > lib/facter/osfamily.rb | 24

[Puppet-dev] [PATCH/facter 1/1] (#6792) Added osfamily fact.

2011-06-08 Thread Adrien Thebo
Added osfamily fact to determine if a given operating system is a derivative of a common operating system. Signed-off-by: Adrien Thebo --- Local-branch: ticket/master/6792 lib/facter/osfamily.rb | 24 1 files changed, 24 insertions(+), 0 deletions(-) create mode 10064