Re: [Puppet-dev] [PATCH/facter 1/1] Fixed #5485 - Removed trailing line for selinux_mode fact

2011-03-07 Thread James Turnbull
Paul Nasrat wrote: > On 7 March 2011 09:25, James Turnbull wrote: >> Signed-off-by: James Turnbull > > > This fact probably could do with a unittest - there is selinux_spec.rb > already and you should be able to add the missing test as you are > touching it. Sure. > > Perhaps use Resolution:

Re: [Puppet-dev] [PATCH/facter 1/1] Fixed #5485 - Removed trailing line for selinux_mode fact

2011-03-07 Thread Paul Nasrat
On 7 March 2011 09:25, James Turnbull wrote: > > Signed-off-by: James Turnbull This fact probably could do with a unittest - there is selinux_spec.rb already and you should be able to add the missing test as you are touching it. Perhaps use Resolution::Exec rather than %x{} We also should enf

[Puppet-dev] [PATCH/facter 1/1] Fixed #5485 - Removed trailing line for selinux_mode fact

2011-03-07 Thread James Turnbull
Signed-off-by: James Turnbull --- Local-branch: tickets/master/5485 lib/facter/selinux.rb |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/facter/selinux.rb b/lib/facter/selinux.rb index 0e9637d..d312b3b 100644 --- a/lib/facter/selinux.rb +++ b/lib/facter/selinux