Re: [Puppet-dev] Autorequiring parent directories to the home directory in user resources

2015-03-04 Thread Trevor Vaughan
If it were of surpassing importance to me that all my tools were designed and behaved exactly exactly as I liked, then I would have no choice but to write them myself. Although I can be impassioned, in the end, I'm a lot more pragmatic than that. This should be engraved in stone

Re: [Puppet-dev] Autorequiring parent directories to the home directory in user resources

2015-03-04 Thread John Bollinger
On Tuesday, March 3, 2015 at 4:34:43 PM UTC-6, Stefan Schulte wrote: I am not saying that the current behaviour is correct/better or that your argument is invalid (you have a good point IMHO). I just wanted to point out that it is implemented for quite a while now and personally I am not

Re: [Puppet-dev] Autorequiring parent directories to the home directory in user resources

2015-03-04 Thread Eric Sorenson
I haven't followed this discussion super closely, so I can't weigh in on the merits. But I wanted to compliment and thank everyone involved (especially John) for keeping such a temperate and constructive tone throughout. --eric0 On Mar 4, 2015, at 1:25 PM, Trevor Vaughan

Re: [Puppet-dev] Autorequiring parent directories to the home directory in user resources

2015-03-03 Thread 'Stefan Schulte' via Puppet Developers
Hello On 02.03.2015 22:21, John Bollinger wrote: *Disadvantages to symlinks autorequiring their targets*: 1. Many unneeded resource relationships are generated. 2. Under some circumstances, Puppet will needlessly create relationship cycles. 3. Although the autorequirement could be

Re: [Puppet-dev] Autorequiring parent directories to the home directory in user resources

2015-03-03 Thread John Bollinger
On Tuesday, March 3, 2015 at 3:55:44 AM UTC-6, Felix Frank wrote: On 03/02/2015 10:55 PM, Trevor Vaughan wrote: So, can I vote for adding '/validate_link = :boolean/' as a parameter to File to effect the state above? (/Is anyone else happy with this?/) Yes, this does appeal to me. I

Re: [Puppet-dev] Autorequiring parent directories to the home directory in user resources

2015-03-03 Thread John Bollinger
On Tuesday, March 3, 2015 at 1:35:28 PM UTC-6, Stefan Schulte wrote: Hello On 02.03.2015 22:21, John Bollinger wrote: *Disadvantages to symlinks autorequiring their targets*: 1. Many unneeded resource relationships are generated. 2. Under some circumstances, Puppet will

Re: [Puppet-dev] Autorequiring parent directories to the home directory in user resources

2015-03-03 Thread 'Stefan Schulte' via Puppet Developers
On 03.03.2015 21:31, John Bollinger wrote: On Tuesday, March 3, 2015 at 1:35:28 PM UTC-6, Stefan Schulte wrote: [..] maybe I am missing something here but a) a resource relationship that is autorequired can be overwritten with explicit requires (at least last time I

Re: [Puppet-dev] Autorequiring parent directories to the home directory in user resources

2015-03-03 Thread Trevor Vaughan
Created with links and details as https://tickets.puppetlabs.com/browse/PUP-4071. Made the :autorequires portion dependent on a risk assessment. The warnings would point out what need to be fixed but may make for a lot of code cruft. Thanks, Trevor On Tue, Mar 3, 2015 at 4:55 AM, Felix Frank

Re: [Puppet-dev] Autorequiring parent directories to the home directory in user resources

2015-03-03 Thread Felix Frank
On 03/02/2015 10:55 PM, Trevor Vaughan wrote: So, can I vote for adding '/validate_link = :boolean/' as a parameter to File to effect the state above? (/Is anyone else happy with this?/) Yes, this does appeal to me. I could even be persuaded that this could benignly default to true. -- You

Re: [Puppet-dev] Autorequiring parent directories to the home directory in user resources

2015-03-02 Thread John Bollinger
On Monday, March 2, 2015 at 1:50:08 PM UTC-6, Trevor Vaughan wrote: Well, there's my concrete example of where dangling symlinks are used in the wild Ok, back to autorequires. I'm still not convinced that it's beneficial to not have it in place. I am unlikely to persuade you if I

Re: [Puppet-dev] Autorequiring parent directories to the home directory in user resources

2015-03-02 Thread Trevor Vaughan
Honestly, it seems like the majority is to not have this, so I'm happy to drop it if that's the consensus. I just keep running into the usual situation where I don't want dangling links. For the other items: if the catalog *does* fail on account of the link's target not being managed soon

Re: [Puppet-dev] Autorequiring parent directories to the home directory in user resources

2015-03-02 Thread Trevor Vaughan
HmmOk, how about this: 1) Dangling symlinks are allowed 2) Warnings on dangling symlinks are the default (because you *probably* don't want them) 3) Setting :force = true, disables the warning message (in theory, you would only do this after seeing the message) 3a) For a less destructive

Re: [Puppet-dev] Autorequiring parent directories to the home directory in user resources

2015-03-02 Thread John Bollinger
On Friday, February 27, 2015 at 2:51:03 PM UTC-6, Trevor Vaughan wrote: Ok, you certainly have a working counter example, but I feel that it *should* actually fail and that this is a bug. [...] I would like to propose that symlinks should naturally (i.e. autorequire*) come *after*

Re: [Puppet-dev] Autorequiring parent directories to the home directory in user resources

2015-03-02 Thread Reid Vandewiele
On Monday, March 2, 2015 at 7:21:55 AM UTC-8, Trevor Vaughan wrote: HmmOk, how about this: 1) Dangling symlinks are allowed 2) Warnings on dangling symlinks are the default (because you *probably* don't want them) 3) Setting :force = true, disables the warning message (in theory, you

Re: [Puppet-dev] Autorequiring parent directories to the home directory in user resources

2015-03-02 Thread Trevor Vaughan
Well, there's my concrete example of where dangling symlinks are used in the wild Ok, back to autorequires. I'm still not convinced that it's beneficial to not have it in place. I suppose that I could do some hack-fu like I did with 'group' so that people that want it could patch it into

Re: [Puppet-dev] Autorequiring parent directories to the home directory in user resources

2015-03-01 Thread Felix Frank
On 02/27/2015 06:22 PM, Trevor Vaughan wrote: I still can't come up with a scenario where this would ever be an issue. Auto-creating a resource (especially a directory) is a greater level of spooky action at a distance since it's actually *doing* something to your system and I'm very against

Re: [Puppet-dev] Autorequiring parent directories to the home directory in user resources

2015-02-27 Thread Trevor Vaughan
I still can't come up with a scenario where this would ever be an issue. Auto-creating a resource (especially a directory) is a greater level of spooky action at a distance since it's actually *doing* something to your system and I'm very against that when possible. (It also bloats your catalog,

Re: [Puppet-dev] Autorequiring parent directories to the home directory in user resources

2015-02-27 Thread Felix Frank
Hi, thanks for building this. I must admit, I find the prospect a little frightening. The logic that picks the autorequire target makes sense, but I see quite some potential for surprising the user with weird dependency cycles. What I'd like to see instead would be for the user type to actually

Re: [Puppet-dev] Autorequiring parent directories to the home directory in user resources

2015-02-27 Thread Trevor Vaughan
Ok, you certainly have a working counter example, but I feel that it *should* actually fail and that this is a bug. The expected state of the system is: 1) Make a FIFO file at /other/path 2) Set permissions on /other/path 3) Link /path/link to /other/path I would like to propose that symlinks

Re: [Puppet-dev] Autorequiring parent directories to the home directory in user resources

2015-02-27 Thread John Bollinger
On Thursday, February 26, 2015 at 2:28:22 PM UTC-6, David Schmitt wrote: On 2015-02-26 20:31, John Bollinger wrote: Symbolic links do _not_ have the same kind of relationship with their targets. A link can be managed entirely independently of its target, therefore Puppet should

Re: [Puppet-dev] Autorequiring parent directories to the home directory in user resources

2015-02-26 Thread David Schmitt
On 2015-02-26 20:31, John Bollinger wrote: On Wednesday, February 25, 2015 at 6:06:33 PM UTC-6, Trevor Vaughan wrote: I think I filed a bug about this a while back. +1 for autorequiring targets +1 from me too. Slightly conditional on the discussion below. I'm inclined to disagree.

Re: [Puppet-dev] Autorequiring parent directories to the home directory in user resources

2015-02-26 Thread John Bollinger
On Wednesday, February 25, 2015 at 6:06:33 PM UTC-6, Trevor Vaughan wrote: I think I filed a bug about this a while back. +1 for autorequiring targets I'm inclined to disagree. Autorequiring should be reserved for cases where the requirement is inherent in the resource's nature. Files'

[Puppet-dev] Autorequiring parent directories to the home directory in user resources

2015-02-25 Thread Raphaël Pinson
Hello, As per Kylo's comment in PR for PUP-4036 https://github.com/puppetlabs/puppet/pull/3645#issuecomment-76032829, I'd like to discuss the possibility and implications of autorequiring parent directories of the home directory for user resources. As stated in the PR, the idea came from

Re: [Puppet-dev] Autorequiring parent directories to the home directory in user resources

2015-02-25 Thread Trevor Vaughan
I think I filed a bug about this a while back. +1 for autorequiring targets Trevor On Wed, Feb 25, 2015 at 6:41 PM, Raphaël Pinson raphael.pin...@camptocamp.com wrote: Hello, As per Kylo's comment in PR for PUP-4036 https://github.com/puppetlabs/puppet/pull/3645#issuecomment-76032829,