Re: [Puppet-dev] Re: The string to number torture never stops

2014-11-05 Thread Joshua Hoblitt
On 11/04/2014 09:09 PM, Joshua Hoblitt wrote: On 11/04/2014 01:04 PM, Andy Parker wrote: It would also provide at lot more confidence that a manifest is 4x safe if it passes `puppet parser validate`. Without that you'd have to worry about conditional expressions

[Puppet-dev] Re: The string to number torture never stops

2014-11-05 Thread Henrik Lindberg
On 2014-05-11 15:45, Joshua Hoblitt wrote: On 11/04/2014 09:09 PM, Joshua Hoblitt wrote: On 11/04/2014 01:04 PM, Andy Parker wrote: It would also provide at lot more confidence that a manifest is 4x safe if it passes `puppet parser validate`. Without that you'd have to worry

[Puppet-dev] Re: The string to number torture never stops

2014-11-04 Thread Henrik Lindberg
On 2014-03-11 18:19, John Bollinger wrote: On Friday, October 31, 2014 8:22:36 PM UTC-5, henrik lindberg wrote: [...] Yet again someone was bit by the automatic String to Numeric conversion that is in Puppet (and also in --parser future). I must confess to a certain dark amusement

Re: [Puppet-dev] Re: The string to number torture never stops

2014-11-04 Thread Joshua Hoblitt
On 11/04/2014 09:46 AM, Henrik Lindberg wrote: It is a bit difficult since operators are overloaded on type. The good part is that if we stop transforming strings to numbers there will be errors for arithmetic expressions. The bad part is that ==, != cannot raise errors (since a string is

Re: [Puppet-dev] Re: The string to number torture never stops

2014-11-04 Thread Trevor Vaughan
Without that you'd have to worry about conditional expressions silently changing their result between 3x and 4x. This x 1000. This is an absolute MUST for the release of 4.0 lest we silently alter every system out there (terrifying). Trevor On Tue, Nov 4, 2014 at 5:28 PM, Joshua Hoblitt

Re: [Puppet-dev] Re: The string to number torture never stops

2014-11-04 Thread Andy Parker
On Tue, Nov 4, 2014 at 9:28 AM, Joshua Hoblitt jhobl...@cpan.org wrote: On 11/04/2014 09:46 AM, Henrik Lindberg wrote: It is a bit difficult since operators are overloaded on type. The good part is that if we stop transforming strings to numbers there will be errors for arithmetic

[Puppet-dev] Re: The string to number torture never stops

2014-11-04 Thread Henrik Lindberg
On 2014-04-11 18:28, Joshua Hoblitt wrote: On 11/04/2014 09:46 AM, Henrik Lindberg wrote: It is a bit difficult since operators are overloaded on type. The good part is that if we stop transforming strings to numbers there will be errors for arithmetic expressions. The bad part is that ==, !=

Re: [Puppet-dev] Re: The string to number torture never stops

2014-11-04 Thread Joshua Hoblitt
On 11/04/2014 01:04 PM, Andy Parker wrote: It would also provide at lot more confidence that a manifest is 4x safe if it passes `puppet parser validate`. Without that you'd have to worry about conditional expressions silently changing their result between 3x

[Puppet-dev] Re: The string to number torture never stops

2014-11-03 Thread John Bollinger
On Friday, October 31, 2014 8:22:36 PM UTC-5, henrik lindberg wrote: [...] Yet again someone was bit by the automatic String to Numeric conversion that is in Puppet (and also in --parser future). I must confess to a certain dark amusement at Puppet struggling with its weak-typing legacy

Re: [Puppet-dev] Re: The string to number torture never stops

2014-11-03 Thread Joshua Hoblitt
On 11/02/2014 05:34 PM, Henrik Lindberg wrote: On 2014-02-11 10:19, Joshua Hoblitt wrote: On 11/01/2014 03:35 AM, David Schmitt wrote: On 2014-11-01 01:22, Henrik Lindberg wrote: The requirement to compare strings and numerals can also be implemented by converting the numeral to a string

[Puppet-dev] Re: The string to number torture never stops

2014-11-02 Thread Henrik Lindberg
On 2014-02-11 10:19, Joshua Hoblitt wrote: On 11/01/2014 03:35 AM, David Schmitt wrote: On 2014-11-01 01:22, Henrik Lindberg wrote: The requirement to compare strings and numerals can also be implemented by converting the numeral to a string (using a canoical non-locale dependent format). This

[Puppet-dev] Re: The string to number torture never stops

2014-11-01 Thread Daniele Sluijters
I was also bitten by this during testing and it made the thought of converting my code to 4.0 daunting. The auto conversion also holds for the current parser, so I don't see how that's making anything different, or daunting. Essentially what it comes down to is input sanitisation. Up