Re: [Puppet-dev] Use of private in module skeleton

2014-11-22 Thread Eric Shamow
+1 here as well. My choice of Puppet has always been based on the default behavior guiding users who don’t know better toward better patterns. In the end they can modify the template if they have unusual needs, but as Felix says, we should set them up to do the right thing. -Eric --  Eric Sh

Re: [Puppet-dev] Use of private in module skeleton

2014-11-22 Thread Wil Cooley
On Nov 22, 2014 4:22 AM, "Gareth Rushgrove" wrote: > I'd love some feedback on this PR, which adds the private function to > the puppet-module-skeleton that a bunch of people use. > > https://github.com/garethr/puppet-module-skeleton/pull/43 ... > And I'm on the fence too. Any thoughts? As a ge

Re: [Puppet-dev] Use of private in module skeleton

2014-11-22 Thread Felix Frank
On 11/22/2014 01:22 PM, Gareth Rushgrove wrote: > Hey all > > I'd love some feedback on this PR, which adds the private function to > the puppet-module-skeleton that a bunch of people use. > > https://github.com/garethr/puppet-module-skeleton/pull/43 > > A few people commented on Twitter and it's p

[Puppet-dev] Use of private in module skeleton

2014-11-22 Thread Gareth Rushgrove
Hey all I'd love some feedback on this PR, which adds the private function to the puppet-module-skeleton that a bunch of people use. https://github.com/garethr/puppet-module-skeleton/pull/43 A few people commented on Twitter and it's prety much 50/50. https://twitter.com/garethr/status/53552687