Re: [Puppet-dev] freebsd ports provider is broken in puppetlabs/puppet HEAD?

2017-05-05 Thread Branan Riley
Unfortunately it looks like there actually isn't a spec test for the ports provider right now - https://github.com/puppetlabs/puppet/tree/master/spec/unit/provider/package If you feel like learning rspec and contributing tests for the provider, that would be awesome. Otherwise I think that this is

Re: [Puppet-dev] freebsd ports provider is broken in puppetlabs/puppet HEAD?

2017-05-05 Thread Michael Smith
You can run rspec. The standard way to do that for Ruby projects is to run `bundle install`, then `bundle exec rspec spec`. You can also rely on the CI systems on pull requests to check your code, but you'll get faster feedback running locally. On Fri, May 5, 2017 at 2:29 AM wrote: > Thanks! Is

Re: [Puppet-dev] freebsd ports provider is broken in puppetlabs/puppet HEAD?

2017-05-05 Thread rafeltstykket
Thanks! Is there a test suite I can run the tree through to make sure my patch is fine before i submit the PR? First change to the puppet code base itself... Richard On Thursday, May 4, 2017 at 4:23:54 PM UTC-7, Branan Purvine-Riley wrote: > > I think it would be fine to put up the PR as-is,

Re: [Puppet-dev] freebsd ports provider is broken in puppetlabs/puppet HEAD?

2017-05-04 Thread Branan Riley
I think it would be fine to put up the PR as-is, since FreeBSD 9 is EOL. Thanks for contributing, Branan Riley Software Engineer, Puppet On Thu, May 4, 2017 at 4:12 PM wrote: > Hello, > > Today I think I found a bug in the ports provider for FreeBSD: > puppet/lib/puppet/provider/package/ports.r

[Puppet-dev] freebsd ports provider is broken in puppetlabs/puppet HEAD?

2017-05-04 Thread rafeltstykket
Hello, Today I think I found a bug in the ports provider for FreeBSD: puppet/lib/puppet/provider/package/ports.rb:7: :portinfo => "/usr/sbin/pkg_info" The pkg_info command has been replaced with 'pkg info' as of freebsd 10.0 : https://wiki.freebsd.org/PkgPrimer I've made a simple patch for the