[Puppet Users] Review of new type & provider

2011-09-20 Thread Jesse Peterson
Hello, I'm new to both Ruby and Puppet. Puppet is fantastic - loving it so far. I created a new type & provider (of parsed file type) for modifying newsyslog.conf files and am hoping some folks would be willing to review it to make sure there are no glaring mistakes or perhaps some shortcuts or l

Re: [Puppet Users] Review of new type & provider

2011-09-20 Thread James Turnbull
Jesse Peterson wrote: > Hello, > > I'm new to both Ruby and Puppet. Puppet is fantastic - loving it so > far. > > I created a new type & provider (of parsed file type) for modifying > newsyslog.conf files and am hoping some folks would be willing to > review it to make sure there are no glaring m

Re: [Puppet Users] Review of new type & provider

2011-09-21 Thread Jacob Helwig
On Tue, 20 Sep 2011 23:19:36 -0700, James Turnbull wrote: > > Jesse Peterson wrote: > > Hello, > > > > I'm new to both Ruby and Puppet. Puppet is fantastic - loving it so > > far. > > > > I created a new type & provider (of parsed file type) for modifying > > newsyslog.conf files and am hoping s