[pve-devel] [PATCH pve-common 1/1] network: tap_plug: fix mtu

2022-02-18 Thread Alexandre Derumier
- ovsint port mtu need to be set with ""ovs-vsctl set mtu-request" - update mtu on already existing interfaces (fwbr,fwln,tap,veth) if existing tap|veth interface is replugged on a different mtu bridge --- src/PVE/Network.pm | 30 -- 1 file changed, 20 insertions(+),

[pve-devel] [PATCH pve-common 0/1] network: tap_plug: fix mtu bugs

2022-02-18 Thread Alexandre Derumier
a forum user have reported strange bug with ovs + mtu9000 when switching between 2 ovs bridge with different mtu. (1500 vs 9000) https://forum.proxmox.com/threads/ovs-problem-with-mtu-9000-on-vms-assigned-to-vmbr0.105172/ I have found 2 bugs: 1) ovsint port mtu need to be set with ""ovs-vsctl

Re: [pve-devel] [PATCH qemu-server] fix 3674: QEMU restore: verify storage allows images before writing

2022-02-18 Thread Matthias Heiserer
Sorry, wrong bug. Should be 3886. ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager 4/6] api: mon: mds: osd: add safety check endpoints

2022-02-18 Thread Aaron Lauterer
for mon, mds and osd: ok-to-stop mon: ok-to-rm osd: safe-to-destroy Signed-off-by: Aaron Lauterer --- I added the OSD safe-to-destroy endpoint even though I have no immediate use for it as of now. But plan to include it in the OSD panel once I have an idea how to do so in a sensible manner.

[pve-devel] [PATCH librados2-perl manager 0/6] Add Ceph safety checks

2022-02-18 Thread Aaron Lauterer
The main motivation behind this series is to leverage several safety checks that Ceph has to make sure it is ok to stop or destroy a service. For this to work, the librados2-perl needs to be adapted as the Ceph API will return a non-zero return value and will also present a human readable

[pve-devel] [PATCH manager 6/6] ui: osd: mon: mds: warn if stop/destroy actions are problematic

2022-02-18 Thread Aaron Lauterer
Check if stopping of a service (OSD, MON, MDS) will be problematic for Ceph. The warning still allows the user to proceed. Ceph also has a check if the destruction of a MON is okay, so let's use it. Instead of the common OK button, label it with `Stop OSD` and so forth to hopefully reduce the

[pve-devel] [PATCH librados2-perl 2/6] mon_command: optionally ignore errors and return hashmap

2022-02-18 Thread Aaron Lauterer
In some situations, we do not want to abort if the Ceph API returns an error (ret != 0). We also want to be able to access all the retured values from the Ceph API (return code, status, data). One such situation can be the 'osd ok-to-stop' call where Ceph will return a non zero code if it is not

[pve-devel] [PATCH manager 5/6] ui: osd: warn if removal could be problematic

2022-02-18 Thread Aaron Lauterer
If an OSD is removed during the wrong conditions, it could lead to blocked IO or worst case data loss. Check against global flags that limit the capabilities of Ceph to heal itself (norebalance, norecover, noout) and if there are degraded objects. Unfortunately, the 'safe-to-destroy' API

[pve-devel] [PATCH librados2-perl 1/6] mon_command: free outs buffer

2022-02-18 Thread Aaron Lauterer
Signed-off-by: Aaron Lauterer --- thanks @Dominik who realized that we did not free this buffer in all situations. RADOS.xs | 4 1 file changed, 4 insertions(+) diff --git a/RADOS.xs b/RADOS.xs index 7eca024..1eb0b5a 100644 --- a/RADOS.xs +++ b/RADOS.xs @@ -145,6 +145,10 @@ CODE:

[pve-devel] [PATCH manager 3/6] api: osd: force mon_command to scalar context

2022-02-18 Thread Aaron Lauterer
With the changes in librados2-perl, we need to make sure to call it in scalar context. Signed-off-by: Aaron Lauterer --- This needs to be released in combination with the previous changes (2/6) in librados2-perl to not break OSD removal! PVE/API2/Ceph/OSD.pm | 2 +- 1 file changed, 1

[pve-devel] [PATCH manager] storage GUI: fix unintuitive sorting order

2022-02-18 Thread Matthias Heiserer
The backups in the 'Backups' table in Storages are now initially sorted by column 'Name' ascending. Previously, they were first sorted by 'vmid' descending, then by date descending. This was unintuitive as 'vmid' doesn't exist as column in the GUI, and only 'Date' displayed a sorting arrow.

[pve-devel] [PATCH v3 storage 1/2] fix #3894: cast 'size' and 'used' to integer

2022-02-18 Thread Mira Limbeck
Perl's automatic conversion can lead to integers being converted to strings, for example by matching it in a regex. To make sure we always return an integer in the API call, add an explicit cast to integer. Signed-off-by: Mira Limbeck Reviewed-by: Fabian Ebner --- v3: - fixed style nits -

[pve-devel] [PATCH storage v3 2/2] file_size_info: cast 'size' and 'used' to integer

2022-02-18 Thread Mira Limbeck
`qemu-img info --output=json` returns the size and used values as integers in the JSON format, but the regex match converts them to strings. As we know they only contain digits, we can simply cast them back to integers after the regex. The API requires them to be integers. Signed-off-by: Mira