[pve-devel] applied: [PATCH manager] fix #3976: api/backup: make schedule/starttime truly optional on update

2022-04-01 Thread Thomas Lamprecht
On 01.04.22 08:14, Dominik Csapak wrote: > on create we require either starttime (+dow) or a schedule, but when > updating an existing job, this is not necessary > > before we changed to schedules, the starttime was not optional either on > update, but i think there is no reason to require the

Re: [pve-devel] 3rd-party storage has "Unknown" type

2022-04-01 Thread Thomas Lamprecht
Hi Josh, On 31.03.22 22:39, Joshua Huber wrote: ... > > 1) The simplest: if there's no entry in storageSchema for value, just > return value as the "formatted" storage type. This seems like a great > low-cost, low-risk change. > > diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js >

[pve-devel] [RFC container] alloc disk: fix #3970 avoid ambiguous rbd image path

2022-04-01 Thread Aaron Lauterer
If two RBD storages use the same pool, but connect to different clusters, we cannot say to which cluster the mapped RBD image belongs to. To avoid potential data loss, we need to verify that no other storage is configured that could have a volume mapped under the same path before we format

[pve-devel] [RFC qemu-server] clone disk: fix #3970 catch same source and destination

2022-04-01 Thread Aaron Lauterer
In rare situations, it could happen that the source and target path is the same. For example, if the disk image is to be copied from one RBD storage to another one on different Ceph clusters but the pools have the same name. In this situation, the clone operation will clone it to the same image

Re: [pve-devel] [PATCH manager] Replaced system-report file download

2022-04-01 Thread Thomas Lamprecht
On 01.04.22 16:07, Daniel Tschlatscher wrote: > with a function call to the newly added textToFile() function in > the utils class (Proxmox.Utils). please refer to the fact that it got moved to proxmox-widget-toolkit to imply the required dependency bump more explicitly. > > Signed-off-by:

Re: [pve-devel] [PATCH widget-toolkit] fix #3971: Download and copy button in the TaskViewer

2022-04-01 Thread Thomas Lamprecht
On 01.04.22 16:07, Daniel Tschlatscher wrote: > The taskviewer now has 2 more buttons which implement > functionality for downloading the current tasklog as a file > or copying it to the clipboard. The code for saving the log > to a file was taken from the pve System Report class and > moved to

[pve-devel] applied: [PATCH manager] Jobs: don't schedule jobs with no computable next event

2022-04-01 Thread Thomas Lamprecht
On 01.04.22 13:24, Dominik Csapak wrote: > if we have a schedule that has no 'next event' we should skip the scheduling > instead of schedule every round > > this can happen if someone sets an schedule that has no next match. > some examples: > * 2-31 00:00 (there is not February 31st) > * mon

[pve-devel] [PATCH widget-toolkit] fix #3971: Download and copy button in the TaskViewer

2022-04-01 Thread Daniel Tschlatscher
The taskviewer now has 2 more buttons which implement functionality for downloading the current tasklog as a file or copying it to the clipboard. The code for saving the log to a file was taken from the pve System Report class and moved to its own function in the Utils file. Tested on Firefox

[pve-devel] [PATCH manager] Replaced system-report file download

2022-04-01 Thread Daniel Tschlatscher
with a function call to the newly added textToFile() function in the utils class (Proxmox.Utils). Signed-off-by: Daniel Tschlatscher --- www/manager6/node/Subscription.js | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/www/manager6/node/Subscription.js

[pve-devel] applied: [PATCH v3 proxmox-openid-rs] fix Open ID with Azure as provider

2022-04-01 Thread Thomas Lamprecht
On 01.04.22 11:44, Mira Limbeck wrote: > Azure doesn't accept `Transfer-Encoding: chunked` on their token endpoint, > but with the switch to ureq we always send requests with this set. > > Fix by switching to `Content-Length` in the header instead. ureq only > sets `Transfer-Encoding: chunked`

Re: [pve-devel] [PATCH v3 manager 0/4] BackupView as TreePanel

2022-04-01 Thread Matthias Heiserer
On 31.03.2022 12:47, Matthias Heiserer wrote: Depends on https://lists.proxmox.com/pipermail/pve-devel/2022-March/052322.html Matthias Heiserer (4): ui: Utils: Helpers for backup type and icon ui: storage: Rewrite backup content view as TreePanel. ui: delete BackupView and replace it

[pve-devel] [PATCH manager] Jobs: don't schedule jobs with no computable next event

2022-04-01 Thread Dominik Csapak
if we have a schedule that has no 'next event' we should skip the scheduling instead of schedule every round this can happen if someone sets an schedule that has no next match. some examples: * 2-31 00:00 (there is not February 31st) * mon 2022-04-02 (this would be a saturday, not monday) *

Re: [pve-devel] [PATCH v3 manager 0/4] BackupView as TreePanel

2022-04-01 Thread Markus Frank
Works as intended except of the search filter. Here I don't get results if i search for CT/VM-Names or Format-Names. This search-filter works for CT/VM-ID or a backupname like "ct/101/2022-04-01T09:38:59Z" Tested-by: Markus Frank On 3/31/22 12:47, Matthias Heiserer wrote: Depends on

[pve-devel] [PATCH manager v4 4/4] ui: move NotesView panel and NotesEdit window to widget kit

2022-04-01 Thread Stefan Sterz
this removes the NotesView panel and NotesEdit and replaces them with with the version from the widget kit. Signed-off-by: Stefan Sterz --- www/manager6/Makefile | 2 - www/manager6/dc/Config.js | 2 +- www/manager6/node/Config.js| 2 +-

[pve-devel] [PATCH proxmox-backup v4 1/4] fix #3067: docs: add markdown primer from pve to pbs

2022-04-01 Thread Stefan Sterz
this copies the markdown primer from the pve docs to allow access to it via the help buttons in the gui Signed-off-by: Stefan Sterz --- docs/index.rst | 1 + docs/markdown-primer.rst | 178 +++ 2 files changed, 179 insertions(+) create mode

[pve-devel] [PATCH proxmox-backup v4 3/4] fix #3067: ui: add a separate notes view for longer markdown notes

2022-04-01 Thread Stefan Sterz
since markdown notes might be rather long, this commit adds a tab similar to pve's datacenter or node notes. requires a bump of the widget toolkit in order to use the `pmxNotesView`. Signed-off-by: Stefan Sterz --- the maxLength of a note in pbs is chosen to be 1022*64 because the server allows

[pve-devel] [PATCH widget-toolkit v4 2/4] toolkit: add markdown based NotesView and NotesEdit

2022-04-01 Thread Stefan Sterz
adds a universal version of NotesView and NotesEdit to the widget toolkit that is compatible with pve and pbs. this avoids maintaining duplicate code in pve and pbs, but since the original versions were very tightly integrated with pve-manager, changes are required to make them compatible with

[pve-devel] [PATCH SERIES v4 0/4] add notes to functionality to pbs webui

2022-04-01 Thread Stefan Sterz
adds support for markdown-based notes to pbs. It also refactors the pve `NotesView` panel and `NotesEdit` window so that we can move it to the widget toolkit and maintain a single version of the two. hence, the last commits for proxmox-backup and pve-manager need to be applied and bumped with or

[pve-devel] [PATCH v3 proxmox-openid-rs] fix Open ID with Azure as provider

2022-04-01 Thread Mira Limbeck
Azure doesn't accept `Transfer-Encoding: chunked` on their token endpoint, but with the switch to ureq we always send requests with this set. Fix by switching to `Content-Length` in the header instead. ureq only sets `Transfer-Encoding: chunked` when the body length is not known beforehand, which

Re: [pve-devel] [PATCH v2 proxmox-openid-rs] fix Open ID with Azure as provider

2022-04-01 Thread Mira Limbeck
On 4/1/22 11:32, Mira Limbeck wrote: Azure doesn't accept `Transfer-Encoding: chunked` on their token endpoint, but with the switch to ureq we always send requests with this set. Fix by switching to `Content-Length` in the header instead. ureq only sets `Transfer-Encoding: chunked` when the

[pve-devel] [PATCH v2 proxmox-openid-rs] fix Open ID with Azure as provider

2022-04-01 Thread Mira Limbeck
Azure doesn't accept `Transfer-Encoding: chunked` on their token endpoint, but with the switch to ureq we always send requests with this set. Fix by switching to `Content-Length` in the header instead. ureq only sets `Transfer-Encoding: chunked` when the body length is not known beforehand, which

Re: [pve-devel] [PATCH proxmox-openid-rs] fix Open ID with Azure as provider

2022-04-01 Thread Mira Limbeck
On 4/1/22 06:21, Dietmar Maurer wrote: let response = if let Method::POST = request.method { -req.send(&*request.body) +let bytes = request.body.as_slice(); +req.send_bytes(bytes) Does this have the side effect of changing the transfer encoding? If so, it is worth

[pve-devel] applied-series: [PATCH-SERIES v2 manager/storage/container/qemu-server] improve check_volume_access

2022-04-01 Thread Fabian Grünbichler
with potential for the following follow-up: - uploading isos/templates or downloading them currently requires Datastore.AllocateTemplate - deleting isos/templates currently requires Datastore.Allocate the latter could get a less restrictive check like we already have for backup volumes, to

[pve-devel] [PATCH manager] fix #3976: api/backup: make schedule/starttime truly optional on update

2022-04-01 Thread Dominik Csapak
on create we require either starttime (+dow) or a schedule, but when updating an existing job, this is not necessary before we changed to schedules, the starttime was not optional either on update, but i think there is no reason to require the user to send the schedule/startime along every time.