On 2024-07-22 18:57, Thomas Lamprecht wrote:
Am 10/07/2024 um 14:42 schrieb Aaron Lauterer:
The ID for the MDS cannot start with a number [0]. The first patch adds
a check for this.
The second patch is the actual fix, by reworking the edit window when
adding new MDS'.
By allowing the user
On Mon Jul 22, 2024 at 5:38 PM CEST, Thomas Lamprecht wrote:
> Am 01/07/2024 um 16:10 schrieb Max Carrara:
> > This commit adds `PVE.Utils.parseCephBuildCommit`, which can be used
> > to get the full hash "eccf199d..." in parentheses from a string like
> > the following:
> >
> > ceph version 17.
Am 08/07/2024 um 11:37 schrieb Lukas Wagner:
> This patch series attempts to improve the user experience when creating
> notification matchers.
>
> Some of the noteworthy changes:
> - Allow setting a custom backup job ID, similar how we handle it for
> sync/prune jobs in PBS (to allow recogniz
Am 08/07/2024 um 13:56 schrieb Dominik Csapak:
> With the last change in the permission check, I accidentally broke the
> check for 'spice' host value, since in the if/elsif/else this will fall
> through to the else case which was only intended for when neither 'host'
> nor 'mapping' was set.
>
>
Am 08/07/2024 um 11:38 schrieb Lukas Wagner:
> This allows us to access the backup job id in the send_notification
> function, where we can set it as metadata for the notification.
> The 'job-id' parameter can only be used by 'root@pam' to prevent
> abuse. This has the side effect that manually tri
Am 08/07/2024 um 11:38 schrieb Lukas Wagner:
> 'job-id' is passed when a backup as started as a job and will be
> passed to the notification system as matchable metadata. It
> can be considered 'internal'.
>
> Signed-off-by: Lukas Wagner
> Reviewed-by: Max Carrara
> ---
> src/PVE/VZDump/Common.
Am 09/07/2024 um 11:09 schrieb Wolfgang Bumiller:
> The function can be called with
> - neither quota nor period
> - only a period (quota will be 'max')
> - both
>
> $quota was therefore defaulted to 'max' and the check for whether
> values were provided should use $period instead of $quota.
> Als
Am 09/07/2024 um 13:49 schrieb Maximiliano Sandoval:
> Having the complete command printed out makes debuging easier.
>
> Signed-off-by: Maximiliano Sandoval
> ---
> src/PVE/Storage/BTRFSPlugin.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
__
Am 10/07/2024 um 13:57 schrieb Fabian Grünbichler:
> for package builds to ensure all common flags are actually set.
>
> Signed-off-by: Fabian Grünbichler
> ---
>
> Notes:
> v2: symlink wrapper config in place
>
> Makefile | 9 +++--
> debian/rules | 11 ---
> docs/Makef
Am 09/07/2024 um 13:41 schrieb Aaron Lauterer:
> By only setting propterties that have changed, we can avoid potential
> errors in the task.
>
> For example, if one configures the "nosizechange" property on a pool, to
> prevent accidential size changes, the task will now only error if the
> user i
Am 10/07/2024 um 14:42 schrieb Aaron Lauterer:
> The ID for the MDS cannot start with a number [0]. The first patch adds
> a check for this.
>
> The second patch is the actual fix, by reworking the edit window when
> adding new MDS'.
>
> By allowing the users to set the name of the MDS directly,
Am 15/07/2024 um 09:56 schrieb Christoph Heiss:
> This series adds a new answer option `global.root_password_hashed`
> for the auto-installer, enabling administrators to specify the root
> password of the new installation in a hashed format - as generated by
> e.g. mkpasswd(1) - instead of plain-te
Am 17/07/2024 um 15:06 schrieb Stefan Hanreich:
> Currently custom mappings cannot be edited, due to them having no VMID
> value. The VMID parameter was always sent by the frontend to the
> update call - even if it was empty - leading to validation failure on
> the backend. Fix this by only sending
Am 17/07/2024 um 15:06 schrieb Stefan Hanreich:
> Updating the NIC of a VM when the following conditions were met:
> * VM is turned off
> * NIC is on a bridge that uses automatic dhcp
> * Leave bridge unchanged
>
> led to duplicate IPAM entries for the same network device.
>
> This is due to the
Am 17/07/2024 um 14:49 schrieb Christoph Heiss:
> Comparing with Proxmox.Utils.render_cpu() seems just a slight oversight
> in the condition. Fix it by aligning it with how it is done in
> Proxmox.Utils.render_cpu() for consistency.
>
> Signed-off-by: Christoph Heiss
> ---
> www/manager6/Utils.j
Am 17/07/2024 um 14:16 schrieb Maximiliano Sandoval:
> Signed-off-by: Maximiliano Sandoval
> ---
> PVE/API2/Nodes.pm | 2 +-
> PVE/APLInfo.pm | 2 +-
> PVE/CLI/pveceph.pm | 2 +-
> PVE/Service/pvestatd.pm | 2 +-
>
Am 03/07/2024 um 11:17 schrieb Stefan Hanreich:
> Signed-off-by: Stefan Hanreich
> ---
> proxmox-ve-config/Cargo.toml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>
applied series with some merge conflict in the context addressed for the
second patch and updated the dependencie
Am 05/07/2023 um 16:38 schrieb Christoph Heiss:
> While working on this code, I noticed that the `firewall` argument is
> never used (nor even declared) [0] in both
> PVE::Network::{add,del}_bridge_fdb().
>
> Thus drop it everywhere and avoid needlessly passing around things which
> are never used
Am 17/07/2024 um 15:16 schrieb Stefan Hanreich:
> When disabling the nftables firewall again, there is a race condition
> where the nftables ruleset never gets flushed and persists after
> disabling.
>
> The nftables firewall update loop does a noop when the force disable
> file exists. It only fl
Am 01/07/2024 um 16:10 schrieb Max Carrara:
> Ceph Build Commit in UI - Version 2
> ===
>
> Notable Changes since v1
>
>
> * Use camelCase instead of snake_case for new functions / variables
> as per our style guide [0] (thanks Lukas!
Am 01/07/2024 um 16:10 schrieb Max Carrara:
> This commit adds `PVE.Utils.parseCephBuildCommit`, which can be used
> to get the full hash "eccf199d..." in parentheses from a string like
> the following:
>
> ceph version 17.2.7 (eccf199d63457659c09677399928203b7903c888) quincy
> (stable)
>
> Th
Thanks for this patch.
A few things need to be changed in the actually commands/API/…
definitions as we autogenerate the manual pages.
This is true for any file with `*-synopsis` or `*-opts*` in its name.
Please send a v2 without the synopsis and opts files. For the synopsis
and opts files,
just chiming in on the perl dereference style
Am 22/07/2024 um 11:50 schrieb Max Carrara:
+ %$webhook_properties,
>>> Would prefer `$webhook_properties->%*` here (postfix dereferencing) -
>>> even though not explicitly stated in our style guide, we use that kind
>>> of syntax for cal
On 2024-07-22 14:10, Stefan Hanreich wrote:
> I got the following JS error when trying to save a secret/header/body
> template with the content: `qweqwe ßẞ`
>
> Uncaught DOMException: String contains an invalid character
> getValue https://10.101.110.1:8007/widgettoolkit/proxmoxlib.js
Hi, I tested the following things via the 'Test' option in the
Notifications configuration panel in PBS and PVE:
* Setting a custom header
* Using a secret in body / URL
* POST / PUT / GET methods
I triggered notifications in PBS for the following things:
* GC
* Sync
I triggered notifications in
Thank you for testing it!
On 7/18/24 17:51, Friedrich Weber wrote:
> On 09/07/2024 17:12, Mira Limbeck wrote:
>> cloudbase-init, a cloud-init reimplementation for Windows, supports only
>> a subset of the configuration options of cloud-init. Some features
>> depend on support by the Metadata Servi
On Mon Jul 22, 2024 at 9:37 AM CEST, Lukas Wagner wrote:
>
>
> On 2024-07-17 17:36, Max Carrara wrote:
> > On Fri Jul 12, 2024 at 1:27 PM CEST, Lukas Wagner wrote:
> >> These just call the API implementation via the perl-rs bindings.
> >>
> >> Signed-off-by: Lukas Wagner
> >> ---
> >> PVE/API2/C
On Mon Jul 22, 2024 at 9:30 AM CEST, Lukas Wagner wrote:
>
>
> On 2024-07-17 17:35, Max Carrara wrote:
> >> +let handlebars = setup_handlebars();
> >> +let body_template =
> >> self.base_64_decode(self.config.body.as_deref().unwrap_or_default())?;
> >> +
> >> +let body = h
On 2024-07-17 17:34, Max Carrara wrote:
> On Fri Jul 12, 2024 at 1:27 PM CEST, Lukas Wagner wrote:
>> Sending as an RFC because I don't want this merged yet; that being
>> said, the feature should be mostly finished at this point, I'd
>> appreciate any reviews and feedback.
>>
>> This series ad
On 2024-07-17 17:36, Max Carrara wrote:
> On Fri Jul 12, 2024 at 1:27 PM CEST, Lukas Wagner wrote:
>> These just call the API implementation via the perl-rs bindings.
>>
>> Signed-off-by: Lukas Wagner
>> ---
>> PVE/API2/Cluster/Notifications.pm | 263 +-
>> 1 file
On 2024-07-17 17:35, Max Carrara wrote:
>> +
>> +assert_eq!(secrets[1].name, "token".to_string());
>> +assert_eq!(secrets[1].value, Some(encode("secret")));
>> +assert_eq!(secrets[0].name, "token2".to_string());
>> +assert_eq!(secrets[0].value, Some(encode("newse
On 2024-07-17 17:35, Max Carrara wrote:
>> +let handlebars = setup_handlebars();
>> +let body_template =
>> self.base_64_decode(self.config.body.as_deref().unwrap_or_default())?;
>> +
>> +let body = handlebars
>> +.render_template(&body_template, &data)
>> +
32 matches
Mail list logo
