[pve-devel] [PATCH frr 1/2] debian: remove patch sequence numbers

2025-06-17 Thread Gabriel Goller
Are not needed and we don't seem to add them usually on debian patches. Otherwise we'd need to increment on every new patch. Signed-off-by: Gabriel Goller --- debian/patches/pve/0001-enable-bgp-bfd-daemons.patch| 2 +- ...2-bgpd-add-an-option-for-RT-auto-derivation-to-force-A.patch |

Re: [pve-devel] [PATCH frr 1/2] d/patches: add backport for bfd session down fix

2025-06-17 Thread Gabriel Goller
Obsolete with: https://lore.proxmox.com/pve-devel/20250617162136.444316-2-g.gol...@proxmox.com/T/#u ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH frr 2/2] frr: bump to 10.3.1

2025-06-17 Thread Gabriel Goller
Important for us is the BFD fix backported by stefan [0] and an openfabric fix for IPv6 [1]. Note: 10.3 will also be the version available in debian trixie. [0]: https://github.com/FRRouting/frr/pull/18682 [1]: https://github.com/FRRouting/frr/pull/17083 Signed-off-by: Gabriel Goller --- debian

Re: [pve-devel] [PATCH manager v2] fix #4166: restore: add resource pool selector

2025-06-17 Thread Thomas Lamprecht
Am 12.06.25 um 10:23 schrieb Maximiliano Sandoval: > The pool selector is only visible when restoring from the > Datacenter->{node}->{storage}->Backups panel. I mean fine for now, but IMO if the user has enough rights then restoring to another pool for when overwriting an existing VM might make se

Re: [pve-devel] [PATCH pve_flutter_frontend v2] fix: ui: remove blue background under bottom bar in iOS

2025-06-17 Thread Shan Shaji
Superseeded by v3: https://lore.proxmox.com/pve-devel/20250617153145.18048-1-s.sh...@proxmox.com/T/#u On Fri Jun 13, 2025 at 2:29 PM CEST, Michael Köppl wrote: > Tested the effects of the changes on Android, so I cannot say anything > about the effects on iOS. With the exception noted below, I di

[pve-devel] [PATCH pve_flutter_frontend v3] fix: ui: remove blue background under bottom bar in iOS

2025-06-17 Thread Shan Shaji
In iOS, there was a blue background color visible beneath the bottom bar, which caused the app to not utilize the full screen height. Additionally, the colors of the app bar and the status bar differed when the user began scrolling. This issue was due to the container color used in the `ColoredSaf

Re: [pve-devel] [PATCH qemu-server 03/13] blockdev: vm_devices_list : fix block-query

2025-06-17 Thread Fiona Ebner
Am 03.06.25 um 09:55 schrieb Alexandre Derumier via pve-devel: > > Look at qdev value, as cdrom drives can be empty > without any inserted media > > Signed-off-by: Alexandre Derumier > --- > PVE/QemuServer.pm | 17 ++--- > 1 file changed, 14 insertions(+), 3 deletions(-) > > diff -

Re: [pve-devel] [PATCH proxmox{_login_manager, _dart_api_client} v3 0/2] fix #6409: login manager doesn't pre-selects default authentication realm

2025-06-17 Thread Shan Shaji
Ping On Fri Jun 6, 2025 at 10:18 AM CEST, Michael Köppl wrote: > Gave this another spin in my Android emulator. User's realm selection is > now respected if there is one, otherwise the site's selected default is > used. Did not notice anything off. With my comments from v2 addressed > and everyth

Re: [pve-devel] [RFC qemu-server 21/22] blockdev: add support for NBD paths

2025-06-17 Thread Fiona Ebner
Am 16.06.25 um 12:46 schrieb DERUMIER, Alexandre via pve-devel: > > I think I have wrongly dropped nbd with unix socket in my last patch > series, but previously it was: > > > +} elsif ($path =~ m/^nbd:(\S+):(\d+):exportname=(\S+)$/) { > + my $server = { type => 'inet', host => $1, por

Re: [pve-devel] [PATCH qemu-server 20/22] blockdev: add helpers to generate blockdev commandline

2025-06-17 Thread Fiona Ebner
Am 16.06.25 um 13:07 schrieb DERUMIER, Alexandre via pve-devel: >>> The 'snapshot' option, for QEMU's snapshot mode, i.e. writes are only >>> temporary, is not yet supported. > > from qemu manpage: > > " >-snapshot > Write to temporary files instead of disk image files. In >

Re: [pve-devel] [PATCH qemu-server 20/22] blockdev: add helpers to generate blockdev commandline

2025-06-17 Thread Fabian Grünbichler
> Fiona Ebner hat am 17.06.2025 11:37 CEST geschrieben: > > > Am 13.06.25 um 13:35 schrieb Fabian Grünbichler: > > On June 12, 2025 4:02 pm, Fiona Ebner wrote: > >> The drive device and node structure is: > >> front-end device {ide-hd,scsi-hd,virtio-blk-pci} (id=$drive_id) > >> - throttle nod

Re: [pve-devel] [PATCH qemu-server 20/22] blockdev: add helpers to generate blockdev commandline

2025-06-17 Thread Fiona Ebner
Am 13.06.25 um 13:35 schrieb Fabian Grünbichler: > On June 12, 2025 4:02 pm, Fiona Ebner wrote: >> The drive device and node structure is: >> front-end device {ide-hd,scsi-hd,virtio-blk-pci} (id=$drive_id) >> - throttle node (node-name=$drive_id) > > should we prefix this is well to not "use" the

[pve-devel] applied: [PATCH promxox-mail-forward v2] fix logging by switching to proxmox-log

2025-06-17 Thread Thomas Lamprecht
On Fri, 13 Jun 2025 09:54:43 +0200, Lukas Wagner wrote: > The proxmox-notify crate now uses tracing for logging, hence we have to > set up some tracing logging infrastructure if we want to see any > messages in the journal. Therefore we switch from the syslog crate to > proxmox-log, which configure

[pve-devel] superseded: [PATCH manager 1/2] ui: backup job edit: move notification related settings to separate tab

2025-06-17 Thread Lukas Wagner
Superseded by v2: https://lore.proxmox.com/all/20250617084448.87536-1-l.wag...@proxmox.com/T/#t -- - Lukas ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager 1/2] ui: backup job edit: move notification related settings to separate tab

2025-06-17 Thread Lukas Wagner
Thanks a lot for testing and the review, Michael. On 2025-06-13 15:51, Michael Köppl wrote: > Tested both creating a scheduled backup job and creating a backup of a > single guest. For both cases I tested: > - using the global settings > - using sendemail with specific email addresses > Both work

[pve-devel] [PATCH manager v2 1/3] ui: backup job edit: move notification related settings to separate tab

2025-06-17 Thread Lukas Wagner
The notification settings in the 'General' tab were unfortunately a source of regular confusion for many people. This was primarily due to the behavior of the 'notification mode'. The notification mode can one of the following: - notification-system: Emit a notification event to the global no

[pve-devel] [PATCH manager v2 2/3] ui: one-shot backup: remove 'auto' notification mode for clarity

2025-06-17 Thread Lukas Wagner
The 'auto' mode does not really add any functionality but only adds confusion about what it actually does, so it is completely removed from the UI. It is still supported by the backend, but in the UI it is mapped it to a concrete mode (either notification-system or legacy-sendmail, depending on whe

[pve-devel] [PATCH manager v2 3/3] ui: oneshot backup: stop shifting UI when selecting 'legacy-sendmail'

2025-06-17 Thread Lukas Wagner
The 'protected' checkbox in the left column seems to use slightly less space than the 'mailto' field in the same row in the right column. The 'mailto' field is only shown when the 'notification-mode' is set to legacy-sendmail. Due to the differences in size, the UI shifts by a couple pixels when th

Re: [pve-devel] [PATCH manager 2/2] ui: one-shot backup: remove 'auto' notification mode for clarity

2025-06-17 Thread Lukas Wagner
Thanks for testing and the review! On 2025-06-13 15:51, Michael Köppl wrote: >> --- a/www/manager6/window/Backup.js >> +++ b/www/manager6/window/Backup.js >> @@ -33,22 +33,22 @@ Ext.define('PVE.window.Backup', { >> let mailtoField = Ext.create('Ext.form.field.Text', { >> fieldLabel:

Re: [pve-devel] [PATCH container/manager/proxmox{, -perl-rs}/storage v2 00/11] support OCI images as container templates

2025-06-17 Thread Christoph Heiss
pve-container changes now need a rebase due to the perltidy re-formatting. Tested the series using the same setup as last time. Tested the following images, exported with podman: - docker.io/library/nginx:mainline-alpine - docker.io/library/nginx:mainline-bookworm - ghcr.io/dani-garcia/vaultwarde

Re: [pve-devel] [PATCH qemu-server 19/22] drive: create a throttle group for each drive starting with machine version 10.0

2025-06-17 Thread Fiona Ebner
Am 13.06.25 um 13:23 schrieb Fabian Grünbichler: > On June 12, 2025 4:02 pm, Fiona Ebner wrote: >> @@ -3943,6 +3944,12 @@ sub config_to_command { >> push @$devices, '-blockdev', $live_restore->{blockdev}; >> } >> >> +if (min_version($machine_version, 10, 0)) { >> +my $dr

Re: [pve-devel] [PATCH qemu-server 15/22] vm start/commandline: activate volumes before config_to_command()

2025-06-17 Thread Fiona Ebner
Am 13.06.25 um 12:16 schrieb Fabian Grünbichler: > On June 12, 2025 4:02 pm, Fiona Ebner wrote: >> @@ -5982,14 +5979,25 @@ sub vm_commandline { >> >> my $defaults = load_defaults(); >> >> +my $running = PVE::QemuServer::Helpers::vm_running_locally($vmid); >> +my $volumes = []; >> +

Re: [pve-devel] [PATCH qemu-server 18/22] print drive device: don't reference any drive for 'none' starting with machine version 10.0

2025-06-17 Thread Fiona Ebner
Am 13.06.25 um 13:14 schrieb Fabian Grünbichler: > On June 12, 2025 4:02 pm, Fiona Ebner wrote: >> There will be no block node for 'none' after switching to '-blockdev'. >> >> Co-developed-by: Alexandre Derumier >> [FE: split out from larger patch >> do it also for non-SCSI cases] >> Signed-o

Re: [pve-devel] [PATCH qemu-server 16/22] print drive device: explicitly set write-cache starting with machine version 10.0

2025-06-17 Thread Fiona Ebner
Am 13.06.25 um 12:28 schrieb Fabian Grünbichler: > On June 12, 2025 4:02 pm, Fiona Ebner wrote: >> @@ -1403,6 +1404,15 @@ sub print_drivedevice_full { >> $device .= ",serial=$serial"; >> } >> >> +if (min_version($machine_version, 10, 0)) { > > should we add a comment here (and for

Re: [pve-devel] [PATCH qemu-server 15/22] vm start/commandline: activate volumes before config_to_command()

2025-06-17 Thread Fiona Ebner
Am 17.06.25 um 08:04 schrieb DERUMIER, Alexandre via pve-devel: >>> With '-blockdev', it is necessary to activate the volumes to >>> generate >>> the command line, because it can be necessary to check whether the >>> volume is a block device or a regular file. > >>> I was thinking about that, but

Re: [pve-devel] [PATCH promxox-mail-forward v2] fix logging by switching to proxmox-log

2025-06-17 Thread Lukas Wagner
On 2025-06-16 21:28, Thomas Lamprecht wrote: >> >> [dependencies] >> anyhow = "1.0" >> -log = "0.4.17" >> nix = "0.26" >> -syslog = "6.0" >> >> -proxmox-sys = "0.6" >> +proxmox-log = "0.2.8" >> proxmox-notify = {version = "0.5.4", features = ["mail-forwarder", >> "pve-context", "pbs-conte