[pve-devel] [PATCH pve-kernel 0/2] cherry-picks and config-options for downfall

2023-08-11 Thread Stoiko Ivanov
be tested on an affected machine too! Stoiko Ivanov (2): add fixes for downfall d/rules: enable mitigation config-options debian/rules | 4 +- ...-init-Provide-arch_cpu_finalize_init.patch | 85 +++ ...cpu-Switch-to-arch_cpu_finalize_init.patch | 235

[pve-devel] [PATCH pve-kernel 0/2] cherry-picks and config-options for downfall

2023-08-11 Thread Stoiko Ivanov
be tested on an affected machine too! Stoiko Ivanov (2): add fixes for downfall d/rules: enable mitigation config-options debian/rules | 4 +- ...-init-Provide-arch_cpu_finalize_init.patch | 85 +++ ...cpu-Switch-to-arch_cpu_finalize_init.patch | 235

[pve-devel] [PATCH pve-kernel 2/2] d/rules: enable mitigation config-options

2023-08-11 Thread Stoiko Ivanov
CONFIG_ARCH_HAS_CPU_FINALIZE_INIT and CONFIG_GDS_FORCE_MITIGATION follows commit 3edbe24ed004516bd910f6e97fbd4b62cf589239 in ubuntu-upstream/master-next Signed-off-by: Stoiko Ivanov --- debian/rules | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/debian/rules b/debian

[pve-devel] [PATCH container] setup: fedora: fix wrong systemd-networkd preset

2023-06-23 Thread Stoiko Ivanov
off-by: Stoiko Ivanov --- src/PVE/LXC/Setup/Fedora.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/LXC/Setup/Fedora.pm b/src/PVE/LXC/Setup/Fedora.pm index 80ee85f..1a487c6 100644 --- a/src/PVE/LXC/Setup/Fedora.pm +++ b/src/PVE/LXC/Setup/Fedora.pm @@ -39,7 +39,7 @@

[pve-devel] [PATCH docs] faq: fix typo in release names

2023-06-23 Thread Stoiko Ivanov
Reported-by: Daniela Häsler Signed-off-by: Stoiko Ivanov --- pve-faq.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pve-faq.adoc b/pve-faq.adoc index ce22ad5..a0b838d 100644 --- a/pve-faq.adoc +++ b/pve-faq.adoc @@ -89,7 +89,7 @@ recommended. [width="100%"

[pve-devel] [PATCH installer] fix space calculation for small disks for pve product

2023-06-22 Thread Stoiko Ivanov
, which overflows in the `& ~0xFFF` opration. Signed-off-by: Stoiko Ivanov --- tested in a VM with an 8GB disk Proxmox/Install.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm index 7970f83..28add10 100644 --- a/Proxmox/Instal

[pve-devel] [PATCH] pve7to8: add check for systemd-boot presence where needed

2023-06-21 Thread Stoiko Ivanov
comes from the API-modules, which limit it to the pve-relevant packages. tested in VMs with uefi and legacy mode, with existing proxmox-boot-uuids both with and w/o systemd-boot being installed Signed-off-by: Stoiko Ivanov --- PVE/CLI/pve7to8.pm | 29 + 1 file changed

[pve-devel] [PATCH 3/3] d/control: add Recommends on systemd-boot

2023-06-21 Thread Stoiko Ivanov
systemd-boot is a separate binary package, and proxmox-boot-tool needs it in the uefi-case as boot-loader for the ESPs Not adding as Depends, because it is not strictly necessary for proxmox-boot-tool (pinning is independent as is its use on legacy-boot systems) Signed-off-by: Stoiko Ivanov

[pve-devel] [PATCH 2/3] proxmox-boot: warn on missing systemd-boot package

2023-06-21 Thread Stoiko Ivanov
of bootctl in the boot-tool codebase Signed-off-by: Stoiko Ivanov --- src/bin/proxmox-boot-tool | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/bin/proxmox-boot-tool b/src/bin/proxmox-boot-tool index d41f921..913b0f6 100755 --- a/src/bin/proxmox-boot-tool +++ b/src/bin/proxmox-boot

[pve-devel] [PATCH 0/3] adapt to systemd-boot hooks in bookworm

2023-06-21 Thread Stoiko Ivanov
ool into it later (by partitioning accordingly) While I tested the patches - some review and consideration, especially about potential pitfalls regarding the in place editing of the hook-scripts would be very much appreciated! Stoiko Ivanov (3): boot-tool: disarm upstream systemd-boot hookscri

[pve-devel] [PATCH 1/3] boot-tool: disarm upstream systemd-boot hookscripts

2023-06-21 Thread Stoiko Ivanov
/8a38b62f37189b071a30f208530ce5dc278e521e/src/boot/bootctl.c#L90 [2] https://www.debian.org/doc/debian-policy/ap-pkg-diversions.html [3] https://www.debian.org/doc/debian-policy/ch-relationships.html Reported-by: Aaron Lauterer Signed-off-by: Stoiko Ivanov --- src/proxmox-boot/zz-proxmox-boot | 23

[pve-devel] [PATCH] smartmontools.default: add `-q never` to smartd_opts

2023-06-16 Thread Stoiko Ivanov
by installing a version with this patch on the HP DL380g8 mentioned above, additionally inside a VM running PVE and a workstation upgraded to the latest 8.0 beta. Signed-off-by: Stoiko Ivanov --- debian/smartmontools.default | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/debian

[pve-devel] [PATCH proxmox-backup 1/3] file-restore: add zfs. prefix to arc_min/max settings

2023-06-15 Thread Stoiko Ivanov
to be set: `grep '^c_' /proc/spl/kstat/zfs/arcstats` showed half of the memory for c_max. [0] https://github.com/openzfs/zfs/issues/698 [1] https://github.com/openzfs/zfs/issues/12504 Signed-off-by: Stoiko Ivanov --- proxmox-file-restore/src/qemu_helper.rs | 2 +- 1 file changed, 1 insertion(+), 1

[pve-devel] [PATCH proxmox-backup 2/3] file-restore: set zfs_arc_min to current minimum of 32M

2023-06-15 Thread Stoiko Ivanov
, and will still be kept should the restore vm have more than 1G of memory at some point. Signed-off-by: Stoiko Ivanov --- proxmox-file-restore/src/qemu_helper.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proxmox-file-restore/src/qemu_helper.rs b/proxmox-file-restore/src

[pve-devel] [PATCH proxmox-backup 0/3] file-restore: set arc limits correctly

2023-06-15 Thread Stoiko Ivanov
- it explicitly split them out for ease of reviewing the last patch is more as an rfc, because it puzzled my why a debug-log message was not printed when running with debug. Stoiko Ivanov (3): file-restore: add zfs. prefix to arc_min/max settings file-restore: set zfs_arc_min to current minimum of 32M

[pve-devel] [PATCH proxmox-backup 3/3] file-restore: set loglevel considering PBS_QEMU_DEBUG

2023-06-15 Thread Stoiko Ivanov
during some tests recently I wondered why a debug log-message was not printed, despite running with PBS_QEMU_DEBUG. This patch sets the loglevel for the cli logger to debug if the variable is present and not-empty (see qemu_helper.rs for the other usage). Signed-off-by: Stoiko Ivanov

[pve-devel] [PATCH container v2 0/2] add test for LXC_NAME hosts entry and fix a minor glitch

2023-06-14 Thread Stoiko Ivanov
est::MockModule in the snapshot-test.pm - which should be addressed with patch 1 of this series. Stoiko Ivanov (2): tests: fix small syntax glitch tests: add minimal test for LXC_NAME hosts entry src/test/snapshot-test.pm | 12 +-- src/test/test-alpine-003/con

[pve-devel] [PATCH container v2 1/2] tests: fix small syntax glitch

2023-06-14 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- src/test/snapshot-test.pm | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/test/snapshot-test.pm b/src/test/snapshot-test.pm index 8e6e9c2..f9b1616 100644 --- a/src/test/snapshot-test.pm +++ b/src/test/snapshot-test.pm @@ -297,21

[pve-devel] [PATCH container v2 2/2] tests: add minimal test for LXC_NAME hosts entry

2023-06-14 Thread Stoiko Ivanov
based on test-alpine-002 Signed-off-by: Stoiko Ivanov --- src/test/test-alpine-003/config | 2 ++ src/test/test-alpine-003/etc/alpine-release | 1 + src/test/test-alpine-003/etc/hostname.exp | 1 + src/test/test-alpine-003/etc/hosts| 3 +++ src/test/test

[pve-devel] [PATCH container 2/2] tests: add minimal test for LXC_NAME hosts entry

2023-06-14 Thread Stoiko Ivanov
based on test-alpine-002 Signed-off-by: Stoiko Ivanov --- src/test/test-alpine-003/config | 2 ++ src/test/test-alpine-003/etc/alpine-release | 1 + src/test/test-alpine-003/etc/hostname.exp | 1 + src/test/test-alpine-003/etc/hosts| 5 + src/test/test

[pve-devel] [PATCH container 0/2] add test for LXC_NAME hosts entry and fix a minor glitch

2023-06-14 Thread Stoiko Ivanov
)! patch 2 adds an explicit test for the functionality in the patch While checking the output I noticed a small glitch with Test::MockModule in the snapshot-test.pm - which should be addressed with patch 1 of this series. Stoiko Ivanov (2): tests: fix small syntax glitch tests: add minimal test

[pve-devel] [PATCH container 1/2] tests: fix small syntax glitch

2023-06-14 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- src/test/snapshot-test.pm | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/test/snapshot-test.pm b/src/test/snapshot-test.pm index 8e6e9c2..f9b1616 100644 --- a/src/test/snapshot-test.pm +++ b/src/test/snapshot-test.pm @@ -297,21

Re: [pve-devel] [PATCH container] setup: template_fixup: remove bogus LXC_NAME line from /etc/hosts

2023-06-13 Thread Stoiko Ivanov
! On Fri, 9 Jun 2023 19:36:27 +0200 Stoiko Ivanov wrote: > Templates not built directly by us, but redistributed from > images.linuxcontainer.org contain the following line in /etc/hosts: > `127.0.1.1 LXC_NAME` > > While it is mostly cosmetic - LXC_NAME, contain

[pve-devel] [PATCH zfsonlinux 2/2] /lib/zfs-linux/trim: don't exit 1 if last pool isn't nvme-only (Closes: #1030316)

2023-06-13 Thread Stoiko Ivanov
(cherry picked from debian-upstream[0] commit 8ed69adac193f6463832f6ae34b5ded88b8014d8) [0] https://salsa.debian.org/zfsonlinux-team/zfs Signed-off-by: Stoiko Ivanov --- debian/tree/zfsutils-linux/usr/lib/zfs-linux/trim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian

[pve-devel] [PATCH zfsonlinux 0/2] update to 2.1.12

2023-06-13 Thread Stoiko Ivanov
. Stoiko Ivanov (2): update zfs submodule to 2.1.12 /lib/zfs-linux/trim: don't exit 1 if last pool isn't nvme-only (Closes: #1030316) [0] https://github.com/openzfs/zfs/releases/tag/zfs-2.1.12 [1] https://github.com/openzfs/zfs/pull/14908 [2] https://github.com/openzfs/zfs/pull/14493 [3] https

[pve-devel] [PATCH zfsonlinux 1/2] update zfs submodule to 2.1.12

2023-06-13 Thread Stoiko Ivanov
patches still applied cleanly Signed-off-by: Stoiko Ivanov --- upstream | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/upstream b/upstream index e25f9131..86783d7d 16 --- a/upstream +++ b/upstream @@ -1 +1 @@ -Subproject commit e25f9131d679692704c11dc0c1df6d4585b70c35

[pve-devel] [PATCH container] setup: template_fixup: remove bogus LXC_NAME line from /etc/hosts

2023-06-09 Thread Stoiko Ivanov
] https://nixos.wiki/wiki/Proxmox_Linux_Container Signed-off-by: Stoiko Ivanov --- src/PVE/LXC/Setup/Alpine.pm| 2 ++ src/PVE/LXC/Setup/ArchLinux.pm | 2 ++ src/PVE/LXC/Setup/Base.pm | 11 +++ src/PVE/LXC/Setup/CentOS.pm| 2 ++ src/PVE/LXC/Setup/Fedora.pm| 2 ++ src/PVE

[pve-devel] [PATCH http-server] proxy request: handle missing content-type header

2023-06-09 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- src/PVE/APIServer/AnyEvent.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/PVE/APIServer/AnyEvent.pm b/src/PVE/APIServer/AnyEvent.pm index 6831a86..1fd7a74 100644 --- a/src/PVE/APIServer/AnyEvent.pm +++ b/src/PVE/APIServer/AnyEvent.pm

[pve-devel] [PATCH container] setup: systemd-network: use correct values for dhcp-modes

2023-06-09 Thread Stoiko Ivanov
sue is only cosmetic for now. Noticed with a current arch-linux container Signed-off-by: Stoiko Ivanov --- src/PVE/LXC/Setup/Base.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/LXC/Setup/Base.pm b/src/PVE/LXC/Setup/Base.pm index c88bf03..5534397 100644 --- a/src/

[pve-devel] [PATCH storage] cifs: use empty string instead of / as default directory

2023-03-21 Thread Stoiko Ivanov
type cifs... ``` * the cifs_is_mounted helper does not recognize it as being mounted (as the source now has a / in the end) * attempting to mount leads to ``` mount error(16): Device or resource busy ``` noticed after upgrading and having a cifs storage mounted Signed-off-by: Stoiko Ivanov --- PVE

[pve-devel] [PATCH proxmox-acme 0/2] add missing _clearaccountconf_mutable and improve check-missing script

2023-02-21 Thread Stoiko Ivanov
such issues (now it caught the missing _clearaccountconf_mutable). Patches are ordered inversely to their implementation, so that `make deb` does not fail on the first commit. Stoiko Ivanov (2): proxmox-acme: add empty _clearaccountconf_mutable helper tests: add non-word boundary to present

[pve-devel] [PATCH proxmox-acme 1/2] proxmox-acme: add empty _clearaccountconf_mutable helper

2023-02-21 Thread Stoiko Ivanov
it is used by dns_cf.sh. reported in our community forum: https://forum.proxmox.com/threads/.122961/ Signed-off-by: Stoiko Ivanov --- src/proxmox-acme | 4 1 file changed, 4 insertions(+) diff --git a/src/proxmox-acme b/src/proxmox-acme index 8d022c6..a796547 100644 --- a/src/proxmox-acme

[pve-devel] [PATCH proxmox-acme 2/2] tests: add non-word boundary to present functions

2023-02-21 Thread Stoiko Ivanov
error which is only hit very seldomly) Signed-off-by: Stoiko Ivanov <s.iva...@proxmox.com> --- src/test/check-missing-functions| 4 ++-- src/test/missing-functions.expected | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/test/check-missing-functions b/src/test/c

[pve-devel] [PATCH zfsonlinux] update zfs submodule to 2.1.9 and refresh patches

2023-01-26 Thread Stoiko Ivanov
mostly drop patches we already applied intermittently Signed-off-by: Stoiko Ivanov --- This supersedes the patch from https://lists.proxmox.com/pipermail/pve-devel/2023-January/05.html 2.1.9 was released yesterday and addresses exactly the 2 issues with 2.1.8 noted there did some minimal

[pve-devel] [PATCH zfsonlinux] update zfs submodule to 2.1.8 and refresh patches

2023-01-24 Thread Stoiko Ivanov
mostly drop patches we already applied intermittently Signed-off-by: Stoiko Ivanov --- did some minimal testing: * running ztest on a VM * having a few containers with replication setup and migrating one of them * creating a PBS-backup of a VM and then again (to verify that incremental dirty

Re: [pve-devel] [RFC manager] vzdump: exclude zfs control dirs by default

2023-01-17 Thread Stoiko Ivanov
nt namespace), which in turn fails (because the snapshot is already mounted. w/ w/o a potential adaptation of the commit message: Tested-by: Stoiko Ivanov Reviewed-by: Stoiko Ivanov > storage will fail (because an attempt to `mkdir > /path/to/target/.zfs/snapshot/XXX`

[pve-devel] [PATCH zfsonlinux] fix #4440: cherry-pick patch for mountpoint=legacy on /

2023-01-02 Thread Stoiko Ivanov
pve-1 / zfs defaults 0 0" >> /mnt/etc/fstab` * `zpool export rpool` * reboot - the boot breaks with zfs-initramfs 2.1.7-pve1 but works with this patch applied Signed-off-by: Stoiko Ivanov --- The current changes on zfs-2.1.8-staging could all be applied without too much expected fallo

[pve-devel] [PATCH zfsonlinux 0/3] update to 2.1.7

2022-12-02 Thread Stoiko Ivanov
://github.com/openzfs/zfs/pull/14162/commits/52e658edd7afbe66149da6efec467633868ca03c Stoiko Ivanov (3): update zfs submodule to 2.1.7 and refresh patches trim: clean up, fix d/control: add libudev-dev and libaio-dev to build-depends debian/control| 2 + ...ith

[pve-devel] [PATCH zfsonlinux 2/3] trim: clean up, fix

2022-12-02 Thread Stoiko Ivanov
of if tree * shellcheck-clean the script (cherry picked from debian-upstream[0] commit 769a09407c6b65db981804a05a81ea63d004ebeb) [0] https://salsa.debian.org/zfsonlinux-team/zfs Signed-off-by: Stoiko Ivanov --- .../zfsutils-linux/usr/lib/zfs-linux/trim | 74 --- 1 file changed

[pve-devel] [PATCH zfsonlinux 3/3] d/control: add libudev-dev and libaio-dev to build-depends

2022-12-02 Thread Stoiko Ivanov
noticed by lintian on my system (after a new install) Signed-off-by: Stoiko Ivanov --- debian/control | 2 ++ 1 file changed, 2 insertions(+) diff --git a/debian/control b/debian/control index 7322dc8a..b6305e0a 100644 --- a/debian/control +++ b/debian/control @@ -5,12 +5,14 @@ Maintainer

[pve-devel] [PATCH installer] create lvm: improve rounding/alignment for non-pve products

2022-11-28 Thread Stoiko Ivanov
This commit follows 1a5fa7b0936381314f613e525255078093f7f258 for PMG and PBS installations. without it installation fails due to one missing extent when creating the root LV. minimally tested on a VM of mine Signed-off-by: Stoiko Ivanov --- proxinstall | 1 + 1 file changed, 1 insertion

[pve-devel] [PATCH zfsonlinux 1/2] cherry-pick a few patches from zfs-2.1.7-staging

2022-10-17 Thread Stoiko Ivanov
/master [1] https://github.com/openzfs/zfs/issues/14010 Signed-off-by: Stoiko Ivanov --- ...ramfs-use-mount.zfs-instead-of-mount.patch | 74 +++ .../0013-etc-mask-zfs-load-key.service.patch | 37 ++ ...ould-have-its-argument-list-marked-v.patch | 40 ++ debian

[pve-devel] [PATCH zfsonlinux 2/2] install zfs-load-key.service

2022-10-17 Thread Stoiko Ivanov
following upstream shipping it as a symlnk to /dev/null (to mask it) follows commit b18419d7068b7ebcaa6dfbee85263177feffa711 from debian-upstream: https://salsa.debian.org/zfsonlinux-team/zfs/ Signed-off-by: Stoiko Ivanov --- debian/zfsutils-linux.install | 1 + 1 file changed, 1 insertion

[pve-devel] [PATCH zfsonlinux 0/2] add patches already on zfs-2.1.7-staging upstream

2022-10-17 Thread Stoiko Ivanov
and then changed to our repositories is the one situation I think might cause issues) The remaining patches were included due to being quite limited in what they do. minimally tested on 2 VMs of mine with the current tip of pve-kernel/master and on a hardware machine with ZFS on / Stoiko Ivanov (2): cherry

[pve-devel] [PATCH zfsonlinux 5/6] debian/lintian-overrides: future-proof

2022-10-04 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- debian/libzfsbootenv1linux.lintian-overrides | 2 +- debian/zfs-test.lintian-overrides| 18 +- debian/zfsutils-linux.lintian-overrides | 15 +++ 3 files changed, 17 insertions(+), 18 deletions(-) diff --git a/debian

[pve-devel] [PATCH zfsonlinux 2/6] trim: determine if a device uses nvme transport with lsblk (Closes: #990745)

2022-10-04 Thread Stoiko Ivanov
Thanks to Miao Wang for get_transp() function (cherry picked from debian-upstream[0] commit 1f5433b15e4f7c823983bb90390c4b023f3d1948) [0] https://salsa.debian.org/zfsonlinux-team/zfs Signed-off-by: Stoiko Ivanov --- .../zfsutils-linux/usr/lib/zfs-linux/trim | 29 +++ 1 file

[pve-devel] [PATCH zfsonlinux 3/6] Symlink zfs, zpool to /bin/ for non-root usage. (Closes: #979437)

2022-10-04 Thread Stoiko Ivanov
(cherry picked from debian-upstream[0] commit 9fe812af0c9fb0382b05b300244f120179e201e7) [0] https://salsa.debian.org/zfsonlinux-team/zfs Signed-off-by: Stoiko Ivanov --- debian/zfsutils-linux.links | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 debian/zfsutils-linux.links diff

[pve-devel] [PATCH zfsonlinux 1/6] update zfs submodule to 2.1.6 and refresh patches

2022-10-04 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- .../0010-arcstat-Fix-integer-division-with-python3.patch| 2 +- ...1-arc-stat-summary-guard-access-to-l2arc-MFU-MRU-stats.patch | 2 +- upstream| 2 +- 3 files changed, 3 insertions(+), 3 deletions

[pve-devel] [PATCH zfsonlinux 4/6] Symlink zpool_influxdb to /bin. (Closes: #1001446)

2022-10-04 Thread Stoiko Ivanov
(cherry picked from debian-upstream[0] commit 4ce9e9b7a221ba1a84a921a34db582a2ef68b950) [0] https://salsa.debian.org/zfsonlinux-team/zfs Signed-off-by: Stoiko Ivanov --- debian/zfsutils-linux.links | 1 + 1 file changed, 1 insertion(+) diff --git a/debian/zfsutils-linux.links b/debian/zfsutils

[pve-devel] [PATCH zfsonlinux 6/6] debian/zfs-initramfs.lintian-overrides add overrides file

2022-10-04 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- debian/zfs-initramfs.lintian-overrides | 1 + 1 file changed, 1 insertion(+) create mode 100644 debian/zfs-initramfs.lintian-overrides diff --git a/debian/zfs-initramfs.lintian-overrides b/debian/zfs-initramfs.lintian-overrides new file mode 100644 index

[pve-devel] [PATCH zfsonlinux 0/6] update to ZFS 2.1.6

2022-10-04 Thread Stoiko Ivanov
. tested the lintian changes with the current versions in bullseye and bullseye-backports. minimally tested by building a 5.19 kernel and running ztest for 20 minutes Stoiko Ivanov (6): update zfs submodule to 2.1.6 and refresh patches trim: determine if a device uses nvme transport with lsblk

Re: [pve-devel] [PATCH manager] postinst: migrate/update APT auth config

2022-09-13 Thread Stoiko Ivanov
Thanks for the patch! 2-3 small issues and one nit: On Tue, 13 Sep 2022 14:30:35 +0200 Fabian Grünbichler wrote: > missed when switching over to Proxmox::RS::Subscription, which stores > the same info in the product-specific /etc/apt/auth.conf.d/pve.conf . > > the top-level file might contain

[pve-devel] [PATCH manager 2/2] report: stabilize order of guests and network

2022-09-12 Thread Stoiko Ivanov
-by: Stoiko Ivanov --- PVE/Report.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Report.pm b/PVE/Report.pm index 3c61c1e4..b8bceb24 100644 --- a/PVE/Report.pm +++ b/PVE/Report.pm @@ -68,7 +68,7 @@ my $init_report_cmds = sub { ], }, network

[pve-devel] [PATCH manager 1/2] report: add proxmox-boot-tool status output

2022-09-12 Thread Stoiko Ivanov
while needed seldomly we had a few cases recently where this would have saved the user and us one roundtrip. adding to storage, to be close to the `findmnt` output (which usually tells us if the system is booted in efi or legacy mode) Signed-off-by: Stoiko Ivanov --- alternatively could also

[pve-devel] [PATCH manager 0/2] minor improvements to pvereport

2022-09-12 Thread Stoiko Ivanov
these two patches add small improvements to pvereport Stoiko Ivanov (2): report: add proxmox-boot-tool status output report: stabilize order of guests and network PVE/Report.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.30.2

[pve-devel] [PATCH pve-kernel-meta] proxmox-boot: re-add include of helper-functions

2022-09-12 Thread Stoiko Ivanov
for /. Signed-off-by: Stoiko Ivanov --- bin/grub-install-wrapper | 2 ++ 1 file changed, 2 insertions(+) diff --git a/bin/grub-install-wrapper b/bin/grub-install-wrapper index 90c144e..69bd878 100755 --- a/bin/grub-install-wrapper +++ b/bin/grub-install-wrapper @@ -2,6 +2,8 @@ set -e +. /usr/share/pve

Re: [pve-devel] [RFC cluster] pmxcfs startup: order before MTAs

2022-09-05 Thread Stoiko Ivanov
ase of a mail for 'root' being in the > > mailq: postfix tries to deliver the mail - pvemailforward tries to > > look up the destination address in /etc/pve/user.cfg and gets a > > connection refused since pmxcfs is not running yet. > > > > reported via our community-forum:

[pve-devel] [PATCH access-control] auth ldap/ad: compare group member dn case-insensitively

2022-08-29 Thread Stoiko Ivanov
forum: https://forum.proxmox.com/threads/.113387 tested against a local test-vm used for reproducing the issue. [0] https://ldapwiki.com/wiki/Distinguished%20Name%20Case%20Sensitivity Signed-off-by: Stoiko Ivanov --- src/PVE/Auth/LDAP.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

Re: [pve-devel] Security vulnerability in Proxmox backup server code

2022-08-17 Thread Stoiko Ivanov
Hi, On Mon, 15 Aug 2022 21:40:14 +0200 (CEST) "distortedbit.pro--- via pve-devel" wrote: > > I have discovered a potential security vulnerability and wanted to bring > > your attention to it. Please see > > > > https://gist.github.com/DistortedBit/6d3cd9c8d14a22376c6f43344306aaba > > > And 

[pve-devel] [PATCH zfsonlinux 1/3] update submodule and patches to ZFS

2022-06-24 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- debian/patches/0005-Enable-zed-emails.patch | 4 ++-- .../0009-Patch-move-manpage-arcstat-1-to-arcstat-8.patch | 4 ++-- upstream | 2 +- 3 files changed, 5 insertions(+), 5 deletions

[pve-devel] [PATCH zfsonlinux 3/3] d/control: add new zfs-dracut package

2022-06-24 Thread Stoiko Ivanov
following debian upstream (which pulled it in from Ubuntu in 44915cf387d45a123b11a8c24d3f30a8fdbcc532) Signed-off-by: Stoiko Ivanov --- debian/control| 13 + debian/zfs-dracut.install | 2 ++ 2 files changed, 15 insertions(+) create mode 100644 debian/zfs

[pve-devel] [PATCH zfsonlinux 2/3] Build with libcurl for new keylocation=https://

2022-06-24 Thread Stoiko Ivanov
are in upstream/lib/libzfs/libzfs_crypto.c) Signed-off-by: Stoiko Ivanov --- debian/control | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/debian/control b/debian/control index 06ec27b7..b6029e8e 100644 --- a/debian/control +++ b/debian/control @@ -6,6 +6,7 @@ Build-Depends: abigail

[pve-devel] [PATCH zfsonlinux 0/3] Update to ZFS 2.1.5

2022-06-24 Thread Stoiko Ivanov
https://forum.proxmox.com/threads/.109541 minimally tested on 2 VMs with storage-replication setup and by running ztest there for 20 minutes Stoiko Ivanov (3): update submodule and patches to ZFS Build with libcurl for new keylocation=https:// d/control: add new zfs-dracut package debian

[pve-devel] [RFC pve-kernel 1/2] d/rules: kconfig: disable CONFIG_UBSAN

2022-05-30 Thread Stoiko Ivanov
reenabled with 5.15.0-14.14/ ddcf9715e1d13cea21ac90014f848e0c4c0ad23c last December) based on reports about UBSAN warnings in our community-forum: https://forum.proxmox.com/threads/.110097/ https://forum.proxmox.com/threads/.109368/ Signed-off-by: Stoiko Ivanov --- debian/rules | 3 ++- 1 file changed

[pve-devel] [RFC pve-kernel 0/2] disable UBSAN in kernel config

2022-05-30 Thread Stoiko Ivanov
inclined to agree with them. rationale in patch 1/2 patch 2/2 contains the changes for the abi-change Stoiko Ivanov (2): d/rules: kconfig: disable CONFIG_UBSAN update ABI file for 5.15.35-2-pve abi-prev-5.15.35-1-pve | 26217 --- abi-prev-5.15.35-2-pve

Re: [pve-devel] [PATCH pve-kernel] d/rules: kconfig: do not enable intel_iommu by default

2022-05-13 Thread Stoiko Ivanov
On Fri, 13 May 2022 11:31:42 +0200 Thomas Lamprecht wrote: > Am 5/13/22 um 10:57 schrieb Stoiko Ivanov: > ..snip.. > > alternatively we could document this in the 7.2 release notes and ask > > users of problematic hardware to set this explicitly > > This all resemble

[pve-devel] [PATCH zfsonlinux] fix #4052 cherry-pick ZERO_RANGE correction

2022-05-13 Thread Stoiko Ivanov
the commit is already queued up for 2.1.5 upstream. Since the 2.1.5 release is not in the makings yet AFAICS and pulling in all the other changes has some potential for regressions - I went for this single cherry-pick Signed-off-by: Stoiko Ivanov --- quickly tested by compiling a kernel

[pve-devel] [PATCH pve-kernel] d/rules: kconfig: do not enable intel_iommu by default

2022-05-13 Thread Stoiko Ivanov
forum: https://forum.proxmox.com/threads/.109368 Signed-off-by: Stoiko Ivanov --- tested by installing on a HP G8 (and starting a minimal VM and running stress-ng -d 2 for a minute), and on 2 VMs alternatively we could document this in the 7.2 release notes and ask users of problematic hardware

[pve-devel] [PATCH proxmox-perl-rs] common: d/control: break/replace libpve-rs-perl (<< 0.6.0)

2022-05-09 Thread Stoiko Ivanov
://www.debian.org/doc/debian-policy/ch-relationships.html#s-breaks Signed-off-by: Stoiko Ivanov --- Sadly was not able to trigger this issue on any of my systems (and a VM with a fresh 7.1 ISO install). common/pkg/debian/control | 2 ++ 1 file changed, 2 insertions(+) diff --git a/common/pkg/debian

[pve-devel] [PATCH installer] zfs compression - fix wrongly added zle option

2022-05-04 Thread Stoiko Ivanov
introduced in 38aa09be4794307145a0acf37f66aa7e2fac7e62 the newly added compression mode lze - does not exist (zle does) Signed-off-by: Stoiko Ivanov --- quickly tested on a VM by scp'ing the installer script in debug mode. proxinstall | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [pve-devel] [PATCH storage] Diskmanage: check for extended partitions

2022-05-03 Thread Stoiko Ivanov
On Tue, 3 May 2022 13:08:47 +0200 Dominik Csapak wrote: > those would not get assinged a usage and thus appear in the list > when we want to select a partition (e.g. for creating a zpool) > > since we cannot do anything with such a partition, return the usage > 'Extended Partition' for these.

[pve-devel] [PATCH storage 0/2] rbd: improve errormessages on missing/wrong poolname

2022-05-03 Thread Stoiko Ivanov
ran into the issues while configuring an external rbd-storage on my node (and not adding the correct poolname) Issue is cosmetic in nature - but the new messages should help in identifying where the problem is rooted Stoiko Ivanov (2): rbd: add fallback default poolname 'rbd' to status rbd

[pve-devel] [PATCH storage 2/2] rbd: warn if no stats for a pool could be gathered

2022-05-03 Thread Stoiko Ivanov
happens in case of a mistyped poolname, and the new message should be more helpful than: `Use of uninitialized value $free in addition (+) at \ /usr/share/perl5/PVE/Storage/RBDPlugin.pm line 64` Signed-off-by: Stoiko Ivanov --- PVE/Storage/RBDPlugin.pm | 5 + 1 file changed, 5 insertions

[pve-devel] [PATCH storage 1/2] rbd: add fallback default poolname 'rbd' to status

2022-05-03 Thread Stoiko Ivanov
of uninitialized value in string eq at \ /usr/share/perl5/PVE/Storage/RBDPlugin.pm line 633` (e.g. in the journal from pvestatd) Signed-off-by: Stoiko Ivanov --- PVE/Storage/RBDPlugin.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/PVE/Storage/RBDPlugin.pm b/PVE/Storage

[pve-devel] [PATCH qemu-server/pve-manager] notify users about virtio-gl prerequisites

2022-04-29 Thread Stoiko Ivanov
without GPU (where it cannot work). qemu-server: Stoiko Ivanov (1): check prerequisites for virtio-gl display PVE/QemuServer.pm | 11 +++ 1 file changed, 11 insertions(+) pve-manager: Stoiko Ivanov (1): ui: qemu: show hint about prerequisites for virgl display www/manager6/qemu

[pve-devel] [PATCH qemu-server 1/1] check prerequisites for virtio-gl display

2022-04-29 Thread Stoiko Ivanov
-off-by: Stoiko Ivanov --- PVE/QemuServer.pm | 11 +++ 1 file changed, 11 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 8e7cfb8..1290f33 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -1880,6 +1880,17 @@ sub print_vga_device { $pciaddr

[pve-devel] [PATCH manager 1/1] ui: qemu: show hint about prerequisites for virgl display

2022-04-29 Thread Stoiko Ivanov
since there is no hard dependency on the needed libraries (and we cannot easily check if a fitting GPU is present in the GUI) - notify the user about the prerequisites - else the error-messages might be a bit confusing [0] Suggested-by: Thomas Lamprecht Signed-off-by: Stoiko Ivanov [0] https

[pve-devel] [PATCH pve-kernel-meta] proxmox-boot: fix #3729 add --graceful to bootctl invocation

2022-04-25 Thread Stoiko Ivanov
` command. see also: https://github.com/systemd/systemd/issues/13603 Signed-off-by: Stoiko Ivanov --- originally sent as part of a series: https://lists.proxmox.com/pipermail/pve-devel/2022-March/052054.html as: https://lists.proxmox.com/pipermail/pve-devel/2022-March/052052.html however since

[pve-devel] [PATCH installer 1/2] fix #3188: update hdsize spin-button on disk-selection change

2022-04-19 Thread Stoiko Ivanov
is not provided. Additionally the bogus 'zfs' argument to the create_raid_advanced_grid was dropped. Tested with a VM with 2x 100G disks, and one with 20G Signed-off-by: Stoiko Ivanov --- proxinstall | 78 ++--- 1 file changed, 50 insertions

[pve-devel] [PATCH installer 2/2] fix #3587: make hdsize configurable for btrfs setups

2022-04-19 Thread Stoiko Ivanov
-by: Stoiko Ivanov --- proxinstall | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/proxinstall b/proxinstall index 5360b08..93f2443 100755 --- a/proxinstall +++ b/proxinstall @@ -1341,7 +1341,7 @@ sub extract_data { my $logical_bsize = @$hd[4

[pve-devel] [PATCH installer 0/2] fix 2 bugs related to hdsize selection

2022-04-19 Thread Stoiko Ivanov
) Stoiko Ivanov (2): fix #3188: update hdsize spin-button on disk-selection change fix #3587: make hdsize configurable for btrfs setups proxinstall | 95 - 1 file changed, 65 insertions(+), 30 deletions(-) -- 2.30.2

[pve-devel] [PATCH docs 0/2] update proxmox-boot-tool docs

2022-04-12 Thread Stoiko Ivanov
the 2 patches are independent of each other (I had overlooked 3479 for a while) Stoiko Ivanov (2): zfs: fix #3479 rephrase boot-loader description. sys: boot: minimally document kernel version pinning local-zfs.adoc | 8 ++-- system-booting.adoc | 48

[pve-devel] [PATCH docs 2/2] sys: boot: minimally document kernel version pinning

2022-04-12 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- system-booting.adoc | 48 + 1 file changed, 48 insertions(+) diff --git a/system-booting.adoc b/system-booting.adoc index 2b96409..7d8ff47 100644 --- a/system-booting.adoc +++ b/system-booting.adoc @@ -68,6 +68,7

[pve-devel] [PATCH docs 1/2] zfs: fix #3479 rephrase boot-loader description.

2022-04-12 Thread Stoiko Ivanov
since using proxmox-boot-tool also for legacy systems the distinction of p-b-t vs grub is not accurate anymore. Signed-off-by: Stoiko Ivanov --- local-zfs.adoc | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/local-zfs.adoc b/local-zfs.adoc index e77595f..ab0f6ad

[pve-devel] [PATCH pve-kernel-meta v3 3/8] proxmox-boot: add helpers to check for bootloader configs

2022-03-11 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- bin/proxmox-boot-tool| 4 ++-- proxmox-boot/functions | 16 proxmox-boot/zz-proxmox-boot | 4 ++-- 3 files changed, 20 insertions(+), 4 deletions(-) diff --git a/bin/proxmox-boot-tool b/bin/proxmox-boot-tool index 4ca3025

[pve-devel] [PATCH pve-kernel-meta v3 6/8] proxmox-boot: init bootloaders based on esp contents

2022-03-11 Thread Stoiko Ivanov
in addition to installing the boot loader for the current bootmode (grub for legacy, systemd-boot for uefi) also install the bootloader if its config is already present on the ESP. Signed-off-by: Stoiko Ivanov --- bin/proxmox-boot-tool | 26 -- 1 file changed, 24

[pve-devel] [PATCH pve-kernel-meta v3 1/8] rename pve-efiboot-manual-kernels to proxmox-boot-manual-kernels

2022-03-11 Thread Stoiko Ivanov
was forgotten during the general renaming of pve-efiboot -> proxmox-boot. follows commit 8c0a22adfe15dc00cf2194647bb254201d8d187b Signed-off-by: Stoiko Ivanov --- debian/pve-kernel-helper.postinst | 4 proxmox-boot/functions| 2 +- 2 files changed, 5 insertions(+), 1 delet

[pve-devel] [PATCH pve-kernel-meta v3 4/8] proxmox-boot: refresh based on bootloader config instead of bootmode

2022-03-11 Thread Stoiko Ivanov
should be fine with it. Additionally adapt the output of `p-b-t status` to the new paths [0] https://systemd.io/BOOT_LOADER_SPECIFICATION/ [1] section 13.3.1.3 of https://uefi.org/sites/default/files/resources/UEFI_Spec_2_9_2021_03_18.pdf Signed-off-by: Stoiko Ivanov --- bin/proxmox-boot-tool

[pve-devel] [PATCH installer v3 2/2] use proxmox-boot-tool for all uefi installs

2022-03-11 Thread Stoiko Ivanov
grub by itself is only used for btrfs/ext4/xfs installs on legacy systems for zfs proxmox-boot-tool is used in legacy and uefi mode Signed-off-by: Stoiko Ivanov --- proxinstall | 80 ++--- 1 file changed, 14 insertions(+), 66 deletions(-) diff

[pve-devel] [PATCH pve-kernel-meta v3 2/8] proxmox-boot: add reinit subcommand

2022-03-11 Thread Stoiko Ivanov
to iterate over all configured ESPs and refresh the boot-loader installations. the init function was changed to not run refresh directly - to prevent refresh from running once for each ESP currently reinit does not imply refresh Signed-off-by: Stoiko Ivanov --- bin/grub-install-wrapper | 19

[pve-devel] [PATCH pve-kernel-meta/pve-installer v3] improve boot-mode switching

2022-03-11 Thread Stoiko Ivanov
ox.com/pipermail/pve-devel/2022-February/051732.html pve-kernel-meta: Stoiko Ivanov (8): rename pve-efiboot-manual-kernels to proxmox-boot-manual-kernels proxmox-boot: add reinit subcommand proxmox-boot: add helpers to check for bootloader configs proxmox-boot: refresh based on bootloader

[pve-devel] [PATCH pve-kernel-meta v3 7/8] proxmox-boot: allow to manually specify bootloader

2022-03-11 Thread Stoiko Ivanov
CD, chrooting and manually running the necessary p-b-t commands. Signed-off-by: Stoiko Ivanov --- bin/proxmox-boot-tool | 60 +++ 1 file changed, 38 insertions(+), 22 deletions(-) diff --git a/bin/proxmox-boot-tool b/bin/proxmox-boot-tool index 9731204

[pve-devel] [PATCH pve-kernel-meta v3 8/8] proxmox-boot: fix #3729 add --graceful to bootctl invocation

2022-03-11 Thread Stoiko Ivanov
` command. see also: https://github.com/systemd/systemd/issues/13603 Signed-off-by: Stoiko Ivanov --- bin/proxmox-boot-tool | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/proxmox-boot-tool b/bin/proxmox-boot-tool index 164ae91..c2704af 100755 --- a/bin/proxmox-boot-tool

[pve-devel] [PATCH installer v3 1/2] remove /mnt/hostrun after install

2022-03-11 Thread Stoiko Ivanov
else the directory lingers around on fresh systems. follows 8d7ddbde84b3ebde29108b2080977b03853b2b69 Signed-off-by: Stoiko Ivanov --- proxinstall | 1 + 1 file changed, 1 insertion(+) diff --git a/proxinstall b/proxinstall index a39d405..bddcc5d 100755 --- a/proxinstall +++ b/proxinstall

[pve-devel] [PATCH pve-kernel-meta v3 5/8] proxmox-boot: remove now obsolete EFI/proxmoxdir if it exists

2022-03-11 Thread Stoiko Ivanov
this can be dropped in the next major version - so keeping it as separate commit. Signed-off-by: Stoiko Ivanov --- proxmox-boot/zz-proxmox-boot | 6 ++ 1 file changed, 6 insertions(+) diff --git a/proxmox-boot/zz-proxmox-boot b/proxmox-boot/zz-proxmox-boot index fa0ea4a..39e3bea 100755

[pve-devel] [PATCH installer] fix #3905: allow lze/gzip/zstd compression for ZFS

2022-03-11 Thread Stoiko Ivanov
Since all our zfs installs use proxmox-boot-tool the compatibility is not an issue anymore Signed-off-by: Stoiko Ivanov --- tested the zstd option by pushing the updated proxinstall to the current 7.1-2 ISO proxinstall | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[pve-devel] [PATCH zfsonlinux 1/2] update submodule and patches to ZFS 2.1.3

2022-03-11 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- ...META-and-DCH-consistency-in-autoconf.patch | 4 +- debian/patches/0005-Enable-zed-emails.patch | 17 +- ...md-unit-for-importing-specific-pools.patch | 2 +- .../0012-Fix-zvol_open-lock-inversion.patch | 212 -- debian/patches/series

[pve-devel] [PATCH zfsonlinux 0/2] update to ZFS 2.1.3

2022-03-11 Thread Stoiko Ivanov
with the latest 5.13 kernel on 2 VMs (running ztest) Stoiko Ivanov (2): update submodule and patches to ZFS 2.1.3 add zfs-scrub timers+services to zfsutils-linux ...META-and-DCH-consistency-in-autoconf.patch | 4 +- debian/patches/0005-Enable-zed-emails.patch | 17 +- ...md-unit

[pve-devel] [PATCH zfsonlinux 2/2] add zfs-scrub timers+services to zfsutils-linux

2022-03-11 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- debian/zfsutils-linux.install | 3 +++ 1 file changed, 3 insertions(+) diff --git a/debian/zfsutils-linux.install b/debian/zfsutils-linux.install index b7501b30..4e4554f8 100644 --- a/debian/zfsutils-linux.install +++ b/debian/zfsutils-linux.install @@ -9,6 +9,9

[pve-devel] [PATCH proxmox-acme 0/2] add missing readdomainconf and helper script

2022-03-04 Thread Stoiko Ivanov
- I thought it might make sense to have it in the repo. Stoiko Ivanov (2): plugin-caller: add _readdomainconf stub add shellscript to find needed functions not provided by proxmox-acme check-missing-functions | 13 + src/proxmox-acme| 5 + 2 files changed, 18

<    1   2   3   4   5   6   >