in order to be consistent with the renaming of pve-efiboot-tool to
proxmox-boot-tool.
Sending as separate patch, since it changes and removes a file in
'/etc', which could be considered part of the external 'api' of
proxmox-boot-tool
Co-authored-by: Thomas Lamprecht
Signed-off-by: Stoiko Ivanov
-by: Thomas Lamprecht
Signed-off-by: Stoiko Ivanov
---
v1->v2:
* newly added (as an optional addition - feel free to not apply it)
proxmox-boot/000_proxmox_boot_header | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/proxmox-boot/000_proxmox_boot_header
b/proxmox-b
task (after a kernel install/removal)
and for PVE_EFIBOOT_UNSHARED, which is set by proxmox-boot-tool when
running `proxmox-boot-tool refresh.`
Signed-off-by: Stoiko Ivanov
---
proxmox-boot/000_proxmox_boot_header | 22 ++
proxmox-boot/Makefile| 4
2 files
in order to be consistent with the renaming of pve-efiboot-tool to
proxmox-boot-tool.
Sending as separate patch, since it changes and removes a file in
'/etc', which could be considered part of the external 'api' of
proxmox-boot-tool
Signed-off-by: Stoiko Ivanov
---
debian/pve-kernel
We will be using the mechanics also for ZFS systems booting with BIOS
legacy boot, and the tool is used also in PMG and PBS.
A symlink is kept in place for compatibility reasons
Signed-off-by: Stoiko Ivanov
---
Makefile | 2 +-
bin/Makefile
currently simply checking if $ESP_LIST exists, and indicating via
the exit status if proxmox-boot-tool is used for booting the system.
Signed-off-by: Stoiko Ivanov
---
bin/proxmox-boot-tool | 20
1 file changed, 20 insertions(+)
diff --git a/bin/proxmox-boot-tool b/bin
for grub-install are taken from the pve-installer.
The approach is inspired by @avw in our community-forum [0].
[0]
https://forum.proxmox.com/threads/zfs-error-no-such-device-error-unknown-filesystem-entering-rescue-mode.75122/post-374799
Signed-off-by: Stoiko Ivanov
---
best viewed with `git show -w
if
`proxmox-boot-tool status` indicates that proxmox-boot is used and
errors out in that case, and runs the actual grub-install else.
Signed-off-by: Stoiko Ivanov
---
bin/Makefile | 1 +
bin/grub-install-wrapper | 12
bin/proxmox-boot-tool| 2
t's missing (at least):
* support in the installer
* the renaming is not quite through (the kernel-hooks are still containing
pve/efi in their name)
* testing the removal part of the$kernel-sync
pve-kernel-meta:
Stoiko Ivanov (7):
proxmox-boot-tool: rename from pve-efiboot-tool
proxmox-boot-t
proxmox-boot-tool now supports configuring grub to boot from the ESPs
the installer creates on all (bootable) disks - use this approach
for zfs installs.
Signed-off-by: Stoiko Ivanov
---
best viewed with `git show -w`
proxinstall | 26 +-
1 file changed, 13 insertions
This is mostly in preparation for renaming pve-efiboot-uuids into
proxmox-boot-uuids, but can help in general (since each duplicate uuid
causes excessive disk i/o upon kernel upgrades).
Signed-off-by: Stoiko Ivanov
---
bin/proxmox-boot-tool | 4
1 file changed, 4 insertions(+)
diff --git
(at least):
* support in the installer
* the renaming is not quite through (the kernel-hooks are still containing
pve/efi in their name)
* testing the removal part of the kernel-sync
Stoiko Ivanov (2):
proxmox-boot-tool: rename from pve-efiboot-tool
proxmox-boot-tool: handle legacy boot zfs
is inspired by @avw in our community-forum [0].
[0]
https://forum.proxmox.com/threads/zfs-error-no-such-device-error-unknown-filesystem-entering-rescue-mode.75122/post-374799
Signed-off-by: Stoiko Ivanov
---
best viewed with `git show -w`
bin/proxmox-boot-tool | 21 ++
proxmox-boot/zz
We will be using the mechanics also for ZFS systems booting with BIOS
legacy boot, and the tool is used also in PMG and PBS.
A symlink is kept in place for compatibility reasons
Signed-off-by: Stoiko Ivanov
---
Makefile| 2 +-
bin/Makefile
.
The code is adapted from the renderer in
PVE::Inotify::__write_etc_network_interfaces.
Tested on a virtual PVE instance.
Signed-off-by: Stoiko Ivanov
---
PVE/API2/Network.pm | 37 +
1 file changed, 37 insertions(+)
diff --git a/PVE/API2/Network.pm b/PVE/API2
Thanks for the patch!
can see that it could help users, who (have to) navigate the installer
with a keyboard...
gave it a (very quick) spin with the check-pve make-target - in
general it seems ok to me
one thing that does not look too nice to me is the +/- buttons for integer
entry (click on
-account-register-dialog-does-not-accept-gtlds.87305/
Quickly tested (by using test@test.systems(|test)? on my test-installation)
Signed-off-by: Stoiko Ivanov
---
src/Toolkit.js | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/Toolkit.js b/src/Toolkit.js
index b011c38..6ae31ed 100644
primarily in order to warn users booting from ZFS with grub.
Signed-off-by: Stoiko Ivanov
Reviewed-By: Aaron Lauterer
---
* incorporated Dylan's excellent and almost sed'able feedback
* added Aaron's Reviewed-By tag despite sending a v2, since the content
did not change - hope that's ok
primarily in order to warn users booting from ZFS with grub.
Signed-off-by: Stoiko Ivanov
---
local-zfs.adoc | 36
1 file changed, 36 insertions(+)
diff --git a/local-zfs.adoc b/local-zfs.adoc
index 4819678..a003a7c 100644
--- a/local-zfs.adoc
+++ b/local
porting over the changes done in pmg-docs
Signed-off-by: Stoiko Ivanov
---
certificate-management.adoc | 31 +++
1 file changed, 15 insertions(+), 16 deletions(-)
diff --git a/certificate-management.adoc b/certificate-management.adoc
index 00633a1..065433d 100644
Signed-off-by: Stoiko Ivanov
---
2.0.4 was tagged earlier this week and contains a few minor fixes (including
Thomas' patch for zpool output).
Tested very roughly by running ztest on a VM
...-intend-continuation-from-removal-st.patch | 48 ---
debian/patches/series
.
the patch for pve-storage fixes the issue of failed result verification.
the patch for pve-manager is optional, but I thought that a pool, that never
has been scrubbed is worth an informational notice.
pve-storage:
Stoiko Ivanov (1):
disks: zfs: scan is only returned optionally
PVE/API2
the line is not present if a zpool has never been scrubbed before
(e.g. if it's freshly setup)
Signed-off-by: Stoiko Ivanov
---
PVE/API2/Disks/ZFS.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/PVE/API2/Disks/ZFS.pm b/PVE/API2/Disks/ZFS.pm
index 2884bb0..b815ee7 100644
--- a/PVE/API2
in case a zpool has not been yet scrubbed, there is no 'scan'
information in `zpool status` output.
Adding a informational text in that case might help users to notice
that something is not configured optimally (e.g. disabled cronjob)
Signed-off-by: Stoiko Ivanov
---
www/manager6/node/ZFS.js
patch aligns our package names with d.o
the remaining patches are mostly cosmetic cleanups picked up while diffing
d/rules with upstream. The added checkabi test seemed quick enough and
potentially worth it.
Stoiko Ivanov (4):
d/control: match package names to debian-upstream
d/rules: cosmetic
we don't build or ship udebs
Signed-off-by: Stoiko Ivanov
---
debian/rules | 7 ---
1 file changed, 7 deletions(-)
diff --git a/debian/rules b/debian/rules
index 06100b8e..fe09e2e1 100755
--- a/debian/rules
+++ b/debian/rules
@@ -84,13 +84,6 @@ override_dh_python3
/42ba750f8ca07625e9d58c14b46420768ab23c09
Signed-off-by: Stoiko Ivanov
---
Makefile | 8 +--
debian/control| 50 ++-
debian/libnvpair2linux.lintian-overrides | 1 -
...nvpair2linux.docs => libnvpair3linux.docs} | 0
install
off-by: Stoiko Ivanov
---
debian/control | 3 ++-
debian/rules | 6 ++
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/debian/control b/debian/control
index 4ab6bda4..619244e9 100644
--- a/debian/control
+++ b/debian/control
@@ -2,7 +2,8 @@ Source: zfs-linux
Section: contrib/ker
Signed-off-by: Stoiko Ivanov
---
debian/rules | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/debian/rules b/debian/rules
index 932153d2..06100b8e 100755
--- a/debian/rules
+++ b/debian/rules
@@ -29,13 +29,13 @@ override_dh_auto_configure:
--bindir=/usr/bin
This commit is a small performance optimization to the previous one:
`zpool list` is cheaper than `zpool import -d /dev..` (the latter
scans the disks in the provided directory for zfs signatures,
unconditionally)
Signed-off-by: Stoiko Ivanov
---
PVE/Storage/ZFSPoolPlugin.pm | 14
Signed-off-by: Stoiko Ivanov
---
PVE/Storage/ZFSPoolPlugin.pm | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/PVE/Storage/ZFSPoolPlugin.pm b/PVE/Storage/ZFSPoolPlugin.pm
index 105d802..be7b1b9 100644
--- a/PVE/Storage/ZFSPoolPlugin.pm
+++ b/PVE/Storage
owever in that case, if the (child) datasets were not mounted due to
a timeout, they will not get mounted (as before)
Stoiko Ivanov (3):
zfspoolplugin: activate_storage: minor cleanup
zfspoolplugin: check if mounted instead of imported
zfspoolplugin: check if imported before importing
PVE/S
and should not occur, if using our
tooling.
Signed-off-by: Stoiko Ivanov
---
PVE/Storage/ZFSPoolPlugin.pm | 27 ---
1 file changed, 24 insertions(+), 3 deletions(-)
diff --git a/PVE/Storage/ZFSPoolPlugin.pm b/PVE/Storage/ZFSPoolPlugin.pm
index be7b1b9..a524515 100644
--- a/PVE
dataset after booting the system
(but does not set the canmount option).
Signed-off-by: Stoiko Ivanov
---
rfc -> v1:
* incorporated Thomas' feedback (Thanks):
** we now check both properties mounted,canmount and only run mount -a
if the dataset is not mounted, but should be by con
Thanks for looking at the patch!
On Thu, 18 Feb 2021 13:20:55 +0100
Thomas Lamprecht wrote:
> On 18.02.21 12:33, Stoiko Ivanov wrote:
> > This patch addresses an issue we recently saw on a production machine:
> > * after booting a ZFS pool failed to get imported (due to an empty
(but does not set the canmount option)
Signed-off-by: Stoiko Ivanov
---
* sending as RFC since I have the feeling that I miss quite a few corner-cases.
* an alternative to getting the mounted property via `zfs get` might be
parsing /proc/mounts (but zfs get mounted does mostly just that +stating
Signed-off-by: Stoiko Ivanov
---
did a quick test on my zfs storage-replication testcluster:
* both systems failed to import their zfs pools upon boot (I'm quite sure
it's related to upstream commit 642d86af0d91b2bf88d5ea34cb6888b03c39c459)
* both systems were used for running the zfs testsuite
-off-by: Stoiko Ivanov
---
src/PVE/Certificate.pm | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/PVE/Certificate.pm b/src/PVE/Certificate.pm
index 5bc9848..31a7722 100644
--- a/src/PVE/Certificate.pm
+++ b/src/PVE/Certificate.pm
@@ -199,10 +199,8 @@ my $read_certificate
Thanks for looking into this!
On Wed, 10 Feb 2021 17:01:42 +0100
Oguz Bektas wrote:
> default to 0.0.0.0 to preserve backwards behavior
>
> Signed-off-by: Oguz Bektas
> ---
> PVE/Service/pveproxy.pm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git
the patch fixes a potential panic on systems running ZFS > 2.0.0 and
is already queued for inclusion in 2.0.3 - see [0] for a related
github issue.
[0] https://github.com/openzfs/zfs/issues/11474
Signed-off-by: Stoiko Ivanov
---
tested by compiling our current 5.4 kernel and boot
that
our debian/copyright file got a bit out-of-sync with debian's and pulled
their version in (additionally adding Proxmox for the files in debian/*)
Thanks to Fabian for catching this and pointing me in the right direction!
Stoiko Ivanov (2):
buildsys: make libpam-zfs a separate package
by taking the current version from debian-upstream.
The only addition is an attribution for Proxmox for the files in
debian/*
Signed-off-by: Stoiko Ivanov
---
debian/copyright | 840 +++
1 file changed, 271 insertions(+), 569 deletions(-)
diff --git
--package` (e.g. by installing
an upgraded libpam-runtime package).
[0] https://github.com/openzfs/zfs/issues/11222
[1] https://salsa.debian.org/zfsonlinux-team/zfs/
Reported-by: Fabian Grünbichler
Originally-by: Antonio Russo
Signed-off-by: Stoiko Ivanov
---
debian/control| 14
Adapted from debian upstream [0] commits:
1a3239e6b3b5604bb588c10912f57f32962b38c3
66b7241c965cdce730e76ca59c242fccc267b302
[0] https://salsa.debian.org/zfsonlinux-team/zfs/
Originally-By: Mo Zhou
Originally-By: Antonio Russo
Signed-off-by: Stoiko Ivanov
---
...-move-manpage-arcstat-1
Signed-off-by: Stoiko Ivanov
---
upstream | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/upstream b/upstream
index 32a78e57..d022406a 16
--- a/upstream
+++ b/upstream
@@ -1 +1 @@
-Subproject commit 32a78e579dd3395e122a451848cf88089f6b18ae
+Subproject commit
Adapted from debian upstream [0] commits:
76f1cec519ce3bd126dbb3b9d63e3a76c1b7c89e
[0] https://salsa.debian.org/zfsonlinux-team/zfs/
Originally-By: Antonio Russo
Signed-off-by: Stoiko Ivanov
---
debian/zfsutils-linux.install | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
the other one to keep closer to debian
upstream.
I built a test kernel based on 5.4.86-1-pve (no changes needed there) and gave
it a quick spin on a virtual setup of mine.
Stoiko Ivanov (3):
update submodule to zfs-2.0.0
zgenhostid is installed in /sbin
move manpage arcstat(1) to arcstat(8
concise and does not mess up the balanced
layout.
Quickly tested on my setup.
Signed-off-by: Stoiko Ivanov
---
Thanks to Dominik for pointing me to the RemoteEdit.js!
www/manager6/storage/PBSEdit.js | 57 +++--
1 file changed, 55 insertions(+), 2 deletions(-)
diff
Signed-off-by: Stoiko Ivanov
---
Recently we had a few cases in our enterprise support, where this information
would have saved us one roundtrip.
PVE/Report.pm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/PVE/Report.pm b/PVE/Report.pm
index 36bbcebb..d2ede5fa 100644
--- a/PVE/Report.pm
Gave the patch a spin on a v2-only system.
* it fixes the issue as described
we had a short chat off-list with Wolfgang - and considered restructuring
the code a bit (currently the patch makes parts of PVE::CGroup dead code)
but for alleviating the immediate issue:
Tested-By: Stoiko Ivanov
Thanks for the patch!
(not a user of non-english locales myself, so probably not the best source
for feedback)
noticed one typo (and a few places where the use of gettext seems wrong)
feel free to ignore any and all of the suggestions :)
On Tue, 5 Jan 2021 13:12:29 +0100
Dominic Jäger
for regression to me.
I quickly tested it on a test-setup of mine:
* storage replication
* container snapshot+rollback
Signed-off-by: Stoiko Ivanov
---
.../0004-import-with-d-dev-disk-by-id-in-scan-service.patch | 4 ++--
...0008-Add-systemd-unit-for-importing-specific-pools.patch | 6 +++---
upstream
Thanks for getting this documented!
LGTM as it currently is! (All comments are purely suggestions - feel free
to ignore them)
One thing I would emphasize a bit more (e.g. by adding it as list items in
the initial paragraph) is that getting all the guest agent goodness needs
2 prerequisites:
*
Signed-off-by: Stoiko Ivanov
---
PVE/Ceph/Tools.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/Ceph/Tools.pm b/PVE/Ceph/Tools.pm
index 12d309be..ab38f7bc 100644
--- a/PVE/Ceph/Tools.pm
+++ b/PVE/Ceph/Tools.pm
@@ -292,7 +292,7 @@ sub setup_pve_symlinks {
# fail if we
on packet (RST,ACK), vs shutdown
(FIN,ACK+RST,ACK) in its use here).
Co-Authored-by: Dominik Csapak
Signed-off-by: Stoiko Ivanov
---
PVE/APIServer/AnyEvent.pm | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/PVE/APIServer/AnyEvent.pm b/PVE/APIServer/AnyEvent.pm
Signed-off-by: Stoiko Ivanov
---
PVE/APIServer/AnyEvent.pm | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/PVE/APIServer/AnyEvent.pm b/PVE/APIServer/AnyEvent.pm
index 0165264..9a4b7e7 100644
--- a/PVE/APIServer/AnyEvent.pm
+++ b/PVE/APIServer
if an error happens before AnyEvent::Handle registers the cleanup
callback, we should shutdown the socket, when handling it.
Co-Authored-by: Dominik Csapak
Signed-off-by: Stoiko Ivanov
---
PVE/APIServer/AnyEvent.pm | 18 --
1 file changed, 16 insertions(+), 2 deletions(-)
diff
Signed-off-by: Stoiko Ivanov
---
PVE/APIServer/AnyEvent.pm | 4
1 file changed, 4 insertions(+)
diff --git a/PVE/APIServer/AnyEvent.pm b/PVE/APIServer/AnyEvent.pm
index a679006..0165264 100644
--- a/PVE/APIServer/AnyEvent.pm
+++ b/PVE/APIServer/AnyEvent.pm
@@ -1547,6 +1547,7 @@ sub
ngs in
the future.
Huge thanks to Dominik, who analyzed this issue with me!
Stoiko Ivanov (5):
add debug print helper
accept-phase: fix conn_count "leak"
accept-phase: shutdown socket on early error
add debug log for problems during accept
debug: uniformly use dprint
Suggested-by: Thomas Lamprecht
Signed-off-by: Stoiko Ivanov
---
PVE/APIServer/AnyEvent.pm | 10 ++
1 file changed, 10 insertions(+)
diff --git a/PVE/APIServer/AnyEvent.pm b/PVE/APIServer/AnyEvent.pm
index c55da7f..7916bdd 100644
--- a/PVE/APIServer/AnyEvent.pm
+++ b/PVE/APIServer
ted via our community-forum:
https://forum.proxmox.com/threads/pveproxy-eats-available-ram.79617/
Co-Authored-by: Dominik Csapak
Signed-off-by: Stoiko Ivanov
---
PVE/APIServer/AnyEvent.pm | 22 +++---
1 file changed, 19 insertions(+), 3 deletions(-)
diff --git a/PVE/APISer
.
The second seemed to me like a sensible further cleanup, and the third patch
will hopefully provide the needed information when debugging such things in
the future.
Huge thanks to Dominik, who analyzed this issue with me!
Stoiko Ivanov (3):
accept-phase: fix conn_count "leak"
ac
a denied ip until the connection count exeeds the maximum
connections of all child-processes.
Reported via our community-forum:
https://forum.proxmox.com/threads/pveproxy-eats-available-ram.79617/
Co-Authored-by: Dominik Csapak
Signed-off-by: Stoiko Ivanov
---
PVE/APIServer/AnyEvent.pm | 7
if an error happens before AnyEvent::Handle registers the cleanup
callback, we should shutdown the socket, when handling it.
Co-Authored-by: Dominik Csapak
Signed-off-by: Stoiko Ivanov
---
PVE/APIServer/AnyEvent.pm | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git
Co-Authored-by: Dominik Csapak
Signed-off-by: Stoiko Ivanov
---
PVE/APIServer/AnyEvent.pm | 9 +
1 file changed, 9 insertions(+)
diff --git a/PVE/APIServer/AnyEvent.pm b/PVE/APIServer/AnyEvent.pm
index 7038b07..d33f6b0 100644
--- a/PVE/APIServer/AnyEvent.pm
+++ b/PVE/APIServer
adapted from debian-upstream a149a374057d55ec82d8d9d258105aeb316bb1fb
Signed-off-by: Stoiko Ivanov
---
debian/zfsutils-linux.install | 72 ++-
1 file changed, 71 insertions(+), 1 deletion(-)
diff --git a/debian/zfsutils-linux.install b/debian/zfsutils
From: Antonio Russo
(cherry picked from commit 7f3dec474aff811b72220858fb5935054fd58a3c)
Signed-off-by: Stoiko Ivanov
---
debian/zfsutils-linux.install | 2 ++
1 file changed, 2 insertions(+)
diff --git a/debian/zfsutils-linux.install b/debian/zfsutils-linux.install
index c376d537..6a18eab9
Signed-off-by: Stoiko Ivanov
---
debian/rules | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/debian/rules b/debian/rules
index 7c4f9f6..48680f8 100755
--- a/debian/rules
+++ b/debian/rules
@@ -128,7 +128,7 @@ binary: install
${MAKE} -C ${KERNEL_SRC
adapted from debian-upstream 490ecc37abc7f6759293b90334768d088f2ff98c
Signed-off-by: Stoiko Ivanov
---
Makefile | 8 ++--
debian/control| 48 +--
debian/libnvpair1linux.lintian-overrides | 1
Signed-off-by: Stoiko Ivanov
---
.../0002-always-load-ZFS-module-on-boot.patch | 8
...o-the-zed-binary-on-the-systemd-unit.patch | 6 +++---
...ith-d-dev-disk-by-id-in-scan-service.patch | 4 ++--
debian/patches/0005-Enable-zed-emails.patch | 2 +-
.../0006-dont-symlink-zed
adapted from debian-upstream 0be5e4edc2eef9885fd03e9c797b9429da539ce2
Signed-off-by: Stoiko Ivanov
---
debian/control | 12
debian/libzfsbootenv1linux.docs | 2 ++
debian/libzfsbootenv1linux.install | 1 +
debian
zfsonlinux:
Antonio Russo (4):
ship arcstat(1) manual page
Add new zstream utility
Include new zfs_ids_to_path tool
Include new pam_zfs_key mechanism
Stoiko Ivanov (5):
update submodule and patches for zfs-2.0.0
Install files under multiarch directories
Bump libz{fs,pool,uutil} soname
adapted from debian-upstream 8f137b115a89348e7816f60b5e8410fd303fec81
Signed-off-by: Stoiko Ivanov
---
debian/libnvpair1linux.install| 1 -
debian/libnvpair1linux.install.in | 1 +
debian/libuutil1linux.install | 1 -
debian/libuutil1linux.install.in | 1 +
debian
From: Antonio Russo
(cherry picked from commit 3376e22c139b6dcd5774018fc7ebcdff9fac66c3)
Signed-off-by: Stoiko Ivanov
---
debian/zfsutils-linux.install | 2 ++
1 file changed, 2 insertions(+)
diff --git a/debian/zfsutils-linux.install b/debian/zfsutils-linux.install
index 6a18eab9..77b3ab88
From: Antonio Russo
(cherry picked from commit c5b72db53215c2ca7b76c21113f466938517d71b)
Signed-off-by: Stoiko Ivanov
---
debian/zfsutils-linux.install | 1 +
1 file changed, 1 insertion(+)
diff --git a/debian/zfsutils-linux.install b/debian/zfsutils-linux.install
index 229ff2ea..c3a32bcc
On Wed, 25 Nov 2020 12:08:39 +0100 (CET)
Dietmar Maurer wrote:
> What kind of format is that? RFC2373 does not mention it. Please can
> you give me a hint?
was curious myself - since I know the format but wasn't sure where it's
specified. ripe has a nice explanation:
] https://lists.proxmox.com/pipermail/pve-devel/2020-October/045524.html
Stoiko Ivanov (2):
api2: osd destroy: fix error function
api2: osd destroy: untaint device before pvremove
PVE/API2/Ceph/OSD.pm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--
2.20.1
on a virtual testsetup by creating OSDs with second DB disk,
and destroying it via GUI (did not manage to get the error without the
DB disk)
Reported via our community forum:
https://forum.proxmox.com/threads/insecure-dependency-in-exec-during-osd-destroy.79574/
Signed-off-by: Stoiko Ivanov
---
PVE
Signed-off-by: Stoiko Ivanov
---
PVE/API2/Ceph/OSD.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/API2/Ceph/OSD.pm b/PVE/API2/Ceph/OSD.pm
index f1f39bf9..685b68bc 100644
--- a/PVE/API2/Ceph/OSD.pm
+++ b/PVE/API2/Ceph/OSD.pm
@@ -575,7 +575,7 @@ __PACKAGE__
::parse_volume_id failing on those mountpoints.
Since the fsfreeze call is best-effort and only run for specific
storageplugins, we can simply skip non-volume mountpoints, when gathering
the list of volumes to call fsfreeze on.
Tested with a container with a bindmount.
Signed-off-by: Stoiko Ivanov
Hi,
Thank you for contributing to PVE!
Could you explain what the patch fixes and why it works (would also be
great to have that information in the commit-message)?
I checked our bugzilla and the community forum, but could not find any
recent issue regarding gluster and containers (I probably
testing)
Stoiko Ivanov (3):
memorize keyboard layout selection
add run_in_background
set the keymap on the installer console
proxinstall | 52 +++-
1 file changed, 51 insertions(+), 1 deletion(-)
--
2.20.1
, or if a different country was
selected
Signed-off-by: Stoiko Ivanov
---
proxinstall | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/proxinstall b/proxinstall
index 9879df4..9977f44 100755
--- a/proxinstall
+++ b/proxinstall
@@ -2549,6 +2549,8 @@ sub get_device_desc
the children get reaped.
Signed-off-by: Stoiko Ivanov
---
proxinstall | 23 +++
1 file changed, 23 insertions(+)
diff --git a/proxinstall b/proxinstall
index 9977f44..1551e18 100755
--- a/proxinstall
+++ b/proxinstall
@@ -21,6 +21,7 @@ use Data::Dumper;
use File::Basename
s_hook)
Would be grateful for feedback if this approach is ok (reading containerconfig
+ storage config in __snapshot_freeze) or if some other way would be nicer.
Tested on my testsetup with a ceph-backed container (and 2 additional
mountpoints (one ceph, one on LVM thin).
pve-storage:
Stoiko Iva
is not
consistent.
Needed to fix #2991 and #2528.
The ioctl numbers were found via strace -X verbose (and verified with the
kernel documentation).
Signed-off-by: Stoiko Ivanov
---
src/PVE/LXC/Config.pm | 19 +++
1 file changed, 19 insertions(+)
diff --git a/src/PVE/LXC/Config.pm b
Signed-off-by: Stoiko Ivanov
---
PVE/Storage.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/Storage.pm b/PVE/Storage.pm
index cd7b5ff..ad10827 100755
--- a/PVE/Storage.pm
+++ b/PVE/Storage.pm
@@ -40,7 +40,7 @@ use PVE::Storage::ZFSPlugin;
use PVE::Storage::DRBDPlugin
In order to take a snapshot of a container volume, which can be mounted
read-only with RBD, the volume needs to be frozen (fsfreeze (8)) before taking
the snapshot.
This commit adds helpers to determine if the FIFREEZE ioctl needs to be called
for the volume.
Signed-off-by: Stoiko Ivanov
that this helps to successfully create backups.
needs a versioned dependency bump on pve-storage
Signed-off-by: Stoiko Ivanov
---
src/PVE/LXC/Config.pm | 28
src/test/snapshot-test.pm | 12 +++-
2 files changed, 39 insertions(+), 1 deletion(-)
diff --git
In order to take a snapshot of a container volume, which can be mounted
read-only with RBD, the volume needs to be frozen (fsfreeze (8)) before taking
the snapshot.
This commit adds helpers to determine if the FIFREEZE ioctl needs to be called
for the volume.
Signed-off-by: Stoiko Ivanov
Signed-off-by: Stoiko Ivanov
---
PVE/Storage.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/Storage.pm b/PVE/Storage.pm
index cd7b5ff..ad10827 100755
--- a/PVE/Storage.pm
+++ b/PVE/Storage.pm
@@ -40,7 +40,7 @@ use PVE::Storage::ZFSPlugin;
use PVE::Storage::DRBDPlugin
is not
consistent
Needed to fix #2991 and #2528.
The ioctl numbers were found via strace -X verbose (and verified with the
kernel documentation).
Signed-off-by: Stoiko Ivanov
---
src/PVE/LXC.pm | 19 +++
1 file changed, 19 insertions(+)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
that this helps to successfully create backups.
needs a versioned dependency bump on pve-storage
Signed-off-by: Stoiko Ivanov
---
src/PVE/LXC.pm| 26 +++---
src/PVE/LXC/Config.pm | 19 +--
src/test/snapshot-test.pm | 12 +++-
3 files
is not consistent
Needed to fix #2991 and #2528.
The ioctl numbers were found via strace -X verbose (and compared with the
kernel source).
Signed-off-by: Stoiko Ivanov
---
src/PVE/Tools.pm | 18 ++
1 file changed, 18 insertions(+)
diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
if the FIFREEZE ioctl needs to be called
for the volume.
Signed-off-by: Stoiko Ivanov
---
PVE/Storage.pm | 12
PVE/Storage/Plugin.pm| 4
PVE/Storage/RBDPlugin.pm | 5 +
3 files changed, 21 insertions(+)
diff --git a/PVE/Storage.pm b/PVE/Storage.pm
index cd7b5ff..27223b6
.
needs a versioned dependency bump on pve-common and pve-storage
Signed-off-by: Stoiko Ivanov
---
src/PVE/LXC.pm| 21 +
src/PVE/LXC/Config.pm | 15 ++-
src/test/snapshot-test.pm | 12 +++-
3 files changed, 42 insertions(+), 6 deletions
in __snapshot_freeze) or if some other way would be nicer.
Tested on my testsetup with a ceph-backed container (and 2 additional
mountpoints (one ceph, one on LVM thin).
pve-common:
Stoiko Ivanov (1):
add fsfreeze helper:
src/PVE/Tools.pm | 18 ++
1 file changed, 18 insertions
it got moved to proxmox-widget-toolkit for reuse in PMG
Signed-off-by: Stoiko Ivanov
---
www/manager6/storage/PBSEdit.js | 62 -
1 file changed, 62 deletions(-)
diff --git a/www/manager6/storage/PBSEdit.js b/www/manager6/storage/PBSEdit.js
index 841b5218
for reuse in PMG
Signed-off-by: Stoiko Ivanov
---
src/Makefile | 1 +
src/form/PBSEncryptionCheckbox.js | 63 +++
2 files changed, 64 insertions(+)
create mode 100644 src/form/PBSEncryptionCheckbox.js
diff --git a/src/Makefile b/src/Makefile
This patchset is in preparation for adding PBS-integration to PMG.
It requires a versioned dependency from pve-mangager on proxmox-widget-toolkit
(and a Breaks in the other direction)
Tested by applying both patches and editing my configured PBS storages.
proxmox-widget-toolkit:
Stoiko Ivanov
401 - 500 of 537 matches
Mail list logo
