Signed-off-by: Stoiko Ivanov
---
PVE/API2/Ceph/OSD.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/API2/Ceph/OSD.pm b/PVE/API2/Ceph/OSD.pm
index f1f39bf9..685b68bc 100644
--- a/PVE/API2/Ceph/OSD.pm
+++ b/PVE/API2/Ceph/OSD.pm
@@ -575,7 +575,7 @@ __PACKAGE__
E::Storage::parse_volume_id failing on those mountpoints.
Since the fsfreeze call is best-effort and only run for specific
storageplugins, we can simply skip non-volume mountpoints, when gathering
the list of volumes to call fsfreeze on.
Tested with a container with a bindmount.
Signed-off-by: Sto
Hi,
Thank you for contributing to PVE!
Could you explain what the patch fixes and why it works (would also be
great to have that information in the commit-message)?
I checked our bugzilla and the community forum, but could not find any
recent issue regarding gluster and containers (I probably ove
this patch partially reverts 8bc528041ba85e1b9bd4c17638a2302088bc19ce
by writing /etc/default/keyboard and running `setupcon` in the background
the delay should not harm the UX in the installer
Signed-off-by: Stoiko Ivanov
---
proxinstall | 12
1 file changed, 12 insertions
some testing)
Stoiko Ivanov (3):
memorize keyboard layout selection
add run_in_background
set the keymap on the installer console
proxinstall | 52 +++-
1 file changed, 51 insertions(+), 1 deletion(-)
--
2
different country was
selected
Signed-off-by: Stoiko Ivanov
---
proxinstall | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/proxinstall b/proxinstall
index 9879df4..9977f44 100755
--- a/proxinstall
+++ b/proxinstall
@@ -2549,6 +2549,8 @@ sub get_device_desc
the children get reaped.
Signed-off-by: Stoiko Ivanov
---
proxinstall | 23 +++
1 file changed, 23 insertions(+)
diff --git a/proxinstall b/proxinstall
index 9977f44..1551e18 100755
--- a/proxinstall
+++ b/proxinstall
@@ -21,6 +21,7 @@ use Data::Dumper;
use File::Basename
each volume twice (in
__snapshot_create_vol_snapshs_hook)
Would be grateful for feedback if this approach is ok (reading containerconfig
+ storage config in __snapshot_freeze) or if some other way would be nicer.
Tested on my testsetup with a ceph-backed container (and 2 additional
mountpoints (on
because the ext4 is not
consistent.
Needed to fix #2991 and #2528.
The ioctl numbers were found via strace -X verbose (and verified with the
kernel documentation).
Signed-off-by: Stoiko Ivanov
---
src/PVE/LXC/Config.pm | 19 +++
1 file changed, 19 insertions(+)
diff --git a/src
Signed-off-by: Stoiko Ivanov
---
PVE/Storage.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/Storage.pm b/PVE/Storage.pm
index cd7b5ff..ad10827 100755
--- a/PVE/Storage.pm
+++ b/PVE/Storage.pm
@@ -40,7 +40,7 @@ use PVE::Storage::ZFSPlugin;
use PVE::Storage::DRBDPlugin
In order to take a snapshot of a container volume, which can be mounted
read-only with RBD, the volume needs to be frozen (fsfreeze (8)) before taking
the snapshot.
This commit adds helpers to determine if the FIFREEZE ioctl needs to be called
for the volume.
Signed-off-by: Stoiko Ivanov
icate that this helps to successfully create backups.
needs a versioned dependency bump on pve-storage
Signed-off-by: Stoiko Ivanov
---
src/PVE/LXC/Config.pm | 28
src/test/snapshot-test.pm | 12 +++-
2 files changed, 39 insertions(+), 1 deletion(-)
diff --
In order to take a snapshot of a container volume, which can be mounted
read-only with RBD, the volume needs to be frozen (fsfreeze (8)) before taking
the snapshot.
This commit adds helpers to determine if the FIFREEZE ioctl needs to be called
for the volume.
Signed-off-by: Stoiko Ivanov
only, because the ext4 is not
consistent
Needed to fix #2991 and #2528.
The ioctl numbers were found via strace -X verbose (and verified with the
kernel documentation).
Signed-off-by: Stoiko Ivanov
---
src/PVE/LXC.pm | 19 +++
1 file changed, 19 insertions(+)
diff --git a/src/PV
ng containerconfig
+ storage config in __snapshot_freeze) or if some other way would be nicer.
Tested on my testsetup with a ceph-backed container (and 2 additional
mountpoints (one ceph, one on LVM thin).
pve-storage:
Stoiko Ivanov (2):
fix typo in comment
add check for fsfreeze before sn
Signed-off-by: Stoiko Ivanov
---
PVE/Storage.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/Storage.pm b/PVE/Storage.pm
index cd7b5ff..ad10827 100755
--- a/PVE/Storage.pm
+++ b/PVE/Storage.pm
@@ -40,7 +40,7 @@ use PVE::Storage::ZFSPlugin;
use PVE::Storage::DRBDPlugin
icate that this helps to successfully create backups.
needs a versioned dependency bump on pve-storage
Signed-off-by: Stoiko Ivanov
---
src/PVE/LXC.pm| 26 +++---
src/PVE/LXC/Config.pm | 19 +--
src/test/snapshot-test.pm | 12 +++-
3
only, because the ext4 is not consistent
Needed to fix #2991 and #2528.
The ioctl numbers were found via strace -X verbose (and compared with the
kernel source).
Signed-off-by: Stoiko Ivanov
---
src/PVE/Tools.pm | 18 ++
1 file changed, 18 insertions(+)
diff --git a/src/PVE/To
FIFREEZE ioctl needs to be called
for the volume.
Signed-off-by: Stoiko Ivanov
---
PVE/Storage.pm | 12
PVE/Storage/Plugin.pm| 4
PVE/Storage/RBDPlugin.pm | 5 +
3 files changed, 21 insertions(+)
diff --git a/PVE/Storage.pm b/PVE/Storage.pm
index cd7b5ff..27223b6
ckups.
needs a versioned dependency bump on pve-common and pve-storage
Signed-off-by: Stoiko Ivanov
---
src/PVE/LXC.pm| 21 +
src/PVE/LXC/Config.pm | 15 ++-
src/test/snapshot-test.pm | 12 +++-
3 files changed, 42 insertions(+), 6 dele
+ storage config in __snapshot_freeze) or if some other way would be nicer.
Tested on my testsetup with a ceph-backed container (and 2 additional
mountpoints (one ceph, one on LVM thin).
pve-common:
Stoiko Ivanov (1):
add fsfreeze helper:
src/PVE/Tools.pm | 18 ++
1 file ch
Hi,
On Thu, 29 Oct 2020 13:44:05 +0100
Alexandre Derumier wrote:
> Hi,
> I'm stil working on rdd && new pressure stats.
>
> pressure stats in cgroup are only available in cgroupv2.
> so it's working for qemu, but I don't have counter for lxc as it's
> still using cgroupv1.
>
> I see that wo
it got moved to proxmox-widget-toolkit for reuse in PMG
Signed-off-by: Stoiko Ivanov
---
www/manager6/storage/PBSEdit.js | 62 -
1 file changed, 62 deletions(-)
diff --git a/www/manager6/storage/PBSEdit.js b/www/manager6/storage/PBSEdit.js
index 841b5218
for reuse in PMG
Signed-off-by: Stoiko Ivanov
---
src/Makefile | 1 +
src/form/PBSEncryptionCheckbox.js | 63 +++
2 files changed, 64 insertions(+)
create mode 100644 src/form/PBSEncryptionCheckbox.js
diff --git a/src/Makefile b/src/Makefile
This patchset is in preparation for adding PBS-integration to PMG.
It requires a versioned dependency from pve-mangager on proxmox-widget-toolkit
(and a Breaks in the other direction)
Tested by applying both patches and editing my configured PBS storages.
proxmox-widget-toolkit:
Stoiko Ivanov
Thanks for the patch!
I could reproduce the issue by creating a centos container and
installing 'centos-release-stream' and the patch does fix it.
We'd still need a signed CLA from you in order to be able to incorporate
it - see:
https://pve.proxmox.com/wiki/Developer_Documentation#Software_Licen
li on the remote host (via
run_command), untainting prevents the call to crash when run with '-T'.
Tested by creating a zfs over iscsi backed VM, starting it, adding disks,
resizing disks, removing disks, creating snapshots, rolling back to a snapshot.
Signed-off-by: Stoiko Ivanov
-
minor cleanup of left-over/unused statements.
Signed-off-by: Stoiko Ivanov
---
PVE/Storage/LunCmd/LIO.pm | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/PVE/Storage/LunCmd/LIO.pm b/PVE/Storage/LunCmd/LIO.pm
index f9e7143..b98edc2 100644
--- a/PVE/Storage/LunCmd/LIO.pm
The second patch removes two small left-over statements, which confused me
while debugging.
Tested very roughly (adding disks, create/rollback snapshot, remove disk) on
a VM backed by a LIO-iSCSI target.
Stoiko Ivanov (2):
LIO: untaint values read from remote config
LIO: drop unused state
On Fri, 9 Oct 2020 17:44:22 +0200 (CEST)
Daniel Berteaud wrote:
> - Le 9 Oct 20, à 17:26, Daniel Berteaud dan...@firewall-services.com a
> écrit :
>
> > - Le 9 Oct 20, à 17:13, Stoiko Ivanov s.iva...@proxmox.com a écrit :
> >
> >> ZFS over iSCSI fetc
th `perl -T /usr/sbin/qm start $vmid`
[0] https://lists.proxmox.com/pipermail/pve-user/2020-October/172055.html
Signed-off-by: Stoiko Ivanov
---
PVE/Storage/ZFSPlugin.pm | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/PVE/Storage/ZFSPlugin.pm b/PVE/Storage/ZFSPlugin.pm
hange from 9a04c500f17d8df20a017137211d0984cace98ff in
debian's repository [0].
[0] https://salsa.debian.org/zfsonlinux-team/zfs.git
Signed-off-by: Stoiko Ivanov
---
did some very rough tests in a VM (container snapshot+rollback) and am
currently running it on my host.
Most commits are to enable compilation with newer
by building the package as root (otherwise the zfs
regressiontests are skipped).
Reported-by: Thomas Lamprecht
Signed-off-by: Stoiko Ivanov
---
PVE/Storage/ZFSPoolPlugin.pm | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/PVE/Storage/ZFSPoolPlugin.pm b/PVE/Storage
skip additional virtual filesystems.
the list is taken from a running debian container's /proc/mounts
Signed-off-by: Stoiko Ivanov
---
v1 -> v2:
* changed the non-anchored unwieldy regex to a hash based on Thomas' suggestion
- Thanks!
src/PVE/LXC.pm | 15 ++-
1 fil
skip additional virtual filesystems.
the list is taken from a running debian container's /proc/mounts
Signed-off-by: Stoiko Ivanov
---
src/PVE/LXC.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index b3e3581..b67d872 100644
--- a/sr
toiko Ivanov (1):
sync_mountpoint: open path so that sync works
src/PVE/Tools.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
pve-container:
Stoiko Ivanov (1):
sync_container_namespace: skip virtual filesystems
src/PVE/LXC.pm | 2 +-
1 file changed, 1 insertion(+), 1 del
sync_mountpoint takes a path, gets an open filedescriptor and calls
syncfs(2) on it.
by opening with O_PATH the syncfs call fails with EBADF (see open(2)).
found by running:
```
pkill -f 'pvedaemon worker';
strace -yyttT -s 512 -o /tmp/trace -fp $(pgrep -f pvedaemon$)
```
Signed-off-
l get
imported by scanning.
Suggested-by: Fabian Grünbichler
Signed-off-by: Stoiko Ivanov
---
...md-unit-for-importing-specific-pools.patch | 75 +++
debian/patches/series | 1 +
debian/zfsutils-linux.install | 1 +
3 files changed, 77 inser
fsonlinux repository.
Suggested-by: Fabian Grünbichler
Signed-off-by: Stoiko Ivanov
---
src/api2/node/disks/zfs.rs | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/api2/node/disks/zfs.rs b/src/api2/node/disks/zfs.rs
index c5d6f6a6..0f0e4220 100644
--- a/src/api2/node/disks/zfs.rs
+++ b/src/ap
ode 100644
debian/patches/0008-Add-systemd-unit-for-importing-specific-pools.patch
proxmox-backup:
Stoiko Ivanov (1):
api2/node/disks/zfs: instantiate import service
src/api2/node/disks/zfs.rs | 5 +
1 file changed, 5 insertions(+)
pve-storage:
Stoiko Ivanov (1):
Disks: instantiate impor
ervice' in
the zfsonlinux repository.
Suggested-by: Fabian Grünbichler
Signed-off-by: Stoiko Ivanov
---
PVE/API2/Disks/ZFS.pm | 6 ++
1 file changed, 6 insertions(+)
diff --git a/PVE/API2/Disks/ZFS.pm b/PVE/API2/Disks/ZFS.pm
index 7a633a7..66b26e9 100644
--- a/PVE/API2/Disks/ZFS.pm
+++ b
d-off-by: Stoiko Ivanov
---
sorry - forgot to add this to my previous series
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 5f44c7b..e08155e 100644
--- a/Makefile
+++ b/Makefile
@@ -19,7 +19,7 @@ all: $(DEBS)
.PHONY: submodule
subm
this patchset updates lxc to 4.0.4
tested on my system and a virtual ceph-cluster (for ha and migration tests),
created some backups of containers. - everything seems to work fine.
Stoiko Ivanov (2):
update upstream to 4.0.4 and rebase patches
bump version to 4.0.4-1
debian/changelog
Signed-off-by: Stoiko Ivanov
---
...ning-lxc-monitord-as-a-system-daemon.patch | 4 +--
...roup.dir.-monitor-container-containe.patch | 8 +++---
container.namespace-lxc.cgroup.cont.patch | 2 +-
...dd-and-document-cgroup_advanced_isol.patch | 14 +-
...up.dir.-monitor-container
Signed-off-by: Stoiko Ivanov
---
debian/changelog | 6 ++
1 file changed, 6 insertions(+)
diff --git a/debian/changelog b/debian/changelog
index e1ab53d..8bca333 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+lxc-pve (4.0.4-1) pve; urgency=medium
+
+ * update to lxc
instead of calling /usr/sbin/sendmail directly.
Tested with:
```
echo "[]" > /var/lib/pve-manager/pkgupdates
pvesh create /nodes/rosa/apt/update --notify 1
Signed-off-by: Stoiko Ivanov
---
PVE/API2/APT.pm | 19 ---
1 file changed, 4 insertions(+), 15 deletions(-)
This patch enables the sendmail helper sub to send emails with a non-existant
display name in the from address. This is used to replace the direct call to
the sendmail binary in pve-manager/PVE/API2/APT.pm.
Signed-off-by: Stoiko Ivanov
---
src/PVE/Tools.pm | 2 +-
1 file changed, 1 insertion
sending a few small mails via
'perl -e'
Signed-off-by: Stoiko Ivanov
---
src/PVE/Tools.pm | 41 -
1 file changed, 28 insertions(+), 13 deletions(-)
diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
index f9270d9..3b5b199 100644
--- a/src/PVE/Tool
course.
[0] https://lists.proxmox.com/pipermail/pbs-devel/2020-August/000423.html
Stoiko Ivanov (2):
move email regex from JSONSchema to Tools
sendmail-helper: only send multipart if necessary
src/PVE/JSONSchema.pm | 4 ++--
src/PVE/Tools.pm | 49 +--
Move the Regular expression used for matching e-mail addresses from
the verify sub in PVE::JSONSchema to PVE::Tools, so that it can be reused
in PVE::Tools::sendmail. This ensures that both uses have the same
definition of valid email addresses.
Signed-off-by: Stoiko Ivanov
---
src/PVE
rl -e'
Signed-off-by: Stoiko Ivanov
---
src/PVE/Tools.pm | 46 ++
1 file changed, 30 insertions(+), 16 deletions(-)
diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
index e849bdf..6aadd1f 100644
--- a/src/PVE/Tools.pm
+++ b/src/PVE/Tools.pm
@@ -25,6 +2
https://lists.proxmox.com/pipermail/pbs-devel/2020-August/000423.html
Stoiko Ivanov (2):
move email regex from JSONSchema to Tools
sendmail-helper: only send multipart if necessary
src/PVE/JSONSchema.pm | 4 ++--
src/PVE/Tools.pm | 49 +--
2 files chang
Otherwise a warning is printed if the bios is not set in the config.
reported via community forum:
https://forum.proxmox.com/threads/warning-in-qemuserver.74683/
reproduced and tested that the patch fixes the issue.
Signed-off-by: Stoiko Ivanov
---
PVE/QemuServer.pm | 2 +-
1 file changed, 1
actually bootable (else the systemd-boot config uses
the cmdline from the installer).
Signed-off-by: Stoiko Ivanov
---
steps to reproduce the issue:
* install pve 6.2 with ZFS on root from iso on a seabios vm
* after install stop the VM and change the BIOS to OVMF
* start the vm
proxinstall | 4 +---
1
On Wed, 22 Jul 2020 14:09:09 +0200
Thomas Lamprecht wrote:
> On 22.07.20 13:59, Stoiko Ivanov wrote:
> > On Wed, 22 Jul 2020 13:51:19 +0200
> > Thomas Lamprecht wrote:
> >
> >> On 22.07.20 13:05, Stoiko Ivanov wrote:
> >>> commit 863845075d3f77d
On Wed, 22 Jul 2020 13:51:19 +0200
Thomas Lamprecht wrote:
> On 22.07.20 13:05, Stoiko Ivanov wrote:
> > commit 863845075d3f77d27c91bd9f47d2f8ddc4867bd5 in upstream only partially
> > fixes the apparmor deny for mounting boot_id (used for example for
> > identifying
>
//github.com/lxc/lxc/issues/3183
Stoiko Ivanov (2):
update lxc to include fixes for cgroupv2 setups
apparmor: add rule for allowing remount of boot_id
...apparmor-Allow-ro-remount-of-boot_id.patch | 26 +++
debian/patches/series
, which I haven't seen in our
support channels, thus assume limited potential for regressions.
Signed-off-by: Stoiko Ivanov
---
lxc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lxc b/lxc
index 538337e..4547e73 16
--- a/lxc
+++ b/lxc
@@ -1 +1 @@
-Subproject c
:
`apparmor_parser -W -T -r /etc/apparmor.d/usr.bin.lxc-start`
Signed-off-by: Stoiko Ivanov
---
...apparmor-Allow-ro-remount-of-boot_id.patch | 26 +++
debian/patches/series | 1 +
2 files changed, 27 insertions(+)
create mode 100644
debian/patches/pve/0004-apparmor
Thanks for picking this up! Looking forward to not searching the web/our
forum for the good answers to questions that come up quite often.
a few mostly stylistic (as in more a matter of my taste) comments inline:
On Fri, 17 Jul 2020 14:12:32 +0200
Aaron Lauterer wrote:
> This new section explai
ork, since the
keymaps in debian are generated from the x11 definitions by ckbcomp and then
saved in '/etc/console-setup/'.
Signed-off-by: Stoiko Ivanov
---
v1->v2:
* incorporated Thomas' feedback, making the whitespace prefix stripping more
robust (Thanks!)
* took a look at t
On Mon, 20 Jul 2020 18:00:25 +0200
Thomas Lamprecht wrote:
> On 20.07.20 16:54, Stoiko Ivanov wrote:
> > This is an enhancement for #2804
> >
> > Having a shell waiting on vt3, it improves user experience if it has the
> > same keyboard map as the X11 installer.
>
`loadkeys` would not
work, since the keymaps in debian are generated from the x11 definitions by
ckbcomp and then saved in '/etc/console-setup/'.
Signed-off-by: Stoiko Ivanov
---
roughly tested with a PBS-iso (can provide should someone else want to test it)
in a VM (clicking on french yiel
ng
debug-logs (after starting failed with our tooling) - so the potential for
regression in that case should also be small.
The $loopdevlist variable is not used anywhere in our codebase since 2015
(da6298481ea4dfe7d894f42fa105cda015ebe5ce).
Signed-off-by: Stoiko Ivanov
---
v1 -> v2:
* added the v
with the change introduced in 848cf539e59b4553559b9ff3207a3c5556dc1cc0 the
exported variable name changed from tarfile to target.
this patch reflects the renaming in the example hook script.
Signed-off-by: Stoiko Ivanov
---
vzdump-hook-script.pl | 8
1 file changed, 4 insertions(+), 4
The renaming of tarfile to target in 848cf539e59b4553559b9ff3207a3c5556dc1cc0
can break existing vzdump hook scripts of users.
by setting the TARFILE variable in addition to TARGET the scripts will continue
to work.
Signed-off-by: Stoiko Ivanov
---
PVE/VZDump.pm | 2 ++
1 file changed, 2
is there for a smoother experience of the existing users of
hook-scripts - Maybe we could also just mention it explicitly in the changelog?
feel free to squash the patches if applying both.
Stoiko Ivanov (2):
vzdump-hook-script: rename TARFILE to TARGET
VZDump: add TARFILE to environment for
4 (introduced in qemu-server for handling pending configuration
changes), and their removal did not cause any other regressions.
To my knowledge only the raw lxc config keys are parsed into a non-scalar
value.
Tested by adding a 'lxc.init.cmd' key to a container config.
Signed-off-by: St
g the resulting /etc/network/interfaces.
[0] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=912220
Signed-off-by: Stoiko Ivanov
---
src/PVE/LXC/Setup/Debian.pm | 19 ++-
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/src/PVE/LXC/Setup/Debian.pm b/src/PVE/LXC/S
501 - 569 of 569 matches
Mail list logo
