Re: [pve-devel] [PATCH v2 qemu-server] fix #4201: delete cloud-init disk on rollback

2022-11-11 Thread Mira Limbeck
On 11/11/22 16:18, Stefan Hanreich wrote: Test Setup: I created a new VM, without any Cloud-Init drive, and immediately created a snapshot. Then I setup a Cloud-Init drive according to the PVE documentation via CLI. I created another snapshot of this state with a Cloud-Init drive. What I

Re: [pve-devel] [PATCH v2 qemu-server] fix #4201: delete cloud-init disk on rollback

2022-11-11 Thread Stefan Hanreich
Test Setup: I created a new VM, without any Cloud-Init drive, and immediately created a snapshot. Then I setup a Cloud-Init drive according to the PVE documentation via CLI. I created another snapshot of this state with a Cloud-Init drive. What I tested: - Rolling back to the older snapshot

[pve-devel] [PATCH v2 qemu-server] fix #4201: delete cloud-init disk on rollback

2022-10-20 Thread Mira Limbeck
If the config doesn't contain the cloud-init disk anymore after the rollback, we have to clean it up since otherwise no further disk can be attached unless the one still existing on the storage is deleted. Signed-off-by: Mira Limbeck --- v2: - chose the add_unused_volume way as @fiona