Re: [pve-devel] [PATCH i18n] improve/update turkish translation

2019-03-19 Thread Thomas Lamprecht
On 3/19/19 3:07 PM, Oguz Bektas wrote: > Signed-off-by: Oguz Bektas > --- > tr.po | 439 > -- > 1 file changed, 183 insertions(+), 256 deletions(-) > > diff --git a/tr.po b/tr.po > index 5850773..a3c9c21 100644 > --- a/tr.po > +++

[pve-devel] [RFC v3 manager] fix: # 2123 Logging of user defined firewall rules

2019-03-19 Thread Christian Ebner
This patch relies on the corresponding patch to pve-firewall, adding the user defined log levels for firewall rules. By this, the user can select a per-rule log level for self defined rules. These are independent of the global log level, which is defined in the firewall options. Signed-off-by: C

[pve-devel] [PATCH firewall] Remove hard coded rate limit of logged packets

2019-03-19 Thread Christian Ebner
As some users rely on logging of all packets dropped/rejected, this removes the hard coded rate limit. Signed-off-by: Christian Ebner --- src/PVE/Firewall.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm index f294d36..30e2b4b 10064

Re: [pve-devel] applied: [RFC v2 firewall 1/1] fix: #2123 Logging of user defined firewall rules

2019-03-19 Thread Christian Ebner
Okay, I will send a patch to remove the hard coded rate limit. Maybe we might introduce a host / datacenter level option to set such a limit in the future. Thanks for the feedback! > On March 19, 2019 at 4:22 PM Alexandre DERUMIER wrote: > > > >>BTW, are you sure that's it's only limiting log

[pve-devel] [PATCH container] setup: fix alpine ipv6-slaac configuration

2019-03-19 Thread Stoiko Ivanov
busybox ifupdown implementation differs from debian's - configuration type auto is not supported. If SLAAC is selected for the ipv6 configuration of an interface, the complete networking is not started, because of that error. This workaround sets the interface type to 'manual' in case SLAAC is sel

Re: [pve-devel] applied: [RFC v2 firewall 1/1] fix: #2123 Logging of user defined firewall rules

2019-03-19 Thread Alexandre DERUMIER
>>BTW, are you sure that's it's only limiting logging ? What happen on an >>ACCEPT log for example ? sorry, respond to my myself, it's only applied on -j LOG, so it's ok. - Mail original - De: "aderumier" À: "pve-devel" Envoyé: Mardi 19 Mars 2019 16:09:56 Objet: Re: [pve-devel] appli

Re: [pve-devel] applied: [RFC v2 firewall 1/1] fix: #2123 Logging of user defined firewall rules

2019-03-19 Thread Alexandre DERUMIER
Hi, Nice work ! Could we have an option to disable rate limit or configure it (host option for example) The patch change the current behaviour on default vm log action, where we don't have limit currently. (and I really need to log all dropped/reject) BTW, are you sure that's it's only lim

[pve-devel] [PATCH docs v2] Reword krbd option description

2019-03-19 Thread Alwin Antreich
Reword the description and add an extra note box for the KRBD option to reflect its current use. As containers needs to use KRBD for a mapped device anyway and they are not affected by this option. Signed-off-by: Alwin Antreich --- V1 -> V2: puts clarification into a note box pve-storage-rbd.ad

[pve-devel] [PATCH i18n] improve/update turkish translation

2019-03-19 Thread Oguz Bektas
Signed-off-by: Oguz Bektas --- tr.po | 439 -- 1 file changed, 183 insertions(+), 256 deletions(-) diff --git a/tr.po b/tr.po index 5850773..a3c9c21 100644 --- a/tr.po +++ b/tr.po @@ -8,7 +8,7 @@ msgstr "" "Project-Id-Version: prox

Re: [pve-devel] [RFC v2 manager 1/1] fix: # 2123 Logging of user defined firewall rules

2019-03-19 Thread Thomas Lamprecht
On 3/18/19 5:05 PM, Christian Ebner wrote: > This patch relies on the corresponding patch to pve-firewall, adding the user > defined log levels for firewall rules. > > By this, the user can select a per-rule log level for self defined rules. > These > are independent of the global log level, whic

[pve-devel] [PATCH docs] Fixed some typos and slight language improvements

2019-03-19 Thread Christian Ebner
Signed-off-by: Christian Ebner --- pve-firewall.adoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pve-firewall.adoc b/pve-firewall.adoc index acaca95..3e417e8 100644 --- a/pve-firewall.adoc +++ b/pve-firewall.adoc @@ -35,7 +35,7 @@ containers. Features like firewall m

[pve-devel] applied: [RFC docs 1/1] fix: #2123 Logging of user defined firewall rules

2019-03-19 Thread Thomas Lamprecht
On 3/18/19 5:05 PM, Christian Ebner wrote: > Extends the documentation to mention the additional option to define a > per-rule > log level for user-defined rules. > > Signed-off-by: Christian Ebner > --- > pve-firewall.adoc | 43 +++ > 1 file changed, 43

[pve-devel] applied: [RFC v2 firewall 1/1] fix: #2123 Logging of user defined firewall rules

2019-03-19 Thread Thomas Lamprecht
On 3/18/19 5:05 PM, Christian Ebner wrote: > This allows a user to log traffic filtered by a self defined firewall rule. > Therefore the API is extended to include a 'log' option allow to specify the > log level for each rule individually. > > The 'log' option can also be specified in the fw confi

[pve-devel] applied: [PATCH firewall] add 'log_nf_conntrack' option description

2019-03-19 Thread Thomas Lamprecht
On 3/19/19 2:27 PM, Mira Limbeck wrote: > Signed-off-by: Mira Limbeck > --- > src/PVE/Firewall.pm | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm > index 6ac3038..cd3b911 100644 > --- a/src/PVE/Firewall.pm > +++ b/src/PVE/Firewall.pm > @@

[pve-devel] [PATCH firewall] add 'log_nf_conntrack' option description

2019-03-19 Thread Mira Limbeck
Signed-off-by: Mira Limbeck --- src/PVE/Firewall.pm | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm index 6ac3038..cd3b911 100644 --- a/src/PVE/Firewall.pm +++ b/src/PVE/Firewall.pm @@ -1248,6 +1248,12 @@ our $host_option_properties = {

Re: [pve-devel] [PATCH qemu-server] api/resume: allow to resume 'to-disk suspended' VMs

2019-03-19 Thread Thomas Lamprecht
On 3/19/19 1:23 PM, Dominik Csapak wrote: > > Reviewed-by: Dominik Csapak > Tested-by: Dominik CSapak > thanks, with this tags: applied > On 19/03/2019 12:58, Thomas Lamprecht wrote: >> Signed-off-by: Thomas Lamprecht >> Cc: Dominik Csapak >> --- >>   PVE/API2/Qemu.pm | 18 -

Re: [pve-devel] [PATCH qemu-server] api/resume: allow to resume 'to-disk suspended' VMs

2019-03-19 Thread Dominik Csapak
Reviewed-by: Dominik Csapak Tested-by: Dominik CSapak On 19/03/2019 12:58, Thomas Lamprecht wrote: Signed-off-by: Thomas Lamprecht Cc: Dominik Csapak --- PVE/API2/Qemu.pm | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Q

Re: [pve-devel] [PATCH docs] Reword krbd option description

2019-03-19 Thread Thomas Lamprecht
On 3/19/19 1:06 PM, Alwin Antreich wrote: > On Tue, Mar 19, 2019 at 01:00:29PM +0100, Thomas Lamprecht wrote: >> On 3/19/19 12:56 PM, Alwin Antreich wrote: >>> Reword the description of the KRBD option to reflect its current use for >>> VMs only. A container needs to use KRBD for a mapped device an

Re: [pve-devel] [PATCH docs] Reword krbd option description

2019-03-19 Thread Alwin Antreich
On Tue, Mar 19, 2019 at 01:00:29PM +0100, Thomas Lamprecht wrote: > On 3/19/19 12:56 PM, Alwin Antreich wrote: > > Reword the description of the KRBD option to reflect its current use for > > VMs only. A container needs to use KRBD for a mapped device anyway and > > is not affected by this option.

Re: [pve-devel] [PATCH docs] Reword krbd option description

2019-03-19 Thread Thomas Lamprecht
On 3/19/19 12:56 PM, Alwin Antreich wrote: > Reword the description of the KRBD option to reflect its current use for > VMs only. A container needs to use KRBD for a mapped device anyway and > is not affected by this option. > > Signed-off-by: Alwin Antreich > --- > pve-storage-rbd.adoc | 3 +--

[pve-devel] [PATCH qemu-server] api/resume: allow to resume 'to-disk suspended' VMs

2019-03-19 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht Cc: Dominik Csapak --- PVE/API2/Qemu.pm | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 3c0ad23..99e37d8 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -2444,14 +2444,28 @@

[pve-devel] [PATCH docs] Reword krbd option description

2019-03-19 Thread Alwin Antreich
Reword the description of the KRBD option to reflect its current use for VMs only. A container needs to use KRBD for a mapped device anyway and is not affected by this option. Signed-off-by: Alwin Antreich --- pve-storage-rbd.adoc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --g

[pve-devel] applied: [PATCH dab 1/2] add support for Debian 10 Buster

2019-03-19 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- DAB.pm | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/DAB.pm b/DAB.pm index cba8548..2a6f3de 100644 --- a/DAB.pm +++ b/DAB.pm @@ -319,7 +319,9 @@ sub new { if $arch !~ m/^(i386|amd64)$/; my $suite = $config->{su

[pve-devel] applied: [PATCH dab 2/2] add support for Ubuntu 19.04 Disco Dingo

2019-03-19 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- DAB.pm | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/DAB.pm b/DAB.pm index 2a6f3de..b79826e 100644 --- a/DAB.pm +++ b/DAB.pm @@ -365,6 +365,8 @@ sub new { $config->{ostype} = "ubuntu-18.04"; } elsif ($suite eq 'cosm

[pve-devel] applied: [PATCH container] setup: add support for Ubuntu 19.04 Disco Dingo

2019-03-19 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- src/PVE/LXC/Setup/Ubuntu.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/src/PVE/LXC/Setup/Ubuntu.pm b/src/PVE/LXC/Setup/Ubuntu.pm index 56de9f1..e18d396 100644 --- a/src/PVE/LXC/Setup/Ubuntu.pm +++ b/src/PVE/LXC/Setup/Ubuntu.pm @@ -12,6 +12,7 @@ use PVE

[pve-devel] applied: [PATCH qemu] build qemu multithreaded

2019-03-19 Thread Thomas Lamprecht
On 3/18/19 11:56 AM, Dominik Csapak wrote: > same as in pve-kernel where we have --jobs=auto > > Signed-off-by: Dominik Csapak > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index 9e13081..b73514a 100644 > --- a/Makefile > +++ b/M

Re: [pve-devel] [PATCH qemu-server 1/3] add correct comment about savevm-start

2019-03-19 Thread Thomas Lamprecht
On 3/19/19 9:17 AM, Dominik Csapak wrote: > Signed-off-by: Dominik Csapak > --- > PVE/QemuConfig.pm | 4 > 1 file changed, 4 insertions(+) > > diff --git a/PVE/QemuConfig.pm b/PVE/QemuConfig.pm > index b2d4e45..8fae4fc 100644 > --- a/PVE/QemuConfig.pm > +++ b/PVE/QemuConfig.pm > @@ -138,6 +

[pve-devel] [PATCH qemu-server 3/3] increase timeout when resuming suspended VM

2019-03-19 Thread Dominik Csapak
when the state is on a slow storage, it can take a while to load it Signed-off-by: Dominik Csapak --- PVE/QemuServer.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 05fb4be..580c432 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuSe

[pve-devel] [PATCH qemu-server 1/3] add correct comment about savevm-start

2019-03-19 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- PVE/QemuConfig.pm | 4 1 file changed, 4 insertions(+) diff --git a/PVE/QemuConfig.pm b/PVE/QemuConfig.pm index b2d4e45..8fae4fc 100644 --- a/PVE/QemuConfig.pm +++ b/PVE/QemuConfig.pm @@ -138,6 +138,10 @@ sub __snapshot_save_vmstate { } my $driv

[pve-devel] [PATCH qemu-server 2/3] suspend: output some information about progress

2019-03-19 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- PVE/QemuServer.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index b3b95ef..05fb4be 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -5226,6 +5226,7 @@ sub vm_start { if ($is_suspended) {

[pve-devel] applied: [PATCH qemu-server v3 0/5] implement suspend to disk

2019-03-19 Thread Thomas Lamprecht
On 3/14/19 5:04 PM, Dominik Csapak wrote: > implement suspend to disk for vms > > the idea is the following: > > add a 'suspending' lock > halt execution of the vm > save the vmstate to a file/disk/etc. > hard poweroff the vm (qmp quit) > add 'suspended' lock > > on the next start check for 'sus