On 7/8/19 2:12 PM, Dominik Csapak wrote:
> 0 || '1' will always return '1'
>
> Signed-off-by: Dominik Csapak
> ---
> www/manager6/ha/Resources.js | 10 --
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/www/manager6/ha/Resources.js b/www/manager6/ha/Resources.js
> ind
On 7/8/19 4:29 PM, Dominik Csapak wrote:
> otherwise a user cannot delete an ip from an interface
>
> Signed-off-by: Dominik Csapak
> ---
> PVE/API2/Network.pm | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/PVE/API2/Network.pm b/PVE/API2/Network.pm
> index 00337fe2..5e2abda1 10
On 7/8/19 3:48 PM, Dominik Csapak wrote:
> the osdid has not only a single digit
> also add more regression tests for this
>
> Signed-off-by: Dominik Csapak
> ---
> PVE/Diskmanage.pm | 2 +-
> test/disk_tests/usages/disklist | 2 ++
> test/disk_tests/u
On 7/8/19 1:54 PM, Fabian Grünbichler wrote:
> patch #1 is new (inline of pve-cluster commits)
> patch #2 is adapated for #1
>
> rest are clean cherry-picks
>
> Fabian Grünbichler (6):
> 5to6: add Corosync resolve helper
> 5to6: attempt to resolve corosync rings
> 5to6: reword/-structure co
On 7/8/19 2:36 PM, Fabian Grünbichler wrote:
> to fix an issue where valid tickets could be rejected 5 minutes after a
> key rotation, where the minimum age is exactly 0 seconds.
>
> thanks Dominik for triaging!
>
> Signed-off-by: Fabian Grünbichler
> (cherry picked from commit 5bb966fe5d6f3f6a3
On 7/8/19 6:26 PM, Stefan Reiter wrote:
> Signed-off-by: Stefan Reiter
> ---
>
> Hope it's the correct style now.
>
> I decided to this into its own commit, since it could technically be applied
> to
> the docs for pve 5 as well (although with little visual effect).
in general OK and good (tha
Parts about multicast and RRP have been removed entirely. Instead, a new
section 'Corosync Redundancy' has been added explaining the concept of
links and link priorities.
Signed-off-by: Stefan Reiter
---
pvecm.adoc | 372 +
1 file changed, 147
Signed-off-by: Stefan Reiter
---
Hope it's the correct style now.
I decided to this into its own commit, since it could technically be applied to
the docs for pve 5 as well (although with little visual effect).
pvecm.adoc | 30 +++---
1 file changed, 15 insertions(+), 1
In short, EFI variables can get quite big, and the old sysfs
interface was made for when they couldn't. A few firmwares out there
have such big variables, and if those are accessed through the sysfs
backed interface one gets a "Input/Output Error". 'grub-install'
chokes on that error when it iterat
otherwise a user cannot delete an ip from an interface
Signed-off-by: Dominik Csapak
---
PVE/API2/Network.pm | 7 +++
1 file changed, 7 insertions(+)
diff --git a/PVE/API2/Network.pm b/PVE/API2/Network.pm
index 00337fe2..5e2abda1 100644
--- a/PVE/API2/Network.pm
+++ b/PVE/API2/Network.pm
@@
the osdid has not only a single digit
also add more regression tests for this
Signed-off-by: Dominik Csapak
---
PVE/Diskmanage.pm | 2 +-
test/disk_tests/usages/disklist | 2 ++
test/disk_tests/usages/disklist_expected.json | 31 +++
te
to fix an issue where valid tickets could be rejected 5 minutes after a
key rotation, where the minimum age is exactly 0 seconds.
thanks Dominik for triaging!
Signed-off-by: Fabian Grünbichler
(cherry picked from commit 5bb966fe5d6f3f6a30e86724c024f80ebebacfba)
---
this cherry-pick was missed, a
hi
On Fri, Jul 05, 2019 at 07:00:08PM +0200, Thomas Lamprecht wrote:
> On 7/5/19 1:27 PM, Oguz Bektas wrote:
> > this allows the following mount options for lxc container rootfs or
> > mountpoints:
> > * noatime
> > * nosuid
> > * noexec
> > * nodev
> >
> > Signed-off-by: Oguz Bektas
> > ---
> >
0 || '1' will always return '1'
Signed-off-by: Dominik Csapak
---
www/manager6/ha/Resources.js | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/www/manager6/ha/Resources.js b/www/manager6/ha/Resources.js
index 0b142c8d..bd6c337c 100644
--- a/www/manager6/ha/Resource
On Mon, 8 Jul 2019 11:09:38 +0200
Aaron Lauterer wrote:
> Some things that I have seen, mostly regarding style and readability.
Thanks big time - incorporated and will be included in my v2
>
> On 7/5/19 6:31 PM, Stoiko Ivanov wrote:
> > With the recently added support for booting ZFS on root on
copied from PVE 6.x's pve-cluster.
since Corosync 2.x has a different default value for ip_version, we
don't want to backport this for general usage in PVE::Corosync. the
check here needs the default of Corosync 3.x, since that is what we
upgrade to.
Signed-off-by: Fabian Grünbichler
---
PVE/CL
and fix a typo as well
Signed-off-by: Fabian Grünbichler
(cherry picked from commit 388a505104eae0d8c6389b247aba7eca713b03ba)
---
PVE/CLI/pve5to6.pm | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/PVE/CLI/pve5to6.pm b/PVE/CLI/pve5to6.pm
index f84a8c1b..33079553 1
patch #1 is new (inline of pve-cluster commits)
patch #2 is adapated for #1
rest are clean cherry-picks
Fabian Grünbichler (6):
5to6: add Corosync resolve helper
5to6: attempt to resolve corosync rings
5to6: reword/-structure corosync message
5to6: fail if a corosync node has neither ring
Signed-off-by: Fabian Grünbichler
(cherry picked from commit e6b956df7bb1522e0cf47e2afb3dbb609a88b750)
---
PVE/CLI/pve5to6.pm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/PVE/CLI/pve5to6.pm b/PVE/CLI/pve5to6.pm
index 33079553..e7c9a24f 100644
--- a/PVE/CLI/pve5to6.pm
+++ b/PVE/CLI/pve5to
to improve readability
Signed-off-by: Fabian Grünbichler
(cherry picked from commit 5684da54dc15fb2a5bb26fdef95db67cea836a21)
---
PVE/CLI/pve5to6.pm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/PVE/CLI/pve5to6.pm b/PVE/CLI/pve5to6.pm
index e7c9a24f..0c7efbb1 100644
---
to avoid just printing the subheader with no results
Signed-off-by: Fabian Grünbichler
(cherry picked from commit c4bc94bb7b019e3c5a4518eda55883bb989146c5)
---
PVE/CLI/pve5to6.pm | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/PVE/CLI/pve5to6.pm b/PVE/CLI/
and only fail if unable to
Signed-off-by: Fabian Grünbichler
(backported from commit 669211d8bbb0857275669068fcbf62560782b888)
use local copy of resolve_hostname_like_corosync instead of
pve-cluster's.
Signed-off-by: Fabian Grünbichler
---
PVE/CLI/pve5to6.pm | 13 +++--
1 file change
On Mon, Jul 08, 2019 at 10:38:26AM +0200, Thomas Lamprecht wrote:
> Am 7/8/19 um 9:33 AM schrieb Fabian Grünbichler:
> > when globally disabling the FW, or on shutdown of firewall service.
> > otherwise, ebtables rules are leftover (and perpetually displayed as
> > pending changes as well).
> >
>
with qemu 4.0 we can make use of the new pcie-root-ports with settings
for the width/speed which can resolve issues with some hardware combinations
when negioating link speed
so we add a new q35 cfg that we include with machine types >= 4.0
to preserve live migration of machines without passthroug
Not much here but one instance where it helps to simplify a sentence.
On 7/5/19 6:31 PM, Stoiko Ivanov wrote:
Editing the kernel commandline is described centrally in the bootloaders
chapter. Refer to it where appropriate (qm-pci-passthrough.adoc).
Additionally update the documentation on ZFS a
Some things that I have seen, mostly regarding style and readability.
On 7/5/19 6:31 PM, Stoiko Ivanov wrote:
With the recently added support for booting ZFS on root on EFI systems via
`systemd-boot` the documentation needs adapting (mostly related to editing
the kernel commandline).
This patch
Am 7/5/19 um 2:44 PM schrieb Fabian Grünbichler:
> series should be cherry-pickable to stable-5, except patches #1 (see note)
> and #6 (obviously ;))
>
> Fabian Grünbichler (6):
> 5to6: attempt to resolve corosync rings
> 5to6: reword/-structure corosync messages
> 5to6: fail if a corosync
Am 7/5/19 um 2:44 PM schrieb Fabian Grünbichler:
> series should be cherry-pickable to stable-5, except patches #1 (see note)
> and #6 (obviously ;))
>
for the next time please just send the cherry-picks a long, may even just
send two series for each branch with the respective patches, so that
t
Am 7/8/19 um 9:33 AM schrieb Fabian Grünbichler:
> when globally disabling the FW, or on shutdown of firewall service.
> otherwise, ebtables rules are leftover (and perpetually displayed as
> pending changes as well).
>
> the actual removal is done by taking the same code path as when
> disabling
when globally disabling the FW, or on shutdown of firewall service.
otherwise, ebtables rules are leftover (and perpetually displayed as
pending changes as well).
the actual removal is done by taking the same code path as when
disabling just ebtables on the cluster level, i.e. applying an empty
ru
30 matches
Mail list logo
