[pve-devel] [PATCH pve-manager] Move logout button to the top right corner of the workspace

2016-04-19 Thread Emmanuel Kasper
This makes us similar to 90% of sites and thus make the interface more familiar to new users. --- www/manager6/Workspace.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js index 771e067..685b909 100644 --- a/www/manage

[pve-devel] RFC: move logout button to the top right corner of the GUI

2016-04-19 Thread Emmanuel Kasper
Hi Since we changed quite a lot of things in the GUI in this cycle, I would like to propose to move the logout button to the top right corner of the workspace GUI. The most popular websites where people have an account follow this convention ( Facebook, Gmail, Github ) so it makes the GUI more fa

[pve-devel] [PATCH tar v2 5/5] Update README

2016-04-19 Thread Emmanuel Kasper
--- README | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/README b/README index 6b00738..e5f2dfd 100644 --- a/README +++ b/README @@ -1,7 +1,5 @@ We recompile tar ourselfs to fix bug: -https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=737226 +https://bugs.debian.org/c

[pve-devel] [PATCH tar v2 3/5] Update version and changelog for 1.27.1+pve.3

2016-04-19 Thread Emmanuel Kasper
--- Makefile | 4 ++-- changelog | 8 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 8062c1c..edee266 100644 --- a/Makefile +++ b/Makefile @@ -1,10 +1,10 @@ -RELEASE=4.0 +RELEASE=4.1 # Note: compile as root fail, so you need to do that as unp

[pve-devel] [PATCH tar v2 4/5] reenable upload

2016-04-19 Thread Emmanuel Kasper
--- Makefile | 2 -- 1 file changed, 2 deletions(-) diff --git a/Makefile b/Makefile index edee266..ade5611 100644 --- a/Makefile +++ b/Makefile @@ -38,8 +38,6 @@ deb ${DEB}: ${TARSRC} .PHONY: upload upload: - # this is no longer required - false umount /pve/${RELEASE}; m

[pve-devel] [PATCH tar v2 1/5] Remove fix-sparse-archives.patch

2016-04-19 Thread Emmanuel Kasper
the issue is fixed in tar-1.27.1 --- Makefile | 1 - fix-sparse-archives.patch | 18 -- 2 files changed, 19 deletions(-) delete mode 100644 fix-sparse-archives.patch diff --git a/Makefile b/Makefile index 64aa3ed..3ed2e94 100644 --- a/Makefile +++ b/Makefile @@

[pve-devel] [PATCH tar v2 2/5] Add acls-bugfix patch for PVE Bug 928

2016-04-19 Thread Emmanuel Kasper
--- Makefile | 1 + acls-bugfix.patch | 109 ++ 2 files changed, 110 insertions(+) create mode 100644 acls-bugfix.patch diff --git a/Makefile b/Makefile index 3ed2e94..8062c1c 100644 --- a/Makefile +++ b/Makefile @@ -33,6 +33,7 @@ de

[pve-devel] fix acl for tar 1.27.1

2016-04-19 Thread Emmanuel Kasper
Since the backport of tar 1.28 breaks dpkg-deb, we cherry pick the ACL bugfix patch from upstream to tar 1.27.1 The patch applies cleanly and works as expected. ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman

Re: [pve-devel] Backport of Debian Strech tar 1.28 in the pve archive

2016-04-18 Thread Emmanuel Kasper
> > The problem seems to be with dpkg-deb and was fixed it upstream at: > https://anonscm.debian.org/cgit/dpkg/dpkg.git/commit/?id=fcfe4f3aa2f3cb7f8179d4f2fe6dd65e75f7bbdf > > So the back port of tar will also need dpkg fix(es) and is problematic. The problem is the hard coded position of the ta

[pve-devel] [PATCH tar 2/5] Don't pass the '--print-directory' MAKEFLAGS to debian/rules

2016-04-18 Thread Emmanuel Kasper
Calling a sub Makefile from a top Makefile causes make to pass a default 'w' flag aka print-directory. However debian/rules in tar packages use these inherited MAKEFLAGS without prepending a dash, causing the 'w' string to be interpreted as a target. The error is then as such: RSH="/usr/bin/rsh"

[pve-devel] [PATCH tar 1/5] rebuild our tar package by doing a backport from Debian Stretch

2016-04-18 Thread Emmanuel Kasper
changelog entries from our previous packages are dropped, as they would break the changelog version ordering ( ie we would have debian entries for 1.28, then our old own entries for 1.27, then our own entries for 1.28) --- Makefile | 6 +++--- changelog | 21 + 2 files change

[pve-devel] Backport of Debian Strech tar 1.28 in the pve archive

2016-04-18 Thread Emmanuel Kasper
Hi This patch serie updates creates a backport from the tar package 1.28 from Debian Stretch. It fixes the following bug https://bugzilla.proxmox.com/show_bug.cgi?id=928 ( creating a container from a template or restoring from a backup would create unwanted default acls ) The version string for th

[pve-devel] [PATCH tar 4/5] Add readme explaining the backport

2016-04-18 Thread Emmanuel Kasper
--- README.adoc | 32 1 file changed, 32 insertions(+) create mode 100644 README.adoc diff --git a/README.adoc b/README.adoc new file mode 100644 index 000..62b06e5 --- /dev/null +++ b/README.adoc @@ -0,0 +1,32 @@ +PVE backport of tar +~~~ + +

[pve-devel] [PATCH tar 5/5] Reenable upload target

2016-04-18 Thread Emmanuel Kasper
--- Makefile | 2 -- 1 file changed, 2 deletions(-) diff --git a/Makefile b/Makefile index 2b9f655..c5ca59b 100644 --- a/Makefile +++ b/Makefile @@ -37,8 +37,6 @@ deb ${DEB}: ${TARSRC} .PHONY: upload upload: - # this is no longer required - false umount /pve/${RELEASE}; m

[pve-devel] [PATCH tar 3/5] Remove fix-sparse-archive patches

2016-04-18 Thread Emmanuel Kasper
This was fixed in tar 1.27.1 --- Makefile | 1 - README| 7 --- fix-sparse-archives.patch | 18 -- 3 files changed, 26 deletions(-) delete mode 100644 README delete mode 100644 fix-sparse-archives.patch diff --git a/Makefile b/Makefile

[pve-devel] [PATCH pve-docs] Replace VM occurences with 'guest' or 'container' when appropriate

2016-04-13 Thread Emmanuel Kasper
also replace Qemu/KVM with QemuServer as it is the detailed term used in the vzdump man page --- vzdump.adoc | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/vzdump.adoc b/vzdump.adoc index fc42468..b8794d9 100644 --- a/vzdump.adoc +++ b/vzdump.adoc @@ -25

Re: [pve-devel] Generic term to cover VMs and containers in the documentation

2016-04-13 Thread Emmanuel Kasper
On 04/12/2016 02:09 PM, Fabian Grünbichler wrote: >> Emmanuel Kasper hat am 12. April 2016 um 13:55 >> geschrieben: >> What would be a good term to cover both of these ? >> >> I am thinking of either 'machine' or 'virtualized system'. &

[pve-devel] [PATCH pve-docs v2] Add subchapter about ACLs, and make even more clear what quotas are about

2016-04-12 Thread Emmanuel Kasper
Document that use of a tmpdir is recommended when doing a 'suspend' backup to a NFS share. --- changes since v1: * move NFS related hints to vzdump documentation, recommend tmpdir * reword quota description pct.adoc| 8 vzdump.adoc | 14 ++ 2 files changed, 18 insertio

[pve-devel] Generic term to cover VMs and containers in the documentation

2016-04-12 Thread Emmanuel Kasper
Hi While reading the vzdump documentation, I notice that we use there the term VM to describe both containers and qemu based virtualized systems. For instance: 'vzdump' is a utility to make consistent snapshots of running virtual machines (VMs). It basically creates an archive of the VM private

Re: [pve-devel] [PATCH pve-docs] Add subchapter about ACLs, and make even more clear what quotas are about

2016-04-12 Thread Emmanuel Kasper
On 04/11/2016 05:28 PM, Dietmar Maurer wrote: >> +Please be aware that NFS do not store ACLs, so if you plan to do snapshots >> and >> +restores from a container to a NFS storage, it is advised to disable ACLs >> +in the options of your container mountpoint to avoid bad surprises later. > > Isn't

[pve-devel] [PATCH pve-docs] Add subchapter about ACLs, and make even more clear what quotas are about

2016-04-11 Thread Emmanuel Kasper
Some users thinks quotas relate to the amount of diskspace used for the mountpoint as the whole. --- pct.adoc | 11 +++ 1 file changed, 11 insertions(+) diff --git a/pct.adoc b/pct.adoc index 82f257b..cd817dd 100644 --- a/pct.adoc +++ b/pct.adoc @@ -401,6 +401,8 @@ Similarly device mounts

Re: [pve-devel] [PATCH manager] www: monitor: support page up/down, home/end

2016-04-11 Thread Emmanuel Kasper
On 04/11/2016 02:28 PM, Wolfgang Bumiller wrote: > Actually... the home/end key part might annoy some people... > Thoughts? Disclaimer: I rarely use the Monitor in the GUI. But yes people would expect HOME and END to interact within the input field, not with other stuff on the display, so it's b

[pve-devel] [PATCH pve-manager 1/2] Recheck field validation after manually enabling the input field of a ComboGrid

2016-04-11 Thread Emmanuel Kasper
Calling setDisabled(true) on a component makes it valid, but calling setDisabled(false) afterwards did not retrigger a validation check This fixes a serious bug which was happening in the following conditions, for instance in the template tab of LXC Wizard: 1) user selects a storage 2) this trigg

[pve-devel] [PATCH pve-manager 2/2] Do not disable a invalid previous tab, as this make the tab fields valid

2016-04-11 Thread Emmanuel Kasper
disable_at() iterates over all the fields of the previously selected tab and disables them however disabling an input field makes it valid for validation purposes. I can't see a reason why disabling the tab fields is needed, since the tab already hidden and after testing, it seems safe to remove t

[pve-devel] [PATCH pve-manager v3] Update French po files

2016-04-11 Thread Emmanuel Kasper
+8,15 @@ msgstr "" "Project-Id-Version: pve-manager 2.0\n" "Report-Msgid-Bugs-To: \n" "POT-Creation-Date: Tue Apr 5 11:10:38 2016\n" -"PO-Revision-Date: 2013-10-16 11:26+0100\n" -"Last-Translator: Damien PIQUET \n" +"PO-Revision-Dat

[pve-devel] [PATCH pve-manager] Overrides Ext.Msg.alert() to always display an Error Icon

2016-04-07 Thread Emmanuel Kasper
--- www/manager6/Toolkit.js | 22 ++ 1 file changed, 22 insertions(+) diff --git a/www/manager6/Toolkit.js b/www/manager6/Toolkit.js index 91a4fa6..a8089aa 100644 --- a/www/manager6/Toolkit.js +++ b/www/manager6/Toolkit.js @@ -137,6 +137,28 @@ Ext.define('PVE.Datepicker', {

[pve-devel] [PATCH pve-manager v2] Update French po files

2016-04-07 Thread Emmanuel Kasper
+8,15 @@ msgstr "" "Project-Id-Version: pve-manager 2.0\n" "Report-Msgid-Bugs-To: \n" "POT-Creation-Date: Tue Apr 5 11:10:38 2016\n" -"PO-Revision-Date: 2013-10-16 11:26+0100\n" -"Last-Translator: Damien PIQUET \n" +"PO-Revision-Dat

[pve-devel] [PATCH pve-manager] Update French po files

2016-04-05 Thread Emmanuel Kasper
+8,15 @@ msgstr "" "Project-Id-Version: pve-manager 2.0\n" "Report-Msgid-Bugs-To: \n" "POT-Creation-Date: Tue Apr 5 11:10:38 2016\n" -"PO-Revision-Date: 2013-10-16 11:26+0100\n" -"Last-Translator: Damien PIQUET \n" +"PO-Revision-Dat

[pve-devel] [PATCH pve-manager] Use Ext.apply instead of applyIf when loading a task window

2016-04-04 Thread Emmanuel Kasper
Without this the window title is not displayed --- www/manager6/window/TaskViewer.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/window/TaskViewer.js b/www/manager6/window/TaskViewer.js index c3cea39..0750ffd 100644 --- a/www/manager6/window/TaskViewer.js +++

[pve-devel] [PATCH pve-manager v2] SafeDestroy.js: allow to submit the form with Enter key

2016-04-04 Thread Emmanuel Kasper
also set focus on the confirm field of the Destroy Window on display --- www/manager6/window/SafeDestroy.js | 8 1 file changed, 8 insertions(+) diff --git a/www/manager6/window/SafeDestroy.js b/www/manager6/window/SafeDestroy.js index ec4a2f5..047c48b 100644 --- a/www/manager6/window/S

Re: [pve-devel] [PATCH pve-manager] SafeDestroy.js: allow to submit the form with Enter key

2016-04-04 Thread Emmanuel Kasper
On 03/31/2016 10:29 AM, Dietmar Maurer wrote: > >> @@ -102,7 +108,12 @@ Ext.define('PVE.window.SafeDestroy', { >> fieldLabel: gettext('Please enter the {item.type} ID to >> confirm'), >> }, >> hideTrigger: true, >> -allowBlank

[pve-devel] [PATCH pve-manager] Fix ExtJS6 locales file name

2016-03-31 Thread Emmanuel Kasper
--- PVE/ExtJSIndex.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/ExtJSIndex.pm b/PVE/ExtJSIndex.pm index 90c6ddd..4dcf454 100644 --- a/PVE/ExtJSIndex.pm +++ b/PVE/ExtJSIndex.pm @@ -29,7 +29,7 @@ _EOD - + _EOD my $jssrc = <<_EOJS; -- 2

[pve-devel] [PATCH pve-manager] Readme.md: add pveproxy restart as neeed step for testing ExtJS6 GUI

2016-03-31 Thread Emmanuel Kasper
--- www/manager6/Readme.md | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/www/manager6/Readme.md b/www/manager6/Readme.md index 81c3b26..e59c6aa 100644 --- a/www/manager6/Readme.md +++ b/www/manager6/Readme.md @@ -11,6 +11,10 @@ symlink the ext6 dir in pve-manager to the

[pve-devel] [PATCH pve-manager] SafeDestroy.js: allow to submit the form with Enter key

2016-03-31 Thread Emmanuel Kasper
also set focus on the confirm field of the Destroy Window on display --- www/manager6/window/SafeDestroy.js | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/www/manager6/window/SafeDestroy.js b/www/manager6/window/SafeDestroy.js index ec4a2f5..fea9594 100644 --- a

[pve-devel] [PATCH pve-manager 1/2] fix tree update when migrating a VM/CT

2016-03-24 Thread Emmanuel Kasper
original bug: migrated items where not appearing under the target server implentation: remove items whose 'node' property has changed as these items need to be removed before being re-added also rename the local variable 'changed' to 'moved' to better differentiate between what is updated in plac

[pve-devel] [PATCH pve-manager 2/2] disable console button for templates

2016-03-24 Thread Emmanuel Kasper
--- www/manager6/qemu/Config.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/qemu/Config.js b/www/manager6/qemu/Config.js index dce4792..7b1ebb7 100644 --- a/www/manager6/qemu/Config.js +++ b/www/manager6/qemu/Config.js @@ -244,6 +244,7 @@ Ext.define('PVE.qemu.Config', {

[pve-devel] [PATCH pve-manager v2] Do not turn the strings CT and VM into separate localizable strings

2016-03-23 Thread Emmanuel Kasper
According to the PO files, translators keep 'CT' and 'VM' unchanged --- change since v1: * keep CT/VM out of the gettext string, to reduce the amount of translation needed www/manager6/lxc/CmdMenu.js | 10 +- www/manager6/qemu/CmdMenu.js | 8 2 files changed, 9 insertions(+),

[pve-devel] [PATCH pve-manager v3] Do not use the term 'VM' as a generic name for containers and qemu VMs

2016-03-23 Thread Emmanuel Kasper
and get the Window text to display from the calling function --- change since v2: * use the same gettext string for CTs and VMs to reduce the amount of stuff to localize www/manager6/lxc/Config.js | 11 +-- www/manager6/qemu/Config.js| 10 -- www/manager6/window/S

[pve-devel] [PATCH pve-manager] Do not turn the strings CT and VM into separate localizable strings

2016-03-21 Thread Emmanuel Kasper
as it happens, even the translators of non-latin alphabet languages always leave those intact in their translations --- www/manager6/lxc/CmdMenu.js | 8 www/manager6/qemu/CmdMenu.js | 8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/www/manager6/lxc/CmdMenu.js b

[pve-devel] Do not use the term 'VM' as a generic name for containers and qemu VMs

2016-03-21 Thread Emmanuel Kasper
changes since first patch: * call gettext() properly with a string instead of dynamic parameter ( would have been hard to translate ... ) * pass the whole sentence message to gettext() instead of breaking it in word groups This should help doing a better translation especially for right-to-le

[pve-devel] [PATCH pve-manager v2] Do not use the term 'VM' as a generic name for containers and qemu VMs

2016-03-21 Thread Emmanuel Kasper
and get the Window text to display from the calling function --- www/manager6/lxc/Config.js | 11 +-- www/manager6/qemu/Config.js| 10 -- www/manager6/window/SafeDestroy.js | 12 ++-- 3 files changed, 23 insertions(+), 10 deletions(-) diff --git a/www/manag

[pve-devel] [PATCH pve-manager] Do not use the term 'VM' as a generic name for containers and qemu VMs

2016-03-21 Thread Emmanuel Kasper
instead get the machine type ('CT' or 'VM') from the calling function --- www/manager6/lxc/Config.js | 3 ++- www/manager6/qemu/Config.js| 3 ++- www/manager6/window/SafeDestroy.js | 16 +++- 3 files changed, 15 insertions(+), 7 deletions(-) diff --git a/www/manager6

[pve-devel] [PATCH pve-manager] requires manual entering VM id before enabling the delete Button for VMs

2016-03-21 Thread Emmanuel Kasper
suggested by a user in https://bugzilla.proxmox.com/show_bug.cgi?id=360#c7 similar to the way github handles the deleting of a repository fixes: #360 --- PVE/ExtJSIndex6.pm | 1 + www/manager6/lxc/Config.js | 14 ++- www/manager6/qemu/Config.js| 14 ++- ww

[pve-devel] [PATCH pve-manager 5/5] Enable four first tabs of Qemu Panel

2016-03-19 Thread Emmanuel Kasper
--- www/manager6/qemu/Config.js | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/www/manager6/qemu/Config.js b/www/manager6/qemu/Config.js index 1d66621..70734a7 100644 --- a/www/manager6/qemu/Config.js +++ b/www/manager6/qemu/Config.js @@ -135,9 +135,7 @@ Ext.define('PVE.

[pve-devel] [PATCH pve-manager 1/5] Fix Qemu summary view:

2016-03-19 Thread Emmanuel Kasper
* replace scrollable with autoScroll and move to prototype body * use 'activate' to load store on F5 * do not set a height on the StatusView component: it hides some rows, and the framework sets a good working default height * replace deprecated 'rows' parameter in textareafield with height in pixe

[pve-devel] [PATCH pve-manager 2/5] initialize Diffstore sorters and filters with empty arrays

2016-03-19 Thread Emmanuel Kasper
ExtJS expect this properties to be arrays of Filters/Sorters objects, but sets them to null setting an empty array here allows to push sorters/filters easily later This fix allows loading the Hardware Tab of the Qemu Panel --- www/manager6/grid/ObjectGrid.js | 5 - 1 file changed, 4 insertio

[pve-devel] enable a first group of qemu panels

2016-03-19 Thread Emmanuel Kasper
This patch serie enables proper displaying of a first group of Qemu tabs. Nothing really new in this patch serie compared to the changes we already did for other panels. ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-b

[pve-devel] [PATCH pve-manager 4/5] Fixes Hardware View gridPanel for ExtJS6

2016-03-19 Thread Emmanuel Kasper
* uses Ext.apply() instead of applyIf(), because the parent class already set a toolbar to 'null', and we want to override that * use 'activate' event to redisplay content on page reload * use a managed listener via mon() so we ignore events from the store when the component is not displayed (

[pve-devel] [PATCH pve-manager 3/5] replace calls to new() with Ext.create()

2016-03-19 Thread Emmanuel Kasper
--- www/manager6/grid/ObjectGrid.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/www/manager6/grid/ObjectGrid.js b/www/manager6/grid/ObjectGrid.js index 466e7be..159c9c8 100644 --- a/www/manager6/grid/ObjectGrid.js +++ b/www/manager6/grid/ObjectGrid.js @@ -82,12 +82,12 @

[pve-devel] [PATCH pve-manager] Don't set a fix size for MPResize window

2016-03-18 Thread Emmanuel Kasper
Due to the font increase of the Crisp theme, the text was truncated Instead of setting manually window size, let the items of the component freely expend to what they need ( layout 'fit') --- www/manager6/lxc/MPResize.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/www/manager6/lxc/MPResi

[pve-devel] [PATCH pve-manager 3/5] use proper xtype name

2016-03-15 Thread Emmanuel Kasper
--- www/manager6/lxc/CreateWizard.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/lxc/CreateWizard.js b/www/manager6/lxc/CreateWizard.js index fee77d8..a1a7b57 100644 --- a/www/manager6/lxc/CreateWizard.js +++ b/www/manager6/lxc/CreateWizard.js @@ -58,7 +58,7 @@

[pve-devel] [PATCH pve-manager 2/5] fix delayed store loading

2016-03-15 Thread Emmanuel Kasper
Because the store loading delay, it can be that reload() fails on trying to load an undefined store, if the user switched tabs in the meantime --- www/manager6/grid/BackupView.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/grid/BackupView.js b/www/manager6/grid

[pve-devel] last fixes for LXC

2016-03-15 Thread Emmanuel Kasper
this patch series completes the adaptation of lxc components to ExtJS all components should be now working in LXC except boot ordering settings which requires a class from the qemu folder ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.

[pve-devel] [PATCH pve-manager 4/5] use Ext.apply() instead of Ext.applyIf() to properly load child items

2016-03-15 Thread Emmanuel Kasper
--- www/manager6/window/Wizard.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/window/Wizard.js b/www/manager6/window/Wizard.js index 0e6b02d..cc7f3fb 100644 --- a/www/manager6/window/Wizard.js +++ b/www/manager6/window/Wizard.js @@ -171,7 +171,7 @@ Ext.define('

[pve-devel] [PATCH pve-manager 5/5] Enlarge Wizard window vertically to accomodate all our LXC settings

2016-03-15 Thread Emmanuel Kasper
Without this, the summary grid in the end of the LXC creation wizard needs to be scrolled to see some settings. Note that we still want to use a fixed height, so that all wizard panels have the same height and next/previous buttons are always displayed at the same place. --- www/manager6/window/W

[pve-devel] [PATCH pve-manager 1/5] use 'refresh' event to redisplay the grid after loading the store

2016-03-15 Thread Emmanuel Kasper
'datachanged' event is not actualizing the component with ExtJS6, but 'refresh' does. --- www/manager6/lxc/Snapshot.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/lxc/Snapshot.js b/www/manager6/lxc/Snapshot.js index 7b2e33a..bded7cd 100644 --- a/www/manager6/lx

[pve-devel] [PATCH pve-manager 2/3] Enable last remaining lxc panels

2016-03-14 Thread Emmanuel Kasper
--- www/manager6/lxc/Config.js | 36 +--- 1 file changed, 17 insertions(+), 19 deletions(-) diff --git a/www/manager6/lxc/Config.js b/www/manager6/lxc/Config.js index 8902c86..491a5f8 100644 --- a/www/manager6/lxc/Config.js +++ b/www/manager6/lxc/Config.js @@ -121,

[pve-devel] [PATCH pve-manager 1/3] css improvements for crisp theme

2016-03-14 Thread Emmanuel Kasper
* usability improvement for enabled buttons: in the default theme, ExtJS uses two different nuances of grey to distinguish enabled or disabled buttons the problem is that compared to the full black of the panels titles, it gives the impression that everything is disabled (the contrast is not strong

[pve-devel] [PATCH pve-manager 3/3] Fix LXC summary view:

2016-03-14 Thread Emmanuel Kasper
* replace scrollable with autoScroll and move to prototype body * use 'activate' to load store on F5 * do not set a height on the StatusView component: it hides some rows, and the framework sets a good working default height --- www/manager6/lxc/StatusView.js | 1 - www/manager6/lxc/Summary.js

[pve-devel] [PATCH pve-manager v2] update leaf nodes instead of removing / readding them

2016-03-14 Thread Emmanuel Kasper
if the selected node has its status changed between stop & running, the node was removed and then readded during the remove / add process the 'selected' status of the node was lost if it has one instead of deleting / readding the node, we update now its content this was the default behaviour for s

Re: [pve-devel] [PATCH pve-manager] reselect the current node after a tree refresh

2016-03-10 Thread Emmanuel Kasper
This patch triggers a not so beautiful flicker of the tab panel, please ignore I have a better patch on the way. On 03/10/2016 03:43 PM, Emmanuel Kasper wrote: > if the selected node has its status changed between stop & > running, the node is removed and then readded > during the

Re: [pve-devel] [PATCH manager 04/10] ext6migrate: fix dropboxes in Storage Edit windows

2016-03-10 Thread Emmanuel Kasper
> fix dropboxes in Storage Edit windows I guess you mean comboboxes here, otherwie some people might thing we have a new cloud based storage plugin ! ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pv

[pve-devel] [PATCH pve-manager] reselect the current node after a tree refresh

2016-03-10 Thread Emmanuel Kasper
if the selected node has its status changed between stop & running, the node is removed and then readded during the remove / add process the 'selected' status of the node is lost if it has one, so we need to reselect it this fixes a graphical bug where starting/stopping a VM/container would displa

[pve-devel] [PATCH pve-manager 6/6] fix storage selector 'change' event handling

2016-03-09 Thread Emmanuel Kasper
the initial loading of the storage selector fires a 'change' event via the 'onLoad' method of its parent class at that point the value of the storage selector is empty, and the callback function fails --- www/manager6/lxc/ResourceEdit.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/www/

[pve-devel] [PATCH pve-manager 4/6] copy missing methods from ExtJS 4 Parser.js

2016-03-09 Thread Emmanuel Kasper
--- www/manager6/Parser.js | 142 - 1 file changed, 141 insertions(+), 1 deletion(-) diff --git a/www/manager6/Parser.js b/www/manager6/Parser.js index 5f15a76..68a6b70 100644 --- a/www/manager6/Parser.js +++ b/www/manager6/Parser.js @@ -5,6 +5,16 @

[pve-devel] [PATCH pve-manager 2/6] load/reload stores of tabpanel children on 'activate' event

2016-03-09 Thread Emmanuel Kasper
--- www/manager6/lxc/DNS.js | 5 ++--- www/manager6/lxc/Network.js | 4 +--- www/manager6/lxc/Options.js | 5 ++--- www/manager6/lxc/Resources.js| 2 +- www/manager6/lxc/SnapshotTree.js | 4 ++-- 5 files changed, 8 insertions(+), 12 deletions(-) diff --git a/www/manager6/lx

[pve-devel] [PATCH pve-manager 5/6] Fix ComboBoxes when adding a mountpoint

2016-03-09 Thread Emmanuel Kasper
reasoning identic to: commit 548b29644df81408fc0fb4f3f450047e906c26c7 adapt KVComboBoxes to pass store items using 'comboItems' parameter --- www/manager6/lxc/ResourceEdit.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/www/manager6/lxc/ResourceEdit.js b/www/manager6/lxc

[pve-devel] [PATCH pve-manager 1/6] fix lxc console selection ComboBox for extjs6

2016-03-09 Thread Emmanuel Kasper
reasoning identic to commit 548b29644df81408fc0fb4f3f450047e906c26c7 adapt KVComboBoxes to pass store items using 'comboItems' parameter commit 7515e62236b9f3c8317c3aa0dbf470e2b8efdd71 ext6migrate fix model behaviour for KVComboBox --- www/manager6/lxc/Options.js | 6 +++--- 1 file changed, 3 in

[pve-devel] [PATCH pve-manager 3/6] fix display of lxc console button text

2016-03-09 Thread Emmanuel Kasper
same reasoning as 841343e1c80a1d81a0e4fa90def389983f4a60fe do not use applyIf when adding items in initComponent() --- www/manager6/button/ConsoleButton.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/button/ConsoleButton.js b/www/manager6/button/ConsoleButton

[pve-devel] first patch serie for LXC panel

2016-03-09 Thread Emmanuel Kasper
this patch serie fixes a first group of Lxc tabs ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH pve-manager 2/3] do not use applyIf when adding items in initComponent()

2016-03-03 Thread Emmanuel Kasper
our parent class Ext.grid.GridPanel sets 'tbar: null' and Ext.applyIf() will only apply our property if it is undefined, so switch to Ext.apply() it is safe to use Ext.apply() because none of these classes is further extended, so we don't have to worry that might me might override a toolbar set fu

[pve-devel] [PATCH pve-manager 3/3] enable a first group of LXC panels

2016-03-03 Thread Emmanuel Kasper
--- www/manager6/lxc/Config.js | 110 ++--- 1 file changed, 55 insertions(+), 55 deletions(-) diff --git a/www/manager6/lxc/Config.js b/www/manager6/lxc/Config.js index a05fb08..8902c86 100644 --- a/www/manager6/lxc/Config.js +++ b/www/manager6/lxc/Config.j

[pve-devel] [PATCH pve-manager 1/3] adapt KVComboBoxes to pass store items using 'comboItems' parameter

2016-03-03 Thread Emmanuel Kasper
we used a custom 'data' property to pass around the items to add to the store, but this property is now used by ExtJS to store content for the component template also move to declarative style, saves lines --- www/manager6/form/Boolean.js| 17 +++- www/manager6/form/BusTypeSel

[pve-devel] [PATCH pve-container] Document the difference between stop and shutdown

2016-03-03 Thread Emmanuel Kasper
--- src/PVE/API2/LXC/Status.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/PVE/API2/LXC/Status.pm b/src/PVE/API2/LXC/Status.pm index c5fca29..01dfe12 100644 --- a/src/PVE/API2/LXC/Status.pm +++ b/src/PVE/API2/LXC/Status.pm @@ -198,7 +198,7 @@ __PACKAGE__->register_

[pve-devel] [PATCH qemu-server] document for end users the differences between shutdown and stop

2016-03-03 Thread Emmanuel Kasper
--- PVE/API2/Qemu.pm | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index efac2c7..1bff2f7 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -1623,7 +1623,8 @@ __PACKAGE__->register_method({ method => 'POST', protected

[pve-devel] [PATCH pve-manager 1/2] fix Timezones window

2016-03-02 Thread Emmanuel Kasper
Ext.regModel() was removed from the framework rewrite the store in declarative style with inline data --- www/manager6/data/TimezoneStore.js | 34 -- www/manager6/node/TimeEdit.js | 2 +- 2 files changed, 9 insertions(+), 27 deletions(-) diff --git a/www/mana

[pve-devel] [PATCH pve-manager 2/2] fix display cluster status in Datacenter Panel

2016-03-02 Thread Emmanuel Kasper
use getData() instead of accessing the intern raw value --- www/manager6/dc/Summary.js | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/www/manager6/dc/Summary.js b/www/manager6/dc/Summary.js index e6d8236..ba9f774 100644 --- a/www/manager6/dc/Summary.js +++ b/www/manage

[pve-devel] [PATCH pve-manager 2/3] adapt BondSelector to our ExtJS6 KVComboBox parameters

2016-02-29 Thread Emmanuel Kasper
--- www/manager6/form/BondModeSelector.js | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/www/manager6/form/BondModeSelector.js b/www/manager6/form/BondModeSelector.js index 4504e8b..97445d5 100644 --- a/www/manager6/form/BondModeSelector.js +++ b/www/manager6/

[pve-devel] [PATCH pve-manager 3/3] move component properties to prototype body

2016-02-29 Thread Emmanuel Kasper
this is needed for 'displayField' also remove redundant truthiness test which is also taking place at the beginning of setNodeName() --- www/manager6/form/BridgeSelector.js | 66 + 1 file changed, 30 insertions(+), 36 deletions(-) diff --git a/www/manager6/for

[pve-devel] [PATCH pve-manager 1/3] push column items individually

2016-02-29 Thread Emmanuel Kasper
looks like ExtJS is not automatically flattening the array anymore and items in a multidimensionnal array are not displayed with ExtJS6 lxc/Config.js is still commented because we haven't reached this part in the upgrade, but fixing there too --- www/manager6/dc/AuthEdit.js | 4 ++-- www/man

Re: [pve-devel] [PATCH pve-manager 2/4] enable more node panels

2016-02-29 Thread Emmanuel Kasper
On 02/29/2016 03:40 PM, Dietmar Maurer wrote: > The network panel shows "Pending changes" - always (although > there are no changes). > >> title: gettext('Network'), >> itemId: 'network', >> -// xtype: 'pveNodeNetworkView' >> -xtype: '

[pve-devel] [PATCH pve-manager 3/4] reload stores of tabpanel children on 'activate' event

2016-02-29 Thread Emmanuel Kasper
--- www/manager6/node/DNSView.js | 2 +- www/manager6/node/ServiceView.js | 2 +- www/manager6/node/TimeView.js| 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/www/manager6/node/DNSView.js b/www/manager6/node/DNSView.js index e756c18..4dff115 100644 --- a/www/manager6

[pve-devel] [PATCH pve-manager 4/4] use 'refresh' event to reload the grid after the store content has changed

2016-02-29 Thread Emmanuel Kasper
this fixes the problem that buttons and grid contents were not updated after a service stop/start --- www/manager6/node/ServiceView.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/node/ServiceView.js b/www/manager6/node/ServiceView.js index c701ccb..ab0c1a8 1006

[pve-devel] [PATCH pve-manager 1/4] move tabs of a sub tabpanel to the left by default

2016-02-29 Thread Emmanuel Kasper
This takes a bit of screensize, but is fine as long as the browser horizontal screen size is at least 1280 px ( 92 % of desktop users in 2016 according to StatsCounter) Still usable for the remaining small displays, but horizontal scrolling is needed for grids with a lot of columns. Moving the sub

[pve-devel] [PATCH pve-manager 2/4] enable more node panels

2016-02-29 Thread Emmanuel Kasper
--- www/manager6/node/Config.js | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/www/manager6/node/Config.js b/www/manager6/node/Config.js index 7a65ae2..b617c86 100644 --- a/www/manager6/node/Config.js +++ b/www/manager6/node/Config.js @@ -134,26 +134,22 @@ Ext.def

[pve-devel] [PATCH pve-manager] fix HA Group Selector display

2016-02-25 Thread Emmanuel Kasper
displayField must now be set in class body, take opportunity to move out other config properties from initComponent() --- www/manager6/ha/GroupSelector.js | 66 ++-- 1 file changed, 30 insertions(+), 36 deletions(-) diff --git a/www/manager6/ha/GroupSelector.js

Re: [pve-devel] [PATCH manager 2/4] ext6migrate: fix LogView

2016-02-25 Thread Emmanuel Kasper
> Signed-off-by: Dominik Csapak > --- > www/manager6/panel/LogView.js | 22 ++ > 1 file changed, 6 insertions(+), 16 deletions(-) > > diff --git a/www/manager6/panel/LogView.js b/www/manager6/panel/LogView.js > index 49be118..9ed1213 100644 > --- a/www/manager6/panel/LogView.

Re: [pve-devel] [PATCH manager 1/4] ext6migrate: fix Task History for nodes

2016-02-25 Thread Emmanuel Kasper
> diff --git a/ww/manager6/node/Tasks.js b/www/manager6/node/Tasks.js > index e76a982..6a73ef8 100644 > --- a/www/manager6/node/Tasks.js > +++ b/www/manager6/node/Tasks.js > @@ -2,7 +2,9 @@ Ext.define('PVE.node.Tasks', { > extend: 'Ext.grid.GridPanel', > > alias: ['widget.pveNodeTasks']

[pve-devel] [PATCH pve-manager 3/3] load the store later, move non-dynamic properties and methods to class body

2016-02-25 Thread Emmanuel Kasper
this fixes two problems: * we were loading the store before the parent ComboGrid class could put a listener on the load event * displayField must now be set in class body, take opportunity to move out what we can of the mega initComponent() this two fixes allow the HA GroupEdit Window to p

[pve-devel] [PATCH pve-manager 1/3] change xtype name to follow ExtJS and our own conventions

2016-02-25 Thread Emmanuel Kasper
this also fixes the problem that the method Ext.ComponentQuery.query() was outputting a warning since it did not know if it should perform a lookup for a class name or a xtype --- www/manager6/form/NodeSelector.js | 2 +- www/manager6/ha/GroupEdit.js | 2 +- www/manager6/window/Migrate.js

[pve-devel] [PATCH pve-manager 2/3] reload stores of tabpanel children on 'activate' event

2016-02-25 Thread Emmanuel Kasper
Tabpanel reload -> send 'show' event -> reload child panel store do not work with ExtJS6 but Tabpanel reload -> reload child panel -> child send 'show' event -> reload a grid store in the panel still works so we don't blindly replace the 'show' events everywhere but only when the event was ex

Re: [pve-devel] [PATCH 1/4] refactor pveam to use it with our CLI Handler.

2016-02-24 Thread Emmanuel Kasper
By the way what do pveam stand for ? Is that for pve appliance manager ? ( helps to remember purpose of command) On 02/24/2016 12:10 PM, Wolfgang Link wrote: > --- > PVE/CLI/Makefile | 2 +- > PVE/CLI/pveam.pm | 88 > > bin/Makefile |

[pve-devel] [PATCH pve-manager 1/2] Add documentation header for ObjectGrid.js

2016-02-24 Thread Emmanuel Kasper
also enhance the documentation header for DiffStore and UpdateStore --- www/manager6/data/DiffStore.js | 12 +++- www/manager6/data/UpdateStore.js | 3 +++ www/manager6/grid/ObjectGrid.js | 14 ++ 3 files changed, 24 insertions(+), 5 deletions(-) diff --git a/www/manager6/

[pve-devel] [PATCH pve-manager 2/2] Revert "ext5migrate: do not set a custome idProperty for the KeyValue model"

2016-02-24 Thread Emmanuel Kasper
This reverts commit 3150236aa5ebed6565c6eaf64126bb1195693396. Without using an idProperty in the KeyValue model, the id of each store item is autogenerated, and the DiffStore always recreate the whole store content every second instead of updating the fields where values have changed. Recreating t

[pve-devel] [PATCH pve-manager] rename component 'id' property to 'stateId'

2016-02-22 Thread Emmanuel Kasper
ExtJS6 requires a stateId if we want to save the component state (seems it is not autogenerated anymore from 'id') this fix the selection of timeframes in the Summary View also move properties out of initComponent() also remove code which duplicates framework code: setting stateEvents to 'select'

[pve-devel] [PATCH pve-manager 1/4] Fix initial loading of Node tabpanel:

2016-02-17 Thread Emmanuel Kasper
* push initial components individually * replace ifor the momment pvepanels with basic panels so we can at least load the first tabs * group ceph component with previous push call as they require the same capabilities --- www/manager6/node/Config.js | 65 ++---

[pve-devel] [PATCH pve-manager 2/4] remove redundant model definition

2016-02-17 Thread Emmanuel Kasper
pve-services is already declared in ServiceView.js provoking a namespace clash --- www/manager6/node/Subscription.js | 8 1 file changed, 8 deletions(-) diff --git a/www/manager6/node/Subscription.js b/www/manager6/node/Subscription.js index 8101d1b..c4e9979 100644 --- a/www/manager6/no

[pve-devel] [PATCH pve-manager 4/4] rename 'autoscroll' parameter to 'scrollable' following framework changes

2016-02-17 Thread Emmanuel Kasper
also move static parameters out of initComponent() for proper panel initialization --- www/manager6/node/Summary.js | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/www/manager6/node/Summary.js b/www/manager6/node/Summary.js index 6d44869..b01f848 100644 --- a/www/

[pve-devel] [PATCH pve-manager 3/4] temporary disable accessibility warnings

2016-02-17 Thread Emmanuel Kasper
ExtJS6 adds accessibility (aria) support to the framework, which means special handling of space/enter key and panels title, and a lot of warnings / errors in the browser console Aria support will be reenabled after all the components are migrated to ExtJS6 --- www/manager6/Utils.js | 7 +++

[pve-devel] [PATCH pve-manager 1/2] use 'refresh' event to reload the grid after filtering the store

2016-02-16 Thread Emmanuel Kasper
'datachanged' event was not reloading the store with ExtJS5, but 'refresh' does. According to the API description 'refresh' seems to be what we need: http://docs.sencha.com/extjs/5.1/5.1.0-apidocs/#!/api/Ext.data.AbstractStore-event-refresh also remove deprecated readme ( ExtJS6 do not have the 'c

<    2   3   4   5   6   7   8   9   10   >