[pve-devel] Qemu-Guest-Agent implementing problems

2014-11-25 Thread Wolfgang
Hi at all, I have some problems by implementing the qga. There are 4 commands (guest-shutdown, guest-suspend-disk, guest-suspend-ram, guest-suspend-hybrid) which does NOT return a response on success. How should i handle this. Have anyone an Idea? greetings __

[pve-devel] Question to code

2014-12-02 Thread Wolfgang
with or without ram? Greetings Wolfgang ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] Qemu nic link status

2014-12-09 Thread Wolfgang
Hallo, is there a way to get the Nic Link status from Qemu? Thanks for replying. Regrades Wolfgang ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] Qemu nic link status

2014-12-09 Thread Wolfgang
0,script=/var/lib/qemu-server/pve-bridge,downscript= >/var/lib/qemu-server/pve-bridgedown Is there something I have been missed? Regrades Wolfgang 2014-12-09 12:38 GMT+01:00 Alexandre DERUMIER : > Hi, > > >>is there a way to get the Nic Link status from Qemu? > > I have

Re: [pve-devel] Qemu nic link status

2014-12-09 Thread Wolfgang
for this ? > > (They are some example in net.c , qmp_set_link (), to get the current > status link.) > > Why do you need it exactly ? > > > > - Mail original - > De: "Wolfgang Link" > À: "aderumier" > Cc: "pve-devel" > E

Re: [pve-devel] [PATCHV3 pve-container 4/4] Prevent that a CT run at cloning.

2016-05-11 Thread Wolfgang
First step include without running container. Is this function in the code I want make it possible to clone if the container is running. 2016-05-11 9:18 GMT+02:00 Fabian Grünbichler : > > > Wolfgang Link hat am 10. Mai 2016 um 11:13 > geschrieben: > > > > > > If

Re: [pve-devel] [PATCH] Implements ZFSLocalPlugin.pm to use Zfs with volumes locally. You can snapshot on the volumes but only in a linear way.

2015-01-20 Thread Wolfgang
it depend on the features we will implement in this! This is not all. But your right it would be better extend on from an other. regards Wolfgang Link 2015-01-20 18:29 GMT+01:00 Adrian Costin : > I’ve been using a similar plugin for local zfs, basically a stripped down > version

Re: [pve-devel] [PATCH] ZFSPoolPlugin: Added the ability to use nested ZVOLs

2015-02-12 Thread Wolfgang
There is no need for a flag to do not autoimport, because first you can disable the storage in storage.cfg. and so it will not activated. Second one pool with iscsi export should not in the storage.cfg. Am 12.02.2015 21:25 schrieb "Pablo Ruiz" : > Hi, > > IMHO, I see no reason to not default for

Re: [pve-devel] [PATCH_V2] implement offline migration on zfs

2015-04-28 Thread Wolfgang
Hi, As fare I know is hyper-v shared nothing a live mig. Or Migration is a offline only migration. About the speed, this is at the moment limited by openssh. Am 29.04.2015 00:50 schrieb "Lindsay Mathieson" : > Just as a matter of curiosity - this is Live offline Migration? like > Hyper-V's > "Sha

[pve-devel] [PATCH] Bugfix 860: fix the upload from a VM when it is restricted.

2015-08-14 Thread Wolfgang
--- src/PVE/Network.pm | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/src/PVE/Network.pm b/src/PVE/Network.pm index b9d2d37..92162c3 100644 --- a/src/PVE/Network.pm +++ b/src/PVE/Network.pm @@ -73,15 +73,6 @@ sub setup_tc_rate_limit { return if !$rate;

Re: [pve-devel] [PATCH storage] migrate: snapshot parameter for use with replication

2017-05-22 Thread Wolfgang Bumiller
> > On May 22, 2017 at 10:16 AM Wolfgang Bumiller > > wrote: > > > > > > --- > > PVE/Storage.pm | 31 ++- > > 1 file changed, 22 insertions(+), 9 deletions(-) > > > > diff --git a/PVE/Storage.pm b/PVE/Stor

[pve-devel] [PATCH storage 2/2] migrate: replace target ip parameter with sshinfo parameter

2017-05-23 Thread Wolfgang Bumiller
--- PVE/API2/Storage/Content.pm | 3 ++- PVE/Storage.pm | 28 2 files changed, 14 insertions(+), 17 deletions(-) diff --git a/PVE/API2/Storage/Content.pm b/PVE/API2/Storage/Content.pm index 20c2eda..3449e35 100644 --- a/PVE/API2/Storage/Content.pm +++ b/

[pve-devel] [PATCH storage, qm, ct ] let storage_migrate take an ssh info hash

2017-05-23 Thread Wolfgang Bumiller
First storage patch is just the previous one resent (since the sshinfo patch is to be applied on top of it). Needless to say the pve-container & qemu-server changes need to be packaged together with these patches. Wolfgang Bumiller (2): migrate: snapshot parameter for use with replica

[pve-devel] [PATCH storage 1/2] migrate: snapshot parameter for use with replication

2017-05-23 Thread Wolfgang Bumiller
--- PVE/Storage.pm | 31 ++- 1 file changed, 22 insertions(+), 9 deletions(-) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index 5819bde..73f2976 100755 --- a/PVE/Storage.pm +++ b/PVE/Storage.pm @@ -525,7 +525,7 @@ sub abs_filesystem_path { } sub storage_migrate {

[pve-devel] [PATCH qemu-server] migrate: pass ssh_info to storage_migrate

2017-05-23 Thread Wolfgang Bumiller
--- PVE/QemuMigrate.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm index 5caac15..100c583 100644 --- a/PVE/QemuMigrate.pm +++ b/PVE/QemuMigrate.pm @@ -399,7 +399,7 @@ sub sync_disks { push @{$self->{online_local_volume

[pve-devel] [PATCH container] migrate: pass ssh_info to storage_migrate

2017-05-23 Thread Wolfgang Bumiller
--- src/PVE/LXC/Migrate.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/LXC/Migrate.pm b/src/PVE/LXC/Migrate.pm index 6b9687b..2f0244b 100644 --- a/src/PVE/LXC/Migrate.pm +++ b/src/PVE/LXC/Migrate.pm @@ -267,7 +267,7 @@ sub phase1 { foreach my $volid (keys %$vol

Re: [pve-devel] [PATCH pve-manager 05/18] PVE::Replication - use new calendar events instead of interval

2017-05-23 Thread Wolfgang Bumiller
On Tue, May 23, 2017 at 09:08:44AM +0200, Dietmar Maurer wrote: > And implement retry algorythm after failure: > > $next_sync = $state->{last_try} + 5*60*$fail_count; > > and limit to 3 failures. > > Signed-off-by: Dietmar Maurer > --- > PVE/API2/Replication.pm | 2 +- > PVE/CLI/pvesr.pm

Re: [pve-devel] [PATCH pve-manager 07/18] ReplicationTestEnv.pm: add job tracking log

2017-05-23 Thread Wolfgang Bumiller
On Tue, May 23, 2017 at 09:08:46AM +0200, Dietmar Maurer wrote: > To generate persistent logs with job state/config changes. > > Signed-off-by: Dietmar Maurer > --- > bin/test/ReplicationTestEnv.pm | 118 > +++-- > 1 file changed, 115 insertions(+), 3 deletio

Re: [pve-devel] [PATCH pve-manager 10/18] PVE::Replication::run_jobs - fix job start time

2017-05-23 Thread Wolfgang Bumiller
On Tue, May 23, 2017 at 09:08:49AM +0200, Dietmar Maurer wrote: > Value $now is ment for use inside regression tests. Normally > a job should get the actual start time. > > Signed-off-by: Dietmar Maurer > --- > PVE/Replication.pm | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > dif

Re: [pve-devel] [PATCH pve-manager 11/18] pvesr prepare-local-job: new helper

2017-05-23 Thread Wolfgang Bumiller
On Tue, May 23, 2017 at 09:08:50AM +0200, Dietmar Maurer wrote: > Prepare for starting a replication job. This is called on the target > node before replication starts. This call is for internal use, and > return a JSON object on stdout. The method first test if VM > reside on the local node. If s

[pve-devel] [PATCH storage 2/3] migrate: cleanup & fixup

2017-05-23 Thread Wolfgang Bumiller
The volume_snapshot call was missing the condition when to create a snapshot. Make the whole logic easier to follow with a $migration_snapshot boolean. Also get rid of the remote `pvesm free -snapshot` call by using import's new -delete-snapshot parameter. --- PVE/Storage.pm | 23 +

[pve-devel] [PATCH storage 3/3] Revert "free: added snapshot parameter"

2017-05-23 Thread Wolfgang Bumiller
This reverts commit a26e1abc70e087a7f42e8197ef080222990a680f. --- Not required anymore. PVE/API2/Storage/Content.pm | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/PVE/API2/Storage/Content.pm b/PVE/API2/Storage/Content.pm index 3449e35..daf8b95 100644 --- a/PVE/A

[pve-devel] [PATCH storage 1/3] import: add -delete-snapshot parameter

2017-05-23 Thread Wolfgang Bumiller
This deletes a snapshot on *success*, done directly in the CLI handler, as the rollback/delete on failure is already happening inside the plugin's import method. --- PVE/CLI/pvesm.pm | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/PVE/CLI/pvesm.pm b/PVE/CLI/pvesm.

Re: [pve-devel] [RFC PATCH 3/4] add genfont2 and unifont build-dependency

2017-05-23 Thread Wolfgang Bumiller
On Mon, May 22, 2017 at 06:14:57PM +0200, Dominik Csapak wrote: > this patch introduces a new tool to generate font data > it uses a new build-dependency, namely unifont, which is an opensource > font with printable charachters for the unicode range from > 0x to 0x > > we generate a file w

Re: [pve-devel] [RFC PATCH 4/4] use unifont and add support for wide-characters and diacritics

2017-05-23 Thread Wolfgang Bumiller
On Mon, May 22, 2017 at 06:14:58PM +0200, Dominik Csapak wrote: > this patch makes use of unifont with genfont2 and introduces support for > wide-characters and diacritics AFAIK "diacritic" is the more specific term (a combining glyph which modifies the pronunciation) which this implementation is

[pve-devel] applied: RFC: abstract raw syscall numbers out in a perl module

2017-05-24 Thread Wolfgang Bumiller
applied On Wed, May 10, 2017 at 03:03:44PM +0200, Thomas Lamprecht wrote: > The raw syscall numbers are problematic when porting PVE to other > architectures as for some reason the Linux syscall numbers differ between > those architectures. > The by h2ph produced syscall.ph file has all syscalls p

[pve-devel] applied: [PATCH qemu-server] improve error on '{full, linked} clone not available' error

2017-05-24 Thread Wolfgang Bumiller
applied to master & stable-4 On Tue, May 23, 2017 at 10:39:45AM +0200, Thomas Lamprecht wrote: > Signed-off-by: Thomas Lamprecht > --- > > instead of: > > Full clone feature is not available at /usr/share/perl5/PVE/API2/Qemu.pm > > line 2435 > > we get now: > > Full clone feature is not suppor

[pve-devel] applied [PATCH http-server] add json/mp3/oga/svg filetypes

2017-05-24 Thread Wolfgang Bumiller
On Thu, May 11, 2017 at 01:01:10PM +0200, Dominik Csapak wrote: > those are needed for the noVNC upgrade > > svg: button images > mp3/oga: bell sound of terminal > json: language files > > Signed-off-by: Dominik Csapak > --- > PVE/APIServer/AnyEvent.pm | 4 > 1 file changed, 4 insertions(+

[pve-devel] applied: [PATCH vncterm v2 0/4] vncterm improvements

2017-05-24 Thread Wolfgang Bumiller
applied whole series On Wed, May 24, 2017 at 11:37:47AM +0200, Dominik Csapak wrote: > this series cleans up the debian packaging, > adds new width/height parameters > introduces a new way to use a font > and introduces support for wide-characters and diacritics > > the height/width parameters ar

Re: [pve-devel] [PATCH manager 3/3] add more verbose warning for node shutdown/reboot

2017-05-24 Thread Wolfgang Bumiller
On Wed, May 24, 2017 at 12:16:39PM +0200, Emmanuel Kasper wrote: > On 05/12/2017 12:14 PM, Thomas Lamprecht wrote: > > Signed-off-by: Thomas Lamprecht > > --- > > > > I'm open for better warning message suggestions :-) > > I would reuse the already localized gettext String "Stop all VMs and > Co

[pve-devel] [PATCH storage 2/3] migrate: cleanup & fixup

2017-05-24 Thread Wolfgang Bumiller
The volume_snapshot call was missing the condition when to create a snapshot. Make the whole logic easier to follow with a $migration_snapshot boolean. Also get rid of the remote `pvesm free -snapshot` call by using import's new -delete-snapshot parameter. --- PVE/Storage.pm | 23 +

[pve-devel] [PATCH storage 1/3] import: add -delete-snapshot parameter

2017-05-24 Thread Wolfgang Bumiller
This deletes a snapshot on *success*, done directly in the CLI handler, as the rollback/delete on failure is already happening inside the plugin's import method. --- Actually wanted to send this series yesterday already... PVE/CLI/pvesm.pm | 13 - 1 file changed, 12 insertions(+), 1 d

[pve-devel] [PATCH storage 3/3] Revert "free: added snapshot parameter"

2017-05-24 Thread Wolfgang Bumiller
This reverts commit a26e1abc70e087a7f42e8197ef080222990a680f. --- PVE/API2/Storage/Content.pm | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/PVE/API2/Storage/Content.pm b/PVE/API2/Storage/Content.pm index 3449e35..daf8b95 100644 --- a/PVE/API2/Storage/Content.pm

[pve-devel] dropped: [PATCH storage 1/3] import: add -delete-snapshot parameter

2017-05-24 Thread Wolfgang Bumiller
Please ignore, I just forgot to remove this series from my send queue... ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] Building from Source - Dependency Sequencing Issue?

2017-05-29 Thread Wolfgang Bumiller
On Mon, May 29, 2017 at 12:10:58PM +0200, Dietmar Maurer wrote: > > > I'm building from source according to the document located at > > https://git.proxmox.com/?p=pve-common.git;a=blob;f=README.dev;h=4e0794890b6b865fb1a1b4a07cf4cd7e19ad9cf7;hb=HEAD > > and I've hit a stumbling block building qemu-

[pve-devel] applied: [PATCH manager v2] Fix #1386: track postfix daemon status via postfix@-

2017-05-29 Thread Wolfgang Bumiller
applied On Thu, May 18, 2017 at 11:10:52AM +0200, Emmanuel Kasper wrote: > --- > IMHO #1387 has a different scope. This patch here deals with > fixing the default reporting when a the status of one of our > default daemon is reported in a different unit. > #1387 is about *manually* changing the d

[pve-devel] [PATCH storage] migrate: implement rate limiting

2017-05-29 Thread Wolfgang Bumiller
Note that it does not apply to the local 'mkdir && cp' case. --- PVE/Storage.pm | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index ee2295a..7edda8f 100755 --- a/PVE/Storage.pm +++ b/PVE/Storage.pm @@ -525,7 +525,7 @@ sub

Re: [pve-devel] Building from Source - Dependency Sequencing Issue?

2017-05-30 Thread Wolfgang Bumiller
> On May 29, 2017 at 11:12 PM Michael Aldridge wrote: > > > If I understand this correctly, I should be able to build pve-firewall > and then qemu-server which would make the build order look like this: > > libqb.git > corosync-pve.git > pve-common.git + pve-guest-common.git Missing this one

[pve-devel] [RFC PATCH storage 1/1] migrate: add insecure parameter

2017-05-30 Thread Wolfgang Bumiller
This uses mtunnel's new -run-command parameter in combination with the ssh-info's network cidr option to use an unprotected TCP port. --- PVE/Storage.pm | 26 +++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index 7edda8f..cf

[pve-devel] [RFC PATCH storage 0/1] insecure storage migration support & unrelated qemu-server fixes

2017-05-30 Thread Wolfgang Bumiller
Note that one of the separate qemu-server fixes needs the pve-common patches here as well which is why I sent them in the same series. Also note that this series currently only covers qemu-server as far as the insecure migration option is concerned. I'll do the pve-container side when I know it's

[pve-devel] [PATCH common 2/2] tools: next_unused_port: use IPPROTO_TCP explicitly

2017-05-30 Thread Wolfgang Bumiller
Otherwise perl tries to bind+listen on a UDP socket if the TCP socket fails - which is a waste since we're looking for TCP ports. Additionall since UDP doesn't support listen(), perl will return EOPNOTSUPP instead of, say, EADDRINUSE. (We don't care about the error in this code though.) --- src/PV

[pve-devel] [PATCH cluster 1/2] sshinfo: add the network cidr

2017-05-30 Thread Wolfgang Bumiller
--- pve-storage needs to pass it to mtunnel data/PVE/Cluster.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/data/PVE/Cluster.pm b/data/PVE/Cluster.pm index 7504410..731acc5 100644 --- a/data/PVE/Cluster.pm +++ b/data/PVE/Cluster.pm @@ -1872,7 +1872,8 @@ sub get_ssh_info

[pve-devel] [PATCH common 1/2] tools: unused ports: optional address parameter

2017-05-30 Thread Wolfgang Bumiller
While it should be impossible to bind to a wildcard address when the port is in use by any other address there's one case where this is allowed, and that's when the port is in use by an ipv6 address while trying to bind to an ipv4 wildcard. This currently happens when qemu finds ::1 for the 'localh

[pve-devel] [RFC PATCH cluster 2/2] mtunnel: add -run-command for insecure pipes

2017-05-30 Thread Wolfgang Bumiller
While we still need ssh to initiate the command, the data can then be sent insecurely to the IP and port the mtunnel command tells us to connect to. --- data/PVE/CLI/pvecm.pm | 80 +-- 1 file changed, 78 insertions(+), 2 deletions(-) diff --git a/da

[pve-devel] [PATCH qemu-server] migration: implement insecure offline migration

2017-05-30 Thread Wolfgang Bumiller
--- This moves the $migration_type logic from phase2 to phase1. PVE/QemuMigrate.pm | 30 +- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm index 100c583..bf756a6 100644 --- a/PVE/QemuMigrate.pm +++ b/PVE/QemuMigr

[pve-devel] [PATCH REBASED qemu-server 1/2] fix #1229: more explicit spice port allocation

2017-05-30 Thread Wolfgang Bumiller
We cannot look for ports on "any" wildcard address while letting qemu bind to "localhost", this may lead to a qemu process occupying ::1 while the next search successfully finds the same port available for IPv4's '*' address. Instead, we now lookup the IP of the desired family for 'localhost'. Not

[pve-devel] [PATCH qemu-server 2/2] fix burst length parameter names and pass them to qemu

2017-05-30 Thread Wolfgang Bumiller
bps_max_length & friends were wrongly named and were only passed to qemu when hot-applying changes. They can only be passed via the command line with their new names. For consistency let's rename them all, that way they're all in one place. Fixes #1195 (for real this time). --- PVE/QemuServer.pm

Re: [pve-devel] [PATCH v3 pve-manager 16/23] PVE::Replication::replicate - implement replicate

2017-05-31 Thread Wolfgang Link
Comment inline On 05/30/2017 03:20 PM, Dietmar Maurer wrote: diff --git a/PVE/Replication.pm b/PVE/Replication.pm index ee0b841b..d235b49d 100644 --- a/PVE/Replication.pm +++ b/PVE/Replication.pm @@ -219,12 +219,138 @@ sub prepare { return $last_snapshots; } -sub replicate { -my ($job

Re: [pve-devel] [PATCH v3 pve-manager 01/23] pvesr: add pve storage replication tool

2017-05-31 Thread Wolfgang Link
On 05/30/2017 03:19 PM, Dietmar Maurer wrote: Just added code to configure jobs. Replication itself is not implemented. Signed-off-by: Dietmar Maurer --- PVE/API2/Cluster.pm | 7 ++ PVE/API2/Makefile | 2 + PVE/API2/Nodes.pm | 7 ++ PVE/API2/Replicatio

[pve-devel] [PATCH pve-manager] Untaint the content of pve-replication-state.json.

2017-05-31 Thread Wolfgang Link
JSON::decode will not untaint the raw text, so we get problems with the last_sync, which we use many times in the code with open3. --- PVE/Replication.pm | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/PVE/Replication.pm b/PVE/Replication.pm index 0787..ce0c863f 100644

Re: [pve-devel] replica problems

2017-06-01 Thread Wolfgang Link
On 06/01/2017 11:01 AM, Dominik Csapak wrote: hi, i tested the replica patches a bit and noticed following problems: 1. when we have a job with a failcount > 0, we can't delete/disable the job (only manually deleting from /etc/pve/replication.cfg works) This is not implemented yet 2. the

[pve-devel] [PATCH manager] replication: use a dedicated lock file

2017-06-01 Thread Wolfgang Bumiller
Otherwise $update_job_state's file_set_contents() call drops our lock. --- PVE/Replication.pm | 5 +++-- bin/test/ReplicationTestEnv.pm | 2 ++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/PVE/Replication.pm b/PVE/Replication.pm index 96c54b09..9256177c 100644 --- a/P

[pve-devel] applied: [PATCH novnc v3 0/6] upgrade novnc

2017-06-02 Thread Wolfgang Bumiller
applied On Mon, May 22, 2017 at 04:58:09PM +0200, Dominik Csapak wrote: > this series upgrades novnc, our patches, and the git structure > > changes from v2: > * instead of having a big app.js in the git repo, we build the bundle > ourselves with node-es6-module-transpiler > > this novnc versi

[pve-devel] applied: [PATCH novnc] request size with vncshell and container console

2017-06-02 Thread Wolfgang Bumiller
applied On Wed, May 24, 2017 at 12:30:49PM +0200, Dominik Csapak wrote: > when opening the console*tab* on a host or a container, > give the current size to the vncproxy api call, so that the console > fills the entire tab > > resizing the window/iframe does not resize the vnc console > (because

[pve-devel] applied: [PATCH container] allow width and height parameter for vncproxy

2017-06-02 Thread Wolfgang Bumiller
applied On Wed, May 24, 2017 at 12:30:48PM +0200, Dominik Csapak wrote: > so that the novnc console can request a different screen size > > Signed-off-by: Dominik Csapak > --- > src/PVE/API2/LXC.pm | 22 ++ > 1 file changed, 22 insertions(+) > > diff --git a/src/PVE/API2/LX

[pve-devel] applied: [PATCH manager] allow width and height parameter for vncshell

2017-06-02 Thread Wolfgang Bumiller
applied On Wed, May 24, 2017 at 12:30:47PM +0200, Dominik Csapak wrote: > so that novnc can request a different screen size > > Signed-off-by: Dominik Csapak > --- > PVE/API2/Nodes.pm | 22 ++ > 1 file changed, 22 insertions(+) > > diff --git a/PVE/API2/Nodes.pm b/PVE/API2/

[pve-devel] applied: [PATCH manager] fix #1400: do not use defaultButton in NotesEdit window

2017-06-02 Thread Wolfgang Bumiller
applied (I wonder if we should make ctrl+enter commit the text...) On Thu, Jun 01, 2017 at 02:37:35PM +0200, Dominik Csapak wrote: > with a defaultButton set, we cannot enter a newline into a textarea > > Signed-off-by: Dominik Csapak > --- > www/manager6/window/NotesEdit.js | 1 + > 1 file ch

[pve-devel] applied: [PATCH common] calendarevent: check range for start also without repetition

2017-06-02 Thread Wolfgang Bumiller
applied On Thu, Jun 01, 2017 at 02:17:10PM +0200, Dominik Csapak wrote: > else an event like "61" never finishes when calculating the next event > > also add regression tests for this and other range checks > > Signed-off-by: Dominik Csapak > --- > src/PVE/CalendarEvent.pm| 1 + > test/ca

[pve-devel] applied: [PATCH manager] remove "read-only" option from container root disk

2017-06-02 Thread Wolfgang Bumiller
applied to master & stable-4 On Mon, May 29, 2017 at 10:50:57AM +0200, Dominik Csapak wrote: > with root-only enabled, you cannot start the conainer anymore, > so we remove it there entirely > > Signed-off-by: Dominik Csapak > --- > www/manager6/lxc/ResourceEdit.js | 15 --- > 1 fil

[pve-devel] applied: [RFC PATCH] Do not internationalize 'Pools' when used in Ceph Context

2017-06-02 Thread Wolfgang Bumiller
applied to master & stable-4 On Mon, May 29, 2017 at 11:55:13AM +0200, Emmanuel Kasper wrote: > This is a Ceph domain term and should not be translated like OSD, ... > Galician had "Virtual Groups" for Pools, which does not apply for > Ceph Context. > Also most languages were using 'Pools' anyway.

[pve-devel] applied: [PATCH storage] fix #1379: return size as number instead of string

2017-06-02 Thread Wolfgang Bumiller
applied to master & stable-4 On Tue, May 16, 2017 at 02:53:54PM +0200, Dominik Csapak wrote: > this caused the webinterface to sort alphabetically instead of numerical > when sorting by image size > > Signed-off-by: Dominik Csapak > --- > PVE/Storage/LVMPlugin.pm | 4 ++-- > 1 file changed, 2 i

[pve-devel] Improvements in the replica functionality

2017-06-02 Thread Wolfgang Link
This 3 patches handle some errors. ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH pve-manager 1/4] Set $running to 0 if undef.

2017-06-02 Thread Wolfgang Link
check_running returns if the guest is not running undef. In the logfunc we get a undefined warning. To avoid this we can set it to 0. --- PVE/Replication.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/PVE/Replication.pm b/PVE/Replication.pm index ae3b771d..ae486e16 100644 --- a/PVE/Repl

[pve-devel] Add job creation checks.

2017-06-02 Thread Wolfgang Link
This checks be should in plugin because they can differ on replication type. ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH pve-manager 2/4] add systemd.timer for pve run

2017-06-02 Thread Wolfgang Link
--- bin/init.d/Makefile | 4 +++- bin/init.d/pvesr.service | 5 + bin/init.d/pvesr.timer | 11 +++ debian/postinst | 4 4 files changed, 23 insertions(+), 1 deletion(-) create mode 100644 bin/init.d/pvesr.service create mode 100644 bin/init.d/pvesr.timer diff

[pve-devel] [PATCH pve-guest-common 2/2] Add check if target exists.

2017-06-02 Thread Wolfgang Link
--- PVE/ReplicationConfig.pm | 15 +++ 1 file changed, 15 insertions(+) diff --git a/PVE/ReplicationConfig.pm b/PVE/ReplicationConfig.pm index 87b3710..1a30e81 100644 --- a/PVE/ReplicationConfig.pm +++ b/PVE/ReplicationConfig.pm @@ -193,6 +193,13 @@ sub guest_exists { } +sub targ

[pve-devel] [PATCH pve-guest-common 1/2] Add check if guest exists.

2017-06-02 Thread Wolfgang Link
--- PVE/ReplicationConfig.pm | 15 +++ 1 file changed, 15 insertions(+) diff --git a/PVE/ReplicationConfig.pm b/PVE/ReplicationConfig.pm index 092c497..87b3710 100644 --- a/PVE/ReplicationConfig.pm +++ b/PVE/ReplicationConfig.pm @@ -186,6 +186,13 @@ sub check_for_existing_jobs {

[pve-devel] [PATCH pve-manager 3/4] Add a message that deletion a job will take some time.

2017-06-02 Thread Wolfgang Link
--- PVE/API2/ReplicationConfig.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/API2/ReplicationConfig.pm b/PVE/API2/ReplicationConfig.pm index 0095bf37..e1623f73 100644 --- a/PVE/API2/ReplicationConfig.pm +++ b/PVE/API2/ReplicationConfig.pm @@ -211,6 +211,7 @@ __PACKAGE__->register_meth

[pve-devel] [PATCH pve-manager] Add checks when job is created.

2017-06-02 Thread Wolfgang Link
We must know if the target and guest exists to avoid creation faulty jobs. --- PVE/API2/ReplicationConfig.pm | 6 ++ 1 file changed, 6 insertions(+) diff --git a/PVE/API2/ReplicationConfig.pm b/PVE/API2/ReplicationConfig.pm index e1623f73..d067356f 100644 --- a/PVE/API2/ReplicationConfig.pm +

[pve-devel] [PATCH pve-manager 4/4] Remove guest form replication.cfg it no vms exists.

2017-06-02 Thread Wolfgang Link
--- PVE/Replication.pm | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/PVE/Replication.pm b/PVE/Replication.pm index ae486e16..c0f80778 100644 --- a/PVE/Replication.pm +++ b/PVE/Replication.pm @@ -90,8 +90,11 @@ sub job_status { die "internal error - not implem

Re: [pve-devel] [PATCH pve-guest-common 2/2] Add check if target exists.

2017-06-02 Thread Wolfgang Link
And what is about the cross cluster replication? I tried to make it generic. On 06/02/2017 12:10 PM, Dietmar Maurer wrote: +sub target_exists { +my ($class, $target) = @_; + +my $nodelist = PVE::Cluster::get_members(); + +return defined($nodelist->{$target}); +} + This function is

[pve-devel] [PATCHV2 pve-manager Add job creation checks] Add job creation checks.

2017-06-05 Thread Wolfgang Link
We must know if the target and guest exists to avoid creation faulty jobs. --- PVE/API2/ReplicationConfig.pm | 9 + 1 file changed, 9 insertions(+) V2 remove the abstraction in pve-guest- common and check directly. diff --git a/PVE/API2/ReplicationConfig.pm b/PVE/API2/ReplicationConfig.p

[pve-devel] [PATCH container] migrate: implement insecure storage migration

2017-06-06 Thread Wolfgang Bumiller
--- src/PVE/LXC/Migrate.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/PVE/LXC/Migrate.pm b/src/PVE/LXC/Migrate.pm index 2f0244b..e78ea89 100644 --- a/src/PVE/LXC/Migrate.pm +++ b/src/PVE/LXC/Migrate.pm @@ -264,10 +264,11 @@ sub phase1 { die "can't migrate CT

[pve-devel] [PATCH storage 3/3] migrate: insecure: untaint the received ip/port

2017-06-06 Thread Wolfgang Bumiller
--- PVE/Storage.pm | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index 5f6650d..f952c8a 100755 --- a/PVE/Storage.pm +++ b/PVE/Storage.pm @@ -672,9 +672,8 @@ sub storage_migrate { if ($insecure) { my $pid

[pve-devel] [PATCH cluster] add sshinfo_to_command_base

2017-06-06 Thread Wolfgang Bumiller
required for rsync's --rsh --- data/PVE/Cluster.pm | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/data/PVE/Cluster.pm b/data/PVE/Cluster.pm index 731acc5..05897ed 100644 --- a/data/PVE/Cluster.pm +++ b/data/PVE/Cluster.pm @@ -1877,15 +1877,21 @@ sub get_ssh_info {

[pve-devel] [PATCH storage 2/3] migrate: don't include the hostname in rsync's rsh command

2017-06-06 Thread Wolfgang Bumiller
--- Requires: [PATCH cluster] add sshinfo_to_command_base PVE/Storage.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index 04682bb..5f6650d 100755 --- a/PVE/Storage.pm +++ b/PVE/Storage.pm @@ -544,7 +544,8 @@ sub storage_migrate { my

[pve-devel] [PATCH storage 1/3] migrate: use the correct IP with rsync

2017-06-06 Thread Wolfgang Bumiller
--- PVE/Storage.pm | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index cfd7b2c..04682bb 100755 --- a/PVE/Storage.pm +++ b/PVE/Storage.pm @@ -540,8 +540,8 @@ sub storage_migrate { my $target_volid = "${target_storeid}:${target_vol

[pve-devel] [PATCH guest-common] migrate: set migration_type

2017-06-06 Thread Wolfgang Bumiller
Moved from qemu-server: set $opts->{migration_type} to a default or a value from datacenter.cfg. --- PVE/AbstractMigrate.pm | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/PVE/AbstractMigrate.pm b/PVE/AbstractMigrate.pm index 3cbe164..a0096fa 100644 --- a/PVE/Abstra

[pve-devel] [PATCH qemu-server] migrate: migration_type setting moved to pve-guest-common

2017-06-06 Thread Wolfgang Bumiller
--- PVE/QemuMigrate.pm | 14 -- 1 file changed, 14 deletions(-) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm index bf756a6..22c0d7d 100644 --- a/PVE/QemuMigrate.pm +++ b/PVE/QemuMigrate.pm @@ -436,20 +436,6 @@ sub phase1 { $conf->{lock} = 'migrate'; PVE::QemuConfig->

Re: [pve-devel] vm migration source vm crash, with qxl , qemu 2.7 -> qemu 2.9

2017-06-06 Thread Wolfgang Bumiller
On Fri, May 19, 2017 at 08:26:31AM +0200, Fabian Grünbichler wrote: > On Thu, May 18, 2017 at 08:52:57PM +0200, Alexandre DERUMIER wrote: > > mmm, seem to be random. (sometime it's work, sometime crash, with/without > > qemu 2.7 - 2.9) > > > > I have seen bug report on qemu mailing list, seem to

[pve-devel] applied: [PATCH storage 00/11] clean up pve-storage tests

2017-06-06 Thread Wolfgang Bumiller
applied whole series On Wed, May 17, 2017 at 11:42:27AM +0200, Fabian Grünbichler wrote: > the zfstests could benefit from further reworking/speedup, but this should > allow us to run them at build for now (~10s seems acceptable to me). > > Fabian Grünbichler (11): > zfstest: fix test 17 to act

[pve-devel] [PATCH] Remove $vmid form ssh prepare and finalize command.

2017-06-07 Thread Wolfgang Link
--- PVE/Replication.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/Replication.pm b/PVE/Replication.pm index 37642f57..e0cf02f0 100644 --- a/PVE/Replication.pm +++ b/PVE/Replication.pm @@ -116,7 +116,7 @@ sub remote_prepare_local_job { my ($ssh_info, $jobid, $v

[pve-devel] applied: [PATCH novnc] change color for highlighting pressed buttons

2017-06-07 Thread Wolfgang Bumiller
applied On Tue, Jun 06, 2017 at 12:09:09PM +0200, Dominik Csapak wrote: > Signed-off-by: Dominik Csapak > --- > ...change-higlight-color-for-pressed-buttons.patch | 26 > ++ > debian/patches/series | 1 + > 2 files changed, 27 insertions(+) > c

[pve-devel] applied: [PATCH vncterm] add custom cursor

2017-06-07 Thread Wolfgang Bumiller
applied On Tue, Jun 06, 2017 at 11:01:51AM +0200, Dominik Csapak wrote: > instead of a black 'x' we now have a 'proper' cursor with a white edge, > to be able to see it when we are in the novnc console > > Signed-off-by: Dominik Csapak > --- > vncterm.c | 58

[pve-devel] [PATCH qemu-server] fix #1405: sort pci ids by functions

2017-06-08 Thread Wolfgang Bumiller
QemuServer::lspci() iterates over /sys/bus/pci/devices which doesn't guarantee any order which means functions sometimes ended up in the wrong order and it was never clear which one would get the additional options such as x-vga passed to them. --- PVE/QemuServer.pm | 6 ++ 1 file changed, 6 i

[pve-devel] [PATCH 1/2] Permit set parent_snapname if it is not set.

2017-06-08 Thread Wolfgang Link
--- PVE/Replication.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/PVE/Replication.pm b/PVE/Replication.pm index 9aad67d8..ab55c9bf 100644 --- a/PVE/Replication.pm +++ b/PVE/Replication.pm @@ -135,7 +135,8 @@ sub remote_prepare_local_job { push @$cmd, @$volumes if sc

[pve-devel] Small fixes for replica

2017-06-08 Thread Wolfgang Link
Small fixes for replica [PATCH 1/2] Permit set parent_snapname if it is not set. [PATCH 2/2] Fix: list_images returns now a array of hashes so adopt ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pv

[pve-devel] [PATCH 2/2] Fix: list_images returns now a array of hashes so adopt the code.

2017-06-08 Thread Wolfgang Link
--- PVE/CLI/pvesr.pm | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/PVE/CLI/pvesr.pm b/PVE/CLI/pvesr.pm index 13ef2730..5e57ac48 100644 --- a/PVE/CLI/pvesr.pm +++ b/PVE/CLI/pvesr.pm @@ -133,9 +133,10 @@ __PACKAGE__->register_method ({ foreach my $storeid (@$stor

[pve-devel] [PATCH] Remove debug output

2017-06-08 Thread Wolfgang Link
--- PVE/CLI/pvesr.pm | 2 -- 1 file changed, 2 deletions(-) diff --git a/PVE/CLI/pvesr.pm b/PVE/CLI/pvesr.pm index 3ca01c86..eb880fda 100644 --- a/PVE/CLI/pvesr.pm +++ b/PVE/CLI/pvesr.pm @@ -144,8 +144,6 @@ __PACKAGE__->register_method ({ } } - print to_json($last_snap

[pve-devel] [PATCH] Add force parameter for delete replica job.

2017-06-08 Thread Wolfgang Link
This parameter is helpful if an unsolvable situation occurs or the vmconfig was delete manually. --- PVE/API2/ReplicationConfig.pm | 35 ++- 1 file changed, 22 insertions(+), 13 deletions(-) diff --git a/PVE/API2/ReplicationConfig.pm b/PVE/API2/ReplicationConfig.p

[pve-devel] applied: [RFC common] add and use physical NIC regexp

2017-06-08 Thread Wolfgang Bumiller
applied On Mon, May 22, 2017 at 09:44:17AM +0200, Fabian Grünbichler wrote: > Signed-off-by: Fabian Grünbichler > --- > this was strangely redundant ;) name and placement in Network.pm up for > discussion of course > > src/PVE/INotify.pm | 9 + > src/PVE/Network.pm | 2 ++ > 2 files cha

[pve-devel] applied: [PATCH manager] use physical NIC regexp

2017-06-08 Thread Wolfgang Bumiller
applied On Mon, May 22, 2017 at 09:44:18AM +0200, Fabian Grünbichler wrote: > because in >= Stretch, most systems don't have ethX devices any more. > > Signed-off-by: Fabian Grünbichler > --- > Note: requires patch introducing this RE in pve-common > > PVE/Service/pvestatd.pm | 3 ++- > 1 file

[pve-devel] applied: [PATCH manager] fix #1385: display no rbd user by default

2017-06-08 Thread Wolfgang Bumiller
applied On Thu, May 18, 2017 at 09:42:17AM +0200, Dominik Csapak wrote: > when having an rbd storage with no user, we displayed 'admin' by default, > this patch sets '' and will be overwritten from the backend if a value is set > > when creating a rbd storage, the textfield still has 'admin' in >

[pve-devel] applied: [PATCH manager 0/4] add usb devices to gui

2017-06-08 Thread Wolfgang Bumiller
applied whole series On Mon, May 29, 2017 at 10:46:30AM +0200, Dominik Csapak wrote: > this series show passed through usb devices (and spice ports) in the gui, > and lets user edit/add them > > i would like to see the first 2 patches applied, but because usb hotplug > is not working 100% the las

[pve-devel] applied: [RFC PATCH manager 1/2] add pci icon/css class

2017-06-08 Thread Wolfgang Bumiller
applied On Mon, May 29, 2017 at 11:10:20AM +0200, Dominik Csapak wrote: > Signed-off-by: Dominik Csapak > --- > www/css/ext6-pve.css| 8 +++- > www/images/Makefile | 3 ++- > www/images/icon-pci.png | Bin 0 -> 199 bytes > www/images/icon-pci.xcf | Bin 0 -> 738 bytes > 4 files c

[pve-devel] applied: [RFC PATCH manager 2/2] show hostpci devices in gui

2017-06-08 Thread Wolfgang Bumiller
applied On Mon, May 29, 2017 at 11:10:21AM +0200, Dominik Csapak wrote: > so one can see which pci devices are assigned to which vm > > Signed-off-by: Dominik Csapak > --- > www/manager6/qemu/HardwareView.js | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/w

[pve-devel] applied: [PATCH manager] fix #1389: vzdump: handle storage failure in new()

2017-06-08 Thread Wolfgang Bumiller
applied On Mon, May 22, 2017 at 01:16:48PM +0200, Fabian Grünbichler wrote: > otherwise the mail notification is not triggered > > Signed-off-by: Fabian Grünbichler > --- > PVE/VZDump.pm | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/PVE/VZDump.pm b/PVE/VZDump.p

[pve-devel] [pve-guest-common 2/2] set_remote_state

2017-06-08 Thread Wolfgang Link
--- PVE/ReplicationState.pm | 19 +++ 1 file changed, 19 insertions(+) diff --git a/PVE/ReplicationState.pm b/PVE/ReplicationState.pm index be5cf5f..086d62f 100644 --- a/PVE/ReplicationState.pm +++ b/PVE/ReplicationState.pm @@ -92,4 +92,23 @@ sub replication_snapshot_name { w

[pve-devel] [pve-manager] pvesr set_state

2017-06-08 Thread Wolfgang Link
--- PVE/CLI/pvesr.pm | 33 + 1 file changed, 33 insertions(+) diff --git a/PVE/CLI/pvesr.pm b/PVE/CLI/pvesr.pm index f64a3103..ca8cd59c 100644 --- a/PVE/CLI/pvesr.pm +++ b/PVE/CLI/pvesr.pm @@ -288,6 +288,38 @@ __PACKAGE__->register_method ({ return PVE::API

[pve-devel] [pve-guest-common 1/2] get_jobid

2017-06-08 Thread Wolfgang Link
--- PVE/ReplicationConfig.pm | 14 ++ 1 file changed, 14 insertions(+) diff --git a/PVE/ReplicationConfig.pm b/PVE/ReplicationConfig.pm index 01e7206..b4f0fe9 100644 --- a/PVE/ReplicationConfig.pm +++ b/PVE/ReplicationConfig.pm @@ -209,6 +209,20 @@ sub check_for_existing_jobs { r

  1   2   3   4   5   6   7   8   9   10   >