Re: [pve-devel] [PATCH cluster v2 0/8] initial API adaption to corosync 3/kronosnet

2019-06-14 Thread Thomas Lamprecht
On 6/11/19 7:36 PM, Thomas Lamprecht wrote: > v2 with a few more patches and some changes regarding Fabian's feedback > (thanks) from the initial RFC version[0]. > > Last two patches, both new, aren't really tested by me to much, just FYI, > the others seen mostly reasonable adaptions and got smok

Re: [pve-devel] [PATCH cluster v2 0/8] initial API adaption to corosync 3/kronosnet

2019-06-14 Thread Thomas Lamprecht
On 6/14/19 5:50 PM, Thomas Lamprecht wrote: > On 6/14/19 3:03 PM, Fabian Grünbichler wrote: >> Jun 14 14:23:50 clustertest71 systemd[1]: Starting Corosync Cluster Engine... >> Jun 14 14:23:50 clustertest71 corosync[2160]: [MAIN ] Corosync Cluster >> Engine 3.0.1-dirty starting up >> Jun 14 14:2

Re: [pve-devel] [PATCH cluster v2 0/8] initial API adaption to corosync 3/kronosnet

2019-06-14 Thread Thomas Lamprecht
On 6/14/19 3:03 PM, Fabian Grünbichler wrote: > with that fixed up, joining works, but the generated corosync.conf is > again wrong: > > > logging { > debug: off > to_syslog: yes > } > > nodelist { > node { > name: clustertest71 > nodeid: 1 > quorum_votes: 1 > ring0_addr: 1

Re: [pve-devel] [PATCH cluster v2 0/8] initial API adaption to corosync 3/kronosnet

2019-06-14 Thread Thomas Lamprecht
On 6/14/19 3:03 PM, Fabian Grünbichler wrote: > ISSUE 1 > > creating a cluster with > > pvesh create /cluster/config -clustername thomastest -link0 192.168.21.71 > -link5 10.0.0.71 > > creates an invalid corosync.conf: > > Jun 14 14:23:50 clustertest71 systemd[1]: Starting Corosync Cluster E

Re: [pve-devel] [PATCH cluster v2 0/8] initial API adaption to corosync 3/kronosnet

2019-06-14 Thread Thomas Lamprecht
On 6/14/19 3:03 PM, Fabian Grünbichler wrote: > On Wed, Jun 12, 2019 at 04:36:00PM +0200, Fabian Grünbichler wrote: >> sent some comments as replies to individual patches, rest LGTM - but >> only read and build-tested so far. I'll try to give this (or a >> subsequent v3) an actual spin this week as

Re: [pve-devel] [PATCH cluster v2 0/8] initial API adaption to corosync 3/kronosnet

2019-06-14 Thread Fabian Grünbichler
On Wed, Jun 12, 2019 at 04:36:00PM +0200, Fabian Grünbichler wrote: > sent some comments as replies to individual patches, rest LGTM - but > only read and build-tested so far. I'll try to give this (or a > subsequent v3) an actual spin this week as well if time permits. did that now, and noticed t

Re: [pve-devel] [PATCH cluster v2 0/8] initial API adaption to corosync 3/kronosnet

2019-06-12 Thread Fabian Grünbichler
sent some comments as replies to individual patches, rest LGTM - but only read and build-tested so far. I'll try to give this (or a subsequent v3) an actual spin this week as well if time permits. On Tue, Jun 11, 2019 at 07:36:25PM +0200, Thomas Lamprecht wrote: > v2 with a few more patches and so

[pve-devel] [PATCH cluster v2 0/8] initial API adaption to corosync 3/kronosnet

2019-06-11 Thread Thomas Lamprecht
v2 with a few more patches and some changes regarding Fabian's feedback (thanks) from the initial RFC version[0]. Last two patches, both new, aren't really tested by me to much, just FYI, the others seen mostly reasonable adaptions and got smoke-tested for them, as I looked more close last time (s