[issue1954] SocketServer.ForkingMixIn creates a zombie

2008-01-28 Thread Ralf Schmitt
Ralf Schmitt added the comment: Well, one child isn't the maximum. All children which do not finish before the last client connects, will live on as zombies (and will be collected when the next client connects). If that is acceptable, then just close this report. Using signals would be easier if

[issue1960] test_gdbm.py converted to unittest

2008-01-28 Thread Brett Cannon
Brett Cannon added the comment: On Jan 28, 2008 6:20 PM, Giampaolo Rodola' <[EMAIL PROTECTED]> wrote: > > Giampaolo Rodola' added the comment: > > > Well, if you have an opinion, feel free to leave a comment in this > > issue about it. I will most likely be the one who does the checkin and > > I

[issue1961] possible error with json format for sphinx

2008-01-28 Thread Brett Cannon
New submission from Brett Cannon: I currently can't build the docs (r60374): ... File "/Users/brett/Dev/python/2.x/pristine/Doc/tools/sphinx/search.py", line 70, in load for (k, v) in frozen[2].iteritems()) AttributeError: 'list' object has no attribute 'iteritems' make: *** [build] Error

[issue1960] test_gdbm.py converted to unittest

2008-01-28 Thread Giampaolo Rodola'
Giampaolo Rodola' added the comment: > Well, if you have an opinion, feel free to leave a comment in this > issue about it. I will most likely be the one who does the checkin and > I will read this issue before I commit. * One of the things I dislike is the fact that the student used "self.g =

[issue1960] test_gdbm.py converted to unittest

2008-01-28 Thread Brett Cannon
Brett Cannon added the comment: On Jan 28, 2008 5:03 PM, Giampaolo Rodola' <[EMAIL PROTECTED]> wrote: > > Giampaolo Rodola' added the comment: > > > Have a look at > http://code.google.com/p/google-highly-open-participation-psf/issues/detail?id=290 > > where a GHOP student did a conversion as wel

[issue923643] long <-> byte-string conversion

2008-01-28 Thread Mark Dickinson
Mark Dickinson added the comment: Closing this due to little-or-no activity for over three years. Antoine's use case seems to me to be covered by issue #1023290. Trevor, please speak up if you want to keep this alive. -- resolution: -> rejected status: open -> pending superseder: ->

[issue1960] test_gdbm.py converted to unittest

2008-01-28 Thread Giampaolo Rodola'
Giampaolo Rodola' added the comment: > Have a look at http://code.google.com/p/google-highly-open-participation-psf/issues/detail?id=290 > where a GHOP student did a conversion as well. Interesting, didn't know about that. In future I'll check that site before start working on a new patch involv

[issue1960] test_gdbm.py converted to unittest

2008-01-28 Thread Brett Cannon
Brett Cannon added the comment: Have a look at http://code.google.com/p/google-highly-open-participation-psf/issues/detail?id=290 where a GHOP student did a conversion as well. Any chance to come up with a possible merged version that takes the best from your work, Giampaolo and the student's wo

[issue1960] test_gdbm.py converted to unittest

2008-01-28 Thread Giampaolo Rodola'
New submission from Giampaolo Rodola': In attachment. All existent tests are unchanged. -- components: Tests files: test_gdbm.diff messages: 61806 nosy: giampaolo.rodola severity: normal status: open title: test_gdbm.py converted to unittest type: rfe versions: Python 2.6 Added file: htt

[issue1960] test_gdbm.py converted to unittest

2008-01-28 Thread Giampaolo Rodola'
Changes by Giampaolo Rodola': Added file: http://bugs.python.org/file9316/test_gdbm.py __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing li

[issue1958] IPv6 compiled getaddrinfo returns IPv6 address even if the system does not support IPv6

2008-01-28 Thread Douglas Mayle
Douglas Mayle added the comment: Martin's hypothesis is confirmed, removing ::1 from /etc/hosts removes the response __ Tracker <[EMAIL PROTECTED]> __ __

[issue1958] IPv6 compiled getaddrinfo returns IPv6 address even if the system does not support IPv6

2008-01-28 Thread Martin v. Löwis
Martin v. Löwis added the comment: My guess is that the C library returns it because /etc/hosts says so. The convention is that /etc/hosts should call ::1 ip6-localhost (and ip6-loopback) instead. -- nosy: +loewis resolution: -> invalid status: open -> closed __

[issue1959] test_contains.py converted to unittest

2008-01-28 Thread Giampaolo Rodola'
Changes by Giampaolo Rodola': Added file: http://bugs.python.org/file9314/test_contains.py __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailin

[issue1959] test_contains.py converted to unittest

2008-01-28 Thread Giampaolo Rodola'
New submission from Giampaolo Rodola': In attachment. All existent tests are unchanged. -- components: Tests files: test_contains.diff messages: 61803 nosy: giampaolo.rodola severity: normal status: open title: test_contains.py converted to unittest type: rfe versions: Python 2.6 Added f

[issue814996] OSF/1 test_dbm segfaults

2008-01-28 Thread Raghuram Devarakonda
Raghuram Devarakonda added the comment: I am assuming that this can be closed considering that there is no activity for a long time. -- nosy: +draghuram resolution: -> out of date status: open -> closed Tracker <[EMAIL PROTECTED]>

[issue1958] IPv6 compiled getaddrinfo returns IPv6 address even if the system does not support IPv6

2008-01-28 Thread Douglas Mayle
Douglas Mayle added the comment: Please close this as invalid, the system C library returns the same response... __ Tracker <[EMAIL PROTECTED]> __ ___ Py

[issue1577] shutil.move() does not use os.rename() if dst is a directory

2008-01-28 Thread Raghuram Devarakonda
Raghuram Devarakonda added the comment: Hi Antoine, You stated the following in a previous comment: "Right now, shutil.move(src_dir, dst_dir) replaces dst_dir with src_dir if dst_dir is empty, but moves src_dir inside dst_dir otherwise." But my test shows differently. If dst_dir doesn't exist

[issue1958] IPv6 compiled getaddrinfo returns IPv6 address even if the system does not support IPv6

2008-01-28 Thread Douglas Mayle
New submission from Douglas Mayle: The following code calls getadddrinfo and returns invalid addresses (IPv6 addresses) when Python has been compiled with IPv6 support and the system kernel does not support IPv6. import socket for res in socket.getaddrinfo("localhost", "80", 0, socket.SOCK_STREA

[issue1952] test_select.py converted to unittest

2008-01-28 Thread Giampaolo Rodola'
Giampaolo Rodola' added the comment: > 1. it's a shame the tests are skipped for windows or macintosh, but it > was just the same in the original version Yeah... I'm probably not the best person for talking about this low level stuff but since sockets seem to be the most portable thing accepted

[issue1389051] imaplib causes excessive fragmentation for large documents

2008-01-28 Thread A.M. Kuchling
Changes by A.M. Kuchling: -- keywords: +patch _ Tracker <[EMAIL PROTECTED]> _ ___ Python-bugs-list mailing list Unsubscribe: http:/

[issue1541] Bad OOB data management when using asyncore with select.poll()

2008-01-28 Thread A.M. Kuchling
Changes by A.M. Kuchling: -- assignee: -> akuchling nosy: +akuchling __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsub

[issue1541] Bad OOB data management when using asyncore with select.poll()

2008-01-28 Thread A.M. Kuchling
Changes by A.M. Kuchling: -- keywords: +patch __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue1952] test_select.py converted to unittest

2008-01-28 Thread Antoine Pitrou
Antoine Pitrou added the comment: The patch looks and works fine for me. Two things: 1. it's a shame the tests are skipped for windows or macintosh, but it was just the same in the original version 2. I don't think sys.platform[:3] can be equal to 'riscos' :) -- nosy: +pitrou __

[issue1507] complex constructor loses signs of zeros

2008-01-28 Thread Christian Heimes
Changes by Christian Heimes: -- priority: -> high versions: -Python 2.6 __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list U

[issue1579] logging documentation is unclear

2008-01-28 Thread Christian Heimes
Changes by Christian Heimes: -- keywords: +easy priority: -> normal type: -> rfe versions: +Python 2.6 -Python 2.5 __ Tracker <[EMAIL PROTECTED]> __ _

[issue1951] test_wave.py converted to unittest

2008-01-28 Thread Giampaolo Rodola'
Giampaolo Rodola' added the comment: Glad to help. __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue1951] test_wave.py converted to unittest

2008-01-28 Thread Christian Heimes
Christian Heimes added the comment: Thanks for the patch! -- keywords: +easy, patch nosy: +tiran priority: -> normal __ Tracker <[EMAIL PROTECTED]> __

[issue1956] Lib/bsddb/test/test_thread.py uses old 'except' syntax

2008-01-28 Thread Christian Heimes
Christian Heimes added the comment: Fixed in r60394 The bug wasn't detected because the tests couldn't be imported. One test file still used an absolute import instead of a relative. -- resolution: accepted -> fixed status: open -> closed __ Tracker <[EM

[issue1956] Lib/bsddb/test/test_thread.py uses old 'except' syntax

2008-01-28 Thread Christian Heimes
Christian Heimes added the comment: Guido van Rossum wrote: > Chris: I think it's worth running all tests before submitting a merge. > Catch them early is what I say. :-) An ordianry test run already takes a considerable amount of time on my system. I usually wait until the build bots notify me

[issue1621] Do not assume signed integer overflow behavior

2008-01-28 Thread Ismail Donmez
Ismail Donmez added the comment: Moving the empty check before the loop will fix this and possibly optimize empty string handling. __ Tracker <[EMAIL PROTECTED]> __

[issue1621] Do not assume signed integer overflow behavior

2008-01-28 Thread Ismail Donmez
Ismail Donmez added the comment: gcc is optimizing the second if check , for specifically i == 0 seems to redundant according to gcc. if (i == 0 && quote_empty) { if (dialect->quoting == QUOTE_NONE) { PyErr_Format(error_obj,

[issue1956] Lib/bsddb/test/test_thread.py uses old 'except' syntax

2008-01-28 Thread Guido van Rossum
Guido van Rossum added the comment: Chris: I think it's worth running all tests before submitting a merge. Catch them early is what I say. :-) -- nosy: +gvanrossum __ Tracker <[EMAIL PROTECTED]>

[issue1954] SocketServer.ForkingMixIn creates a zombie

2008-01-28 Thread Guido van Rossum
Guido van Rossum added the comment: Using signals is asking for all sorts of trouble. What is the point of collecting the last process? Having one zombie child max as a steady state strikes me as totally acceptable. -- nosy: +gvanrossum __ Tracker <[EMAI

[issue1621] Do not assume signed integer overflow behavior

2008-01-28 Thread Ismail Donmez
Ismail Donmez added the comment: > Guido van Rossum added the comment: > > I wonder if it would help making i a Py_ssize_t instead of an int? gcc still issues the same warning with that. __ Tracker <[EMAIL PROTECTED]> __

[issue1954] SocketServer.ForkingMixIn creates a zombie

2008-01-28 Thread Christian Heimes
Christian Heimes added the comment: Can you provide a patch? Next time please fill in type, components and versions, too. :) -- components: +Library (Lib) nosy: +tiran priority: -> normal type: -> behavior versions: +Python 2.6 __ Tracker <[EMAIL PROTE

[issue1956] Lib/bsddb/test/test_thread.py uses old 'except' syntax

2008-01-28 Thread Christian Heimes
Christian Heimes added the comment: I normally don't run the tests with -uall when I merge changes. from the trunk. -- assignee: -> tiran nosy: +tiran priority: -> high resolution: -> accepted __ Tracker <[EMAIL PROTECTED]>

[issue1621] Do not assume signed integer overflow behavior

2008-01-28 Thread Ismail Donmez
Ismail Donmez added the comment: Neal, You could btw check http://repo.or.cz/w/pytest.git?a=shortlog;h=overflow-fix which have each fix seperate so that reviewing is easy. Just ignore configure changes thats for later. Thanks, ismail __ Tracker <[EMAIL PROTECTED

[issue1621] Do not assume signed integer overflow behavior

2008-01-28 Thread Guido van Rossum
Guido van Rossum added the comment: I wonder if it would help making i a Py_ssize_t instead of an int? __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-

[issue1957] [patch] syslogmodule: Release GIL when calling syslog(3)

2008-01-28 Thread Christian Heimes
Christian Heimes added the comment: Thanks for the patch. I'm going to review it later. -- keywords: +patch nosy: +tiran priority: -> high versions: +Python 3.0 __ Tracker <[EMAIL PROTECTED]> ___

[issue1955] fix using unittest as a superclass

2008-01-28 Thread Guido van Rossum
Guido van Rossum added the comment: This patch seems to be based upon a misunderstanding of how Python namespaces work. -- keywords: +patch nosy: +gvanrossum resolution: -> rejected status: open -> closed __ Tracker <[EMAIL PROTECTED]>

[issue1957] [patch] syslogmodule: Release GIL when calling syslog(3)

2008-01-28 Thread Dennis Jensen
New submission from Dennis Jensen: The glibc syslog(3) call will block in some cases; the attached patch releases the GIL around the syslog call. -- components: Extension Modules, Interpreter Core files: syslogmodule-patch.txt messages: 61781 nosy: rd2 severity: minor status: open title:

[issue1955] fix using unittest as a superclass

2008-01-28 Thread Antoine Pitrou
Antoine Pitrou added the comment: I don't really understand what problem you are trying to solve. Can you attach a sample script to show it more clearly? Also, the only thing your patch does is rename Test(Case|Suite) references to unittest.Test(Case|Suite)... I doubt it would have any effect un

[issue1956] Lib/bsddb/test/test_thread.py uses old 'except' syntax

2008-01-28 Thread Georgij Kondratjev
Georgij Kondratjev added the comment: If you notice that at http://svn.python.org/view/python/branches/py3k/Lib/bsddb/test/test_thread.py?rev=60350&r1=58058&r2=60350 "shutil.rmtree(self.homeDir)" didn`t change between revisions, that would be false: in fact extra space ("") was added. Is thi

[issue1956] Lib/bsddb/test/test_thread.py uses old 'except' syntax

2008-01-28 Thread Georgij Kondratjev
Georgij Kondratjev added the comment: Appeared in 60350 svnmerge: http://svn.python.org/view/python/branches/py3k/Lib/bsddb/test/test_thread.py?rev=60350&view=log http://svn.python.org/view/python/branches/py3k/Lib/bsddb/test/test_thread.py?rev=60350&r1=58058&r2=60350 ___

[issue1956] Lib/bsddb/test/test_thread.py uses old 'except' syntax

2008-01-28 Thread Georgij Kondratjev
New submission from Georgij Kondratjev: "except OSError, e:" (appears twice) should be changed to "except OSError as e:" -- components: Library (Lib) messages: 61777 nosy: orivej severity: normal status: open title: Lib/bsddb/test/test_thread.py uses old 'except' syntax type: compile err

[issue1955] fix using unittest as a superclass

2008-01-28 Thread Adam Goucher
New submission from Adam Goucher: There are a couple places in unittest where 'issubclass(something, TestCase)' is used. This prevents you from organizing your test code via class hierarchies. To solve this problem, issubclass should be looking whether the object is a subclass of unittest.TestCas

[issue1923] meaningful whitespace can be lost in rfc822_escape

2008-01-28 Thread Stephen Emslie
Stephen Emslie added the comment: Here's that keeps the whitespace in tact, along with a simple test. This doesn't patch docs as the existing documentation_ already describes the long string as multiple lines of "plain text in reStructuredText format", which is what this fixes. .. _documentation

[issue1025395] email.Utils.parseaddr fails to parse valid addresses

2008-01-28 Thread Martin v. Löwis
Changes by Martin v. Löwis: _ Tracker <[EMAIL PROTECTED]> _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/op

[issue1621] Do not assume signed integer overflow behavior

2008-01-28 Thread Martin v. Löwis
Martin v. Löwis added the comment: > With Neal, I don't see what the warning in _csv is about. What condition > is being turned into a constant? Is the compiler perhaps rearranging the > code so as to insert "if (field[0] == '\0') goto XXX;" in front of the > for-loop where XXX jumps into the mid