Nick Coghlan ncogh...@gmail.com added the comment:
Moving zipimporter to Python code is harder than it sounds: we don't want to
break the ability to ship the standard library itself inside a zipfile.
If you try to move zipimporter to pure Python, you could easily end up with a
*very* ugly
Hynek Schlawack h...@ox.cx added the comment:
David: What do you mean? I'd just catch EPERM and look whether the directory
appeared in the meantime. If it exists, continue. If not: re-raise. Am I
missing something? I may have a look at GNU mkdir if it doesn't help.
--
New submission from Vinay Sajip vinay_sa...@yahoo.co.uk:
I've recently started seeing this failure repeatably on Linux (Ubuntu Jaunty):
[195/364] test_multiprocessing
Process Process-133:
Traceback (most recent call last):
File
Vinay Sajip vinay_sa...@yahoo.co.uk added the comment:
The AssertionError in Brian's initial post indicates that the test is too
restrictive. Though the discussion here has talked about removing the popups
altogether, the test passes on Windows with a small change: instead of
assertEqual(), I
Changes by Nadeem Vawda nadeem.va...@gmail.com:
--
nosy: +nadeem.vawda
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14684
___
___
Charles-François Natali neolo...@free.fr added the comment:
To me, this doesn't look like a os.makedirs() bug, but rather an autofs one
(didn't know it was still in use).
I don't like the idea of adding such a kludge (i.e. catching EPERM and checking
whether the directory appeared in between).
Sandro Tosi sandro.t...@gmail.com added the comment:
Here's the proposed patch.
I'm sorry but probably 'hg diff' went too wild, and since I moved the Using
several working copies as the first sub-paragraph of Forward-Porting it
seems it got confused, so the diff is not so clean. I've also
New submission from Xavier de Gaye xdeg...@gmail.com:
The issue 13183 raises the problem that when the trace function is not
set in the caller frame, the step command fails at a return statement.
This new issue raises the point that, for the same reason:
* the next, until and return
New submission from Vinay Sajip vinay_sa...@yahoo.co.uk:
In test_faulthandler.test_check_fatal_error, the test expects a response which
matches
^Fatal Python error: {name}
{header}:
File string, line {lineno} in module$
.strip()
On Windows, some more information is appended to the end of
Vinay Sajip vinay_sa...@yahoo.co.uk added the comment:
Some more information: after the above-described appears, the test hangs. When
interrupted with a Ctrl+C, this is displayed:
^CProcess PoolWorker-104:
Process PoolWorker-102:
Process PoolWorker-105:1:
Process PoolWorker-101:
Process
Hynek Schlawack h...@ox.cx added the comment:
Charles, I don't think you can blame autofs here. The problem at hand is that
makedirs() never checks whether the directory exists (that would trigger the
mount too I presume). Instead, it tries a mkdir and looks if it gets an EEXIST.
If you try
R. David Murray rdmur...@bitdance.com added the comment:
Good enough for me. I personally don't find it to be easier or harder to read
with the names, so let's keep them.
--
resolution: - works for me
stage: - committed/rejected
status: open - closed
Charles-François Natali neolo...@free.fr added the comment:
Charles, I don't think you can blame autofs here. The problem at hand is that
makedirs() never checks whether the directory exists (that would trigger the
mount too I presume).
Yes, it does. Have a look at line 148:
if head
R. David Murray rdmur...@bitdance.com added the comment:
Hynek: you said just like EEXIST, which doesn't check to see if the directory
exists before continuing, thus my confusion.
If mkdir -p does a stat first, then changing the makedirs algorithm to match is
probably not a bad idea for OS
STINNER Victor victor.stin...@gmail.com added the comment:
On Windows, some more information is appended to the end of the message (...)
Which information? What do write these information?
--
___
Python tracker rep...@bugs.python.org
Hynek Schlawack h...@ox.cx added the comment:
Charles, I don't think you can blame autofs here. The problem at hand is
that makedirs() never checks whether the directory exists (that would
trigger the mount too I presume).
Yes, it does. Have a look at line 148:
if head and tail
New submission from Paul Colomiets p...@colomiets.name:
Attached patch is a partial implementation of PEP 419, it lacks inspect module
functions and requires more unit tests.
--
components: Interpreter Core
files: cleanuphook.patch
keywords: patch
messages: 159994
nosy: tailhook
Vinay Sajip vinay_sa...@yahoo.co.uk added the comment:
Which information? What do write these information?
The Windows error message has the same beginning, but an additional
This application has requested the Runtime to terminate it in an unusual
way.\nPlease contact the application's
Xavier de Gaye xdeg...@gmail.com added the comment:
Uploaded pdb_default.patch that applies on the default branch with
minor changes to the initial pdb.patch.
--
Added file: http://bugs.python.org/file25463/pdb_default.patch
___
Python tracker
Xavier de Gaye xdeg...@gmail.com added the comment:
Uploaded pdb_2.7.patch that applies on the 2.7 branch.
--
Added file: http://bugs.python.org/file25464/pdb_2.7.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14728
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 254cb4f5d0ff by Lars Gustäbel in branch 'default':
Issue #13815: TarFile.extractfile() now returns io.BufferedReader objects.
http://hg.python.org/cpython/rev/254cb4f5d0ff
--
nosy: +python-dev
Larry Hastings la...@hastings.org added the comment:
Attached is rev 3 of my patch, incorporating mainly backing out of dumb ideas.
Thanks for the feedback, Serhiy and Mark!
My name is Serhiy. :)
My genuine apologies! In my defense it was rather late.
'P' has the advantage that you can
Benjamin Peterson benja...@python.org added the comment:
Since no one has produced a good example needing P, I say drop it. At any
rate, it can be almost trivially imitated with O!.
--
nosy: +benjamin.peterson
___
Python tracker
Lars Gustäbel l...@gustaebel.de added the comment:
I did some tarfile spring cleaning: I removed the ExFileObject class completely
as it was more or less a leftover from the old days. io.BufferedReader now does
the job. So, as a side-effect, I close this issue as fixed.
(BTW, this makes
Georg Brandl ge...@python.org added the comment:
Indeed, because the code is written is not a good argument if even you
yourself are -0.
--
nosy: +georg.brandl
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14705
Nadeem Vawda nadeem.va...@gmail.com added the comment:
I've posted a review on Rietveld.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14684
___
Mark Dickinson dicki...@gmail.com added the comment:
Having meditated on it, I think either I should either just call
PyErr_Occured, check for explicit failure (val 0), or explicit success
(val = 0). I've opted for the last of those.
Yes, I think that works; it avoids a relatively
Mark Dickinson dicki...@gmail.com added the comment:
I considered briefly trying to make 'P' handle subclasses of bool.
Not an issue: bool can't be subclassed. :-)
Python 3.2.3 (default, Apr 13 2012, 00:15:25)
[GCC 4.2.1 (Apple Inc. build 5666) (dot 3)] on darwin
Type help, copyright,
Serhiy Storchaka storch...@gmail.com added the comment:
That's not a reason to use 'P'. Why you should use 'P' in the first place?
I just guided by the principle Explicit is better than implicit.
Statements 'if' and 'while' I consider explicit and expect cast to bool.
Implicit cast to bool in
Larry Hastings la...@hastings.org added the comment:
Serhiy, I'm having a little trouble with your English. (But I'm sure your
English is far better than my... uh, anything besides English.) So let me ask
a question with a clear yes/no answer:
Do you still think 'P' is better than 'p'?
Richard Oudkerk shibt...@gmail.com added the comment:
The documentation page for ConnectNamedPipe
(http://msdn.microsoft.com/en-us/library/windows/desktop/aa365146(v=vs.85).aspx)
has a community addition which says that ConnectNamedPipe will appear to
fail with ERROR_NO_DATA (232) if a client
Serhiy Storchaka storch...@gmail.com added the comment:
No one integer produces infinity in 'double' parameter parsing.
But the 'float' parameter parsing can produce infinity, and it can raise
an exception. To be consistent, we need or produce infinity on double
overflow (in this case, we must
Changes by R. David Murray rdmur...@bitdance.com:
--
title: Implementation of the PEP 419 - Implementation of the PEP 419:
Protecting cleanup statements from interruptions
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14730
Serhiy Storchaka storch...@gmail.com added the comment:
Well, it seems, 64-bit processors are smart enough to not feel the need
for this optimization. On 32-bit platforms I see a noticeable increase
in speed.
I am now working on a more advanced optimization, which now shows a gain
of +20-60%
Antoine Pitrou pit...@free.fr added the comment:
The copyxattr() function should be private (_copyxattr()).
For some reason the tests are failing here:
==
ERROR: test_copy2_xattr (test.test_shutil.TestShutil)
Serhiy Storchaka storch...@gmail.com added the comment:
Do you still think 'P' is better than 'p'?
No.
I hope I haven't made a lot of mistakes in the previous sentence.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14705
Antoine Pitrou pit...@free.fr added the comment:
Updated patch also makes PyImport_ImportModuleNoBlock a simple alias of
PyImport_ImportModule.
--
Added file: http://bugs.python.org/file25466/module_locks4.patch
___
Python tracker
New submission from R. David Murray rdmur...@bitdance.com:
As discussed in my email to python-dev, I'm planning to add the new header
parsing to Python 3.3 as a provisional extension, by adding a (set) of policies
that are clearly marked provisional in the documentation. In order for this to
Changes by R. David Murray rdmur...@bitdance.com:
--
keywords: +patch
Added file: http://bugs.python.org/file25467/676f9c8c28c6.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14731
___
Larry Hastings la...@hastings.org added the comment:
I hope I haven't made a lot of mistakes in the previous sentence.
It depends, do you consider three a lot? ;-)
Attached is a new patch removing 'P'. (The regrtest is still running but I
don't expect any failures.) I'm guessing I won't
Changes by R. David Murray rdmur...@bitdance.com:
--
title: Enhance Policy framework in preparation for adding eamil6 policy as
provisional - Enhance Policy framework in preparation for adding email6
policies as provisional
___
Python tracker
Changes by Antoine Pitrou pit...@free.fr:
Removed file: http://bugs.python.org/file25466/module_locks4.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9260
___
Changes by Antoine Pitrou pit...@free.fr:
Added file: http://bugs.python.org/file25469/module_locks4.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9260
___
Changes by Eric Snow ericsnowcurren...@gmail.com:
--
nosy: +eric.snow
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9260
___
___
Python-bugs-list
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 44f078ea05f3 by Richard Oudkerk in branch 'default':
Fix for Issue 14725 for 3.3 branch.
http://hg.python.org/cpython/rev/44f078ea05f3
--
nosy: +python-dev
___
Python
Hynek Schlawack h...@ox.cx added the comment:
The copyxattr() function should be private (_copyxattr()).
Ok. I presumed that not adding it to __all__ is private enough.
For some reason the tests are failing here:
==
Changes by Hynek Schlawack h...@ox.cx:
--
nosy: +hynek
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14731
___
___
Python-bugs-list mailing list
Mark Dickinson dicki...@gmail.com added the comment:
Latest patch looks good to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14705
___
___
Martin v. Löwis mar...@v.loewis.de added the comment:
I'll be closing this issue at this point. Serhiy: I don't think the bug tracker
should be used to evolve work in progress (except when responding to reviews
received). Use a Mercurial clone for that instead. By posting a patch here, you
Antoine Pitrou pit...@free.fr added the comment:
Updated patch also adds unit tests for the module locks and the deadlock
avoidance algorithm.
--
Added file: http://bugs.python.org/file25470/module_locks5.patch
___
Python tracker
Brett Cannon br...@python.org added the comment:
The real problem becomes the issue of what zipfile depends on, which
complicates bootstrapping. I mean things could go as far as to write a script
that takes in anchor points in the stdlib and freezes all code they depend on,
but that seems
Antoine Pitrou pit...@free.fr added the comment:
Updated patch with a couple new tests.
--
stage: - patch review
Added file: http://bugs.python.org/file25471/module_locks6.patch
___
Python tracker rep...@bugs.python.org
Martin v. Löwis mar...@v.loewis.de added the comment:
I still wonder whether Graham Dumpleton's observation has merits.
Suppose we have these modules
# a.py
time.sleep(10)
import b
# b.py
time.sleep(10)
import a
# main.py
def x():
import a
def y():
import b
Now, if x and y are executed
Changes by Eric Snow ericsnowcurren...@gmail.com:
--
nosy: +eric.snow
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14678
___
___
Python-bugs-list
Antoine Pitrou pit...@free.fr added the comment:
I'll be closing this issue at this point. Serhiy: I don't think the
bug tracker should be used to evolve work in progress (except when
responding to reviews received). Use a Mercurial clone for that
instead. By posting a patch here, you are
Antoine Pitrou pit...@free.fr added the comment:
Now, if x and y are executed in separate threads - won't it deadlock?
Well, the patch has a deadlock avoidance mechanism, and it includes unit
tests for precisely this situation.
I cannot promise the algorithm is perfect (although there *are* a
Antoine Pitrou pit...@free.fr added the comment:
Looks like your file system Python uses for tmp files doesn't support
xattr. That's bad because you can't verify. How should I cope with that?
try/catch on the first setxattr() and skip the test if it fails? Is the
an official way to do that?
Sam Rushing rushing@gmail.com added the comment:
renames dict-zdict, splits the test, adds BEGIN/END around inflate call.
--
Added file: http://bugs.python.org/file25472/zlib_set_dictionary_4.patch
___
Python tracker rep...@bugs.python.org
Martin v. Löwis mar...@v.loewis.de added the comment:
Can you please elaborate in the patch what the deadlock avoidance does? AFAICT,
the comment explains that it is able to detect deadlocks, but nowhere says what
it does when it has detected a deadlock.
Also, please submit patches against
Stefan Krah stefan-use...@bytereef.org added the comment:
Vinay's patch solves the problem. +1 for committing.
--
nosy: +skrah
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14729
___
Stefan Krah stefan-use...@bytereef.org added the comment:
I tested the patch, it works fine. I can't test the popup situation
since I currently only have ssh access.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9116
New submission from Robin Schreiber robin.schrei...@me.com:
This patch presents my first try to apply the proposed Refactoring of PEP3121
to the csv module. I have identified three mutable global variables inside the
module, two of which are references to PyObjects. I have wrapped all of them
Robin Schreiber robin.schrei...@me.com added the comment:
The following script should fail before you have applied the bespoken patch: It
basically checks wether one of the global PyObjects inside the csv module is
being deleted after freeing the csv module.
--
Added file:
Antoine Pitrou pit...@free.fr added the comment:
Updated patch against tip, and with a comment of what deadlock avoidance does
(in _ModuleLock.acquire's docstring).
--
Added file: http://bugs.python.org/file25475/module_locks7.patch
___
Python
New submission from Janusz Lewandowski le...@xtreeme.org:
Running (by pysetup run cmdname) custom commands doesn't work, because
setup.cfg is parsed after command handling.
I've attached a patch to fix this behavior.
--
assignee: eric.araujo
components: Distutils2
files:
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 35ef949e85d7 by Richard Oudkerk in branch '2.7':
Fix for issue 14725 for 2.7 branch
http://hg.python.org/cpython/rev/35ef949e85d7
New changeset afab4d14d5e7 by Richard Oudkerk in branch '3.2':
Fix for issue 14725
Martin v. Löwis mar...@v.loewis.de added the comment:
The patch parser of Rietveld actually choked on the git binary diff. It now
skips over these chunks.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9260
New submission from R. David Murray rdmur...@bitdance.com:
Currently the email package uses its own custom quoted printable encode/decode
implementation for handling header quoted printable CTE encoding and decoding.
It could be that using binascii would work, and be more performant. Or it
Changes by Martin v. Löwis mar...@v.loewis.de:
--
nosy: +loewis
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14732
___
___
Python-bugs-list
Stefan Krah stefan-use...@bytereef.org added the comment:
The proposal makes sense at first glance, but I agree with Mark that it is
not clear what should be done. For example, all arrays in Python silently
convert to inf:
from numpy import array
x = array([1,2,3], 'f')
x
array([ 1., 2.,
Hynek Schlawack h...@ox.cx added the comment:
Ok, I've extracted the xattr checker from test_os.py and transformed it into a
caching decorator like skip_unless_symlinks.
_copyxattr rename is also done.
--
Added file:
Éric Araujo mer...@netwok.org added the comment:
Thanks for the report and patch. I discovered the same thing a few weeks ago
when working on a bug with a contributor; I thought there was already a bug
opened for that but apparently not. The fix I had in mind is the same as your
patch, and
New submission from Ed Wodrich ewodri...@rainbowhaven.net:
Greetings,
I am a brand new user attempting to learn Python. I downloaded and installed
the .msi installer version 3.2.3 on May 5, 2012. I am running Windows XP SP2
32-bit on a Pentium 4. I opted to load all features of the
Changes by Ed Wodrich ewodri...@rainbowhaven.net:
--
nosy: -ewodrich
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14735
___
___
Python-bugs-list
Martin v. Löwis mar...@v.loewis.de added the comment:
That's not very nice. If Serhiy wants feedback on his work, he
definitely has to post *somewhere*. The bug tracker sounds like a
reasonable place (certainly more reasonable than python-dev).
I completely disagree (and I really tried to be
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset bc6d28e726d8 by Larry Hastings in branch 'default':
Issue #14705: Add 'p' format character to PyArg_ParseTuple* for bool support.
http://hg.python.org/cpython/rev/bc6d28e726d8
--
nosy: +python-dev
Larry Hastings la...@hastings.org added the comment:
Eh, it was ready, why wait? Thanks everybody for your feedback!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14705
___
Raymond Hettinger raymond.hettin...@gmail.com added the comment:
I would have expected a bool parse code to insist on a boolean, so that:
int x;
PyArg_ParseTupleAndKeywords(args, kwds, p:func, x);
would behave the same as:
PyObject *o;
int x;
Larry Hastings la...@hastings.org added the comment:
I would have expected a bool parse code to insist on a boolean,
I originally had a second form ('P') that insisted on a boolean as you suggest.
But nobody could come up with a use case. So I removed it in the final patch.
Please see
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 709850f1ec67 by Larry Hastings in branch 'default':
Update Misc/NEWS for issues #14127 and #14705. (And, technically, #10148.)
http://hg.python.org/cpython/rev/709850f1ec67
--
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 709850f1ec67 by Larry Hastings in branch 'default':
Update Misc/NEWS for issues #14127 and #14705. (And, technically, #10148.)
http://hg.python.org/cpython/rev/709850f1ec67
--
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 709850f1ec67 by Larry Hastings in branch 'default':
Update Misc/NEWS for issues #14127 and #14705. (And, technically, #10148.)
http://hg.python.org/cpython/rev/709850f1ec67
--
nosy: +python-dev
New submission from Nadeem Vawda nadeem.va...@gmail.com:
Patch attached. Reviews welcome.
--
components: Extension Modules
files: lzma-properties.diff
keywords: patch
messages: 160051
nosy: nadeem.vawda
priority: normal
severity: normal
stage: patch review
status: open
title: Add
Changes by Larry Hastings la...@hastings.org:
--
resolution: - fixed
stage: patch review - committed/rejected
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14705
___
Nadeem Vawda nadeem.va...@gmail.com added the comment:
I've put together a patch for the lzma module adding functions for
encoding and decoding filter properties (see issue 14736). It's a bit
bulky, though, so I'd like to get a review before committing it.
--
Eric Snow ericsnowcurren...@gmail.com added the comment:
Here's my take. No one will care about _frozen_importlib vs.
importlib._bootstrap normally, right? If __module__/__file__ says
_frozen_importlib, it's no big deal. The only time you care about the
distiction for importlib._bootstrap
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 05274ab06182 by Larry Hastings in branch 'default':
Update Misc/NEWS for issues #14127 and #14705. (And, technically, #10148.)
http://hg.python.org/cpython/rev/05274ab06182
--
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 05274ab06182 by Larry Hastings in branch 'default':
Update Misc/NEWS for issues #14127 and #14705. (And, technically, #10148.)
http://hg.python.org/cpython/rev/05274ab06182
--
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 05274ab06182 by Larry Hastings in branch 'default':
Update Misc/NEWS for issues #14127 and #14705. (And, technically, #10148.)
http://hg.python.org/cpython/rev/05274ab06182
--
89 matches
Mail list logo