[issue16478] Fix division in tabnanny

Georg Brandl added the comment: Well, sounds reasonable since we're working with an integer number of spaces :) -- ___ Python tracker ___

[issue16483] Make int(float('inf')) raise ValueError rather than OverflowError.

Case Van Horsen added the comment: I agree that ValueError is a more "correct" exception but I also don't think OverflowError is all that wrong. I don't think the change is worth the risk of breaking existing code. I'd be fine with either option. -- nosy: +casevh

[issue16423] urllib data URL

Changes by Mathias Panzenböck : -- components: +Library (Lib) -Documentation title: urllib data URL recipe -> urllib data URL type: -> enhancement ___ Python tracker ___ ___

[issue16423] urllib data URL recipe

Mathias Panzenböck added the comment: New patch. Instead of adding the data URL support to the doc as a recipe I added it to urllib.request directly. I think this is better and justified, because the old legacy URLopener had (some kind) of support for data URLs. OT: I think that the legacy URL

[issue10966] eliminate use of ImportError implicitly representing SkipTest

Brett Cannon added the comment: I'm at PyCon Argentina Friday and Saturday, so I have a rare opportunity to get stuff done. If anyone has issues or comments, please get them in over the next day or so, else I'm going to check this in as-is. -- ___ P

[issue15894] _PyImport_ReInitLock() doesn't check return value of PyThread_acquire_lock

Brett Cannon added the comment: The chances of this being a problem is REALLY small and the single function that calls this is a public void function so there is no way for an exception to propagate short of a fatal error which seems a bit much. I did change to using NOWAIT_LOCK, though.

[issue15031] Split .pyc parsing from module loading

Brett Cannon added the comment: You can't use "data" as there are connotations for that word thanks to get_data(). Same goes for "load" since this is something that get_code() would use more directly than load_module(). -- ___ Python tracker

[issue9893] Removing the Misc/Vim/ files

Brett Cannon added the comment: I decided against it. If Emacs doesn't already have one I figured Vim shouldn't either. -- ___ Python tracker ___

[issue10049] Add a "no-op" (null) context manager to contextlib

Nick Coghlan added the comment: No, an empty ExitStack() instance already works fine as a no-op context manager in 3.3: http://docs.python.org/3/library/contextlib#simplifying-support-for-single-optional-context-managers We're not going to add a dedicated one under a different name. -

[issue15031] Split .pyc parsing from module loading

Nick Coghlan added the comment: Perhaps go a bit more generic and call it something like "load_cached_data"? -- ___ Python tracker ___ ___

[issue15767] add ModuleNotFoundError

Eric Snow added the comment: Effectively the exception indicates that the import system had an error. -- ___ Python tracker ___ ___ Py

[issue15767] add ModuleNotFoundError

Eric Snow added the comment: I'd say ModuleNotFoundError. You could argue that other exception types aren't really errors in certain circumstances. I'd think that generally this would be an error. -- ___ Python tracker

[issue15627] Add a method to importlib.abc.SourceLoader for converting source to a code object

Eric Snow added the comment: Though I haven't been able to get to this, I do have a demo of sorts that I've been using elsewhere: https://bitbucket.org/ericsnowcurrently/pylt/src/default/pylt/_importing.py?at=default#cl-225 -- ___ Python tracker

[issue16386] imp.find_module does not specify registry key it searches on windows

Eric Snow added the comment: I agree with Andrew. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue10049] Add a "no-op" (null) context manager to contextlib

Dwayne Litzenberger added the comment: After seeing a context manager named like "TempfileIfNeeded(..., cond)", whole sole purpose is to handle the conditional case, I'm firmly +1 on this proposal. It's much easier to just read "with Tempfile() if cond else nullcontext():" than to read through

[issue16469] Exceptions raised by Fraction() different from those raised by int()

Alexey Kachayev added the comment: Ok, I think that ValueError is more appropriate and I have already attached adopted patch for issue 16483. -- ___ Python tracker ___ _

[issue16483] Make int(float('inf')) raise ValueError rather than OverflowError.

Alexey Kachayev added the comment: Patch is attached (ported from full issue patch for issue 16469). -- keywords: +patch nosy: +kachayev Added file: http://bugs.python.org/file27993/issue16483.diff ___ Python tracker

[issue12848] pickle.py treats 32bit lengths as signed, but _pickle.c as unsigned

Serhiy Storchaka added the comment: The C implementation writes and reads BINBYTES and BINUNICODE up to 4G (on 64-bit platform). The Python implementation writes and reads BINBYTES and BINUNICODE up to 2G. What should be compatible fix? Allow the Python implementation to write and read up to 4

[issue16478] Fix division in tabnanny

Changes by Antoine Pitrou : -- nosy: +georg.brandl ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.

[issue16479] Can't install Python 3 on Redhat Linux, make failed

Antoine Pitrou added the comment: Ok, closing then. -- nosy: +pitrou resolution: -> invalid status: open -> closed ___ Python tracker ___ ___

[issue15767] add ModuleNotFoundError

Chris Jerdonek added the comment: I meant to include this link for convenience: http://docs.python.org/dev/library/exceptions.html#exception-hierarchy -- ___ Python tracker ___

[issue15767] add ModuleNotFoundError

Chris Jerdonek added the comment: Since it subclasses ImportError, it seems like we're already considering it to be an error? StopIteration and GeneratorExit don't inherit from an "Error" exception type unlike, say, the OSError exception types. --

[issue16479] Can't install Python 3 on Redhat Linux, make failed

Stephen added the comment: Please ignore this. I have figured out it was caused by our company's make wrapper. Using native "make" works like a charm. -- ___ Python tracker ___

[issue9893] Removing the Misc/Vim/ files

Éric Araujo added the comment: Did you decide against including README.vim after all or just forgot that part? -- ___ Python tracker ___ __

[issue15783] decimal.localcontext(None) fails when using the C accelerator module

Mark Dickinson added the comment: > Should we go ahead with this? Sure: if you're willing to write the patch, go for it. -- ___ Python tracker ___ _

[issue9084] vimrc: use matchall() instead of ":match" to allow multiple matches

Brett Cannon added the comment: 7e37a6c76e36 removes the files in Misc/Vim. Thanks for the patch regardless, Daniel. If the syntax file in Vim is out of date then I would suggest trying to submit a patch. I have found the Vim maintainer quite willing to take fixes. -- resolution: -> w

[issue7620] Vim syntax highlight

Brett Cannon added the comment: 7e37a6c76e36 removed the Misc/Vim files since we just were not staying on top of them. Thanks for the patch regardless, July. If the syntax file in Vim itself is off I would submit those as I have found the Vim maintainers very willing to accept fixes.

[issue16469] Exceptions raised by Fraction() different from those raised by int()

Mark Dickinson added the comment: See issue #16483 for the ValueError / OverflowError switch. To be honest, while I would have preferred ValueError to OverflowError for int(float('inf')) if we were doing this from scratch, I'm not convinced that it's actually worth switching. -- ___

[issue9893] Removing the Misc/Vim/ files

Brett Cannon added the comment: Files removed in 7e37a6c76e36. -- resolution: -> fixed status: open -> closed ___ Python tracker ___ _

[issue16483] Make int(float('inf')) raise ValueError rather than OverflowError.

New submission from Mark Dickinson: [Broken out of the issue 16469 discussion about infinity -> Fraction and nan -> Fraction conversions.] Conversions from float('inf') or Decimal('inf') to int (or Fraction) currently generate an OverflowError, while conversions from nan give a ValueError. I'

[issue16391] add "terminator" ctor argument to logging.StreamHandlers derived handlers

Nikolay Bryskin added the comment: Great, thanks! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue16469] Exceptions raised by Fraction() different from those raised by int()

Mark Dickinson added the comment: Fixed in http://hg.python.org/cpython/rev/a2b54b6d9759. Thanks for the report and patch. -- resolution: -> fixed status: open -> closed ___ Python tracker __

[issue15767] add ModuleNotFoundError

Changes by Brett Cannon : -- stage: needs patch -> test needed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16469] Exceptions raised by Fraction() different from those raised by int()

Mark Dickinson added the comment: The first patch looks great (modulo a stray extra line in test_int). Thank you! Let's just apply that for now; I'll open a new issue for the suggested OverflowError / ValueError switch. (Getting rid of the TypeError seems a clear win to me; switching the Ove

[issue15767] add ModuleNotFoundError

Brett Cannon added the comment: Should it be ModuleNotFoundError or ModuleNotFound? It's not necessarily an error if a module doesn't exist, so failing to find it isn't quite that negative. It also acts somewhat like StopIteration/GeneratorExit which also don't have the common "Error" suffix o

[issue16458] subprocess.py throw "The handle is invalid" error on duplicating the STD_INPUT_HANDLE

Tim Golden added the comment: Karthk, if you can run up an up-to-date patch and a test I'm willing to review and commit it, otherwise this one will lie quiet. -- ___ Python tracker

[issue16281] TODO in tailmatch(): it does not support backward in all cases

Changes by Serhiy Storchaka : -- components: +Interpreter Core stage: -> needs patch ___ Python tracker ___ ___ Python-bugs-list mail

[issue15031] Split .pyc parsing from module loading

Brett Cannon added the comment: Might name it compile_bytecode_file() instead. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue15627] Add a method to importlib.abc.SourceLoader for converting source to a code object

Brett Cannon added the comment: Might name this compile_source() instead. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue15031] Split .pyc parsing from module loading

Brett Cannon added the comment: Here is my current plan:: parse_bytecode_file(data, source_stats, source_path) -> code This will take in the bytes from the bytecode file and a stats dict from SourceLoader.path_stats(). The method will parse the bytecode file, verify the magic number, timestam

[issue16434] SocketServer call shutdown in the wrong way

Changes by Andrew Svetlov : -- stage: -> needs patch ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue12908] Update dev-in-a-box for new coverage steps

Brett Cannon added the comment: Fixed in various commits. -- resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker ___

[issue16469] Exceptions raised by Fraction() different from those raised by int()

Changes by Alexey Kachayev : Added file: http://bugs.python.org/file27992/full_issues16469_fixed.diff ___ Python tracker ___ ___ Python-bugs-l

[issue16475] Support object instancing and recursion in marshal

Antoine Pitrou added the comment: marshal is only supposed to be used to serialize code objects, not arbitrary user data. Why don't you use pickle? -- nosy: +pitrou ___ Python tracker _

[issue16469] Exceptions raised by Fraction() different from those raised by int()

Alexey Kachayev added the comment: I also attached "full_issue" patch: change OverflowError to ValueError for all cases. -- Added file: http://bugs.python.org/file27991/full_issues16469.diff ___ Python tracker ___

[issue16469] Exceptions raised by Fraction() different from those raised by int()

Changes by Mark Dickinson : -- stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue16482] pdb.set_trace() clobbering traceback on error

New submission from A Kaptur: pdb.set_trace() is overwriting the actual traceback when exiting with an error. See minimal recreation here: https://gist.github.com/4079971 -- messages: 175630 nosy: akaptur priority: normal severity: normal status: open title: pdb.set_trace() clobbering

[issue16481] process handle leak on windows in multiprocessing

New submission from Richard Oudkerk: On Windows the handle for a child process is not closed when the popen/process object is garbage collected. -- messages: 175629 nosy: sbt priority: normal severity: normal stage: needs patch status: open title: process handle leak on windows in multi

[issue16446] pdb raises BdbQuit on 'quit' when started with set_trace

Changes by Serhiy Storchaka : -- versions: +Python 3.2, Python 3.3 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue15783] decimal.localcontext(None) fails when using the C accelerator module

Stefan Krah added the comment: By "all cases" I mean the ones listed in msg169144, not the Number methods. -- ___ Python tracker ___ _

[issue15783] decimal.localcontext(None) fails when using the C accelerator module

Stefan Krah added the comment: Should we go ahead with this? If so, then I think it only makes sense to change *all* undocumented cases of None default args. Here's a case that used rounding=None in quantize(): https://bitbucket.org/simplecodes/wtforms/issue/117/test-failure-with-python-33

[issue16480] pyvenv 3.3 fails to create symlinks for /local/{bin, lib} to /{bin, lib}

New submission from Marco Amadori: The solution to work around the bug is there: http://ipoveraviancarriers.blogspot.it/2012/11/python-33-and-pyvenv-hackish-solution.html But probably pyvenv should be patched in order to create symlinks. Thanks! -- components: None messages: 175626 no

[issue16469] Exceptions raised by Fraction() different from those raised by int()

Alexey Kachayev added the comment: Patch is attached for {float, Decimal} -> {int, Fraction} consistency (with ValueError and OverflowError). Test cases are changed as well. I can also change OverflowError to ValueError for all cases, but I'm not sure should I open for this separated issue or

[issue16479] Can't install Python 3 on Redhat Linux, make failed

Stephen added the comment: Sorry, missed the configure command in the previous message. It should have been: --- [sliu@wtl-build-1 Python-3.3.0]$ uname -a Linux wtl-build-1 2.6.18-164.el5 #1 SMP Tue Aug 18 15:51:48 EDT 2009 x86_64 x86_64 x86_64 GNU/Linux [sliu@wtl-build

[issue16479] Can't install Python 3 on Redhat Linux, make failed

New submission from Stephen: Machine is Redhat Linux 6.2. Tried to install Python3.3 build failed in the make step. --- [sliu@wtl-build-1 Python-3.3.0]$ uname -a Linux wtl-build-1 2.6.18-164.el5 #1 SMP Tue Aug 18 15:51:48 EDT 2009 x86_64 x86_64 x86_64 GNU/Linux [sliu@wt

[issue16446] pdb raises BdbQuit on 'quit' when started with set_trace

Changes by Andrew Svetlov : -- nosy: +asvetlov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue16447] SEGFAULT when setting type.__name__

Changes by Andrew Svetlov : -- nosy: +asvetlov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue16444] Use support.TESTFN_UNDECODABLE on UNIX

Changes by Andrew Svetlov : -- nosy: +asvetlov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue16434] SocketServer call shutdown in the wrong way

Changes by Andrew Svetlov : -- nosy: +asvetlov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue16429] Emit SyntaxWarning for code that risks UnboundLocalError

Changes by Andrew Svetlov : -- nosy: +asvetlov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue16427] Faster hash implementation

Changes by Andrew Svetlov : -- nosy: +asvetlov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue16422] Decimal constants should be the same for py & c module versions

Changes by Andrew Svetlov : -- nosy: +asvetlov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue16478] Fix division in tabnanny

New submission from Serhiy Storchaka: Tabnanny should use floor division in calculation, the comment says about this. But in the current Python 3 code "/" was not changed to "//". -- components: Demos and Tools, Library (Lib) files: tabnanny_div.patch keywords: easy, patch messages: 175

[issue16404] Uses of PyLong_FromLong that don't check for errors

Changes by Andrew Svetlov : -- nosy: +asvetlov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue16392] import crashes on circular imports in ext modules

Changes by Andrew Svetlov : -- nosy: +asvetlov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue16391] add "terminator" ctor argument to logging.StreamHandlers derived handlers

Changes by Andrew Svetlov : -- nosy: +asvetlov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue16386] imp.find_module does not specify registry key it searches on windows

Andrew Svetlov added the comment: I think much more important to mention registry key in http://docs.python.org/3/library/importlib.html#importlib.machinery.WindowsRegistryFinder ``imp`` is private module to access implementation internals but ``importlib`` is public interface to import syste

[issue16470] Backport set and dictionary comprehensions in tutorial to 2.7

Changes by Andrew Svetlov : -- nosy: +asvetlov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue16144] misleading sentence in reference/import

Andrew Svetlov added the comment: Fixed in a8ca14983ab1 and 9961a0dafcc7. Thanks, Manuel. -- nosy: +asvetlov ___ Python tracker ___ __

[issue16144] misleading sentence in reference/import

Changes by Andrew Svetlov : -- resolution: -> fixed stage: -> committed/rejected status: open -> closed type: -> behavior ___ Python tracker ___ __

[issue16391] add "terminator" ctor argument to logging.StreamHandlers derived handlers

Vinay Sajip added the comment: I've added the ability to set handler properties via configuration slightly more easily, see the code in changeset a81ae412174a (the unit test shows how the configuration looks in practice). This enhancement cannot be added to earlier Python versions (no feature

[issue16477] tarfile fails to close file handles in case of exception

Serhiy Storchaka added the comment: Issue16408 is similar issue for zipfile. -- keywords: +easy nosy: +lars.gustaebel, serhiy.storchaka stage: -> needs patch type: behavior -> resource usage versions: +Python 2.7, Python 3.2, Python 3.3, Python 3.4 -Python 3.5 _

[issue16477] tarfile fails to close file handles in case of exception

Sam Thursfield added the comment: sorry, replace 'open' with 'bltn_open' in the above comment - no need to change it. -- ___ Python tracker ___ _

[issue16477] tarfile fails to close file handles in case of exception

New submission from Sam Thursfield: Exceptions such as disk full during extraction cause tarfile to leak file handles. Besides being messy, it causes real problems if, for example, the target file is on a mount that should be unmounted before the program exits - in this case, the unmount will

[issue16465] dict creation performance regression

Serhiy Storchaka added the comment: > In the end, it's mostly a wash. Yes, it's predictable. The gain is too small and undistinguished on a background of random noise. May be more long-running benchmark will show more reliable results, but in any case, the gain is small. My long-running hard-

[issue2771] Test issue

Ezio Melotti added the comment: final test -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue2771] Test issue

Ezio Melotti added the comment: another test -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue2771] Test issue

Ezio Melotti added the comment: test -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/m

[issue2771] Test issue

Ezio Melotti added the comment: another test -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue2771] Test issue

Ezio Melotti added the comment: another test -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue2771] Test issue

Ezio Melotti added the comment: test -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/m

[issue16476] Trailing spaces in pretty-printed JSON

Ezio Melotti added the comment: This is a duplicate of #16333. -- nosy: +ezio.melotti resolution: -> duplicate stage: -> committed/rejected status: open -> closed superseder: -> Trailing whitespace in json dump when using indent ___ Python tracker

[issue16476] Trailing spaces in pretty-printed JSON

New submission from Leo Liu: python -mjson.tool some_file.json > x.json x.json will have trailing white spaces. Also reported here: http://thread.gmane.org/gmane.comp.python.devel/135311 -- messages: 175607 nosy: leoliu priority: normal severity: normal status: open title: Trailing spa

[issue16475] Support object instancing and recursion in marshal

Kristján Valur Jónsson added the comment: Second patch which adds the missing internment support for strings, including unittests. -- Added file: http://bugs.python.org/file27988/marshalinstance.patch ___ Python tracker

[issue16469] Exceptions raised by Fraction() different from those raised by int()

Mark Dickinson added the comment: > I think consistent behavior between int() and Fraction() is valuable. Agreed. If no-one objects I'll fix the Decimal -> Fraction and float -> Fraction conversions to match what Decimal -> int and float -> int currently do (ValueError and OverflowError). Th

[issue2771] Test issue

Ezio Melotti added the comment: test -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/m

[issue16475] Support object instancing and recursion in marshal

New submission from Kristján Valur Jónsson: The format used by the marshal module does not support instancing. This precludes certain data optimizations, such as sharing string constants, common tuples, even common code objects. Since the marshal format is used to write compiled code, this m

[issue2771] Test issue

Ezio Melotti added the comment: another test -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue2771] Test issue

Ezio Melotti added the comment: testing the new version of irker -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib