[issue20311] epoll.poll(timeout) and PollSelector.select(timeout) must round the timeout to the upper bound

2014-01-25 Thread Charles-François Natali
Charles-François Natali added the comment: > > But what problem does it cause if, once in a while, the call takes less > > than the passed timeout? > > If that's the case, you'll simply perform another loop, an wake up 1ms > > later, that's all. > > "perform another loop" is my problem. If possib

[issue20133] Derby: Convert the audioop module to use Argument Clinic

2014-01-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > Christian Heimes just posted this to python-dev: See issue20394. This is unrelated to clicalization patch. -- ___ Python tracker ___ __

[issue20394] Coverity complains on audioop

2014-01-25 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: Christian Heimes reported (http://permalink.gmane.org/gmane.comp.python.devel/145253) Coverity issue: """ ** CID 1164423: Division or modulo by zero (DIVIDE_BY_ZERO) /Modules/audioop.c: 1375 in audioop_ratecv_impl() _

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-25 Thread Larry Hastings
Larry Hastings added the comment: I don't know about diff #1, but diff #2 definitely applied cleanly against a fresh trunk at 8:22pm local time. I've turned off git format. -- ___ Python tracker _

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Rietveld doesn't like patches against out of date tree. And unfortunately it doesn't like patches in git format. -- ___ Python tracker ___ __

[issue20358] test_curses is failing on Ubuntu 13.10

2014-01-25 Thread Larry Hastings
Larry Hastings added the comment: I changed the unit test so it doesn't specify a minium row/column greater than the maximum row/column. The tests now pass. So I'm calling this good. Thanks for looking in to it, Zachary and Nadeem! -- assignee: -> larry resolution: -> fixed stage:

[issue20358] test_curses is failing on Ubuntu 13.10

2014-01-25 Thread Roundup Robot
Roundup Robot added the comment: New changeset 0ae768637a07 by Larry Hastings in branch 'default': Issue #20358: Tests for curses.window.overlay and curses.window.overwrite http://hg.python.org/cpython/rev/0ae768637a07 -- nosy: +python-dev ___ Python

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-25 Thread Roundup Robot
Roundup Robot added the comment: New changeset 1435d2fe8e34 by Larry Hastings in branch 'default': Issue #20390: Final fix, for generating NoPositional/NoKeyword for __init__ calls. http://hg.python.org/cpython/rev/1435d2fe8e34 -- ___ Python tracker

[issue20322] Upgrade ensurepip's pip and setuptools

2014-01-25 Thread Donald Stufft
Changes by Donald Stufft : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue19145] Inconsistent behaviour in itertools.repeat when using negative times

2014-01-25 Thread Larry Hastings
Larry Hastings added the comment: Raymond said "The preferred behavior is that a negative number always means 0." My proposal honors that. We certainly aren't changing this in 3.3 and 2.7, and as release manager for 3.4 I'm pretty sure we aren't changing it there. -- ___

[issue19145] Inconsistent behaviour in itertools.repeat when using negative times

2014-01-25 Thread Vajrasky Kok
Vajrasky Kok added the comment: Larry said, "A proper fix for the "bug" will require changing the semantics of the function. It's inappropriate to do that in 2.7, 3.3, and (now that we're in beta) 3.4." I think we can not have it all and need to be pragmatic in this ticket. While we can not f

[issue20226] Argument Clinic: support for simple expressions?

2014-01-25 Thread Larry Hastings
Changes by Larry Hastings : -- stage: commit review -> committed/rejected ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-25 Thread Larry Hastings
Changes by Larry Hastings : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ _

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-25 Thread Roundup Robot
Roundup Robot added the comment: New changeset 9c5b421cc7de by Larry Hastings in branch 'default': Issue #20390: Small fixes and improvements for Argument Clinic. http://hg.python.org/cpython/rev/9c5b421cc7de -- nosy: +python-dev ___ Python tracker <

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-25 Thread Larry Hastings
Larry Hastings added the comment: I don't know why it's refusing to generate the review link. The patch applies cleanly to trunk, even now, hours later. Maybe it doesn't like file moves? -- ___ Python tracker __

[issue20322] Upgrade ensurepip's pip and setuptools

2014-01-25 Thread Larry Hastings
Larry Hastings added the comment: You can check those in for 3.4. Do it right now and you can get them in for beta 3. Sorry for the tardy reply! -- ___ Python tracker ___

[issue13355] random.triangular error when low = high=mode

2014-01-25 Thread Larry Hastings
Larry Hastings added the comment: I haven't looked at this in depth but it sounds like this is a legitimate concern. I'd like it fixed for 3.4, preferably before rc1. -- nosy: +larry ___ Python tracker __

[issue20319] concurrent.futures.wait() can block forever even if Futures have completed

2014-01-25 Thread Glenn Langford
Glenn Langford added the comment: > It seems more plausible that the locks around the removals are fixing the bug > but I don't see how. I'll look into it some more. It is the locks around the waiter removals that matter; I think there are only formatting changes elsewhere in the patch. The re

[issue20319] concurrent.futures.wait() can block forever even if Futures have completed

2014-01-25 Thread Brian Quinlan
Brian Quinlan added the comment: I'm looking at "futures.patch". I don't understand why these blocks are helpful -"_create_and_install_waiters" has two call sites and both ("as_completed" and "wait") call "_create_and_install_waiters" from within an _AcquireFutures context manager: -p

[issue20177] Derby #8: Convert 28 sites to Argument Clinic across 2 files

2014-01-25 Thread Nikolaus Rath
Nikolaus Rath added the comment: I'll wait with working on _datetimemodule.c until someone had a chance to look over my _timemodule.c patch. (I want to make sure I'm following the right procedure). -- ___ Python tracker

[issue20177] Derby #8: Convert 28 sites to Argument Clinic across 2 files

2014-01-25 Thread Nikolaus Rath
Changes by Nikolaus Rath : Added file: http://bugs.python.org/file33717/timemodule_part2_rev3.patch ___ Python tracker ___ ___ Python-bugs-lis

[issue20177] Derby #8: Convert 28 sites to Argument Clinic across 2 files

2014-01-25 Thread Nikolaus Rath
Changes by Nikolaus Rath : Removed file: http://bugs.python.org/file33714/timemodule_part1_rev3.patch ___ Python tracker ___ ___ Python-bugs-l

[issue20177] Derby #8: Convert 28 sites to Argument Clinic across 2 files

2014-01-25 Thread Nikolaus Rath
Changes by Nikolaus Rath : Added file: http://bugs.python.org/file33716/timemodule_part1_rev3.patch ___ Python tracker ___ ___ Python-bugs-lis

[issue20363] BytesWarnings triggerred by test suite

2014-01-25 Thread Berker Peksag
Changes by Berker Peksag : Removed file: http://bugs.python.org/file33712/issue20363_v2.diff ___ Python tracker ___ ___ Python-bugs-list maili

[issue20363] BytesWarnings triggerred by test suite

2014-01-25 Thread Berker Peksag
Berker Peksag added the comment: Ah, my bad. Thanks Arfrever. -- Added file: http://bugs.python.org/file33715/issue20363_v3.diff ___ Python tracker ___ __

[issue20363] BytesWarnings triggerred by test suite

2014-01-25 Thread Berker Peksag
Changes by Berker Peksag : Removed file: http://bugs.python.org/file33669/issue20363.diff ___ Python tracker ___ ___ Python-bugs-list mailing

[issue20177] Derby #8: Convert 28 sites to Argument Clinic across 2 files

2014-01-25 Thread Nikolaus Rath
Nikolaus Rath added the comment: I've attached updated patches to reflect the recent changes in the derby policy. part1 is the part of the patch that is suitable for 3.4. part2 are the changes that have to wait for 3.5 (mostly because of default values). -- Added file: http://bugs.pyt

[issue20367] concurrent.futures.as_completed() fails when given duplicate Futures

2014-01-25 Thread Guido van Rossum
Guido van Rossum added the comment: LGTM. But you also need to update Doc/library/concurrent.futures.rst I see this as a bugfix so it's not necessary to get this in before the beta 3 release tonight. I will work on an asyncio patch and test. -- ___

[issue20363] BytesWarnings triggerred by test suite

2014-01-25 Thread Arfrever Frehtes Taifersar Arahesis
Arfrever Frehtes Taifersar Arahesis added the comment: The new patch has %s and %r reversed in Lib/distutils/command/register.py. -- ___ Python tracker ___ __

[issue20375] ElementTree: Document handling processing instructions

2014-01-25 Thread Nikolaus Rath
Nikolaus Rath added the comment: I've also attached a testcase to confirm that the docpatch reflects current behavior, and to make sure that anticipated enhancements in Python 3.5 behave in a backwards compatible way. -- Added file: http://bugs.python.org/file33713/etree-testcases.patc

[issue20283] Wrong keyword parameter name in regex pattern methods

2014-01-25 Thread Terry J. Reedy
Terry J. Reedy added the comment: Great. Old and new both in at least one release, when possible, is best. I should have thought of asking if that would be possible. In this case, I think the (undocumented) old should disappear in 3.5. Since the mistaken 'pattern' name is not documented now, I

[issue20363] BytesWarnings triggerred by test suite

2014-01-25 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the review, Arfrever and Serhiy. Here's a new patch. -- Added file: http://bugs.python.org/file33712/issue20363_v2.diff ___ Python tracker ___

[issue20386] socket.SocketType enum overwrites import of _socket.SocketType

2014-01-25 Thread Nick Coghlan
Nick Coghlan added the comment: I strongly prefer SocketKind - SockType is far too close to SocketType and "type" is too closely associated with the type system in general. -- ___ Python tracker ___

[issue20133] Derby: Convert the audioop module to use Argument Clinic

2014-01-25 Thread Larry Hastings
Larry Hastings added the comment: Christian Heimes just posted this to python-dev: Coverity has detected an issue in this commit: ** CID 1164423: Division or modulo by zero (DIVIDE_BY_ZERO) /Modules/audioop.c: 1375 in audioop_rate

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-25 Thread Larry Hastings
Larry Hastings added the comment: No, wait, I think it's fine, it was just some detritus in my directory throwing me off. But "hg stat" looks correct. -- ___ Python tracker ___

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-25 Thread Larry Hastings
Larry Hastings added the comment: Oops, I goofed up moving _lzamodule.clinic.c.h. I'll fix that locally, won't regenerate the patch just for that (unless you ask me to). -- ___ Python tracker

[issue20385] Argument Clinic: Support for __new__ not checking _PyArg_NoKeywords for sub-classes

2014-01-25 Thread Larry Hastings
Larry Hastings added the comment: Can you try locally applying my patch for #20390 and seeing if you still have the problem? I tried applying it to the itertoolmodule.c you attached to the issue and it seemed to fix the problem. -- ___ Python track

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-25 Thread Larry Hastings
Larry Hastings added the comment: Okay, here's my revised patch, for real this time, with "hg mv" for the side files and everything. -- Added file: http://bugs.python.org/file33711/larry.clinic.rollup.jan.25.diff.2.txt ___ Python tracker

[issue20358] test_curses is failing on Ubuntu 13.10

2014-01-25 Thread Zachary Ware
Zachary Ware added the comment: Ok, I've tracked down where the error is happening, but I don't know enough about curses to suggest where it should go from here. It does appear to be the version of ncurses that Ubuntu 13.10 uses that's causing problems, version 5.9+20130608. The issue stems

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-25 Thread Larry Hastings
Larry Hastings added the comment: Hang on, my tree was out of date. Which is why I didn't get a review link, duh. And if side files have appeared I'll fix 'em. -- ___ Python tracker _

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-25 Thread Larry Hastings
Changes by Larry Hastings : Removed file: http://bugs.python.org/file33710/larry.clinic.rollup.jan.25.diff.2.txt ___ Python tracker ___ ___ P

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-25 Thread Larry Hastings
Larry Hastings added the comment: Thanks for the reviews, Nick and Serhiy, especially considering that the Rietveld link didn't work! Serhiy: I believe I fixed everything. There are no side files checked in yet. Can you give me another review? -- Added file: http://bugs.python.org/

[issue20311] epoll.poll(timeout) and PollSelector.select(timeout) must round the timeout to the upper bound

2014-01-25 Thread STINNER Victor
STINNER Victor added the comment: > Looks like 3b8a2281d323aa9abf497192b01cf9 06b98ed3d8 broke the buildbots. Oh, I didn't watch buildbots, sorry. It should be fixed by f453443c96e4. My first attempt used an attribute using a default value of None, but it was harder to use: I had to check if th

[issue20311] epoll.poll(timeout) and PollSelector.select(timeout) must round the timeout to the upper bound

2014-01-25 Thread Guido van Rossum
Guido van Rossum added the comment: I don't have the energy to read all the debate here, but over on python-tulip we continue to discuss this. Victor and I have currently agreed to drop the math.ceil() calls from the event loop and instead simply consider any event scheduled within "granularit

[issue20311] epoll.poll(timeout) and PollSelector.select(timeout) must round the timeout to the upper bound

2014-01-25 Thread Roundup Robot
Roundup Robot added the comment: New changeset f453443c96e4 by Victor Stinner in branch 'default': Issue #20311: Fix test_telnetlib, set the resolution of the MockSelector http://hg.python.org/cpython/rev/f453443c96e4 -- ___ Python tracker

[issue20311] epoll.poll(timeout) and PollSelector.select(timeout) must round the timeout to the upper bound

2014-01-25 Thread STINNER Victor
STINNER Victor added the comment: 2014-01-25 Charles-François Natali : >> It looks like changing the rounding method doesn't solve anything. >> selector.select(timeout) may still take less than timeout, so it >> doesn't give any guarantee. > > But what problem does it cause if, once in a while, t

[issue19944] Make importlib.find_spec load packages as needed

2014-01-25 Thread Eric Snow
Changes by Eric Snow : -- status: pending -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue20311] epoll.poll(timeout) and PollSelector.select(timeout) must round the timeout to the upper bound

2014-01-25 Thread Eric Snow
Eric Snow added the comment: A better example: http://buildbot.python.org/all/builders/AMD64%20FreeBSD%2010.0%203.x/builds/1538 -- ___ Python tracker ___ ___

[issue20311] epoll.poll(timeout) and PollSelector.select(timeout) must round the timeout to the upper bound

2014-01-25 Thread Eric Snow
Eric Snow added the comment: FYI: on my local box I saw only the 2 failed tests in test_telnetlib. -- ___ Python tracker ___ ___ Pytho

[issue20311] epoll.poll(timeout) and PollSelector.select(timeout) must round the timeout to the upper bound

2014-01-25 Thread Eric Snow
Eric Snow added the comment: Looks like 3b8a2281d323aa9abf497192b01cf906b98ed3d8 broke the buildbots. e.g. http://buildbot.python.org/all/builders/AMD64%20FreeBSD%2010.0%203.x/builds/1533 -- nosy: +eric.snow ___ Python tracker

[issue19944] Make importlib.find_spec load packages as needed

2014-01-25 Thread Eric Snow
Changes by Eric Snow : -- resolution: -> fixed stage: -> committed/rejected status: open -> pending type: -> enhancement ___ Python tracker ___ ___

[issue19944] Make importlib.find_spec load packages as needed

2014-01-25 Thread Roundup Robot
Roundup Robot added the comment: New changeset 665f1ba77b57 by Eric Snow in branch 'default': Issue 19944: Fix importlib.find_spec() so it imports parents as needed. http://hg.python.org/cpython/rev/665f1ba77b57 -- nosy: +python-dev ___ Python tracker

[issue20311] epoll.poll(timeout) and PollSelector.select(timeout) must round the timeout to the upper bound

2014-01-25 Thread Charles-François Natali
Charles-François Natali added the comment: > > Once again, what's wrong with your initial approach of ceiling the timeout? > > It looks like changing the rounding method doesn't solve anything. > selector.select(timeout) may still take less than timeout, so it > doesn't give any guarantee. But w

[issue20386] socket.SocketType enum overwrites import of _socket.SocketType

2014-01-25 Thread Ethan Furman
Ethan Furman added the comment: How do we feel about SockType instead? (Just a short round of bike-shedding, promise! ;) -- ___ Python tracker ___ _

[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

2014-01-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I suppose that zdict=b'' have same effect as not specifying zdict. Am I right? -- ___ Python tracker ___ _

[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

2014-01-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Updated patch for zlib reverts reverted decompress(), decompressobj() and Decompress.flush(). It get rids from DEF_WBITS and use MAX_WBITS instead, exposes DEF_BUF_SIZE (former DEFAULTALLOC) to Python level. -- Added file: http://bugs.python.org/file

[issue20369] concurrent.futures.wait() blocks forever when given duplicate Futures

2014-01-25 Thread Glenn Langford
Glenn Langford added the comment: Updated patch with a test case, and added a minor note to the docstring to clarify behaviour. The use of sleep() in the test is not great, but it is the most obvious way to test and it is consistent with the approach used in other concurrent test cases. -

[issue20386] socket.SocketType enum overwrites import of _socket.SocketType

2014-01-25 Thread Eli Bendersky
Eli Bendersky added the comment: Yep, the overriding of the type name was inadvertent. Nothing sacred about it, so Ethan's SocketKind is just as good. -- ___ Python tracker ___

[issue20393] Docs: mark deprecated items in the TOC

2014-01-25 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +georg.brandl ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue20393] Docs: mark deprecated items in the TOC

2014-01-25 Thread Zearin
New submission from Zearin: When exploring the docs for the standard library, it’s frustrating to have an idea and look for the answer only to find out that an entire module (or package) has been deprecated _after_ I click on it. Can we have links to deprecated items on the Standard Library’s

[issue20311] epoll.poll(timeout) and PollSelector.select(timeout) must round the timeout to the upper bound

2014-01-25 Thread STINNER Victor
STINNER Victor added the comment: Hi, 2014-01-25 Charles-François Natali : > I'm sorry, but I'm not convinced. > The selector's granularity is an implementation detail, and I don't think > it should be exposed. I disagre, it's not a detail because it causes bugs, knowing the resolution matters.

[issue20386] socket.SocketType enum overwrites import of _socket.SocketType

2014-01-25 Thread Ethan Furman
Ethan Furman added the comment: The containers are there to help with discoverability. If you want to know what all the (common) AF values are you can either do [name for name in dir(socket) if name.isupper() and name.startswith('AF_')] or list(socket.AddressFamily) --

[issue20386] socket.SocketType enum overwrites import of _socket.SocketType

2014-01-25 Thread Ethan Furman
Ethan Furman added the comment: Complete patch with new test, fixed tests, and regression fix. Doc patch still needed. -- stage: test needed -> patch review Added file: http://bugs.python.org/file33707/issue20386.stoneleaf.patch.02 ___ Python tracker

[issue20386] socket.SocketType enum overwrites import of _socket.SocketType

2014-01-25 Thread Georg Brandl
Georg Brandl added the comment: I'm not saying the enums are necessary (argue about that with Eli), but that if they *are* in the module as a public attribute, they *have* to be documented, period. -- ___ Python tracker

[issue20386] socket.SocketType enum overwrites import of _socket.SocketType

2014-01-25 Thread Giampaolo Rodola'
Giampaolo Rodola' added the comment: But as a user when are you gonna need to use AddressFamily container? Before enum we didn't have something like: AddressFamily = (AF_INET, AF_INET6, ...) Basically because we didn't need it. Sorry if I'm missing something here. -- _

[issue20386] socket.SocketType enum overwrites import of _socket.SocketType

2014-01-25 Thread Georg Brandl
Georg Brandl added the comment: > Why should new enums be documented and how are they useful? Because they are a new public class(-like object) in the module. When renaming them to a non-public name, as you suggest, that could be left out. -- ___ Py

[issue20386] socket.SocketType enum overwrites import of _socket.SocketType

2014-01-25 Thread Giampaolo Rodola'
Giampaolo Rodola' added the comment: > Please find a better name for the type enum and document the new enums. Why should new enums be documented and how are they useful? IMO socket module adopted enum module only to provide a better representation of AF_* and SOCK_* constants on repr(), which

[issue20386] socket.SocketType enum overwrites import of _socket.SocketType

2014-01-25 Thread Ethan Furman
Ethan Furman added the comment: Here's a patch for the test. -- Added file: http://bugs.python.org/file33706/issue20386.stoneleaf.test.patch.01 ___ Python tracker ___ ___

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: _PyType_GetDocFromInternalDoc and _PyType_GetTextSignatureFromInternalDoc declarations are too long. could you please wrap them around? First parameter of class methods (e.g. dict.fromkeys) now has a type of object (PyDictObject *) instead of PyTypeObject *

[issue20283] Wrong keyword parameter name in regex pattern methods

2014-01-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Here is patch for 3.3 which adds alternative parameter name. Now both keyword names are allowed, but deprecation warning is emitted if old keyword name is used. >>> import re >>> p = re.compile('') >>> p.match() Traceback (most recent call last): File "",

[issue5755] "-Wstrict-prototypes" is valid for Ada/C/ObjC but not for C++"

2014-01-25 Thread Jon Parise
Changes by Jon Parise : -- nosy: -jon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/m

[issue15955] gzip, bz2, lzma: add option to limit output size

2014-01-25 Thread Nikolaus Rath
Nikolaus Rath added the comment: Let me be more precise: My suggestion is not to remove `unconsumed_tail` entirely, but I think its value needs to be defined only when the end of the compressed stream has been reached. In other words, you could still do: while not decomp.eof # ... if deco

[issue20374] Failure to compile with readline-6.3-rc1

2014-01-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I'm surprised that warnings are emitted at lines 939 and 941, but not 944. I think that instead type casting, the more robust way is to change hook functions signatures for on_startup_hook and on_pre_input_hook. static int #ifdef _RL_FUNCTION_TYPEDEF /* or m

[issue20374] Failure to compile with readline-6.3-rc1

2014-01-25 Thread Benjamin Peterson
Benjamin Peterson added the comment: It doesn't complain on Linux. I suppose if we don't want any warnings, we'd have to do something like the originally proposed patch. -- ___ Python tracker _

[issue20374] Failure to compile with readline-6.3-rc1

2014-01-25 Thread Ned Deily
Ned Deily added the comment: FYI, removing the cast causes the following new warnings when compiling 3.3 with gcc-4.2 on OS X 10.5 and 10.6 (haven't checked elsewhere): Modules/readline.c: In function 'setup_readline': Modules/readline.c:939: warning: assignment from incompatible pointer type M

[issue20331] Fix various fd leaks

2014-01-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you Charles-François. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ _

[issue20331] Fix various fd leaks

2014-01-25 Thread Roundup Robot
Roundup Robot added the comment: New changeset 6548f894b590 by Serhiy Storchaka in branch '2.7': Issue #20331: Fixed possible FD leaks in various modules: http://hg.python.org/cpython/rev/6548f894b590 New changeset 2766320bdb10 by Serhiy Storchaka in branch '3.3': Issue #20331: Fixed possible FD

[issue20385] Argument Clinic: Support for __new__ not checking _PyArg_NoKeywords for sub-classes

2014-01-25 Thread Tal Einat
Tal Einat added the comment: To make reproducing these bugs easier, I'm attaching my partially converted version of Modules/itertoolsmodules.c, which has the buggy generated code inside. "Partially converted" means that I've only converted some of the functions requiring conversion. This file

[issue20385] Argument Clinic: Support for __new__ not checking _PyArg_NoKeywords for sub-classes

2014-01-25 Thread Tal Einat
Tal Einat added the comment: Also, I'm seeing this in the generated code for __new__ methods: if (({self_name} == {self_type_object}) && -- ___ Python tracker ___ __

[issue20385] Argument Clinic: Support for __new__ not checking _PyArg_NoKeywords for sub-classes

2014-01-25 Thread Tal Einat
Tal Einat added the comment: To clarify my previous comment, I was referring to the first argument passed to the generated 'impl' function. Context: I'm attempting to convert 'itertools.groupby' in Modules/itertoolsmodule.c. -- ___ Python tracker

[issue20385] Argument Clinic: Support for __new__ not checking _PyArg_NoKeywords for sub-classes

2014-01-25 Thread Tal Einat
Tal Einat added the comment: I'm still seeing the first argument to a __new__ function as "groupbyobject *" instead of "PyTypeObject *". This causes the following error (for example): ./Modules/itertoolsmodule.c:112:34: error: no member named 'tp_alloc' in 'groupbyobject' gbo = (groupbyobj

[issue20392] Inconsistency with uppercase file extensions in MimeTypes.guess_type

2014-01-25 Thread Rodrigo Parra
New submission from Rodrigo Parra: The functions looks up for the file extension in three maps: types_map, suffix_map and encodings_map. Lookup in types_map is case insensitive (by calling lower() first). Lookup in both suffix_map and encodings_map is case sensitive. These can lead to some see

[issue20331] Fix various fd leaks

2014-01-25 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Don't forget to use "hg mv" to rename existing side files. -- ___ Python tracker ___ ___ Python-bu

[issue20331] Fix various fd leaks

2014-01-25 Thread Charles-François Natali
Charles-François Natali added the comment: LGTM. -- nosy: +neologix ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue20391] windows python launcher should support explicit 64-bit version

2014-01-25 Thread Thomas Heller
New submission from Thomas Heller: The windows python launcher supports the '-3.3' resp. '-3.3-32' command line switches to ask for 'the best 3.3' version resp. 'the 32-bit 3.3' version, but does not support a '-3.3-64' switch to explicitely request the 64-bit version of Python. I suggest tha

[issue20325] Argument Clinic: self converters are not preserved when cloning functions

2014-01-25 Thread Larry Hastings
Larry Hastings added the comment: You didn't supply a test case, nor is there any code checked in that reproduced the issue. I had to make a test case by hand. -- ___ Python tracker __

[issue20311] epoll.poll(timeout) and PollSelector.select(timeout) must round the timeout to the upper bound

2014-01-25 Thread Charles-François Natali
Charles-François Natali added the comment: > If the patch is accepted, my changes on Python 3.3 should also be reverted. I'm sorry, but I'm not convinced. The selector's granularity is an implementation detail, and I don't think it should be exposed. Furthermore, it's not a mere function of the

[issue20325] Argument Clinic: self converters are not preserved when cloning functions

2014-01-25 Thread Tal Einat
Tal Einat added the comment: You're right, this issue does indeed seem to have been resolved since I created this issue. I just checked this on Objects/bytesobject.c with the latest version and get the desired output. So you've done right to close this issue. I'd like to note that I most cert

[issue19023] ctypes docs: Unimplemented and undocumented features

2014-01-25 Thread Adam Knight
Adam Knight added the comment: Can someone add this in? What needs to be done to make it happen? Kind of need this for a project I'm working on... -- nosy: +ahknight ___ Python tracker ___

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-25 Thread Nick Coghlan
Nick Coghlan added the comment: LGTM, but I'm not familiar with Clinic's own code... -- ___ Python tracker ___ ___ Python-bugs-list ma

[issue19145] Inconsistent behaviour in itertools.repeat when using negative times

2014-01-25 Thread Mark Lawrence
Mark Lawrence added the comment: >From a user perspective the docs say this "itertools.repeat(object[, times]) - >Make an iterator that returns object over and over again. Runs indefinitely >unless the times argument is specified." So to me the use of "Times=None" in >the "equivalent to" sect

[issue20231] Argument Clinic accepts no-default args after default args

2014-01-25 Thread Larry Hastings
Larry Hastings added the comment: The bug you cited is fixed in today's rollup patch, #20390. (I don't know how to denote the dependency between the two issues, maybe someone else can do that for me?) -- ___ Python tracker

[issue20385] Argument Clinic: Support for __new__ not checking _PyArg_NoKeywords for sub-classes

2014-01-25 Thread Larry Hastings
Larry Hastings added the comment: The bug you cited is fixed in today's rollup patch, #20390. (I don't know how to denote the dependency between the two issues, maybe someone else can do that for me?) -- ___ Python tracker

[issue20348] Argument Clinic HOWTO listed multiple times in HOWTO index

2014-01-25 Thread Ezio Melotti
Ezio Melotti added the comment: Fixed, thanks for the patch! -- assignee: larry -> ezio.melotti nosy: +ezio.melotti resolution: -> fixed stage: -> committed/rejected status: open -> closed type: -> enhancement ___ Python tracker

[issue20390] Argument Clinic rollup patch, 2014/01/25

2014-01-25 Thread Larry Hastings
New submission from Larry Hastings: Rollup patch with a bunch of small fixes in it. Can I get a quick turnaround review on this? I'd like it to go in before today's beta is cut. Definitely the core change has to go in, but that's uncontroversial. Core: * _PyType_GetDocFromInternalDoc()

[issue20348] Argument Clinic HOWTO listed multiple times in HOWTO index

2014-01-25 Thread Roundup Robot
Roundup Robot added the comment: New changeset 1eec62cf3675 by Ezio Melotti in branch 'default': #20348: fix headers markup in Argument Clinic howto. Patch by Moritz Neeb. http://hg.python.org/cpython/rev/1eec62cf3675 -- nosy: +python-dev ___ Python

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

2014-01-25 Thread Nick Coghlan
Nick Coghlan added the comment: More comprehensive patch uploaded - all the non-type callables implemented in bltinmodule.c have been converted or classified with a reason for not being converted yet (see the new test in test_inspect.py for details, as well as the AC 3.4 and AC 3.5 comments in

[issue20325] Argument Clinic: self converters are not preserved when cloning functions

2014-01-25 Thread Larry Hastings
Larry Hastings added the comment: You didn't give me a test case, and I can't reproduce this. Either it was accidentally fixed already, or there's something else going on in your test case. I'm closing this for now as unreproducable. If you see the problem again, please reopen this issue.

[issue20311] epoll.poll(timeout) and PollSelector.select(timeout) must round the timeout to the upper bound

2014-01-25 Thread STINNER Victor
STINNER Victor added the comment: I revert all changes in select an selectors, the timeout is rounded again towards zero, as it was before. I applied my asyncio_granularity.patch: - selectors.BaseSelector has a new abstract "resolution" property - asyncio.BaseEventLoop has a new granularity att

  1   2   >