Terry J. Reedy added the comment:
Attached is the 3.4 file I am ready to commit. Comments on Rietveld. I believe
the 3 missed line could be hit by adding a delay to a test, but this seems
pretty useless. The test file explicitly tests only two of the methods. Tests
of other methods could be
Terry J. Reedy added the comment:
I did the trivial part of a 2.7 backport of 2 name changes, but the real
problem is that 2.7 does not have unittest.mock (which is why I have not used
it until now). I removed one use with a dummy class, but am leaving the other
one in the last test to you.
Changes by Terry J. Reedy tjre...@udel.edu:
--
stage: patch review - needs patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21694
___
___
Claudiu Popa added the comment:
Antoine, how does my latest patch look?
--
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19776
___
Changes by Claudiu Popa pcmantic...@gmail.com:
--
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15795
___
___
Mark Lawrence added the comment:
As we're now on 3.5, AIX is up to 7.1 and there's no patch can we close this
one as out of date?
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5718
Changes by Tim Golden m...@timgolden.me.uk:
--
assignee: - tim.golden
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21652
___
___
STINNER Victor added the comment:
Updated patch: names must now be strings and cannot be deleted; make
_PyEval_EvalCodeWithName private.
--
Added file: http://bugs.python.org/file35611/gen_qualname-3.patch
___
Python tracker rep...@bugs.python.org
New submission from Matthew Gilson:
The BaseResult has been replaced by namedtuple. This also opens up all of the
documented methods on namedtuple which would be nice to have as part of the
API. I've taken a stab and re-writing the docs here. Feel free to use it (or
not)...
--
Changes by Matthew Gilson m.gils...@gmail.com:
--
assignee: - docs@python
components: +Documentation
nosy: +docs@python
versions: +Python 2.7
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21746
Matthew Gilson added the comment:
Sorry, forgot to remove the mention of BaseResult ...
--
Added file: http://bugs.python.org/file35613/python_doc_patch.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21746
Martijn Pieters added the comment:
Note that the Python 3 docs also need updating, but need a more extensive patch:
https://docs.python.org/3/library/urllib.parse.html#structured-parse-results
--
nosy: +mjpieters
___
Python tracker
Matthew Gilson added the comment:
This originally came up on stackoverflow:
http://stackoverflow.com/questions/24200988/modify-url-components-in-python-2/24201020?noredirect=1#24201020
Would it be helpful if I also added a simple example to the docs as in the
example there?
--
Changes by Josh Rosenberg shadowranger+pyt...@gmail.com:
--
nosy: +josh.rosenberg
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21744
___
___
Mathieu Dupuy added the comment:
Could we at least do something cleaner that let the interpreter raise an
UnboundLocalError ? Maybe something like NotImplemented ?
--
nosy: +deronnax
___
Python tracker rep...@bugs.python.org
Claudiu Popa added the comment:
Hi. Would you like to provide a patch?
--
keywords: +easy
nosy: +Claudiu.Popa
stage: - needs patch
type: - enhancement
versions: +Python 3.5 -Python 3.4
___
Python tracker rep...@bugs.python.org
Berker Peksag added the comment:
Here's a patch. I'm getting the following error without modify Lib/shutil.py:
==
ERROR: test_copytree_symbolic_directory (test.test_shutil.TestShutil)
New submission from Serhiy Ivanov:
have 1.py as:
import argparse
import sys
print (sys.argv)
parser = argparse.ArgumentParser(prog='demo')
parser.add_argument('--host -h', help='host for the server of %(prog)',
nargs=1, required=True, metavar='host')
parser.add_argument('--port -p', help='port
R. David Murray added the comment:
Sure. Would you like to propose a patch? It does seem that
NotImplementedError would be the most appropriate. It could give Christian's
reason why it is not implemented.
--
stage: patch review - needs patch
___
Roundup Robot added the comment:
New changeset 75b18ff66e41 by Victor Stinner in branch 'default':
Issue #16136: VMSError is done, bye bye VMS
http://hg.python.org/cpython/rev/75b18ff66e41
--
___
Python tracker rep...@bugs.python.org
R. David Murray added the comment:
Then don't use itertools for that case. itertools is designed for working with
*arbitrary* iterables, and arbitrary iterables are not seekable.
I'll leave it to Raymond to decide if it is worth making a special-case
optimization :)
--
nosy:
Roundup Robot added the comment:
New changeset 48126f225f10 by Victor Stinner in branch '3.4':
Issue #16136: VMSError is done, bye bye VMS
http://hg.python.org/cpython/rev/48126f225f10
--
___
Python tracker rep...@bugs.python.org
R. David Murray added the comment:
You are missing an 's' after the parens. It should be: %(prog)s
--
nosy: +r.david.murray
resolution: - not a bug
stage: - resolved
status: open - closed
type: - behavior
___
Python tracker rep...@bugs.python.org
Donald Stufft added the comment:
So Twisted is actually in the process of pulling out their tooling they use for
the separate files technique and making it a stand alone project. Seems like
it'd make sense to reuse/contribute to that?
It's at https://github.com/twisted/newsbuilder
--
Ben Hoyt added the comment:
Full patch to add this to Python 3.5 attached:
* code changes to posixmodule.c and _stat.c
* tests added in test_os.py and test_stat.py
* docs added to os.rst and stat.rst
--
keywords: +patch
Added file: http://bugs.python.org/file35615/issue21719.patch
Zachary Ware added the comment:
Here's a diff against 3.4 produced by the script. Warning: it's rather large.
$ hg diff --stat
[...]
162 files changed, 199 insertions(+), 942 deletions(-)
--
keywords: +patch
Added file: http://bugs.python.org/file35616/issue21741.diff
New submission from David Jones:
```
for f in glob.glob('input/*/*.dat'): print f
```
outputs:
```
input/ghcnm.v3.2.2.20140611/ghcnm.tavg.v3.2.2.20140611.qca.dat
input/ghcnm.v3.2.2.20140506/ghcnm.tavg.v3.2.2.20140506.qca.dat
```
Note that these are not in the right order. Compare with shell
New submission from Marc-Andre Lemburg:
This leads to problems when using runpy, since it relies on pkgutil to find
importers.
In Python 2, ImpLoader is used by ImpImporter which is used as fallback
importer by get_importer(). get_importer() is used by runpy to implement e.g.
the -m option.
R. David Murray added the comment:
I think there is no reason to impose the overhead of a sort unless the user
wants it...in which case they can sort it. I'm -1 on this change.
--
nosy: +r.david.murray
___
Python tracker rep...@bugs.python.org
Mark Lawrence added the comment:
Just slipped under the radar?
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17941
___
___
Roundup Robot added the comment:
New changeset 10cca530d14c by Zachary Ware in branch '3.4':
Issue #21745: Mention VS2010 SP1 as a solution for LNK1123 errors
http://hg.python.org/cpython/rev/10cca530d14c
New changeset b5b54073d495 by Zachary Ware in branch 'default':
Issue #21745: Merge with
Mark Lawrence added the comment:
Is this still relevant as GCC 4.9.0 was released on April 22, 2014?
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8535
___
Roundup Robot added the comment:
New changeset 9794412fa62d by Zachary Ware in branch 'default':
Issue #21745: Mention VS2010 SP1 as a solution for error LNK1123.
http://hg.python.org/devguide/rev/9794412fa62d
--
nosy: +python-dev
___
Python tracker
Changes by Claudiu Popa pcmantic...@gmail.com:
--
dependencies: +Expose RegUnloadKey in winreg
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8579
___
Zachary Ware added the comment:
Fixed, thanks for the patch!
--
assignee: docs@python - zach.ware
resolution: - fixed
stage: - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21745
Mark Lawrence added the comment:
Should this be closed in favour of issue 12572?
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5999
___
Mark Lawrence added the comment:
According to msg140433 this should be closed.
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12561
___
Ben Hoyt added the comment:
Cool, thanks for applying. Out of curiosity, how often is the online devguide
HTML updated?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21745
___
Zachary Ware added the comment:
I'm not sure; I expect your change to be live within a day, probably sooner.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21745
___
Mark Lawrence added the comment:
The default build (on Windows anyway)is using tcl/tk 8.6 so I believe that we
can take this forward now.
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7057
Mark Lawrence added the comment:
This is a very simple docs patch so could we have it committed please?
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19362
___
James Y Knight added the comment:
Reverting the incorrect commit which caused the regression would be a good
start.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21652
___
Steve Dower added the comment:
I've noticed this as well. I'm hoping to do a significant rework of the
installer for 3.5 and will keep this in mind, but I honestly have no idea how
to diagnose this in the current setup.
Windows Installer is responsible for the missing entries, and AFAIK the
paul j3 added the comment:
It's essentially the same issue as http://bugs.python.org/issue21666.
An error in the 'help' parameter is not caught until 'print_help' is called
(via 'parse_args').
A possible improvement is to test the 'help' string during 'add_argument'.
Similar testing for
R. David Murray added the comment:
If I understand correct that patch was itself attempting to fix a regression ;)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21652
___
Steve Dower added the comment:
This may actually be a Windows issue... the keys for uninstall are being
written to the Wow6432Node of the registry (on a 64-bit machine), and
apparently the Programs and Features panel does not read them from there.
The 64-bit installers should be fine (testing
Jim Jewett added the comment:
Following up on Mark Lawrence's comment: http://bugs.python.org/issue12572 is
collecting the patches required to compile under HP/UX, and the patch there
supersedes those on this issue. Closing.
--
nosy: +Jim.Jewett
resolution: - duplicate
status: open
STINNER Victor added the comment:
The changeset a7a8ccf69708 (a few months ago) fixed lib_python to not
concatenate bytes string and wide character string. I don't see any occurence
of char+wchar in the code, so I'm closing the issue.
changeset: 87136:a7a8ccf69708
user:Victor
Tim Golden added the comment:
Only if you have something better to put in its place! That commit was
fixing an existing problem; perhaps not your problem, but someone's. To
revert it would simply move the pain around.
I hope to be able to work on this fairly soon. If anyone else wants to
Claudiu Popa added the comment:
Attached a new version of the patch which cleanups properly after tests.
--
Added file: http://bugs.python.org/file35618/issue21518_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21518
Changes by Terry J. Reedy tjre...@udel.edu:
--
nosy: +serhiy.storchaka -gpolo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7057
___
___
Jim Jewett added the comment:
Added version 3.5; is 3.4 somehow still correct?
Set stage to patch review as there are still comments to deal with, but it
looks pretty close to commit review.
--
nosy: +Jim.Jewett
stage: - patch review
versions: +Python 3.4
Jim Jewett added the comment:
As best I can tell, this renames the original get_code to _get_code, and then
delegates to it after handling the imp.PY_FROZEN case ... why not just add
imp.PY_FROZEN to the if/elif chain in the original method?
I also note that the call to self._fix_name doesn't
Jean-Paul Calderone added the comment:
That commit was fixing an existing problem; perhaps not your problem, but
someone's. To revert it would simply move the pain around.
Doesn't the very same logic apply to the original commit?
I hope to be able to work on this fairly soon.
Thanks.
Zachary Ware added the comment:
Not sure what you were going for on the version, Jim; you added 3.4, but this
is a new feature for 3.5.
--
versions: -Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21719
Jim Jewett added the comment:
I agree with R. David Murray, but it may be worth adding a clarification
sentence (or an example with sorted) to the documentation.
Changing status to Pending, in hopes that any doc changes would be quick.
--
nosy: +Jim.Jewett
resolution: - not a bug
Vladimir Iofik added the comment:
Did anyone here managed to reproduce the issue?
I tired but I have failed to.
I'm still trying though.
Anyway I'd start from investigating why a function EnumKey returns Unicode
object while according to documentation it should return string.
--
Marc-Andre Lemburg added the comment:
On 13.06.2014 18:49, Jim Jewett wrote:
As best I can tell, this renames the original get_code to _get_code, and then
delegates to it after handling the imp.PY_FROZEN case ... why not just add
imp.PY_FROZEN to the if/elif chain in the original method?
Marc-Andre Lemburg added the comment:
Here's an updated patch for Python 3.4.1 that doesn't use the awkward style :-)
--
Added file:
http://bugs.python.org/file35619/pkgutil-frozen-modules-support.patch
___
Python tracker rep...@bugs.python.org
Changes by Marc-Andre Lemburg m...@egenix.com:
Removed file:
http://bugs.python.org/file35617/pkgutil-frozen-modules-support.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21749
___
Changes by Terry J. Reedy tjre...@udel.edu:
--
stage: - test needed
versions: +Python 3.5 -Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21684
___
Eric V. Smith added the comment:
I agree that glob shouldn't sort. In addition, iglob definitely can't sort, and
I don't think you want to have glob sort but iglob not sort.
--
nosy: +eric.smith
status: pending - open
___
Python tracker
Terry J. Reedy added the comment:
Looks sensible to me. Except for being name-only, this duplicates the api of
enumerate.
--
nosy: +terry.reedy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21706
Changes by Terry J. Reedy tjre...@udel.edu:
--
assignee: - terry.reedy
nosy: +terry.reedy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20043
___
New submission from Paul Koning:
The read_data iterator that supplies bits of read data when asked from
unittest.mock.mock_open is a class attribute. The result is that, if you
instantiate the class multiple times, that iterator is shared. This isn't
documented and it seems
Roundup Robot added the comment:
New changeset ef491d76ac70 by Terry Jan Reedy in branch '3.4':
Issue #20043: Add direct test for _thread.
http://hg.python.org/cpython/rev/ef491d76ac70
--
nosy: +python-dev
___
Python tracker rep...@bugs.python.org
Terry J. Reedy added the comment:
I added a direct test import of _thread. Since test_multiprocessing is one file
on 2.7 and AMD Fedora without threads is green for 2.7, in spite of the import
of threading, I left 2.7 alone. If that changes, this can be reopened and
marked for 2.7.
New submission from Donald Stufft:
Since Python 3.3 the zipfile module has support bzip2 and lzma compression,
however the zipimporter does not support these. It would be awesome if
zipimport did support them.
--
messages: 220477
nosy: brett.cannon, dstufft, eric.snow, ncoghlan
Changes by Terry J. Reedy tjre...@udel.edu:
--
assignee: docs@python - terry.reedy
nosy: +terry.reedy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21726
___
Jim Jewett added the comment:
(1) The patch is just to docs, not code, so I'm not entirely sure that I
understood it properly.
(2) The new semantics are a huge mess to explain. This might be because the
old semantics were bad, but the result is the same. I think it would be better
to
Roundup Robot added the comment:
New changeset 6f63fff5c120 by Zachary Ware in branch '3.4':
Issue #19493: Refactor ctypes test package.
http://hg.python.org/cpython/rev/6f63fff5c120
New changeset 86d14cf2a6a8 by Zachary Ware in branch 'default':
Issue #19493: Merge with 3.4
Changes by Terry J. Reedy tjre...@udel.edu:
--
resolution: - fixed
stage: - resolved
status: open - closed
versions: +Python 2.7, Python 3.4, Python 3.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21726
Roundup Robot added the comment:
New changeset cd08e366d619 by Terry Jan Reedy in branch '2.7':
Issue #21726: Remove unnecessary and contextually wrong line.
http://hg.python.org/cpython/rev/cd08e366d619
New changeset efa32fcd7a0b by Terry Jan Reedy in branch '3.4':
Issue #21726: Remove
R. David Murray added the comment:
See also issue 17004 and issue 5950.
--
nosy: +r.david.murray
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21751
___
New submission from Don Spaulding:
Discussion of this issue on ML:
https://mail.python.org/pipermail/python-dev/2014-June/135048.html
The behavior of logging.getLevelName changed in Python 3.4. Previously when
passed a string, it would return the corresponding integer value of the level.
New submission from Jim Jewett:
Inspired by https://mail.python.org/pipermail/python-dev/2014-June/135029.html
and the following thread.
Normal Windows behavior:
hg status --rev .^1
M mercurial\commands.py
? pysptest.py
hg status --rev .^1
abort: unknown revision '.1'!
So, ^ is
Changes by Terry J. Reedy tjre...@udel.edu:
--
assignee: - terry.reedy
nosy: +terry.reedy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21730
___
Roundup Robot added the comment:
New changeset f44275c66fcf by Terry Jan Reedy in branch '3.4':
Issue #21730: Add no-thread skip in test_socket. Patch by Berker Peksag.
http://hg.python.org/cpython/rev/f44275c66fcf
--
nosy: +python-dev
___
Python
Terry J. Reedy added the comment:
It is helpful to note that an issue such as this does not apply to 2.7, so no
one needs to check whether the omission is an oversight, and that you know that
the patch applies cleanly to both 3.4 and 3.5.
--
resolution: - fixed
stage: patch review -
Raymond Hettinger added the comment:
I'll apply this (if only to bring this vacuous discussion to a close).
--
assignee: docs@python - rhettinger
priority: normal - low
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19362
R. David Murray added the comment:
This should instead be an escape function parallel to the shlex.quote function
for unix. I was talking to someone on IRC the other day who had at least a
partial implementation, but I guess they haven't opened an issue for it. (At
least, I can't find one.)
Roundup Robot added the comment:
New changeset 08a2b36f6287 by Zachary Ware in branch '2.7':
Issue #19493: Backport 6f63fff5c120
http://hg.python.org/cpython/rev/08a2b36f6287
--
___
Python tracker rep...@bugs.python.org
Zachary Ware added the comment:
Committed; thanks for the review, Serhiy.
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19493
Steve Dower added the comment:
Apparently keys in Wow6432Node are actually okay, so I'm not much closer to
figuring this out. As far as I can tell, the entry I have for Python 2.6.6
(which doesn't appear) has identical information to IronPython 2.7.4 (which
does appear).
--
Aymeric Augustin added the comment:
Thanks for your feedback!
Indeed this is a documentation patch describing what I could implement if a
core dev gave the slightest hint that it stands a small chance of getting
included. There's no point in writing code that Python core doesn't want.
I
Terry J. Reedy added the comment:
You might add a brief description of why this is good idea, or link to such a
discussion.
I am +1 on the idea, but a pydev discussion might be needed.
How did you test the patch? I don't think that passing the same tests in
non-verbose mode is good enough,
Terry J. Reedy added the comment:
Raymond, I was planning to do this today along with other small patches
(already done). Just say so and I will take it.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19362
R. David Murray added the comment:
This appears to be me to be obsolete, given that long messages are now the
default, and the message argument enhances the long message rather than
replacing it.
--
nosy: +r.david.murray
resolution: - out of date
stage: - resolved
status: open -
Steve Dower added the comment:
Okay, now it looks to me like the install that 'works' ran under the SYSTEM
account while the one that didn't work ran under my (admin) user account.
This may be caused by running the installer from an elevated command prompt. If
it detects that it needs to
Martin v. Löwis added the comment:
I can reproduce the issue with the attached script. The problem is not that
EnumKey returns a Unicode string (which it never does), but that QueryValueEx
returns a Unicode string. See http://hg.python.org/cpython/rev/18cfc2a42772 for
the actual change in
Ben Hoyt added the comment:
Updated patch attached based on code reviews.
I'm replying to the code review here as when I tried to reply on
bugs.python.org/review I got a Python exception, AttributeError: NoneType has
no attribute something or other. FYI, it seems Django is set up in debug
Zachary Ware added the comment:
Ben Hoyt wrote:
I'm replying to the code review here as when I tried to reply on
bugs.python.org/review I got a Python exception, AttributeError:
NoneType has no attribute something or other.
Generally when you get that you can just hit back and try again, it
Ben Hoyt added the comment:
The idea is that _stat.c will use system-provided values wherever
possible, but stat.py should be as accurate as we can make it to
provide a backup for when _stat isn't around (either when it's just
not built, which isn't an issue on Windows, or in another Python
Jim Jewett added the comment:
Removing the existing behavior will almost certainly not be accepted, because
of backwards compatibility.
Adding new functionality is generally acceptable.
Doing that through a new keyword that defaults to the old behavior is fairly
common, and generally better
Aymeric Augustin added the comment:
The problem is super simple:
connection = ...
cursor = connection.cursor()
cursor.execute(SAVEPOINT foo)
cursor.execute(ROLLBACK TO SAVEPOINT foo) # will report that the savepoint
doesn't exist.
Please don't make it look more complicated than it is.
Roundup Robot added the comment:
New changeset 31adcc4c4391 by R David Murray in branch '2.7':
#5904: Add sentence about the encoding of strftime's result.
http://hg.python.org/cpython/rev/31adcc4c4391
--
nosy: +python-dev
___
Python tracker
R. David Murray added the comment:
Thanks, Caelyn. I used your patch but added a clause showing explicitly how do
the unicode conversion. I decided to not add that to the datetime, docs, since
they are already pretty clear.
--
nosy: +r.david.murray
resolution: - fixed
stage: needs
Mark Lawrence added the comment:
issue17053 was closed in favour of issue19674 but I don't know if this issue is
a duplicate of the former anyway.
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17424
Mark Lawrence added the comment:
The failing negative years test is still being skipped. I'm assuming this was
not originally intended.
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13312
Oz Tiram added the comment:
@Raymond Hettinger,
You don't have to wait anymore. I would be happy if you review the patch, and
share your opinion.
I might have posted my patch too early. I am still doing changes on the
upstream, in my github posted earlier.So, please test the one upstream.
1 - 100 of 126 matches
Mail list logo
