[issue23328] urllib2 fails for proxy credentials that contain a '/' character

2015-01-26 Thread Andy Reitz
Andy Reitz added the comment: Sorry, went a bit too quickly -- here is the sample code that I meant to use: import os, urllib2 os.environ['http_proxy'] = "http://someuser:a/b@10.11.12.13:1234"; f = urllib2.urlopen('http://www.python.org') data = f.read() print data And the stack trace

[issue23328] urllib2 fails for proxy credentials that contain a '/' character

2015-01-26 Thread Andy Reitz
New submission from Andy Reitz: On Python 2.7.9, if I set an https_proxy environment variable, where the password contains a '/' character, urllib2 fails. Given this test code: import os, urllib os.environ['http_proxy'] = "http://someuser:a/b@10.11.12.13:1234"; f = urllib.urlopen('http://

[issue23269] Tighten-up search loops in sets

2015-01-26 Thread Raymond Hettinger
Raymond Hettinger added the comment: Applied Sirhiy's version of the patch but may switch to the j=0 version later. -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue23269] Tighten-up search loops in sets

2015-01-26 Thread Roundup Robot
Roundup Robot added the comment: New changeset 0b2a3d764e63 by Raymond Hettinger in branch 'default': Issue #23269: Tighten search_loop in set_insert_clean() https://hg.python.org/cpython/rev/0b2a3d764e63 -- nosy: +python-dev ___ Python tracker

[issue23322] parser module docs missing second example

2015-01-26 Thread Berker Peksag
Berker Peksag added the comment: Welcome, please go ahead and send a patch. Thanks! -- ___ Python tracker ___ ___ Python-bugs-list mai

[issue23322] parser module docs missing second example

2015-01-26 Thread Vipul Sharma
Vipul Sharma added the comment: Can I work on this ? This would be my first contribution here also it looks good for a beginner -- nosy: +Vipul.Sharma ___ Python tracker ___ ___

[issue22671] Typo in class io.BufferedIOBase docs

2015-01-26 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list mail

[issue17911] traceback: add a new thin class storing a traceback without storing local variables

2015-01-26 Thread Robert Collins
Robert Collins added the comment: Why do you consider it crippling? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue5309] distutils doesn't parallelize extension module compilation

2015-01-26 Thread Roundup Robot
Roundup Robot added the comment: New changeset 107669985805 by Berker Peksag in branch 'default': Add whatsnew entry for issue #5309. https://hg.python.org/cpython/rev/107669985805 -- ___ Python tracker

[issue23286] A typo in the tutorial

2015-01-26 Thread Berker Peksag
Berker Peksag added the comment: Fixed. Thanks for the patch! -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___

[issue23286] A typo in the tutorial

2015-01-26 Thread Roundup Robot
Roundup Robot added the comment: New changeset b3f0d7f50544 by Berker Peksag in branch '3.4': Issue #23286: Fix typo in the tutorial. https://hg.python.org/cpython/rev/b3f0d7f50544 New changeset 8cb151ff1575 by Berker Peksag in branch 'default': Issue #23286: Fix typo in the tutorial. https://hg

[issue2292] Missing *-unpacking generalizations

2015-01-26 Thread Neil Girdhar
Neil Girdhar added the comment: Everything seems to work except two tests are still failing: parser and venv. Any ideas Joshua? Also, we have to decide what to do with f(*x for x in l) and f(**x for x in l). -- Added file: http://bugs.python.org/file37877/starunpack23.diff __

[issue22936] traceback module has no way to show locals

2015-01-26 Thread Robert Collins
Robert Collins added the comment: First cut implementation. I'm sure there is lots we can add, but this will make things nicer in and of itself. Thanks for the pointer to cgitb, I've skimmed it and its definitely much more comprehensive. I'm not entirely sure about the best way to glue it and

[issue2292] Missing *-unpacking generalizations

2015-01-26 Thread Neil Girdhar
Changes by Neil Girdhar : Added file: http://bugs.python.org/file37876/starunpack22.diff ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue23327] zipimport to import from non-ascii pathname on Windows

2015-01-26 Thread STINNER Victor
STINNER Victor added the comment: > I do agree that it is a corner case scenario and using ASCII names is a > better option :-) Since the patch is short, I see no problem to fix this issue. -- ___ Python tracker

[issue17911] traceback: add a new thin class storing a traceback without storing local variables

2015-01-26 Thread Antoine Pitrou
Antoine Pitrou added the comment: Le 27/01/2015 00:30, Robert Collins a écrit : > > Robert Collins added the comment: > > So its fairly simple IMO: it will be more code, not less, to support the non-triple API, *and* it can be added later, unless we're proposing not to support the triple API at

[issue17911] traceback: add a new thin class storing a traceback without storing local variables

2015-01-26 Thread Robert Collins
Robert Collins added the comment: So its fairly simple IMO: it will be more code, not less, to support the non-triple API, *and* it can be added later, unless we're proposing not to support the triple API at all (which hasn't been proposed AFAICT). To me thats a fairly strong argument for addi

[issue17911] traceback: add a new thin class storing a traceback without storing local variables

2015-01-26 Thread Antoine Pitrou
Antoine Pitrou added the comment: > In this view, __traceback__ is primarily about accessing *chained* > tracebacks Please let's not make up sophistic arguments when the only motivation for triples is backwards compatibility of *existing* APIs. Exception triples are an unnecessary bother in Py

[issue23327] zipimport to import from non-ascii pathname on Windows

2015-01-26 Thread Swapneel Ambre
Swapneel Ambre added the comment: Sorry I was not very clear about the use case. The name of the zipfile or any parent directory name could contain non-ascii characters. Consider a use case where you want to ship some product with third party module shipped as an egg file (say example.egg) al

[issue23324] Nonblocking serial io using Arduino and Ubuntu 14.10 (Python 3.4.2) performance slowdown

2015-01-26 Thread STINNER Victor
Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue23324] Nonblocking serial io using Arduino and Ubuntu 14.10 (Python 3.4.2) performance slowdown

2015-01-26 Thread Carol Willing
Carol Willing added the comment: Alan, Thanks for reporting your issue. I have spent some time looking at it, and I have triaged it as best as I am able for the other developers and you. I am editing the issue title for clarity. The issue is related to nonblocking i/o between a 'linux' (Ubuntu

[issue23327] zipimport to import from non-ascii pathname on Windows

2015-01-26 Thread STINNER Victor
STINNER Victor added the comment: I don't understand the issue: does it only concern the name of the ZIP file? Or also paths inside the ZIP? In both cases, the workaround is to use only ASCII names. I spent a lot of times on supporting any Unicode name, everyone in Python. I didn't expect tha

[issue23095] [Windows] asyncio: race condition when cancelling a _WaitHandleFuture

2015-01-26 Thread STINNER Victor
STINNER Victor added the comment: I fixed many other issues related to the IocpProactor. This time it should be ok. I ran the Tulip and Trollius test suite a lot of times, in release and debug mode. I didn't see any warning nor hang. I also ran test_asyncio of Python as well. I close this iss

[issue23327] zipimport to import from non-ascii pathname on Windows

2015-01-26 Thread STINNER Victor
STINNER Victor added the comment: > Please see zipimport_fix.patch for the possible fix. The solution looks good. Can you please try to convert zipimport_test.py to a patch for test_zipimport.py and combine it with zipimport_fix.patch to create a complete patch? You should also sign the c

[issue23327] zipimport to import from non-ascii pathname on Windows

2015-01-26 Thread Swapneel Ambre
Swapneel Ambre added the comment: I have tried to fix this by calling Py_CompileStringObject instead of Py_CompileString , thus avoiding the need to Encode the pathname. Please see zipimport_fix.patch for the possible fix. -- keywords: +patch Added file: http://bugs.python.org/file3787

[issue17911] traceback: add a new thin class storing a traceback without storing local variables

2015-01-26 Thread Nick Coghlan
Nick Coghlan added the comment: On the triple-or-value front, the main case I see for considering the "you don't need exception state triples any more" argument already lost is the fact exc_info still returns a triple, and __exit__ methods still accept them as unpacked arguments. The C level e

[issue23327] zipimport to import from non-ascii pathname on Windows

2015-01-26 Thread Swapneel Ambre
Swapneel Ambre added the comment: I am attaching the test script I have used to reproduce the issue. -- Added file: http://bugs.python.org/file37873/zipimport_test.py ___ Python tracker

[issue23327] zipimport to import from non-ascii pathname on Windows

2015-01-26 Thread Swapneel Ambre
New submission from Swapneel Ambre: On Windows, using zipimport module APIs like get_filename on a file with non-ascii characters in the full path fails with UnicodeEncodeError: 'mbcs' codec can't encode characters in position 0--1: invalid character ( Full output attached in errorlog.txt ).

[issue2292] Missing *-unpacking generalizations

2015-01-26 Thread Neil Girdhar
Neil Girdhar added the comment: fixed a minor bug with the function address, and made a number of polishing changes. -- Added file: http://bugs.python.org/file37871/starunpack21.diff ___ Python tracker

[issue22286] Allow backslashreplace error handler to be used on input

2015-01-26 Thread Roundup Robot
Roundup Robot added the comment: New changeset 1e8937861ee3 by Victor Stinner in branch 'default': Issue #22286, #23321: Fix failing test on Windows code page 932 https://hg.python.org/cpython/rev/1e8937861ee3 -- ___ Python tracker

[issue23321] Crash in str.decode() with special error handler

2015-01-26 Thread Roundup Robot
Roundup Robot added the comment: New changeset 1e8937861ee3 by Victor Stinner in branch 'default': Issue #22286, #23321: Fix failing test on Windows code page 932 https://hg.python.org/cpython/rev/1e8937861ee3 -- ___ Python tracker

[issue17911] traceback: add a new thin class storing a traceback without storing local variables

2015-01-26 Thread Robert Collins
Robert Collins added the comment: actually, strike that, I'm happy with this pending a final +1 from another reviewer. Finishing the locals stuff is a separate patch, and will look like a single new parameter to StackSummary.extract, similarly on TracebackException.__init__ and then change the

[issue17911] traceback: add a new thin class storing a traceback without storing local variables

2015-01-26 Thread Robert Collins
Robert Collins added the comment: And for profit, review changes applied (minus the small number I disagreed with). I've clarified in the code why the exc_info tuple break out is still used (compat with the legacy API is the strongest argument). I haven't fleshed out the locals thing properly

[issue4395] Document auto __ne__ generation; provide a use case for non-trivial __ne__

2015-01-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: See also issue23326. -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing

[issue23326] Remove redundant __ne__ implementations

2015-01-26 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: As far as default __ne__ implementation delegates to __eq__, concrete __ne__ implementations are mostly redundant. They make sens when default __ne__ did not handle non-comparable types correctly, but now it is fixed. Proposed patch removes correct but red

[issue23095] [Windows] asyncio: race condition when cancelling a _WaitHandleFuture

2015-01-26 Thread Roundup Robot
Roundup Robot added the comment: New changeset 36e80c6599aa by Victor Stinner in branch '3.4': Issue #23095, asyncio: Fix _WaitHandleFuture.cancel() https://hg.python.org/cpython/rev/36e80c6599aa -- ___ Python tracker

[issue17911] traceback: add a new thin class storing a traceback without storing local variables

2015-01-26 Thread Robert Collins
Robert Collins added the comment: The generator thing: the code was refactoring not so long ago to be generator based internally with lists as a UI shim. I don't think there is a major advantage either way. Less buffering on one hand. Less convenient in some cases on the other. Simple use like

[issue21076] Turn signal.SIG* constants into enums

2015-01-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I have other proposition -- turn them into functions (issue23325). -- ___ Python tracker ___ ___ P

[issue23325] Turn SIG_DFL and SIG_IGN into functions

2015-01-26 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: In C the SIG_DFL and SIG_IGN macros expand into integral expressions that are not equal to an address of any function. In Python they are int objects with platform depended values. Second argument of the signal() function should be SIG_DFL, SIG_IGN, or a f

[issue23324] Python 3.4.2 running slow on Ubuntu 14.10

2015-01-26 Thread Alan Yorinks
New submission from Alan Yorinks: Folks, I am not trying to waste anyone's time. If this is not the correct mailing list to get this problem resolved, please point me to the correct one. To summarize my problem, if I run the configuration below with python 3.4.2 on Linux, the program re

[issue23316] Incorrect evaluation order of function arguments with *args

2015-01-26 Thread Neil Girdhar
Neil Girdhar added the comment: (I also suggest that the evaluation order within a function argument list to be defined to be positional and iterable before keyword, otherwise left-to-right —  rather than strictly left-to-right). -- ___ Python tracke

[issue2292] Missing *-unpacking generalizations

2015-01-26 Thread Joshua Landau
Joshua Landau added the comment: Update for the error messages fix. I've put aside the idea of unifying things for now because there are a couple of interdependencies I wasn't expecting and I absolutely don't want the fast-path for f(x) to get slower. -- Added file: http://bugs.python

[issue2292] Missing *-unpacking generalizations

2015-01-26 Thread Joshua Landau
Joshua Landau added the comment: Quick-fix for Guido's bug attached. I'm not familiar with this part of the code, yet, so take this tentatively. I just changed while (containers > 1) { to while (containers) { --- @Guido My comments were assuming `f(**x for x in y)` meant `f({**x fo

[issue21076] Turn signal.SIG* constants into enums

2015-01-26 Thread Ethan Furman
Ethan Furman added the comment: I know nothing about this part of CPython, but wouldn't the correct solution be to not compare by identity? -- ___ Python tracker ___ ___

[issue17911] traceback: add a new thin class storing a traceback without storing local variables

2015-01-26 Thread Antoine Pitrou
Antoine Pitrou added the comment: Le 26/01/2015 19:36, Robert Collins a écrit : > > Two key notes: the use of an exception triple is useful to ease backports of this Then I'd recommend making it exception-or-tuple (rather than a *exc_info), so that both situations are satisfied. -- __

[issue21076] Turn signal.SIG* constants into enums

2015-01-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: And more, as far as standard signal handler is tested for identity, signal.SIG_DFL and _signal.SIG_DFL should be the same object. Current code works only due to coincidence of two circumstances: 1) Small integers are cached in CPython. 2) SIG_DFL and SIG_IGN

[issue2292] Missing *-unpacking generalizations

2015-01-26 Thread Guido van Rossum
Guido van Rossum added the comment: @Joshua: Re: f(x: y for x, y in z) I don't think that follows at all. We support f(**d) now, but if d == {'a': 1, 'b': 2}, it is equivalent to f(a=1, b=2), not f(a: 1, b: 2). -- ___ Python tracker

[issue2292] Missing *-unpacking generalizations

2015-01-26 Thread Guido van Rossum
Guido van Rossum added the comment: So I think the test function here should be: def f(*a, **k): print(list(a), list(k)) Then we can try things like: f(x for x in ['ab', 'cd']) which prints a generator object, because this is interpreted as an argument that's a generator expression. But

[issue17911] traceback: add a new thin class storing a traceback without storing local variables

2015-01-26 Thread Robert Collins
Robert Collins added the comment: Thanks for the review - shall action it all as it seems all good improvements. Two key notes: the use of an exception triple is useful to ease backports of this: a primary goal for me is being able to use the locals stuff in unittest for existing production co

[issue2292] Missing *-unpacking generalizations

2015-01-26 Thread Joshua Landau
Joshua Landau added the comment: If we're supporting f(**x for x in y) surely we should also support f(x: y for x, y in z) I personally don't like this idea. -- ___ Python tracker ___

[issue23317] Incorrect description of descriptor invocation in Python Language Reference

2015-01-26 Thread Justin Eldridge
Justin Eldridge added the comment: Ah, I see how writing a description of this which is both concise and precise would be difficult, especially for Python 2. > But the Class Binding description is correct, since if the __get__ method is > *not* defined on the type (of the descriptor), the descri

[issue22818] Deprecate splitting on possible zero-width re patterns

2015-01-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Updated patch includes Ezio's suggestions. Thank you Ezio, they looks great to me. -- Added file: http://bugs.python.org/file37864/re_deprecate_split_zero_width_4.patch ___ Python tracker

[issue23095] [Windows] asyncio: race condition when cancelling a _WaitHandleFuture

2015-01-26 Thread STINNER Victor
STINNER Victor added the comment: Pseudo-code: --- handle = ... fut = proactor.wait_for_handle(handle) fut.cancel() loop.close() --- Windows functions called in this code: - A: call RegisterWaitForSingleObject() on an handle - A: call UnregisterWaitEx() with an event - B: call RegisterWaitForSi

[issue2292] Missing *-unpacking generalizations

2015-01-26 Thread Guido van Rossum
Guido van Rossum added the comment: Let's wait until I have a keyboard. In 20 min. On Jan 26, 2015 8:55 AM, "Guido van Rossum" wrote: > Wait, with that f() definition I'd expect a different result from the > former -- each letter as a new arg. Right? > On Jan 26, 2015 8:42 AM, "Neil Girdhar" w

[issue2292] Missing *-unpacking generalizations

2015-01-26 Thread Guido van Rossum
Guido van Rossum added the comment: Wait, with that f() definition I'd expect a different result from the former -- each letter as a new arg. Right? On Jan 26, 2015 8:42 AM, "Neil Girdhar" wrote: > > Neil Girdhar added the comment: > > >>> def f(a, *b): print(list(a), list(b)) > > -- >

[issue2292] Missing *-unpacking generalizations

2015-01-26 Thread Neil Girdhar
Neil Girdhar added the comment: Could you help me understand this a bit better? I always thought of f(x for x in l) as equivalent to f( (x for x in l) ). So, I can see that f(*x for x in l) should be equivalent to f( (*x for x in l) ). How should we interpret f(**x for x in l)? Is it then f(

[issue2292] Missing *-unpacking generalizations

2015-01-26 Thread Neil Girdhar
Neil Girdhar added the comment: Is this correct? >>> f(*i for i in ['abc', 'def']) ['a', 'b', 'c', 'd', 'e', 'f'] [] >>> f(**i for i in ['abc', 'def']) File "", line 1 f(**i for i in ['abc', 'def']) ^ SyntaxError: invalid syntax Should neither work? Both? -- ___

[issue2292] Missing *-unpacking generalizations

2015-01-26 Thread Neil Girdhar
Neil Girdhar added the comment: >>> def f(a, *b): print(list(a), list(b)) -- ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue2292] Missing *-unpacking generalizations

2015-01-26 Thread Guido van Rossum
Guido van Rossum added the comment: Both. On Jan 26, 2015 8:42 AM, "Neil Girdhar" wrote: > > Neil Girdhar added the comment: > > Is this correct? > > >>> f(*i for i in ['abc', 'def']) > ['a', 'b', 'c', 'd', 'e', 'f'] [] > >>> f(**i for i in ['abc', 'def']) > File "", line 1 > f(**i for i

[issue23316] Incorrect evaluation order of function arguments with *args

2015-01-26 Thread Neil Girdhar
Neil Girdhar added the comment: After thinking about this a bit more, my suggestion is not to fix it. Instead, I suggest that PEP 8 be modified to suggest that all positional arguments and iterable argument unpackings precede keyword arguments and keyword argument unpackings. Then, a tool li

[issue23255] SimpleHTTPRequestHandler refactor for more extensible usage.

2015-01-26 Thread Demian Brecht
Demian Brecht added the comment: Thanks for the extra effort on this to satisfy multiple people's opinions. It's never an easy thing, especially when dealing with a decentralized group. My following comments are largely based on the public API. I haven't done a full review of the changes made

[issue17911] traceback: add a new thin class storing a traceback without storing local variables

2015-01-26 Thread Martin Richard
Changes by Martin Richard : -- nosy: +martius ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue15859] PyUnicode_EncodeFSDefault win32 inconsistancy.

2015-01-26 Thread STINNER Victor
STINNER Victor added the comment: I applied fix_unicode_v2.diff to Python 3.5. For older Python versions, it's easy to workaround this issue: ensure explicitly that your object is a Unicode object using PyUnicode_Check(). You may write your function to call PyUnicode_EncodeFSDefault() with a

[issue20284] patch to implement PEP 461 (%-interpolation for bytes)

2015-01-26 Thread Roundup Robot
Roundup Robot added the comment: New changeset db7ec64aac39 by Victor Stinner in branch 'default': Issue #20284: Fix a compilation warning on Windows https://hg.python.org/cpython/rev/db7ec64aac39 -- ___ Python tracker

[issue15859] PyUnicode_EncodeFSDefault win32 inconsistancy.

2015-01-26 Thread Roundup Robot
Roundup Robot added the comment: New changeset e124aab5d9a0 by Victor Stinner in branch 'default': Issue #15859: PyUnicode_EncodeFSDefault(), PyUnicode_EncodeMBCS() and https://hg.python.org/cpython/rev/e124aab5d9a0 -- nosy: +python-dev ___ Python tra

[issue3566] httplib persistent connections violate MUST in RFC2616 sec 8.1.4.

2015-01-26 Thread Demian Brecht
Demian Brecht added the comment: > now I’m thinking that should be up to the higher level user +1. A closed connection is a closed connection, whether it's persistent or not. The higher level code should be responsible for the context, not the connection level. -- ___

[issue23057] [Windows] asyncio: support signal handlers on Windows (feature request)

2015-01-26 Thread STINNER Victor
Changes by STINNER Victor : -- title: asyncio loop on Windows should stop on keyboard interrupt -> [Windows] asyncio: support signal handlers on Windows (feature request) type: behavior -> enhancement ___ Python tracker

[issue23046] asyncio.BaseEventLoop is documented, but only exported via asyncio.base_events

2015-01-26 Thread STINNER Victor
STINNER Victor added the comment: Since there is already an open issue suggesting to document AbstractServer (and Server), I close this issue. The original bug was fixed: BaseEventLoop is now part of the asyncio namespace. -- resolution: -> fixed status: open -> closed __

[issue23187] Segmentation fault, possibly asyncio related

2015-01-26 Thread STINNER Victor
STINNER Victor added the comment: Since the issue looks to be related to a third party module (ujson), I close this issue. Note: On UNIX, asyncio is fully implemented in Python, I don't see how it could corrupt internal Python structures. -- resolution: -> not a bug status: open -> c

[issue20284] patch to implement PEP 461 (%-interpolation for bytes)

2015-01-26 Thread Ethan Furman
Ethan Furman added the comment: it does seem a bit odd -- on the other hand, %s is an alias for %b, is deprecated for new 3-only code, and this might help serve as a reminder of that. Or we could fix it. ;) -- ___ Python tracker

[issue14910] argparse: disable abbreviation

2015-01-26 Thread Rémi Rampin
Changes by Rémi Rampin : -- nosy: +remram ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.o

[issue23293] [Windows] asyncio: race condition related to IocpProactor.connect_pipe()

2015-01-26 Thread Roundup Robot
Roundup Robot added the comment: New changeset 99c3e304a4ea by Victor Stinner in branch '3.4': Issue #23293, asyncio: Rewrite IocpProactor.connect_pipe() as a coroutine https://hg.python.org/cpython/rev/99c3e304a4ea -- ___ Python tracker

[issue23208] asyncio: add BaseEventLoop._current_handle (only used in debug mode)

2015-01-26 Thread STINNER Victor
STINNER Victor added the comment: I commited current_handle.patch. It's only a first step, I will also change the logger or calls to the logger to use this traceback of the current handle. -- resolution: -> fixed status: open -> closed ___ Python t

[issue23323] Issue with imaplib and append messages passing a tuple with flags

2015-01-26 Thread R. David Murray
R. David Murray added the comment: Indeed, as with much of the early email related code in the stdlib, the documentation assumes way too much familiarity with the relevant RFC...which is really hard to read. We should add a few more details to the docs (like FLAGS being a string) even if we d

[issue22818] Deprecate splitting on possible zero-width re patterns

2015-01-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you Ezio for your review. Updated patch includes most of your suggestions. But I think some places still can be dim. -- Added file: http://bugs.python.org/file37863/re_deprecate_split_zero_width_3.patch ___

[issue17911] traceback: add a new thin class storing a traceback without storing local variables

2015-01-26 Thread Antoine Pitrou
Antoine Pitrou added the comment: > tb = TracebackException(*sys.exc_info, lookup_lines=False) You don't need an exception tuple in Python 3, the exception instance is enough. -- ___ Python tracker ___

[issue17911] traceback: add a new thin class storing a traceback without storing local variables

2015-01-26 Thread Nick Coghlan
Nick Coghlan added the comment: I put some detailed comments in the review, but my main large scale concern is with the "traceback.Frame" name. Making "frame object" an ambiguous phrase seems like a bad idea to me, so I've suggested making it "FrameSummary" (or "FrameInfo", but on reflection I

[issue23323] Issue with imaplib and append messages passing a tuple with flags

2015-01-26 Thread Eric V. Smith
Eric V. Smith added the comment: flags is supposed to be a string. This is not well documented, like much of the module. Try: flags = r'(\Answered \Seen)' -- nosy: +eric.smith ___ Python tracker _

[issue23323] Issue with imaplib and append messages passing a tuple with flags

2015-01-26 Thread Alessio
New submission from Alessio: In example when appending a message with more than one flag in a tuple with imaplib: print flags ('\\Answered', '\\Seen') connection.append('INBOX', flags, date, msg) --- TypeError

[issue22818] Deprecate splitting on possible zero-width re patterns

2015-01-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Could anyone please make a review (mainly documentation)? It would be good to get this change in first alpha. -- ___ Python tracker ___ _

[issue14099] ZipFile.open() should not reopen the underlying file

2015-01-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Sorry Stepan and David, but for this feature you need wait 3.5. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue14099] ZipFile.open() should not reopen the underlying file

2015-01-26 Thread Roundup Robot
Roundup Robot added the comment: New changeset ae42c4576438 by Serhiy Storchaka in branch '2.7': Issue #14099: Backout changeset c2c4cde55f6f (except adapted tests). https://hg.python.org/cpython/rev/ae42c4576438 New changeset 680b47c96e08 by Serhiy Storchaka in branch '3.4': Issue #14099: Backo

[issue19361] Specialize exceptions thrown by JSON parser

2015-01-26 Thread Roundup Robot
Roundup Robot added the comment: New changeset 07af9847dbec by Serhiy Storchaka in branch 'default': Issue #19361: JSON decoder now raises JSONDecodeError instead of ValueError. https://hg.python.org/cpython/rev/07af9847dbec -- nosy: +python-dev ___ P

[issue19361] Specialize exceptions thrown by JSON parser

2015-01-26 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue18518] return-ing within code timed with timeit.timeit causes wrong return value of timeit.timeit

2015-01-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Already fixed in 617c226da195. Needs time for buildbots to rerun tests. I didn't noticed error when backported tests because there was local file support.py in my workspace. -- ___ Python tracker

[issue18518] return-ing within code timed with timeit.timeit causes wrong return value of timeit.timeit

2015-01-26 Thread STINNER Victor
STINNER Victor added the comment: Buildbots are unhappy. Example: http://buildbot.python.org/all/builders/AMD64%20FreeBSD%2010.0%202.7/builds/837/steps/test/logs/stdio 1 test failed: test_timeit Re-running test 'test_timeit' in verbose mode test test_timeit crashed -- : No module named su

[issue23094] Unpickler failing with PicklingError at frame end on readline due to a broken comparison

2015-01-26 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue23321] Crash in str.decode() with special error handler

2015-01-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I think the changeset which made decoders to use _PyUnicodeWriter (issue16311) is responsible of the regression. For example consider b'\x80abc'.decode('utf-8', 'backslashreplace'). The writer reserves string buffer with size 4 (every byte produces at most 1

[issue11578] Increase test coverage for timeit.py

2015-01-26 Thread Roundup Robot
Roundup Robot added the comment: New changeset 7e7c825f75ad by Serhiy Storchaka in branch '2.7': Issue #11578: Backported test for the timeit module. https://hg.python.org/cpython/rev/7e7c825f75ad -- ___ Python tracker

[issue18518] return-ing within code timed with timeit.timeit causes wrong return value of timeit.timeit

2015-01-26 Thread Roundup Robot
Roundup Robot added the comment: New changeset e8db1cbe416b by Serhiy Storchaka in branch '2.7': Issue #18518: timeit now rejects statements which can't be compiled outside https://hg.python.org/cpython/rev/e8db1cbe416b New changeset a5769fa55791 by Serhiy Storchaka in branch '3.4': Issue #18518

[issue23208] asyncio: add BaseEventLoop._current_handle (only used in debug mode)

2015-01-26 Thread Roundup Robot
Roundup Robot added the comment: New changeset 54d74f954bf9 by Victor Stinner in branch '3.4': Issue #23208, asyncio: Add BaseEventLoop._current_handle https://hg.python.org/cpython/rev/54d74f954bf9 -- nosy: +python-dev ___ Python tracker

[issue23293] [Windows] asyncio: race condition related to IocpProactor.connect_pipe()

2015-01-26 Thread Roundup Robot
Roundup Robot added the comment: New changeset b6ab8fe16d16 by Victor Stinner in branch '3.4': Issue #23293, asyncio: Cleanup IocpProactor.close() https://hg.python.org/cpython/rev/b6ab8fe16d16 -- ___ Python tracker

[issue20284] patch to implement PEP 461 (%-interpolation for bytes)

2015-01-26 Thread STINNER Victor
STINNER Victor added the comment: It's strange that %s format raises an error about the %b format: >>> b's? %s' % 1 Traceback (most recent call last): File "", line 1, in TypeError: %b requires bytes, or an object that implements __bytes__, not 'int' -- _

[issue23321] Crash in str.decode() with special error handler

2015-01-26 Thread STINNER Victor
STINNER Victor added the comment: > Debugging build crashes in some circumstances in str.decode() (...) buildbots > are broken without it Is it a regression? Would it be possible to identify the changeset responsible of the regression? -- ___ Python

[issue23094] Unpickler failing with PicklingError at frame end on readline due to a broken comparison

2015-01-26 Thread Roundup Robot
Roundup Robot added the comment: New changeset d5e13b74d377 by Serhiy Storchaka in branch '3.4': Issue #23094: Fixed readline with frames in Python implementation of pickle. https://hg.python.org/cpython/rev/d5e13b74d377 New changeset c347c21e5afa by Serhiy Storchaka in branch 'default': Issue #

[issue23292] Enum doc suggestion

2015-01-26 Thread Mark Summerfield
Mark Summerfield added the comment: Nice answer Ethan (but I can't vote you up since stack overflow won't let me vote or even comment anymore). As for adding export_to(), it seems like a good idea. However, personally, I think the signature should be hoist_into(namespace, cls, *clses) to

[issue7665] test_urllib2 and test_ntpath fail if path contains "\"

2015-01-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank for your review Senthil. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue7665] test_urllib2 and test_ntpath fail if path contains "\"

2015-01-26 Thread Roundup Robot
Roundup Robot added the comment: New changeset 1e12c9e5bc89 by Serhiy Storchaka in branch '2.7': Issue #7665: Fixed tests test_ntpath and test_urllib2 when ran in the https://hg.python.org/cpython/rev/1e12c9e5bc89 New changeset 04fa56628830 by Serhiy Storchaka in branch '3.4': Issue #7665: Fixed

[issue23268] Fix comparison of ipaddress classes

2015-01-26 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue21408] delegation of `!=` to the right-hand side argument is not always done

2015-01-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you for your contribution Martin. -- resolution: -> fixed stage: commit review -> resolved status: open -> closed versions: +Python 3.5 -Python 3.3 ___ Python tracker

  1   2   >